November 2020 - Wine-commits

Michael Stefaniuc : taskschd: Use wide-char string literals.
by Alexandre Julliard 17 Nov '20

17 Nov '20

Module: wine Branch: master Commit: 48e35424a65ddb89e9877e72f3a997c6e97a6617 URL: https://source.winehq.org/git/wine.git/?a=commit;h=48e35424a65ddb89e9877e72… Author: Michael Stefaniuc <mstefani(a)winehq.org> Date: Tue Nov 17 00:55:17 2020 +0100 taskschd: Use wide-char string literals. Also merge some strings. Signed-off-by: Michael Stefaniuc <mstefani(a)winehq.org> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/taskschd/folder.c | 5 +- dlls/taskschd/regtask.c | 3 +- dlls/taskschd/task.c | 297 +++++++++++++++++------------------------------- 3 files changed, 108 insertions(+), 197 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=48e35424a65ddb89e987…

1 0

Michael Stefaniuc : userenv: Use wide-char string literals.
by Alexandre Julliard 17 Nov '20

17 Nov '20

Module: wine Branch: master Commit: d7e43c9e3108d5d6f78bc74d3dfa6a918ecfea16 URL: https://source.winehq.org/git/wine.git/?a=commit;h=d7e43c9e3108d5d6f78bc74d… Author: Michael Stefaniuc <mstefani(a)winehq.org> Date: Tue Nov 17 00:55:18 2020 +0100 userenv: Use wide-char string literals. Signed-off-by: Michael Stefaniuc <mstefani(a)winehq.org> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/userenv/userenv_main.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/dlls/userenv/userenv_main.c b/dlls/userenv/userenv_main.c index 045bac0cfe1..58e610f6c6e 100644 --- a/dlls/userenv/userenv_main.c +++ b/dlls/userenv/userenv_main.c @@ -418,7 +418,6 @@ BOOL WINAPI GetUserProfileDirectoryA( HANDLE hToken, LPSTR lpProfileDir, BOOL WINAPI GetUserProfileDirectoryW( HANDLE hToken, LPWSTR lpProfileDir, LPDWORD lpcchSize ) { - static const WCHAR slashW[] = {'\\',0}; TOKEN_USER *t; WCHAR *userW = NULL, *dirW = NULL; DWORD len, dir_len, domain_len; @@ -459,7 +458,7 @@ BOOL WINAPI GetUserProfileDirectoryW( HANDLE hToken, LPWSTR lpProfileDir, goto done; } lstrcpyW( lpProfileDir, dirW ); - lstrcatW( lpProfileDir, slashW ); + lstrcatW( lpProfileDir, L"\\" ); lstrcatW( lpProfileDir, userW ); *lpcchSize = len; ret = TRUE; @@ -533,11 +532,8 @@ end: return ret; } -static const WCHAR ProfileListW[] = {'S','o','f','t','w','a','r','e','\\','M','i','c','r','o','s','o','f','t','\\','W','i','n','d','o','w','s',' ','N','T','\\','C','u','r','r','e','n','t','V','e','r','s','i','o','n','\\','P','r','o','f','i','l','e','L','i','s','t',0}; - BOOL WINAPI GetProfilesDirectoryW( LPWSTR lpProfilesDir, LPDWORD lpcchSize ) { - static const WCHAR ProfilesDirectory[] = {'P','r','o','f','i','l','e','s','D','i','r','e','c','t','o','r','y',0}; LONG l; HKEY key; BOOL ret = FALSE; @@ -552,13 +548,15 @@ BOOL WINAPI GetProfilesDirectoryW( LPWSTR lpProfilesDir, LPDWORD lpcchSize ) return FALSE; } - l = RegOpenKeyExW(HKEY_LOCAL_MACHINE, ProfileListW, 0, KEY_READ, &key); + l = RegOpenKeyExW(HKEY_LOCAL_MACHINE, + L"Software\\Microsoft\\Windows NT\\CurrentVersion\\ProfileList", + 0, KEY_READ, &key); if (l) { SetLastError(l); return FALSE; } - l = RegQueryValueExW(key, ProfilesDirectory, NULL, NULL, NULL, &len); + l = RegQueryValueExW(key, L"ProfilesDirectory", NULL, NULL, NULL, &len); if (l) { SetLastError(l); @@ -570,7 +568,7 @@ BOOL WINAPI GetProfilesDirectoryW( LPWSTR lpProfilesDir, LPDWORD lpcchSize ) SetLastError(ERROR_OUTOFMEMORY); goto end; } - l = RegQueryValueExW(key, ProfilesDirectory, NULL, NULL, + l = RegQueryValueExW(key, L"ProfilesDirectory", NULL, NULL, (BYTE *)unexpanded_profiles_dir, &len); if (l) {

1 0

Michael Stefaniuc : oleview: Inline WCHAR strings of length 1.
by Alexandre Julliard 17 Nov '20

17 Nov '20

Module: wine Branch: master Commit: d53577ef7559945f00a9ce7a0389d4d88464c240 URL: https://source.winehq.org/git/wine.git/?a=commit;h=d53577ef7559945f00a9ce7a… Author: Michael Stefaniuc <mstefani(a)winehq.org> Date: Tue Nov 17 00:55:19 2020 +0100 oleview: Inline WCHAR strings of length 1. Merge some of those strings. Signed-off-by: Michael Stefaniuc <mstefani(a)winehq.org> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- programs/oleview/typelib.c | 347 +++++++++++++++------------------------------ 1 file changed, 117 insertions(+), 230 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=d53577ef7559945f00a9…

1 0

Alexandre Julliard : msvcrt: Import _copysign() from musl.
by Alexandre Julliard 17 Nov '20

17 Nov '20

Module: wine Branch: master Commit: b1bc99f02553cc7db81ecbc567690687e1b4adb7 URL: https://source.winehq.org/git/wine.git/?a=commit;h=b1bc99f02553cc7db81ecbc5… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Nov 17 09:57:52 2020 +0100 msvcrt: Import _copysign() from musl. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/msvcrt/math.c | 22 ++++++++++++++-------- 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/dlls/msvcrt/math.c b/dlls/msvcrt/math.c index 8e8324b8fbe..069a2f7f387 100644 --- a/dlls/msvcrt/math.c +++ b/dlls/msvcrt/math.c @@ -177,12 +177,15 @@ float CDECL MSVCRT__chgsignf( float num ) /********************************************************************* * _copysignf (MSVCRT.@) + * + * Copied from musl: src/math/copysignf.c */ -float CDECL MSVCRT__copysignf( float num, float sign ) +float CDECL MSVCRT__copysignf( float x, float y ) { - if (signbit(sign)) - return signbit(num) ? num : -num; - return signbit(num) ? -num : num; + union { float f; UINT32 i; } ux = { x }, uy = { y }; + ux.i &= 0x7fffffff; + ux.i |= uy.i & 0x80000000; + return ux.f; } /********************************************************************* @@ -2126,12 +2129,15 @@ int CDECL MSVCRT_fesetround(int round_mode) /********************************************************************* * _copysign (MSVCRT.@) + * + * Copied from musl: src/math/copysign.c */ -double CDECL MSVCRT__copysign(double num, double sign) +double CDECL MSVCRT__copysign( double x, double y ) { - if (signbit(sign)) - return signbit(num) ? num : -num; - return signbit(num) ? -num : num; + union { double f; UINT64 i; } ux = { x }, uy = { y }; + ux.i &= ~0ull >> 1; + ux.i |= uy.i & 1ull << 63; + return ux.f; } /*********************************************************************

1 0

Alexandre Julliard : msvcrt: Import fabs() from musl.
by Alexandre Julliard 17 Nov '20

17 Nov '20

Module: wine Branch: master Commit: 44e122e04e2f37ef11cded89ab3a8fd2369b2b03 URL: https://source.winehq.org/git/wine.git/?a=commit;h=44e122e04e2f37ef11cded89… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Nov 17 09:58:19 2020 +0100 msvcrt: Import fabs() from musl. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/msvcrt/math.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/dlls/msvcrt/math.c b/dlls/msvcrt/math.c index 069a2f7f387..f5e933fc188 100644 --- a/dlls/msvcrt/math.c +++ b/dlls/msvcrt/math.c @@ -717,10 +717,14 @@ float CDECL MSVCRT_ceilf( float x ) /********************************************************************* * fabsf (MSVCRT.@) + * + * Copied from musl: src/math/fabsf.c */ float CDECL MSVCRT_fabsf( float x ) { - return fabsf(x); + union { float f; UINT32 i; } u = { x }; + u.i &= 0x7fffffff; + return u.f; } /********************************************************************* @@ -1610,10 +1614,14 @@ float CDECL MSVCRT_fmaf( float x, float y, float z ) /********************************************************************* * fabs (MSVCRT.@) + * + * Copied from musl: src/math/fabsf.c */ double CDECL MSVCRT_fabs( double x ) { - return fabs(x); + union { double f; UINT64 i; } u = { x }; + u.i &= ~0ull >> 1; + return u.f; } /*********************************************************************

1 0

Alexandre Julliard : msvcrt: Import ilogb() from musl.
by Alexandre Julliard 17 Nov '20

17 Nov '20

Module: wine Branch: master Commit: 48028c64ea58fb0196eec163e824229ba714db57 URL: https://source.winehq.org/git/wine.git/?a=commit;h=48028c64ea58fb0196eec163… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Nov 17 09:59:54 2020 +0100 msvcrt: Import ilogb() from musl. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- configure | 2 -- configure.ac | 2 -- dlls/msvcrt/math.c | 53 +++++++++++++++++++++++++++++++++++++---------------- include/config.h.in | 6 ------ 4 files changed, 37 insertions(+), 26 deletions(-) diff --git a/configure b/configure index e6409e264f9..4846c93e270 100755 --- a/configure +++ b/configure @@ -19512,8 +19512,6 @@ for ac_func in \ expm1f \ fma \ fmaf \ - ilogb \ - ilogbf \ j0 \ j1 \ jn \ diff --git a/configure.ac b/configure.ac index f70329b41ae..d09fedccbb1 100644 --- a/configure.ac +++ b/configure.ac @@ -2698,8 +2698,6 @@ AC_CHECK_FUNCS(\ expm1f \ fma \ fmaf \ - ilogb \ - ilogbf \ j0 \ j1 \ jn \ diff --git a/dlls/msvcrt/math.c b/dlls/msvcrt/math.c index f5e933fc188..6763b4a00dd 100644 --- a/dlls/msvcrt/math.c +++ b/dlls/msvcrt/math.c @@ -4402,32 +4402,53 @@ double CDECL MSVCR120_creal(_Dcomplex z) return z.x; } +/********************************************************************* + * ilogb (MSVCR120.@) + * + * Copied from musl: src/math/ilogb.c + */ int CDECL MSVCR120_ilogb(double x) { - if (!x) return MSVCRT_FP_ILOGB0; - if (isnan(x)) return MSVCRT_FP_ILOGBNAN; - if (isinf(x)) return MSVCRT_INT_MAX; + union { double f; UINT64 i; } u = { x }; + int e = u.i >> 52 & 0x7ff; -#ifdef HAVE_ILOGB - return ilogb(x); -#else - return logb(x); -#endif + if (!e) + { + u.i <<= 12; + if (u.i == 0) return MSVCRT_FP_ILOGB0; + /* subnormal x */ + for (e = -0x3ff; u.i >> 63 == 0; e--, u.i <<= 1); + return e; + } + if (e == 0x7ff) return u.i << 12 ? MSVCRT_FP_ILOGBNAN : MSVCRT_INT_MAX; + return e - 0x3ff; } +/********************************************************************* + * ilogbf (MSVCR120.@) + * + * Copied from musl: src/math/ilogbf.c + */ int CDECL MSVCR120_ilogbf(float x) { - if (!x) return MSVCRT_FP_ILOGB0; - if (isnan(x)) return MSVCRT_FP_ILOGBNAN; - if (isinf(x)) return MSVCRT_INT_MAX; + union { float f; UINT32 i; } u = { x }; + int e = u.i >> 23 & 0xff; -#ifdef HAVE_ILOGBF - return ilogbf(x); -#else - return logbf(x); -#endif + if (!e) + { + u.i <<= 9; + if (u.i == 0) return MSVCRT_FP_ILOGB0; + /* subnormal x */ + for (e = -0x7f; u.i >> 31 == 0; e--, u.i <<= 1); + return e; + } + if (e == 0xff) return u.i << 9 ? MSVCRT_FP_ILOGBNAN : MSVCRT_INT_MAX; + return e - 0x7f; } +/********************************************************************* + * ilogbl (MSVCR120.@) + */ int CDECL MSVCR120_ilogbl(LDOUBLE x) { return MSVCR120_ilogb(x); diff --git a/include/config.h.in b/include/config.h.in index 241fa7ede38..cd13b9d4bee 100644 --- a/include/config.h.in +++ b/include/config.h.in @@ -288,12 +288,6 @@ /* Define to 1 if you have the `if_nameindex' function. */ #undef HAVE_IF_NAMEINDEX -/* Define to 1 if you have the `ilogb' function. */ -#undef HAVE_ILOGB - -/* Define to 1 if you have the `ilogbf' function. */ -#undef HAVE_ILOGBF - /* Define to 1 if you have the <inet/mib2.h> header file. */ #undef HAVE_INET_MIB2_H

1 0

Alexandre Julliard : msvcrt: Use the global musl copyright notice.
by Alexandre Julliard 17 Nov '20

17 Nov '20

Module: wine Branch: master Commit: 9fa7b779f8292a3a44608cc0966c156fa2ff4faf URL: https://source.winehq.org/git/wine.git/?a=commit;h=9fa7b779f8292a3a44608cc0… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Nov 17 13:45:45 2020 +0100 msvcrt: Use the global musl copyright notice. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/msvcrt/math.c | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/dlls/msvcrt/math.c b/dlls/msvcrt/math.c index 6763b4a00dd..c27b77eca93 100644 --- a/dlls/msvcrt/math.c +++ b/dlls/msvcrt/math.c @@ -18,14 +18,20 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA * * - * For functions copied from musl (http://www.musl-libc.org/) + * For functions copied from musl libc (http://musl.libc.org/) * ==================================================== - * Copyright (C) 1993 by Sun Microsystems, Inc. All rights reserved. + * Copyright 2005-2020 Rich Felker, et al. * - * Developed at SunPro, a Sun Microsystems, Inc. business. - * Permission to use, copy, modify, and distribute this - * software is freely granted, provided that this notice - * is preserved. + * Permission is hereby granted, free of charge, to any person obtaining + * a copy of this software and associated documentation files (the + * "Software"), to deal in the Software without restriction, including + * without limitation the rights to use, copy, modify, merge, publish, + * distribute, sublicense, and/or sell copies of the Software, and to + * permit persons to whom the Software is furnished to do so, subject to + * the following conditions: + * + * The above copyright notice and this permission notice shall be + * included in all copies or substantial portions of the Software. * ==================================================== */

1 0

Alexandre Julliard : msvcrt: Add floating point classification macros.
by Alexandre Julliard 17 Nov '20

17 Nov '20

Module: wine Branch: master Commit: b9002cc8c7ae16b4a61476834318bcefd638e34f URL: https://source.winehq.org/git/wine.git/?a=commit;h=b9002cc8c7ae16b4a6147683… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Nov 17 10:12:34 2020 +0100 msvcrt: Add floating point classification macros. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- configure | 2 -- configure.ac | 2 -- dlls/msvcrt/math.c | 58 ++++++++++++++++++++------------------------------- dlls/msvcrt/msvcrt.h | 52 +++++++++++++++++++++++++++++++++++++++++++++ dlls/msvcrt/printf.h | 4 ---- include/config.h.in | 6 ------ include/msvcrt/math.h | 54 +++++++++++++++++++++++++++++++++++++++++++---- 7 files changed, 125 insertions(+), 53 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=b9002cc8c7ae16b4a614…

1 0

Alexandre Julliard : msvcrt: Avoid long double type in $I10_OUTPUT().
by Alexandre Julliard 17 Nov '20

17 Nov '20

Module: wine Branch: master Commit: 1f27361894ab3160c1f57a0f7f384920af0b21e5 URL: https://source.winehq.org/git/wine.git/?a=commit;h=1f27361894ab3160c1f57a0f… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Nov 17 10:13:31 2020 +0100 msvcrt: Avoid long double type in $I10_OUTPUT(). Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/msvcrt/string.c | 43 ++++++++++------------- dlls/msvcrt/tests/misc.c | 90 +++++++++++++++++++++++++----------------------- 2 files changed, 64 insertions(+), 69 deletions(-) diff --git a/dlls/msvcrt/string.c b/dlls/msvcrt/string.c index 3343f1e3ccf..7ad84a31858 100644 --- a/dlls/msvcrt/string.c +++ b/dlls/msvcrt/string.c @@ -2390,20 +2390,29 @@ struct _I10_OUTPUT_DATA { */ int CDECL MSVCRT_I10_OUTPUT(MSVCRT__LDOUBLE ld80, int prec, int flag, struct _I10_OUTPUT_DATA *data) { - static const char inf_str[] = "1#INF"; - static const char nan_str[] = "1#QNAN"; - - /* MS' long double type wants 12 bytes for Intel's 80 bit FP format. - * Some UNIX have sizeof(long double) == 16, yet only 80 bit are used. - * Assume long double uses 80 bit FP, never seen 128 bit FP. */ - long double ld = 0; + struct fpnum num; double d; char format[8]; char buf[I10_OUTPUT_MAX_PREC+9]; /* 9 = strlen("0.e+0000") + '\0' */ char *p; - memcpy(&ld, &ld80, 10); - d = ld; + if ((ld80.x80[2] & 0x7fff) == 0x7fff) + { + if (ld80.x80[0] == 0 && ld80.x80[1] == 0x80000000) + strcpy( data->str, "1#INF" ); + else + strcpy( data->str, (ld80.x80[1] & 0x40000000) ? "1#QNAN" : "1#SNAN" ); + data->pos = 1; + data->sign = (ld80.x80[2] & 0x8000) ? '-' : ' '; + data->len = strlen(data->str); + return 0; + } + + num.sign = (ld80.x80[2] & 0x8000) ? -1 : 1; + num.exp = (ld80.x80[2] & 0x7fff) - 0x3fff - 63; + num.m = ld80.x80[0] | ((ULONGLONG)ld80.x80[1] << 32); + num.mod = FP_ROUND_EVEN; + fpnum_double( &num, &d ); TRACE("(%lf %d %x %p)\n", d, prec, flag, data); if(d<0) { @@ -2412,22 +2421,6 @@ int CDECL MSVCRT_I10_OUTPUT(MSVCRT__LDOUBLE ld80, int prec, int flag, struct _I1 } else data->sign = ' '; - if(isinf(d)) { - data->pos = 1; - data->len = 5; - memcpy(data->str, inf_str, sizeof(inf_str)); - - return 0; - } - - if(isnan(d)) { - data->pos = 1; - data->len = 6; - memcpy(data->str, nan_str, sizeof(nan_str)); - - return 0; - } - if(flag&1) { int exp = 1+floor(log10(d)); diff --git a/dlls/msvcrt/tests/misc.c b/dlls/msvcrt/tests/misc.c index d77b6c8edfe..e262983e7e6 100644 --- a/dlls/msvcrt/tests/misc.c +++ b/dlls/msvcrt/tests/misc.c @@ -30,8 +30,11 @@ static inline BOOL almost_equal(double d1, double d2) { return FALSE; } +/* MS' "long double" is an 80 bit FP that takes 12 bytes*/ +struct uld { ULONG lo, hi, exp; }; + static int (__cdecl *prand_s)(unsigned int *); -static int (__cdecl *pI10_OUTPUT)(long double, int, int, void*); +static int (__cdecl *pI10_OUTPUT)(struct uld, int, int, void*); static int (__cdecl *pstrerror_s)(char *, size_t, int); static int (__cdecl *p_get_doserrno)(int *); static int (__cdecl *p_get_errno)(int *); @@ -94,7 +97,7 @@ typedef struct _I10_OUTPUT_data { } I10_OUTPUT_data; typedef struct _I10_OUTPUT_test { - long double d; + struct uld d; int size; int flags; @@ -105,63 +108,62 @@ typedef struct _I10_OUTPUT_test { static const I10_OUTPUT_test I10_OUTPUT_tests[] = { /* arg3 = 0 */ - { 0.0, 10, 0, {0, ' ', 1, "0"}, 1, "" }, - { 1.0, 10, 0, {1, ' ', 1, "1"}, 1, "000000009" }, - { -1.0, 10, 0, {1, '-', 1, "1"}, 1, "000000009" }, - { 1.23, 10, 0, {1, ' ', 3, "123"}, 1, "0000009" }, - { 1e13, 10, 0, {14, ' ', 1, "1"}, 1, "000000009" }, - { 1e30, 30, 0, {31, ' ', 21, "100000000000000001988"}, 1, "" }, - { 1e-13, 10, 0, {-12, ' ', 1, "1"}, 1, "000000000" }, - { 0.25, 10, 0, {0, ' ', 2, "25"}, 1, "00000000" }, - { 1.0000001, 10, 0, {1, ' ', 8, "10000001"}, 1, "00" }, + { { 0x00000000, 0x00000000, 0x0000 /* 0.0 */ }, 10, 0, {0, ' ', 1, "0"}, 1, "" }, + { { 0x00000000, 0x80000000, 0x3fff /* 1.0 */ }, 10, 0, {1, ' ', 1, "1"}, 1, "000000009" }, + { { 0x00000000, 0x80000000, 0xbfff /* -1.0 */ }, 10, 0, {1, '-', 1, "1"}, 1, "000000009" }, + { { 0x0a3d7000, 0x9d70a3d7, 0x3fff /* 1.23 */ }, 10, 0, {1, ' ', 3, "123"}, 1, "0000009" }, + { { 0x00000000, 0x9184e72a, 0x402a /* 1e13 */ }, 10, 0, {14, ' ', 1, "1"}, 1, "000000009" }, + { { 0x04675000, 0xc9f2c9cd, 0x4062 /* 1e30 */ }, 30, 0, {31, ' ', 21, "100000000000000001988"}, 1, "" }, + { { 0x4bb41000, 0xe12e1342, 0x3fd3 /* 1e-13 */ }, 10, 0, {-12, ' ', 1, "1"}, 1, "000000000" }, + { { 0x00000000, 0x80000000, 0x3ffd /* 0.25 */ }, 10, 0, {0, ' ', 2, "25"}, 1, "00000000" }, + { { 0xbf94d800, 0x800000d6, 0x3fff /* 1.0000001 */ }, 10, 0, {1, ' ', 8, "10000001"}, 1, "00" }, + { { 0x00000000, 0x80000000, 0x7fff /* +inf */ }, 10, 0, {1, ' ', 5, "1#INF"}, 0, "" }, + { { 0x00000000, 0x80000000, 0xffff /* -inf */ }, 10, 0, {1, '-', 5, "1#INF"}, 0, "" }, + { { 0x00000001, 0x80000000, 0x7fff /* snan */ }, 10, 0, {1, ' ', 6, "1#SNAN"}, 0, "" }, + { { 0x00000001, 0x80000000, 0xffff /* snan */ }, 10, 0, {1, '-', 6, "1#SNAN"}, 0, "" }, + { { 0x00000000, 0xc0000000, 0x7fff /* qnan */ }, 10, 0, {1, ' ', 6, "1#QNAN"}, 0, "" }, + { { 0x00000000, 0x40000000, 0xffff /* qnan */ }, 10, 0, {1, '-', 6, "1#QNAN"}, 0, "" }, /* arg3 = 1 */ - { 0.0, 10, 1, {0, ' ', 1, "0"}, 1, "" }, - { 1.0, 10, 1, {1, ' ', 1, "1"}, 1, "0000000009" }, - { -1.0, 10, 1, {1, '-', 1, "1"}, 1, "0000000009" }, - { 1.23, 10, 1, {1, ' ', 3, "123"}, 1, "00000009" }, - { 1e13, 10, 1, {14, ' ', 1, "1"}, 1, "00000000000000000009" }, - { 1e30, 30, 1, {31, ' ', 21, "100000000000000001988"}, 1, "" }, - { 1e-13, 10, 1, {0, ' ', 1, "0"}, 1, "" }, - { 1e-7, 10, 1, {-6, ' ', 1, "1"}, 1, "09" }, - { 0.25, 10, 1, {0, ' ', 2, "25"}, 1, "00000000" }, - { 1.0000001, 10, 1, {1, ' ', 8, "10000001"}, 1, "000" }, + { { 0x00000000, 0x00000000, 0x0000 /* 0 */ }, 10, 1, {0, ' ', 1, "0"}, 1, "" }, + { { 0x00000000, 0x80000000, 0x3fff /* 1 */ }, 10, 1, {1, ' ', 1, "1"}, 1, "0000000009" }, + { { 0x00000000, 0x80000000, 0xbfff /* -1 */ }, 10, 1, {1, '-', 1, "1"}, 1, "0000000009" }, + { { 0x0a3d7000, 0x9d70a3d7, 0x3fff /* 1.23 */ }, 10, 1, {1, ' ', 3, "123"}, 1, "00000009" }, + { { 0x00000000, 0x9184e72a, 0x402a /* 1e13 */ }, 10, 1, {14, ' ', 1, "1"}, 1, "00000000000000000009" }, + { { 0x04675000, 0xc9f2c9cd, 0x4062 /* 1e30 */ }, 30, 1, {31, ' ', 21, "100000000000000001988"}, 1, "" }, + { { 0x4bb41000, 0xe12e1342, 0x3fd3 /* 1e-13 */ }, 10, 1, {0, ' ', 1, "0"}, 1, "" }, + { { 0xe57a4000, 0xd6bf94d5, 0x3fe7 /* 1e-7 */ }, 10, 1, {-6, ' ', 1, "1"}, 1, "09" }, + { { 0x00000000, 0x80000000, 0x3ffd /* 0.25 */ }, 10, 1, {0, ' ', 2, "25"}, 1, "00000000" }, + { { 0xbf94d800, 0x800000d6, 0x3fff /* 1.0000001 */ }, 10, 1, {1, ' ', 8, "10000001"}, 1, "000" }, + { { 0x00000000, 0x80000000, 0x7fff /* +inf */ }, 10, 1, {1, ' ', 5, "1#INF"}, 0, "" }, + { { 0x00000000, 0x80000000, 0xffff /* -inf */ }, 10, 1, {1, '-', 5, "1#INF"}, 0, "" }, + { { 0x00000001, 0x80000000, 0x7fff /* snan */ }, 10, 1, {1, ' ', 6, "1#SNAN"}, 0, "" }, + { { 0x00000000, 0xc0000000, 0x7fff /* qnan */ }, 10, 1, {1, ' ', 6, "1#QNAN"}, 0, "" }, + { { 0x00000000, 0x40000000, 0x7fff /* qnan */ }, 10, 1, {1, ' ', 6, "1#QNAN"}, 0, "" }, /* too small buffer */ - { 0.0, 0, 0, {0, ' ', 1, "0"}, 1, "" }, - { 0.0, 0, 1, {0, ' ', 1, "0"}, 1, "" }, - { 123.0, 2, 0, {3, ' ', 2, "12"}, 1, "" }, - { 123.0, 0, 0, {0, ' ', 1, "0"}, 1, "" }, - { 123.0, 2, 1, {3, ' ', 3, "123"}, 1, "09" }, - { 0.99, 1, 0, {1, ' ', 1, "1"}, 1, "" }, - { 1264567.0, 2, 0, {7, ' ', 2, "13"}, 1, "" }, - { 1264567.0, 2, 1, {7, ' ', 7, "1264567"}, 1, "00" }, - { 1234567891.0, 2, 1, {10, ' ', 10, "1234567891"}, 1, "09" } + { { 0x00000000, 0x00000000, 0x0000 /* 0 */ }, 0, 0, {0, ' ', 1, "0"}, 1, "" }, + { { 0x00000000, 0x00000000, 0x0000 /* 0 */ }, 0, 1, {0, ' ', 1, "0"}, 1, "" }, + { { 0x00000000, 0xf6000000, 0x4005 /* 123 */ }, 2, 0, {3, ' ', 2, "12"}, 1, "" }, + { { 0x00000000, 0xf6000000, 0x4005 /* 123 */ }, 0, 0, {0, ' ', 1, "0"}, 1, "" }, + { { 0x00000000, 0xf6000000, 0x4005 /* 123 */ }, 2, 1, {3, ' ', 3, "123"}, 1, "09" }, + { { 0x0a3d7000, 0xfd70a3d7, 0x3ffe /* 0.99 */ }, 1, 0, {1, ' ', 1, "1"}, 1, "" }, + { { 0x00000000, 0x9a5db800, 0x4013 /* 1264567.0 */ }, 2, 0, {7, ' ', 2, "13"}, 1, "" }, + { { 0x00000000, 0x9a5db800, 0x4013 /* 1264567.0 */ }, 2, 1, {7, ' ', 7, "1264567"}, 1, "00" }, + { { 0x00000000, 0x932c05a6, 0x401d /* 1234567891.0 */ }, 2, 1, {10, ' ', 10, "1234567891"}, 1, "09" } }; static void test_I10_OUTPUT(void) { I10_OUTPUT_data out; - int i, j = sizeof(long double), ret; + int i, j, ret; if(!pI10_OUTPUT) { win_skip("I10_OUTPUT not available\n"); return; } - if (j != 12) - trace("sizeof(long double) = %d on this machine\n", j); for(i=0; i<ARRAY_SIZE(I10_OUTPUT_tests); i++) { memset(out.str, '#', sizeof(out.str)); - - if (sizeof(long double) == 12) - ret = pI10_OUTPUT(I10_OUTPUT_tests[i].d, I10_OUTPUT_tests[i].size, I10_OUTPUT_tests[i].flags, &out); - else { - /* MS' "long double" is an 80 bit FP that takes 12 bytes*/ - typedef struct { ULONG x80[3]; } uld; /* same calling convention */ - union { long double ld; uld ld12; } fp80; - int (__cdecl *pI10_OUTPUT12)(uld, int, int, void*) = (void*)pI10_OUTPUT; - fp80.ld = I10_OUTPUT_tests[i].d; - ret = pI10_OUTPUT12(fp80.ld12, I10_OUTPUT_tests[i].size, I10_OUTPUT_tests[i].flags, &out); - } + ret = pI10_OUTPUT(I10_OUTPUT_tests[i].d, I10_OUTPUT_tests[i].size, I10_OUTPUT_tests[i].flags, &out); ok(ret == I10_OUTPUT_tests[i].ret, "%d: ret = %d\n", i, ret); ok(out.pos == I10_OUTPUT_tests[i].out.pos, "%d: out.pos = %hd\n", i, out.pos); ok(out.sign == I10_OUTPUT_tests[i].out.sign, "%d: out.size = %c\n", i, out.sign);

1 0

Alexandre Julliard : jscript: Use the standard isfinite() function.
by Alexandre Julliard 17 Nov '20

17 Nov '20

Module: wine Branch: master Commit: 061c747bfaeede8ee9566d9837c442f9415c80b3 URL: https://source.winehq.org/git/wine.git/?a=commit;h=061c747bfaeede8ee9566d98… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Nov 17 10:12:44 2020 +0100 jscript: Use the standard isfinite() function. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/jscript/global.c | 2 +- dlls/jscript/jscript.h | 1 - dlls/jscript/json.c | 2 +- dlls/jscript/jsutils.c | 5 ----- dlls/jscript/number.c | 8 ++++---- 5 files changed, 6 insertions(+), 12 deletions(-) diff --git a/dlls/jscript/global.c b/dlls/jscript/global.c index 64f7bbda959..d5aafe65037 100644 --- a/dlls/jscript/global.c +++ b/dlls/jscript/global.c @@ -238,7 +238,7 @@ static HRESULT JSGlobal_isFinite(script_ctx_t *ctx, vdisp_t *jsthis, WORD flags, if(FAILED(hres)) return hres; - ret = is_finite(n); + ret = isfinite(n); } if(r) diff --git a/dlls/jscript/jscript.h b/dlls/jscript/jscript.h index e1ab5e5824f..dfe087521db 100644 --- a/dlls/jscript/jscript.h +++ b/dlls/jscript/jscript.h @@ -364,7 +364,6 @@ HRESULT variant_change_type(script_ctx_t*,VARIANT*,VARIANT*,VARTYPE) DECLSPEC_HI HRESULT decode_source(WCHAR*) DECLSPEC_HIDDEN; HRESULT double_to_string(double,jsstr_t**) DECLSPEC_HIDDEN; -BOOL is_finite(double) DECLSPEC_HIDDEN; static inline BOOL is_digit(WCHAR c) { diff --git a/dlls/jscript/json.c b/dlls/jscript/json.c index 433c7858cb6..de10ceadd11 100644 --- a/dlls/jscript/json.c +++ b/dlls/jscript/json.c @@ -700,7 +700,7 @@ static HRESULT stringify(stringify_ctx_t *ctx, jsval_t val) } case JSV_NUMBER: { double n = get_number(value); - if(is_finite(n)) { + if(isfinite(n)) { const WCHAR *ptr; jsstr_t *str; diff --git a/dlls/jscript/jsutils.c b/dlls/jscript/jsutils.c index 421116f171b..b12addda794 100644 --- a/dlls/jscript/jsutils.c +++ b/dlls/jscript/jsutils.c @@ -51,11 +51,6 @@ const char *debugstr_jsval(const jsval_t v) return NULL; } -BOOL is_finite(double n) -{ - return !isnan(n) && !isinf(n); -} - #define MIN_BLOCK_SIZE 128 #define ARENA_FREE_FILLER 0xaa diff --git a/dlls/jscript/number.c b/dlls/jscript/number.c index 36384bf0621..fc6bfe10cc9 100644 --- a/dlls/jscript/number.c +++ b/dlls/jscript/number.c @@ -247,7 +247,7 @@ static HRESULT Number_toString(script_ctx_t *ctx, vdisp_t *jsthis, WORD flags, u val = number->value; - if(radix==10 || !is_finite(val)) { + if(radix==10 || !isfinite(val)) { hres = to_string(ctx, jsval_number(val), &str); if(FAILED(hres)) return hres; @@ -373,7 +373,7 @@ static HRESULT Number_toFixed(script_ctx_t *ctx, vdisp_t *jsthis, WORD flags, un } val = number->value; - if(!is_finite(val)) { + if(!isfinite(val)) { hres = to_string(ctx, jsval_number(val), &str); if(FAILED(hres)) return hres; @@ -414,7 +414,7 @@ static HRESULT Number_toExponential(script_ctx_t *ctx, vdisp_t *jsthis, WORD fla } val = number->value; - if(!is_finite(val)) { + if(!isfinite(val)) { hres = to_string(ctx, jsval_number(val), &str); if(FAILED(hres)) return hres; @@ -455,7 +455,7 @@ static HRESULT Number_toPrecision(script_ctx_t *ctx, vdisp_t *jsthis, WORD flags } val = number->value; - if(!is_finite(val) || !prec) { + if(!isfinite(val) || !prec) { hres = to_string(ctx, jsval_number(val), &str); if(FAILED(hres)) return hres;

1 0