November 2020 - Wine-commits

Zebediah Figura : quartz/tests: Add some more tests for seeking formats.
by Alexandre Julliard 02 Nov '20

02 Nov '20

Module: wine Branch: master Commit: 294de6f218957442b9c281e34862803b83db8d3a URL: https://source.winehq.org/git/wine.git/?a=commit;h=294de6f218957442b9c281e3… Author: Zebediah Figura <z.figura12(a)gmail.com> Date: Mon Nov 2 12:25:16 2020 -0600 quartz/tests: Add some more tests for seeking formats. Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/quartz/tests/filtergraph.c | 100 ++++++++++++++++++++++++++++++++++------ 1 file changed, 85 insertions(+), 15 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=294de6f218957442b9c2…

1 0

Zebediah Figura : quartz: Treat a filter as supporting IMediaSeeking only if it supports TIME_FORMAT_MEDIA_TIME.
by Alexandre Julliard 02 Nov '20

02 Nov '20

Module: wine Branch: master Commit: dfa4c07941322dbcad54507cd0acf271a6c719ab URL: https://source.winehq.org/git/wine.git/?a=commit;h=dfa4c07941322dbcad54507c… Author: Zebediah Figura <z.figura12(a)gmail.com> Date: Mon Nov 2 12:25:17 2020 -0600 quartz: Treat a filter as supporting IMediaSeeking only if it supports TIME_FORMAT_MEDIA_TIME. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=48715 Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/quartz/filtergraph.c | 11 +++++++++-- dlls/quartz/tests/filtergraph.c | 10 +++++----- dlls/quartz/tests/videorenderer.c | 8 ++++---- 3 files changed, 18 insertions(+), 11 deletions(-) diff --git a/dlls/quartz/filtergraph.c b/dlls/quartz/filtergraph.c index e5ae12d9452..0f22bb5888c 100644 --- a/dlls/quartz/filtergraph.c +++ b/dlls/quartz/filtergraph.c @@ -585,6 +585,8 @@ static BOOL has_output_pins(IBaseFilter *filter) static void update_seeking(struct filter *filter) { + IMediaSeeking *seeking; + if (!filter->seeking) { /* The Legend of Heroes: Trails of Cold Steel II destroys its filter when @@ -593,8 +595,13 @@ static void update_seeking(struct filter *filter) * Some filters (e.g. MediaStreamFilter) can become seekable when they are * already in the graph, so always try to query IMediaSeeking if it's not * cached yet. */ - if (FAILED(IBaseFilter_QueryInterface(filter->filter, &IID_IMediaSeeking, (void **)&filter->seeking))) - filter->seeking = NULL; + if (SUCCEEDED(IBaseFilter_QueryInterface(filter->filter, &IID_IMediaSeeking, (void **)&seeking))) + { + if (IMediaSeeking_IsFormatSupported(seeking, &TIME_FORMAT_MEDIA_TIME) == S_OK) + filter->seeking = seeking; + else + IMediaSeeking_Release(seeking); + } } } diff --git a/dlls/quartz/tests/filtergraph.c b/dlls/quartz/tests/filtergraph.c index ba63853ec7b..20a730f6aa0 100644 --- a/dlls/quartz/tests/filtergraph.c +++ b/dlls/quartz/tests/filtergraph.c @@ -3914,9 +3914,9 @@ static void test_ec_complete(void) IFilterGraph2_AddFilter(graph, &filter1.IBaseFilter_iface, NULL); hr = check_ec_complete(graph, &filter1.IBaseFilter_iface); - todo_wine ok(hr == E_ABORT, "Got hr %#x.\n", hr); + ok(hr == E_ABORT, "Got hr %#x.\n", hr); - todo_wine ok(filter1.seeking_ref == 0, "Unexpected seeking refcount %d.\n", filter1.seeking_ref); + ok(filter1.seeking_ref == 0, "Unexpected seeking refcount %d.\n", filter1.seeking_ref); IFilterGraph2_RemoveFilter(graph, &filter1.IBaseFilter_iface); filter1.IMediaSeeking_iface.lpVtbl = NULL; @@ -4157,7 +4157,7 @@ static void test_graph_seeking(void) filter1.support_testguid = TRUE; hr = IMediaSeeking_GetDuration(seeking, &time); - todo_wine ok(hr == E_NOTIMPL, "Got hr %#x.\n", hr); + ok(hr == E_NOTIMPL, "Got hr %#x.\n", hr); hr = IMediaSeeking_SetTimeFormat(seeking, &testguid); todo_wine ok(hr == E_NOTIMPL, "Got hr %#x.\n", hr); @@ -4269,8 +4269,8 @@ static void test_graph_seeking(void) hr = IMediaSeeking_GetCapabilities(seeking, &caps); ok(hr == S_OK, "Got hr %#x.\n", hr); - todo_wine ok(caps == (AM_SEEKING_CanDoSegments | AM_SEEKING_CanGetDuration), "Got caps %#x.\n", caps); - todo_wine ok(!filter1.seeking_ref, "Unexpected seeking refcount %d.\n", filter1.seeking_ref); + ok(caps == (AM_SEEKING_CanDoSegments | AM_SEEKING_CanGetDuration), "Got caps %#x.\n", caps); + ok(!filter1.seeking_ref, "Unexpected seeking refcount %d.\n", filter1.seeking_ref); ok(filter2.seeking_ref > 0, "Unexpected seeking refcount %d.\n", filter2.seeking_ref); filter1.support_media_time = TRUE; diff --git a/dlls/quartz/tests/videorenderer.c b/dlls/quartz/tests/videorenderer.c index 448efe501b6..ed2639d2736 100644 --- a/dlls/quartz/tests/videorenderer.c +++ b/dlls/quartz/tests/videorenderer.c @@ -1156,7 +1156,7 @@ static void test_eos(IPin *pin, IMemInputPin *input, IFilterGraph2 *graph) hr = IMediaControl_GetState(control, 1000, &state); ok(hr == S_OK, "Got hr %#x.\n", hr); ret = check_ec_complete(eventsrc, 0); - todo_wine ok(!ret, "Got unexpected EC_COMPLETE.\n"); + ok(!ret, "Got unexpected EC_COMPLETE.\n"); hr = join_thread(send_frame(input)); todo_wine ok(hr == E_UNEXPECTED, "Got hr %#x.\n", hr); @@ -1186,7 +1186,7 @@ static void test_eos(IPin *pin, IMemInputPin *input, IFilterGraph2 *graph) hr = IPin_EndOfStream(pin); ok(hr == S_OK, "Got hr %#x.\n", hr); ret = check_ec_complete(eventsrc, 0); - todo_wine ok(!ret, "Got unexpected EC_COMPLETE.\n"); + ok(!ret, "Got unexpected EC_COMPLETE.\n"); ret = check_ec_complete(eventsrc, 1600); todo_wine ok(ret == 1, "Expected EC_COMPLETE.\n"); @@ -1212,7 +1212,7 @@ static void test_eos(IPin *pin, IMemInputPin *input, IFilterGraph2 *graph) hr = IMediaControl_Stop(control); ok(hr == S_OK, "Got hr %#x.\n", hr); ret = check_ec_complete(eventsrc, 0); - todo_wine ok(!ret, "Got unexpected EC_COMPLETE.\n"); + ok(!ret, "Got unexpected EC_COMPLETE.\n"); /* Test sending EOS and then flushing or stopping. */ @@ -1226,7 +1226,7 @@ static void test_eos(IPin *pin, IMemInputPin *input, IFilterGraph2 *graph) hr = IPin_EndOfStream(pin); ok(hr == S_OK, "Got hr %#x.\n", hr); ret = check_ec_complete(eventsrc, 0); - todo_wine ok(!ret, "Got unexpected EC_COMPLETE.\n"); + ok(!ret, "Got unexpected EC_COMPLETE.\n"); hr = IPin_BeginFlush(pin); ok(hr == S_OK, "Got hr %#x.\n", hr);

1 0

Aurimas Fišeras : po: Update Lithuanian translation.
by Alexandre Julliard 02 Nov '20

02 Nov '20

Module: wine Branch: master Commit: c438a62ddf2ede2b323159ca052e545f8c0d5831 URL: https://source.winehq.org/git/wine.git/?a=commit;h=c438a62ddf2ede2b323159ca… Author: Aurimas Fišeras <aurimas(a)members.fsf.org> Date: Fri Oct 30 23:36:22 2020 +0200 po: Update Lithuanian translation. Signed-off-by: Aurimas Fišeras <aurimas(a)members.fsf.org> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- po/lt.po | 18 +++++------------- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/po/lt.po b/po/lt.po index 620e3e21b9b..3853dcb229c 100644 --- a/po/lt.po +++ b/po/lt.po @@ -5,7 +5,7 @@ msgstr "" "Project-Id-Version: Wine\n" "Report-Msgid-Bugs-To: https://bugs.winehq.org\n" "POT-Creation-Date: N/A\n" -"PO-Revision-Date: 2020-10-29 23:45+0200\n" +"PO-Revision-Date: 2020-10-30 23:36+0200\n" "Last-Translator: Aurimas Fišeras <aurimas(a)members.fsf.org>\n" "Language-Team: Lithuanian <komp_lt(a)konf.lt>\n" "Language: lt\n" @@ -9902,16 +9902,12 @@ msgid "Iran Daylight Time" msgstr "Irano vasaros laikas" #: dlls/tzres/tzres.rc:200 -#, fuzzy -#| msgid "Haiti Standard Time" msgid "Saint Pierre Standard Time" -msgstr "Haičio juostinis laikas" +msgstr "Sen Pjero juostinis laikas" #: dlls/tzres/tzres.rc:201 -#, fuzzy -#| msgid "Haiti Daylight Time" msgid "Saint Pierre Daylight Time" -msgstr "Haičio vasaros laikas" +msgstr "Sen Pjero vasaros laikas" #: dlls/tzres/tzres.rc:166 msgid "Namibia Standard Time" @@ -10002,16 +9998,12 @@ msgid "Azerbaijan Daylight Time" msgstr "Azerbaidžano vasaros laikas" #: dlls/tzres/tzres.rc:146 -#, fuzzy -#| msgid "Magadan Standard Time" msgid "Magallanes Standard Time" -msgstr "Magadano juostinis laikas" +msgstr "Magelano juostinis laikas" #: dlls/tzres/tzres.rc:147 -#, fuzzy -#| msgid "Magadan Daylight Time" msgid "Magallanes Daylight Time" -msgstr "Magadano vasaros laikas" +msgstr "Magelano vasaros laikas" #: dlls/tzres/tzres.rc:202 msgid "Samoa Standard Time"

1 0

Alexandre Julliard : gdi32: Move the font link support out of freetype.c.
by Alexandre Julliard 02 Nov '20

02 Nov '20

Module: wine Branch: master Commit: bc19adf47406190b95266868f896c3d94789a255 URL: https://source.winehq.org/git/wine.git/?a=commit;h=bc19adf47406190b95266868… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Sat Oct 31 10:19:08 2020 +0100 gdi32: Move the font link support out of freetype.c. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/gdi32/font.c | 286 +++++++++++++++++++++++++++++++- dlls/gdi32/freetype.c | 420 ++++------------------------------------------- dlls/gdi32/gdi_private.h | 21 ++- 3 files changed, 336 insertions(+), 391 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=bc19adf47406190b9526…

1 0

Alexandre Julliard : gdi32: Move the creation of the child font list out of freetype.c.
by Alexandre Julliard 02 Nov '20

02 Nov '20

Module: wine Branch: master Commit: 8d4336c5fa8ac99365629d142dae50860468dc2f URL: https://source.winehq.org/git/wine.git/?a=commit;h=8d4336c5fa8ac99365629d14… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Sat Oct 31 10:20:26 2020 +0100 gdi32: Move the creation of the child font list out of freetype.c. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/gdi32/font.c | 78 +++++++++++++++++++++++++++++++++++++++++ dlls/gdi32/freetype.c | 91 ------------------------------------------------ dlls/gdi32/gdi_private.h | 1 + 3 files changed, 79 insertions(+), 91 deletions(-) diff --git a/dlls/gdi32/font.c b/dlls/gdi32/font.c index 4dabc332736..3f6e74fee1c 100644 --- a/dlls/gdi32/font.c +++ b/dlls/gdi32/font.c @@ -1446,6 +1446,84 @@ static UINT get_GSUB_vert_glyph( struct gdi_font *font, UINT glyph ) return GSUB_apply_feature( font->gsub_table, font->vert_feature, glyph ); } +static void add_child_font( struct gdi_font *font, const WCHAR *family_name ) +{ + struct gdi_font *child; + struct gdi_font_family *family; + struct gdi_font_face *child_face, *best_face = NULL; + UINT penalty = 0, new_penalty = 0; + BOOL bold, italic, bd, it; + + italic = !!font->lf.lfItalic; + bold = font->lf.lfWeight > FW_MEDIUM; + + if (!(family = find_family_from_name( family_name ))) return; + + LIST_FOR_EACH_ENTRY( child_face, get_family_face_list(family), struct gdi_font_face, entry ) + { + it = !!(child_face->ntmFlags & NTM_ITALIC); + bd = !!(child_face->ntmFlags & NTM_BOLD); + new_penalty = ( it ^ italic ) + ( bd ^ bold ); + if (!best_face || new_penalty < penalty) + { + penalty = new_penalty; + best_face = child_face; + } + } + if (!best_face) return; + + child = alloc_gdi_font( best_face->file, best_face->data_ptr, best_face->data_size ); + child->fake_italic = italic && !(best_face->ntmFlags & NTM_ITALIC); + child->fake_bold = bold && !(best_face->ntmFlags & NTM_BOLD); + child->lf = font->lf; + child->matrix = font->matrix; + child->can_use_bitmap = font->can_use_bitmap; + child->face_index = best_face->face_index; + child->ntmFlags = best_face->ntmFlags; + child->aa_flags = HIWORD( best_face->flags ); + child->scale_y = font->scale_y; + child->aveWidth = font->aveWidth; + child->charset = font->charset; + child->codepage = font->codepage; + child->base_font = font; + set_gdi_font_names( child, family_name, best_face->style_name, best_face->full_name ); + + list_add_tail( &font->child_fonts, &child->entry ); + TRACE( "created child font %p for base %p\n", child, font ); +} + +void create_child_font_list( struct gdi_font *font ) +{ + static const WCHAR szDefaultFallbackLink[] = {'M','i','c','r','o','s','o','f','t',' ','S','a','n','s',' ','S','e','r','i','f',0}; + struct gdi_font_link *font_link; + struct gdi_font_link_entry *entry; + const WCHAR* font_name; + + if (!(font_name = get_gdi_font_subst( get_gdi_font_name(font), -1, NULL ))) + font_name = get_gdi_font_name( font ); + + if ((font_link = find_gdi_font_link( font_name ))) + { + TRACE("found entry in system list\n"); + LIST_FOR_EACH_ENTRY( entry, &font_link->links, struct gdi_font_link_entry, entry ) + add_child_font( font, entry->family_name ); + } + /* + * if not SYMBOL or OEM then we also get all the fonts for Microsoft + * Sans Serif. This is how asian windows get default fallbacks for fonts + */ + if (is_dbcs_ansi_cp(GetACP()) && font->charset != SYMBOL_CHARSET && font->charset != OEM_CHARSET && + strcmpiW( font_name, szDefaultFallbackLink ) != 0) + { + if ((font_link = find_gdi_font_link( szDefaultFallbackLink ))) + { + TRACE("found entry in default fallback list\n"); + LIST_FOR_EACH_ENTRY( entry, &font_link->links, struct gdi_font_link_entry, entry ) + add_child_font( font, entry->family_name ); + } + } +} + /* font cache */ static struct list gdi_font_list = LIST_INIT( gdi_font_list ); diff --git a/dlls/gdi32/freetype.c b/dlls/gdi32/freetype.c index b4bfd902309..936e8539a8d 100644 --- a/dlls/gdi32/freetype.c +++ b/dlls/gdi32/freetype.c @@ -338,8 +338,6 @@ static BOOL antialias_fakes = TRUE; static const WCHAR font_mutex_nameW[] = {'_','_','W','I','N','E','_','F','O','N','T','_','M','U','T','E','X','_','_','\0'}; -static const WCHAR szDefaultFallbackLink[] = {'M','i','c','r','o','s','o','f','t',' ','S','a','n','s',' ','S','e','r','i','f',0}; - static BOOL CDECL freetype_set_outline_text_metrics( struct gdi_font *font ); static BOOL CDECL freetype_set_bitmap_text_metrics( struct gdi_font *font ); static void remove_face_from_cache( Face *face ); @@ -2136,14 +2134,6 @@ static void delete_external_font_keys(void) if(winnt_key) RegCloseKey(winnt_key); } -static inline BOOL is_dbcs_ansi_cp(UINT ansi_cp) -{ - return ( ansi_cp == 932 /* CP932 for Japanese */ - || ansi_cp == 936 /* CP936 for Chinese Simplified */ - || ansi_cp == 949 /* CP949 for Korean */ - || ansi_cp == 950 ); /* CP950 for Chinese Traditional */ -} - static BOOL init_freetype(void) { ft_handle = dlopen(SONAME_LIBFREETYPE, RTLD_NOW); @@ -2712,87 +2702,6 @@ static LONG load_VDMX(struct gdi_font *font, LONG height) return ppem; } -/************************************************************* - * add_child_font - */ -static void add_child_font( struct gdi_font *font, const WCHAR *family_name ) -{ - struct gdi_font *child; - Family *family; - Face *child_face, *best_face = NULL; - UINT penalty = 0, new_penalty = 0; - BOOL bold, italic, bd, it; - - italic = !!font->lf.lfItalic; - bold = font->lf.lfWeight > FW_MEDIUM; - - if (!(family = find_family_from_name( family_name ))) return; - - LIST_FOR_EACH_ENTRY( child_face, get_face_list_from_family( family ), Face, entry ) - { - it = !!(child_face->ntmFlags & NTM_ITALIC); - bd = !!(child_face->ntmFlags & NTM_BOLD); - new_penalty = ( it ^ italic ) + ( bd ^ bold ); - if (!best_face || new_penalty < penalty) - { - penalty = new_penalty; - best_face = child_face; - } - } - if (!best_face) return; - - child = alloc_gdi_font( best_face->file, best_face->data_ptr, best_face->data_size ); - child->fake_italic = italic && !(best_face->ntmFlags & NTM_ITALIC); - child->fake_bold = bold && !(best_face->ntmFlags & NTM_BOLD); - child->lf = font->lf; - child->matrix = font->matrix; - child->can_use_bitmap = font->can_use_bitmap; - child->face_index = best_face->face_index; - child->ntmFlags = best_face->ntmFlags; - child->aa_flags = HIWORD( best_face->flags ); - child->scale_y = font->scale_y; - child->base_font = font; - set_gdi_font_names( child, family_name, best_face->style_name, best_face->full_name ); - - list_add_tail( &font->child_fonts, &child->entry ); - TRACE( "created child font %p for base %p\n", child, font ); -} - -/************************************************************* - * create_child_font_list - */ -static void create_child_font_list( struct gdi_font *font ) -{ - struct gdi_font_link *font_link; - struct gdi_font_link_entry *entry; - const WCHAR* font_name; - - if (!(font_name = get_gdi_font_subst( get_gdi_font_name(font), -1, NULL ))) - font_name = get_gdi_font_name( font ); - font_link = find_gdi_font_link(font_name); - if (font_link != NULL) - { - TRACE("found entry in system list\n"); - LIST_FOR_EACH_ENTRY( entry, &font_link->links, struct gdi_font_link_entry, entry ) - add_child_font( font, entry->family_name ); - } - /* - * if not SYMBOL or OEM then we also get all the fonts for Microsoft - * Sans Serif. This is how asian windows get default fallbacks for fonts - */ - if (is_dbcs_ansi_cp(GetACP()) && font->charset != SYMBOL_CHARSET && font->charset != OEM_CHARSET && - strcmpiW(font_name,szDefaultFallbackLink) != 0) - { - font_link = find_gdi_font_link(szDefaultFallbackLink); - if (font_link != NULL) - { - TRACE("found entry in default fallback list\n"); - LIST_FOR_EACH_ENTRY( entry, &font_link->links, struct gdi_font_link_entry, entry ) - add_child_font( font, entry->family_name ); - } - } -} - static BOOL select_charmap(FT_Face ft_face, FT_Encoding encoding) { FT_Error ft_err = FT_Err_Invalid_CharMap_Handle; diff --git a/dlls/gdi32/gdi_private.h b/dlls/gdi32/gdi_private.h index e73c4d3b417..fd3f434399e 100644 --- a/dlls/gdi32/gdi_private.h +++ b/dlls/gdi32/gdi_private.h @@ -472,6 +472,7 @@ extern struct gdi_font_face *create_face( const WCHAR *style, const WCHAR *fulln extern struct gdi_font_link *find_gdi_font_link( const WCHAR *name ) DECLSPEC_HIDDEN; extern struct gdi_font_family *find_family_from_font_links( const WCHAR *name, const WCHAR *subst, FONTSIGNATURE fs ) DECLSPEC_HIDDEN; +extern void create_child_font_list( struct gdi_font *font ) DECLSPEC_HIDDEN; extern struct gdi_font *alloc_gdi_font( const WCHAR *file, void *data_ptr, SIZE_T data_size ) DECLSPEC_HIDDEN; extern void free_gdi_font( struct gdi_font *font ) DECLSPEC_HIDDEN;

1 0

Alexandre Julliard : gdi32: Move the dumping of the font list out of freetype.c.
by Alexandre Julliard 02 Nov '20

02 Nov '20

Module: wine Branch: master Commit: ef77b38888d7fb68647ace9fb030be5b47c39189 URL: https://source.winehq.org/git/wine.git/?a=commit;h=ef77b38888d7fb68647ace9f… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Sat Oct 31 10:21:00 2020 +0100 gdi32: Move the dumping of the font list out of freetype.c. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/gdi32/font.c | 19 +++++++++++++++++++ dlls/gdi32/freetype.c | 19 ------------------- 2 files changed, 19 insertions(+), 19 deletions(-) diff --git a/dlls/gdi32/font.c b/dlls/gdi32/font.c index 3f6e74fee1c..5cca897fd40 100644 --- a/dlls/gdi32/font.c +++ b/dlls/gdi32/font.c @@ -667,6 +667,24 @@ static void load_gdi_font_replacements(void) RegCloseKey( hkey ); } +static void dump_gdi_font_list(void) +{ + struct gdi_font_family *family; + struct gdi_font_face *face; + + LIST_FOR_EACH_ENTRY( family, &font_list, struct gdi_font_family, entry ) + { + TRACE( "Family: %s\n", debugstr_w(family->family_name) ); + LIST_FOR_EACH_ENTRY( face, &family->faces, struct gdi_font_face, entry ) + { + TRACE( "\t%s\t%s\t%08x", debugstr_w(face->style_name), debugstr_w(face->full_name), + face->fs.fsCsb[0] ); + if (!face->scalable) TRACE(" %d", face->size.height ); + TRACE("\n"); + } + } +} + struct gdi_font_face *create_face( const WCHAR *style, const WCHAR *fullname, const WCHAR *file, UINT index, FONTSIGNATURE fs, DWORD ntmflags, DWORD version, DWORD flags, const struct bitmap_font_size *size ) @@ -2778,6 +2796,7 @@ void font_init(void) load_gdi_font_subst(); load_gdi_font_replacements(); load_system_links(); + dump_gdi_font_list(); dump_gdi_font_subst(); } diff --git a/dlls/gdi32/freetype.c b/dlls/gdi32/freetype.c index 936e8539a8d..59095d4e6d8 100644 --- a/dlls/gdi32/freetype.c +++ b/dlls/gdi32/freetype.c @@ -1653,23 +1653,6 @@ static INT CDECL freetype_remove_font( const WCHAR *file, DWORD flags ) return count; } -static void DumpFontList(void) -{ - Family *family; - Face *face; - - LIST_FOR_EACH_ENTRY( family, &font_list, Family, entry ) { - TRACE( "Family: %s\n", debugstr_w(family->family_name) ); - LIST_FOR_EACH_ENTRY( face, &family->faces, Face, entry ) { - TRACE( "\t%s\t%s\t%08x", debugstr_w(face->style_name), debugstr_w(face->full_name), - face->fs.fsCsb[0] ); - if(!face->scalable) - TRACE(" %d", face->size.height); - TRACE("\n"); - } - } -} - #ifdef __ANDROID__ static BOOL ReadFontDir(const char *dirname, BOOL external_fonts) { @@ -2321,8 +2304,6 @@ BOOL WineEngInit( const struct font_backend_funcs **funcs ) reorder_font_list(); - DumpFontList(); - if(disposition == REG_CREATED_NEW_KEY) update_reg_entries();

1 0

Alexandre Julliard : gdi32: Add a helper function to create a font from a face.
by Alexandre Julliard 02 Nov '20

02 Nov '20

Module: wine Branch: master Commit: c9b21a57075d01297b320def739b85dd2c6ef100 URL: https://source.winehq.org/git/wine.git/?a=commit;h=c9b21a57075d01297b320def… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Sat Oct 31 15:58:54 2020 +0100 gdi32: Add a helper function to create a font from a face. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/gdi32/font.c | 31 +++++++++++++++++++++---------- dlls/gdi32/freetype.c | 19 +++---------------- dlls/gdi32/gdi_private.h | 3 ++- 3 files changed, 26 insertions(+), 27 deletions(-) diff --git a/dlls/gdi32/font.c b/dlls/gdi32/font.c index 5cca897fd40..abc202afcc3 100644 --- a/dlls/gdi32/font.c +++ b/dlls/gdi32/font.c @@ -1016,7 +1016,7 @@ static void free_font_handle( DWORD handle ) } } -struct gdi_font *alloc_gdi_font( const WCHAR *file, void *data_ptr, SIZE_T data_size ) +static struct gdi_font *alloc_gdi_font( const WCHAR *file, void *data_ptr, SIZE_T data_size ) { UINT len = file ? strlenW(file) : 0; struct gdi_font *font = HeapAlloc( GetProcessHeap(), HEAP_ZERO_MEMORY, @@ -1083,6 +1083,25 @@ void set_gdi_font_names( struct gdi_font *font, const WCHAR *family_name, const font->otm.otmpFaceName = (char *)strdupW( full_name ); } +struct gdi_font *create_gdi_font( const struct gdi_font_face *face, const WCHAR *family_name, + const LOGFONTW *lf ) +{ + struct gdi_font *font; + + if (!(font = alloc_gdi_font( face->file, face->data_ptr, face->data_size ))) return NULL; + font->fs = face->fs; + font->lf = *lf; + font->fake_italic = (lf->lfItalic && !(face->ntmFlags & NTM_ITALIC)); + font->fake_bold = (lf->lfWeight > 550 && !(face->ntmFlags & NTM_BOLD)); + font->scalable = face->scalable; + font->face_index = face->face_index; + font->ntmFlags = face->ntmFlags; + font->aa_flags = HIWORD( face->flags ); + if (!family_name) family_name = face->family->family_name; + set_gdi_font_names( font, family_name, face->style_name, face->full_name ); + return font; +} + struct glyph_metrics { GLYPHMETRICS gm; @@ -1490,22 +1509,14 @@ static void add_child_font( struct gdi_font *font, const WCHAR *family_name ) } if (!best_face) return; - child = alloc_gdi_font( best_face->file, best_face->data_ptr, best_face->data_size ); - child->fake_italic = italic && !(best_face->ntmFlags & NTM_ITALIC); - child->fake_bold = bold && !(best_face->ntmFlags & NTM_BOLD); - child->lf = font->lf; + if (!(child = create_gdi_font( best_face, family_name, &font->lf ))) return; child->matrix = font->matrix; child->can_use_bitmap = font->can_use_bitmap; - child->face_index = best_face->face_index; - child->ntmFlags = best_face->ntmFlags; - child->aa_flags = HIWORD( best_face->flags ); child->scale_y = font->scale_y; child->aveWidth = font->aveWidth; child->charset = font->charset; child->codepage = font->codepage; child->base_font = font; - set_gdi_font_names( child, family_name, best_face->style_name, best_face->full_name ); - list_add_tail( &font->child_fonts, &child->entry ); TRACE( "created child font %p for base %p\n", child, font ); } diff --git a/dlls/gdi32/freetype.c b/dlls/gdi32/freetype.c index 59095d4e6d8..ff57a971976 100644 --- a/dlls/gdi32/freetype.c +++ b/dlls/gdi32/freetype.c @@ -3274,20 +3274,10 @@ found_face: height = lf.lfHeight; TRACE("not in cache\n"); - font = alloc_gdi_font( face->file, face->data_ptr, face->data_size ); + font = create_gdi_font( face, orig_name, &lf ); font->matrix = dcmat; - font->lf = lf; font->can_use_bitmap = can_use_bitmap; - font->fake_italic = (it && !(face->ntmFlags & NTM_ITALIC)); - font->fake_bold = (bd && !(face->ntmFlags & NTM_BOLD)); - font->fs = face->fs; - font->face_index = face->face_index; - font->ntmFlags = face->ntmFlags; - font->aa_flags = HIWORD( face->flags ); - set_gdi_font_names( font, orig_name ? orig_name : family->family_name, - face->style_name, face->full_name ); - if(csi.fs.fsCsb[0]) { font->charset = lf.lfCharSet; font->codepage = csi.ciACP; @@ -3506,6 +3496,7 @@ static void GetEnumStructs(Face *face, const WCHAR *family_name, LPENUMLOGFONTEX NEWTEXTMETRICEXW *pntm) { struct gdi_font *font; + LOGFONTW lf = { .lfHeight = 100 }; if (face->cached_enum_data) { @@ -3515,11 +3506,7 @@ static void GetEnumStructs(Face *face, const WCHAR *family_name, LPENUMLOGFONTEX return; } - font = alloc_gdi_font( face->file, face->data_ptr, face->data_size ); - font->lf.lfHeight = 100; - font->face_index = face->face_index; - font->ntmFlags = face->ntmFlags; - set_gdi_font_names( font, family_name, face->style_name, face->full_name ); + if (!(font = create_gdi_font( face, family_name, &lf ))) return; if (!freetype_load_font( font )) { diff --git a/dlls/gdi32/gdi_private.h b/dlls/gdi32/gdi_private.h index fd3f434399e..6f5266c0053 100644 --- a/dlls/gdi32/gdi_private.h +++ b/dlls/gdi32/gdi_private.h @@ -474,7 +474,6 @@ extern struct gdi_font_family *find_family_from_font_links( const WCHAR *name, c FONTSIGNATURE fs ) DECLSPEC_HIDDEN; extern void create_child_font_list( struct gdi_font *font ) DECLSPEC_HIDDEN; -extern struct gdi_font *alloc_gdi_font( const WCHAR *file, void *data_ptr, SIZE_T data_size ) DECLSPEC_HIDDEN; extern void free_gdi_font( struct gdi_font *font ) DECLSPEC_HIDDEN; extern void cache_gdi_font( struct gdi_font *font ) DECLSPEC_HIDDEN; extern struct gdi_font *find_cached_gdi_font( const LOGFONTW *lf, const FMAT2 *matrix, @@ -482,6 +481,8 @@ extern struct gdi_font *find_cached_gdi_font( const LOGFONTW *lf, const FMAT2 *m static inline const WCHAR *get_gdi_font_name( struct gdi_font *font ) { return (WCHAR *)font->otm.otmpFamilyName; } extern void set_gdi_font_names( struct gdi_font *font, const WCHAR *family_name, const WCHAR *style_name, const WCHAR *full_name ) DECLSPEC_HIDDEN; +extern struct gdi_font *create_gdi_font( const struct gdi_font_face *face, const WCHAR *family_name, + const LOGFONTW *lf ) DECLSPEC_HIDDEN; extern void *get_GSUB_vert_feature( struct gdi_font *font ) DECLSPEC_HIDDEN; extern void font_init(void) DECLSPEC_HIDDEN; extern CRITICAL_SECTION font_cs DECLSPEC_HIDDEN;

1 0

Alexandre Julliard : gdi32: Move the font enumeration out of freetype.c.
by Alexandre Julliard 02 Nov '20

02 Nov '20

Module: wine Branch: master Commit: 356ad03fcf7d3204d89b243a543076e2ada465b5 URL: https://source.winehq.org/git/wine.git/?a=commit;h=356ad03fcf7d3204d89b243a… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Sat Oct 31 16:13:33 2020 +0100 gdi32: Move the font enumeration out of freetype.c. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/gdi32/font.c | 300 +++++++++++++++++++++++++++++++++++++++++++- dlls/gdi32/freetype.c | 319 ----------------------------------------------- dlls/gdi32/gdi_private.h | 8 -- 3 files changed, 298 insertions(+), 329 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=356ad03fcf7d3204d89b…

1 0

Huw Davies : riched20: Use paragraph ptrs in the WM_CHAR handler.
by Alexandre Julliard 02 Nov '20

02 Nov '20

Module: wine Branch: master Commit: 50c8fe4560f1a3489662fd513bd27634c8a0eb43 URL: https://source.winehq.org/git/wine.git/?a=commit;h=50c8fe4560f1a3489662fd51… Author: Huw Davies <huw(a)codeweavers.com> Date: Mon Nov 2 08:23:14 2020 +0000 riched20: Use paragraph ptrs in the WM_CHAR handler. Signed-off-by: Huw Davies <huw(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/riched20/editor.c | 46 ++++++++++++++++++++++++---------------------- 1 file changed, 24 insertions(+), 22 deletions(-) diff --git a/dlls/riched20/editor.c b/dlls/riched20/editor.c index c1138bd1dab..b54b9334265 100644 --- a/dlls/riched20/editor.c +++ b/dlls/riched20/editor.c @@ -897,13 +897,13 @@ void ME_RTFTblAttrHook(RTF_Info *info) if (cellNum >= MAX_TABLE_CELLS) break; info->tableDef->cells[cellNum].rightBoundary = info->rtfParam; - if (cellNum < MAX_TAB_STOPS) { + if (cellNum < MAX_TAB_STOPS) + { /* Tab stops were used to store cell positions before v4.1 but v4.1 * still seems to set the tabstops without using them. */ - ME_DisplayItem *para = info->editor->pCursors[0].pPara; - PARAFORMAT2 *pFmt = &para->member.para.fmt; - pFmt->rgxTabs[cellNum] &= ~0x00FFFFFF; - pFmt->rgxTabs[cellNum] |= 0x00FFFFFF & info->rtfParam; + PARAFORMAT2 *fmt = &info->editor->pCursors[0].pPara->member.para.fmt; + fmt->rgxTabs[cellNum] &= ~0x00FFFFFF; + fmt->rgxTabs[cellNum] |= 0x00FFFFFF & info->rtfParam; } info->tableDef->numCellsDefined++; break; @@ -2795,7 +2795,7 @@ static LRESULT ME_Char(ME_TextEditor *editor, WPARAM charCode, if ((unsigned)wstr >= ' ' || wstr == '\t') { ME_Cursor cursor = editor->pCursors[0]; - ME_DisplayItem *para = cursor.pPara; + ME_Paragraph *para = &cursor.pPara->member.para; int from, to; BOOL ctrl_is_down = GetKeyState(VK_CONTROL) & 0x8000; ME_GetSelectionOfs(editor, &from, &to); @@ -2803,38 +2803,40 @@ static LRESULT ME_Char(ME_TextEditor *editor, WPARAM charCode, /* v4.1 allows tabs to be inserted with ctrl key down */ !(ctrl_is_down && !editor->bEmulateVersion10)) { - ME_DisplayItem *para; BOOL selected_row = FALSE; - para = cursor.pPara; if (ME_IsSelection(editor) && cursor.pRun->member.run.nCharOfs + cursor.nOffset == 0 && - to == ME_GetCursorOfs(&editor->pCursors[0]) && - para->member.para.prev_para->type == diParagraph) + to == ME_GetCursorOfs(&editor->pCursors[0]) && para_prev( para )) { - para = para->member.para.prev_para; + para = para_prev( para ); selected_row = TRUE; } - if (ME_IsInTable(para)) + if (para_in_table( para )) { table_handle_tab( editor, selected_row ); ME_CommitUndo(editor); return 0; } - } else if (!editor->bEmulateVersion10) { /* v4.1 */ - if (para->member.para.nFlags & MEPF_ROWEND) { - if (from == to) { - para = para->member.para.next_para; - if (para->member.para.nFlags & MEPF_ROWSTART) - para = para->member.para.next_para; - editor->pCursors[0].pPara = para; - editor->pCursors[0].pRun = ME_FindItemFwd(para, diRun); + } + else if (!editor->bEmulateVersion10) /* v4.1 */ + { + if (para->nFlags & MEPF_ROWEND) + { + if (from == to) + { + para = para_next( para ); + if (para->nFlags & MEPF_ROWSTART) para = para_next( para ); + editor->pCursors[0].pPara = para_get_di( para ); + editor->pCursors[0].pRun = run_get_di( para_first_run( para ) ); editor->pCursors[0].nOffset = 0; editor->pCursors[1] = editor->pCursors[0]; } } - } else { /* v1.0 - 3.0 */ - if (ME_IsInTable(cursor.pRun) && + } + else /* v1.0 - 3.0 */ + { + if (para_in_table( para ) && cursor.pRun->member.run.nFlags & MERF_ENDPARA && from == to) {

1 0

Huw Davies : riched20: Use a run ptr in the link notify function.
by Alexandre Julliard 02 Nov '20

02 Nov '20

Module: wine Branch: master Commit: 8046b5bc96d243293857109ed8b24d5813a39f64 URL: https://source.winehq.org/git/wine.git/?a=commit;h=8046b5bc96d243293857109e… Author: Huw Davies <huw(a)codeweavers.com> Date: Mon Nov 2 08:23:15 2020 +0000 riched20: Use a run ptr in the link notify function. Signed-off-by: Huw Davies <huw(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/riched20/editor.c | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/dlls/riched20/editor.c b/dlls/riched20/editor.c index b54b9334265..38553f7add3 100644 --- a/dlls/riched20/editor.c +++ b/dlls/riched20/editor.c @@ -3451,8 +3451,9 @@ static void ME_LinkNotify(ME_TextEditor *editor, UINT msg, WPARAM wParam, LPARAM int x,y; BOOL isExact; ME_Cursor cursor; /* The start of the clicked text. */ - + ME_Run *run; ENLINK info; + x = (short)LOWORD(lParam); y = (short)HIWORD(lParam); ME_CharFromPos(editor, x, y, &cursor, &isExact); @@ -3460,8 +3461,6 @@ static void ME_LinkNotify(ME_TextEditor *editor, UINT msg, WPARAM wParam, LPARAM if (is_link( &cursor.pRun->member.run )) { /* The clicked run has CFE_LINK set */ - ME_DisplayItem *di; - info.nmhdr.hwndFrom = NULL; info.nmhdr.idFrom = 0; info.nmhdr.code = EN_LINK; @@ -3472,15 +3471,15 @@ static void ME_LinkNotify(ME_TextEditor *editor, UINT msg, WPARAM wParam, LPARAM /* find the first contiguous run with CFE_LINK set */ info.chrg.cpMin = ME_GetCursorOfs(&cursor); - di = cursor.pRun; - while (ME_PrevRun( NULL, &di, FALSE ) && is_link( &di->member.run )) - info.chrg.cpMin -= di->member.run.len; + run = &cursor.pRun->member.run; + while ((run = run_prev( run )) && is_link( run )) + info.chrg.cpMin -= run->len; /* find the last contiguous run with CFE_LINK set */ info.chrg.cpMax = ME_GetCursorOfs(&cursor) + cursor.pRun->member.run.len; - di = cursor.pRun; - while (ME_NextRun( NULL, &di, FALSE ) && is_link( &di->member.run )) - info.chrg.cpMax += di->member.run.len; + run = &cursor.pRun->member.run; + while ((run = run_next( run )) && is_link( run )) + info.chrg.cpMax += run->len; ITextHost_TxNotify(editor->texthost, info.nmhdr.code, &info); }

1 0