February 2020 - Wine-commits

Jacek Caban : oleaut32: Use ITypeInfoImpl_GetInternalFuncDesc in a few more places.
by Alexandre Julliard 10 Feb '20

10 Feb '20

Module: wine Branch: master Commit: db498b3bf2a17e4e66845bd0988a7aaac780cfd9 URL: https://source.winehq.org/git/wine.git/?a=commit;h=db498b3bf2a17e4e66845bd0… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Mon Feb 10 14:57:04 2020 +0100 oleaut32: Use ITypeInfoImpl_GetInternalFuncDesc in a few more places. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/oleaut32/typelib.c | 29 +++++++++++++++++++---------- 1 file changed, 19 insertions(+), 10 deletions(-) diff --git a/dlls/oleaut32/typelib.c b/dlls/oleaut32/typelib.c index 7020f68ba7..68c31e1d88 100644 --- a/dlls/oleaut32/typelib.c +++ b/dlls/oleaut32/typelib.c @@ -5264,7 +5264,7 @@ static HRESULT WINAPI ITypeLib2_fnGetDocumentation2( return result; } -static HRESULT TLB_copy_all_custdata(struct list *custdata_list, CUSTDATA *pCustData) +static HRESULT TLB_copy_all_custdata(const struct list *custdata_list, CUSTDATA *pCustData) { TLBCustData *pCData; unsigned int ct; @@ -8418,14 +8418,17 @@ static HRESULT WINAPI ITypeInfo2_fnGetParamCustData( VARIANT *pVarVal) { ITypeInfoImpl *This = impl_from_ITypeInfo2(iface); + const TLBFuncDesc *pFDesc; TLBCustData *pCData; - TLBFuncDesc *pFDesc = &This->funcdescs[indexFunc]; + UINT hrefoffset; + HRESULT hr; TRACE("%p %u %u %s %p\n", This, indexFunc, indexParam, debugstr_guid(guid), pVarVal); - if(indexFunc >= This->typeattr.cFuncs) - return TYPE_E_ELEMENTNOTFOUND; + hr = ITypeInfoImpl_GetInternalFuncDesc((ITypeInfo *)iface, indexFunc, &pFDesc, &hrefoffset); + if (FAILED(hr)) + return hr; if(indexParam >= pFDesc->funcdesc.cParams) return TYPE_E_ELEMENTNOTFOUND; @@ -8587,12 +8590,15 @@ static HRESULT WINAPI ITypeInfo2_fnGetAllFuncCustData( CUSTDATA *pCustData) { ITypeInfoImpl *This = impl_from_ITypeInfo2(iface); - TLBFuncDesc *pFDesc = &This->funcdescs[index]; + const TLBFuncDesc *pFDesc; + UINT hrefoffset; + HRESULT hr; TRACE("%p %u %p\n", This, index, pCustData); - if(index >= This->typeattr.cFuncs) - return TYPE_E_ELEMENTNOTFOUND; + hr = ITypeInfoImpl_GetInternalFuncDesc((ITypeInfo *)iface, index, &pFDesc, &hrefoffset); + if (FAILED(hr)) + return hr; return TLB_copy_all_custdata(&pFDesc->custdata_list, pCustData); } @@ -8606,12 +8612,15 @@ static HRESULT WINAPI ITypeInfo2_fnGetAllParamCustData( ITypeInfo2 * iface, UINT indexFunc, UINT indexParam, CUSTDATA *pCustData) { ITypeInfoImpl *This = impl_from_ITypeInfo2(iface); - TLBFuncDesc *pFDesc = &This->funcdescs[indexFunc]; + const TLBFuncDesc *pFDesc; + UINT hrefoffset; + HRESULT hr; TRACE("%p %u %u %p\n", This, indexFunc, indexParam, pCustData); - if(indexFunc >= This->typeattr.cFuncs) - return TYPE_E_ELEMENTNOTFOUND; + hr = ITypeInfoImpl_GetInternalFuncDesc((ITypeInfo *)iface, indexFunc, &pFDesc, &hrefoffset); + if (FAILED(hr)) + return hr; if(indexParam >= pFDesc->funcdesc.cParams) return TYPE_E_ELEMENTNOTFOUND;

1 0

Francois Gouget : tests: Limit spam from todos, skips and traces when winetest_debug==1.
by Alexandre Julliard 10 Feb '20

10 Feb '20

Module: wine Branch: master Commit: e4dbd5670539698243e10fffc64fbdf5a44a7da6 URL: https://source.winehq.org/git/wine.git/?a=commit;h=e4dbd5670539698243e10fff… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Sun Feb 9 20:48:38 2020 +0100 tests: Limit spam from todos, skips and traces when winetest_debug==1. Some tests loop on system resources like fonts and issue todos, skips or even traces on every iteration. Depending on the machine configuration this can result in a lot of traces and push WineTest reports above the 1.5 MB limit. So on low debugging levels automatically silence test lines that issue more than 50 such messages. A count of the silenced messages is given at the end. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- include/wine/test.h | 77 +++++++++++++++++++++++++++++++++++++++++++---------- 1 file changed, 63 insertions(+), 14 deletions(-) diff --git a/include/wine/test.h b/include/wine/test.h index 5c3b432a9a..edaf89bcca 100644 --- a/include/wine/test.h +++ b/include/wine/test.h @@ -62,6 +62,9 @@ extern int winetest_interactive; /* report successful tests (BOOL) */ extern int winetest_report_success; +/* silence todos and skips above this threshold */ +extern int winetest_mute_threshold; + /* current platform */ extern const char *winetest_platform; @@ -211,6 +214,9 @@ const char *winetest_platform = "windows"; /* report successful tests (BOOL) */ int winetest_report_success = 0; +/* silence todos and skips above this threshold */ +int winetest_mute_threshold = 42; + /* passing arguments around */ static int winetest_argc; static char** winetest_argv; @@ -222,6 +228,12 @@ static LONG failures; /* number of failures */ static LONG skipped; /* number of skipped test chunks */ static LONG todo_successes; /* number of successful tests inside todo block */ static LONG todo_failures; /* number of failures inside todo block */ +static LONG muted_traces; /* number of silenced traces */ +static LONG muted_skipped; /* same as skipped but silent */ +static LONG muted_todo_successes; /* same as todo_successes but silent */ + +/* counts how many times a given line printed a message */ +static LONG line_counters[16384]; /* The following data must be kept track of on a per-thread basis */ struct tls_data @@ -284,6 +296,25 @@ int broken( int condition ) return (strcmp(winetest_platform, "windows") == 0) && condition; } +static LONG winetest_add_line( void ) +{ + struct tls_data *data; + int index, count; + + if (winetest_debug > 1) + return 0; + + data = get_tls_data(); + index = data->current_line % ARRAY_SIZE(line_counters); + count = InterlockedIncrement(line_counters + index) - 1; + if (count == winetest_mute_threshold) + printf( "%s:%d Line has been silenced after %d occurrences\n", + data->current_file, data->current_line, + winetest_mute_threshold); + + return count; +} + /* * Checks condition. * Parameters: @@ -310,13 +341,19 @@ int winetest_vok( int condition, const char *msg, __winetest_va_list args ) } else { - if (winetest_debug > 0) + if (!winetest_debug || + winetest_add_line() < winetest_mute_threshold) { - printf( "%s:%d: Test marked todo: ", - data->current_file, data->current_line ); - vprintf(msg, args); + if (winetest_debug > 0) + { + printf( "%s:%d Test marked todo: ", + data->current_file, data->current_line ); + vprintf(msg, args); + } + InterlockedIncrement(&todo_successes); } - InterlockedIncrement(&todo_successes); + else + InterlockedIncrement(&muted_todo_successes); return 1; } } @@ -353,24 +390,32 @@ void __winetest_cdecl winetest_ok( int condition, const char *msg, ... ) void __winetest_cdecl winetest_trace( const char *msg, ... ) { __winetest_va_list valist; - struct tls_data *data = get_tls_data(); - if (winetest_debug > 0) + if (!winetest_debug) + return; + if (winetest_add_line() < winetest_mute_threshold) { - printf( "%s:%d: ", data->current_file, data->current_line ); + struct tls_data *data = get_tls_data(); + printf( "%s:%d ", data->current_file, data->current_line ); __winetest_va_start(valist, msg); vprintf(msg, valist); __winetest_va_end(valist); } + else + InterlockedIncrement(&muted_traces); } void winetest_vskip( const char *msg, __winetest_va_list args ) { - struct tls_data *data = get_tls_data(); - - printf( "%s:%d: Tests skipped: ", data->current_file, data->current_line ); - vprintf(msg, args); - skipped++; + if (winetest_add_line() < winetest_mute_threshold) + { + struct tls_data *data = get_tls_data(); + printf( "%s:%d Tests skipped: ", data->current_file, data->current_line ); + vprintf(msg, args); + InterlockedIncrement(&skipped); + } + else + InterlockedIncrement(&muted_skipped); } void __winetest_cdecl winetest_skip( const char *msg, ... ) @@ -504,7 +549,11 @@ static int run_test( const char *name ) if (winetest_debug) { - printf( "%04x:%s: %d tests executed (%d marked as todo, %d %s), %d skipped.\n", + if (muted_todo_successes || muted_skipped || muted_traces) + printf( "%04x:%s Silenced %d todos, %d skips and %d traces.\n", + GetCurrentProcessId(), test->name, + muted_todo_successes, muted_skipped, muted_traces); + printf( "%04x:%s %d tests executed (%d marked as todo, %d %s), %d skipped.\n", GetCurrentProcessId(), test->name, successes + failures + todo_successes + todo_failures, todo_successes, failures + todo_failures,

1 0

Akihiro Sagawa : user32/tests: Add wsprintfA %S conversion tests.
by Alexandre Julliard 10 Feb '20

10 Feb '20

Module: wine Branch: master Commit: e375f0d45784a880ddc9568d211bbe1c2ca847c9 URL: https://source.winehq.org/git/wine.git/?a=commit;h=e375f0d45784a880ddc9568d… Author: Akihiro Sagawa <sagawa.aki(a)gmail.com> Date: Sun Feb 9 20:51:29 2020 +0900 user32/tests: Add wsprintfA %S conversion tests. Signed-off-by: Akihiro Sagawa <sagawa.aki(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/user32/tests/wsprintf.c | 50 +++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 49 insertions(+), 1 deletion(-) diff --git a/dlls/user32/tests/wsprintf.c b/dlls/user32/tests/wsprintf.c index f79b6306a7..ca0c4802f9 100644 --- a/dlls/user32/tests/wsprintf.c +++ b/dlls/user32/tests/wsprintf.c @@ -52,7 +52,28 @@ static const struct static void wsprintfATest(void) { - char buf[25]; + char buf[25], star[4], partial[4]; + static const WCHAR starW[] = {0x2606, 0}; + static const WCHAR fffeW[] = {0xfffe, 0}; + static const WCHAR wineW[] = {0xd83c, 0xdf77, 0}; /* U+1F377: wine glass */ + const struct { + const void *input; + const char *fmt; + const char *str; + int rc; + BOOL todo_rc; + BOOL todo_str; + } + testcase[] = { + { starW, "%.1S", partial, 1, TRUE, TRUE }, + { starW, "%.2S", star, 2, FALSE, TRUE }, + { starW, "%.3S", star, 2, FALSE, TRUE }, + { fffeW, "%.1S", "?", 1, FALSE, TRUE }, + { fffeW, "%.2S", "?", 1, FALSE, TRUE }, + { wineW, "%.2S", "??", 2, FALSE, TRUE }, + { star, "%.1s", partial, 1 }, + }; + CPINFO cpinfo; unsigned int i; int rc; @@ -72,6 +93,33 @@ static void wsprintfATest(void) ok(rc == strlen(i64_formats[i].res), "%u: wsprintfA length failure: rc=%d\n", i, rc); ok(!strcmp(buf, i64_formats[i].res), "%u: wrong result [%s]\n", i, buf); } + + if (!GetCPInfo(CP_ACP, &cpinfo) || cpinfo.MaxCharSize <= 1) + { + skip("Multi-byte wsprintfA test isn't available for the current codepage\n"); + return; + } + + rc = WideCharToMultiByte(CP_ACP, 0, starW, -1, star, sizeof(star), NULL, NULL); + ok(rc == 3, "unexpected rc, got %d\n", rc); + partial[0] = star[0]; + partial[1] = '\0'; + + for (i = 0; i < ARRAY_SIZE(testcase); i++) + { + memset(buf, 0x11, sizeof(buf)); + rc = wsprintfA(buf, testcase[i].fmt, testcase[i].input); + + todo_wine_if(testcase[i].todo_rc) + ok(rc == testcase[i].rc, + "%u: expected %d, got %d\n", + i, testcase[i].rc, rc); + + todo_wine_if(testcase[i].todo_str) + ok(!strcmp(buf, testcase[i].str), + "%u: expected %s, got %s\n", + i, wine_dbgstr_a(testcase[i].str), wine_dbgstr_an(buf, rc)); + } } static void wsprintfWTest(void)

1 0

Akihiro Sagawa : user32: Fix wsprintfA %S conversion.
by Alexandre Julliard 10 Feb '20

10 Feb '20

Module: wine Branch: master Commit: 08bf605acb4d319e016a7eafe0c675509445bd4a URL: https://source.winehq.org/git/wine.git/?a=commit;h=08bf605acb4d319e016a7eaf… Author: Akihiro Sagawa <sagawa.aki(a)gmail.com> Date: Sun Feb 9 20:51:31 2020 +0900 user32: Fix wsprintfA %S conversion. Signed-off-by: Akihiro Sagawa <sagawa.aki(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/user32/tests/wsprintf.c | 16 ++++++---------- dlls/user32/wsprintf.c | 31 +++++++++++++++++++++++++------ 2 files changed, 31 insertions(+), 16 deletions(-) diff --git a/dlls/user32/tests/wsprintf.c b/dlls/user32/tests/wsprintf.c index ca0c4802f9..ab4f4dae04 100644 --- a/dlls/user32/tests/wsprintf.c +++ b/dlls/user32/tests/wsprintf.c @@ -61,16 +61,14 @@ static void wsprintfATest(void) const char *fmt; const char *str; int rc; - BOOL todo_rc; - BOOL todo_str; } testcase[] = { - { starW, "%.1S", partial, 1, TRUE, TRUE }, - { starW, "%.2S", star, 2, FALSE, TRUE }, - { starW, "%.3S", star, 2, FALSE, TRUE }, - { fffeW, "%.1S", "?", 1, FALSE, TRUE }, - { fffeW, "%.2S", "?", 1, FALSE, TRUE }, - { wineW, "%.2S", "??", 2, FALSE, TRUE }, + { starW, "%.1S", partial, 1 }, + { starW, "%.2S", star, 2 }, + { starW, "%.3S", star, 2 }, + { fffeW, "%.1S", "?", 1 }, + { fffeW, "%.2S", "?", 1 }, + { wineW, "%.2S", "??", 2 }, { star, "%.1s", partial, 1 }, }; CPINFO cpinfo; @@ -110,12 +108,10 @@ static void wsprintfATest(void) memset(buf, 0x11, sizeof(buf)); rc = wsprintfA(buf, testcase[i].fmt, testcase[i].input); - todo_wine_if(testcase[i].todo_rc) ok(rc == testcase[i].rc, "%u: expected %d, got %d\n", i, testcase[i].rc, rc); - todo_wine_if(testcase[i].todo_str) ok(!strcmp(buf, testcase[i].str), "%u: expected %s, got %s\n", i, wine_dbgstr_a(testcase[i].str), wine_dbgstr_an(buf, rc)); diff --git a/dlls/user32/wsprintf.c b/dlls/user32/wsprintf.c index 17d39a4d17..478583d926 100644 --- a/dlls/user32/wsprintf.c +++ b/dlls/user32/wsprintf.c @@ -30,6 +30,7 @@ #include "winbase.h" #include "wingdi.h" #include "winuser.h" +#include "winnls.h" #include "wine/debug.h" @@ -245,7 +246,7 @@ static INT WPRINTF_ParseFormatW( LPCWSTR format, WPRINTF_FORMAT *res ) * WPRINTF_GetLen */ static UINT WPRINTF_GetLen( WPRINTF_FORMAT *format, WPRINTF_DATA *arg, - LPSTR number, UINT maxlen ) + LPSTR number, UINT maxlen, BOOL dst_is_wide ) { UINT len; @@ -264,8 +265,18 @@ static UINT WPRINTF_GetLen( WPRINTF_FORMAT *format, WPRINTF_DATA *arg, return (format->precision = len); case WPR_WSTRING: if (!arg->lpcwstr_view) arg->lpcwstr_view = null_stringW; - for (len = 0; !format->precision || (len < format->precision); len++) - if (!*(arg->lpcwstr_view + len)) break; + if (dst_is_wide) + { + for (len = 0; !format->precision || (len < format->precision); len++) + if (!*(arg->lpcwstr_view + len)) break; + } + else + { + LPCWSTR p = arg->lpcwstr_view; + for (len = 0; (!format->precision || len < format->precision) && *p; p++) + len += WideCharToMultiByte( CP_ACP, 0, p, 1, NULL, 0, NULL, NULL ); + if (format->precision && len > format->precision) len = format->precision; + } if (len > maxlen) len = maxlen; return (format->precision = len); case WPR_SIGNED: @@ -354,7 +365,7 @@ static INT wvsnprintfA( LPSTR buffer, UINT maxlen, LPCSTR spec, __ms_va_list arg break; } - len = WPRINTF_GetLen( &format, &argData, number, maxlen - 1 ); + len = WPRINTF_GetLen( &format, &argData, number, maxlen - 1, FALSE ); sign = 0; if (!(format.flags & WPRINTF_LEFTALIGN)) for (i = format.precision; i < format.width; i++, maxlen--) @@ -374,7 +385,15 @@ static INT wvsnprintfA( LPSTR buffer, UINT maxlen, LPCSTR spec, __ms_va_list arg case WPR_WSTRING: { LPCWSTR ptr = argData.lpcwstr_view; - for (i = 0; i < len; i++) *p++ = (CHAR)*ptr++; + for (i = 0; i < len; ptr++) + { + CHAR mb[5]; /* 5 is MB_LEN_MAX */ + int ret = WideCharToMultiByte( CP_ACP, 0, ptr, 1, mb, sizeof(mb), NULL, NULL ); + i += ret; + if (i > len) ret = len - (p - buffer); + memcpy( p, mb, ret ); + p += ret; + } } break; case WPR_HEXA: @@ -459,7 +478,7 @@ static INT wvsnprintfW( LPWSTR buffer, UINT maxlen, LPCWSTR spec, __ms_va_list a break; } - len = WPRINTF_GetLen( &format, &argData, number, maxlen - 1 ); + len = WPRINTF_GetLen( &format, &argData, number, maxlen - 1, TRUE ); sign = 0; if (!(format.flags & WPRINTF_LEFTALIGN)) for (i = format.precision; i < format.width; i++, maxlen--)

1 0

Akihiro Sagawa : shlwapi: Fix wnsprintfA/wvnsprintfA %S conversion.
by Alexandre Julliard 10 Feb '20

10 Feb '20

Module: wine Branch: master Commit: 6c692dc1af1f3402079db2ced1bc4984dc2084d0 URL: https://source.winehq.org/git/wine.git/?a=commit;h=6c692dc1af1f3402079db2ce… Author: Akihiro Sagawa <sagawa.aki(a)gmail.com> Date: Sun Feb 9 20:51:33 2020 +0900 shlwapi: Fix wnsprintfA/wvnsprintfA %S conversion. Signed-off-by: Akihiro Sagawa <sagawa.aki(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/shlwapi/wsprintf.c | 30 ++++++++++++++++++++++++------ 1 file changed, 24 insertions(+), 6 deletions(-) diff --git a/dlls/shlwapi/wsprintf.c b/dlls/shlwapi/wsprintf.c index 6a36b6a28e..9d4088cc25 100644 --- a/dlls/shlwapi/wsprintf.c +++ b/dlls/shlwapi/wsprintf.c @@ -245,7 +245,7 @@ static INT WPRINTF_ParseFormatW( LPCWSTR format, WPRINTF_FORMAT *res ) * WPRINTF_GetLen */ static UINT WPRINTF_GetLen( WPRINTF_FORMAT *format, WPRINTF_DATA *arg, - LPSTR number, UINT maxlen ) + LPSTR number, UINT maxlen, BOOL dst_is_wide ) { UINT len; @@ -264,8 +264,18 @@ static UINT WPRINTF_GetLen( WPRINTF_FORMAT *format, WPRINTF_DATA *arg, return (format->precision = len); case WPR_WSTRING: if (!arg->lpcwstr_view) arg->lpcwstr_view = null_stringW; - for (len = 0; !format->precision || (len < format->precision); len++) - if (!*(arg->lpcwstr_view + len)) break; + if (dst_is_wide) + { + for (len = 0; !format->precision || (len < format->precision); len++) + if (!*(arg->lpcwstr_view + len)) break; + } + else + { + LPCWSTR p = arg->lpcwstr_view; + for (len = 0; (!format->precision || len < format->precision) && *p; p++) + len += WideCharToMultiByte( CP_ACP, 0, p, 1, NULL, 0, NULL, NULL ); + if (format->precision && len > format->precision) len = format->precision; + } if (len > maxlen) len = maxlen; return (format->precision = len); case WPR_SIGNED: @@ -365,7 +375,7 @@ INT WINAPI wvnsprintfA( LPSTR buffer, INT maxlen, LPCSTR spec, __ms_va_list args break; } - len = WPRINTF_GetLen( &format, &argData, number, maxlen - 1 ); + len = WPRINTF_GetLen( &format, &argData, number, maxlen - 1, FALSE ); sign = 0; if (!(format.flags & WPRINTF_LEFTALIGN)) for (i = format.precision; i < format.width; i++, maxlen--) @@ -385,7 +395,15 @@ INT WINAPI wvnsprintfA( LPSTR buffer, INT maxlen, LPCSTR spec, __ms_va_list args case WPR_WSTRING: { LPCWSTR ptr = argData.lpcwstr_view; - for (i = 0; i < len; i++) *p++ = (CHAR)*ptr++; + for (i = 0; i < len; ptr++) + { + CHAR mb[5]; /* 5 is MB_LEN_MAX */ + int ret = WideCharToMultiByte( CP_ACP, 0, ptr, 1, mb, sizeof(mb), NULL, NULL ); + i += ret; + if (i > len) ret = len - (p - buffer); + memcpy( p, mb, ret ); + p += ret; + } } break; case WPR_HEXA: @@ -472,7 +490,7 @@ INT WINAPI wvnsprintfW( LPWSTR buffer, INT maxlen, LPCWSTR spec, __ms_va_list ar break; } - len = WPRINTF_GetLen( &format, &argData, number, maxlen - 1 ); + len = WPRINTF_GetLen( &format, &argData, number, maxlen - 1, TRUE ); sign = 0; if (!(format.flags & WPRINTF_LEFTALIGN)) for (i = format.precision; i < format.width; i++, maxlen--)

1 0

Akihiro Sagawa : user32/tests: Add wsprintfW %S conversion tests.
by Alexandre Julliard 10 Feb '20

10 Feb '20

Module: wine Branch: master Commit: c8f46313e4e2eae91d55654b3c972ea76aabf7e4 URL: https://source.winehq.org/git/wine.git/?a=commit;h=c8f46313e4e2eae91d55654b… Author: Akihiro Sagawa <sagawa.aki(a)gmail.com> Date: Sun Feb 9 20:51:35 2020 +0900 user32/tests: Add wsprintfW %S conversion tests. Signed-off-by: Akihiro Sagawa <sagawa.aki(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/user32/tests/wsprintf.c | 48 ++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 48 insertions(+) diff --git a/dlls/user32/tests/wsprintf.c b/dlls/user32/tests/wsprintf.c index ab4f4dae04..e5317bdef0 100644 --- a/dlls/user32/tests/wsprintf.c +++ b/dlls/user32/tests/wsprintf.c @@ -123,7 +123,25 @@ static void wsprintfWTest(void) static const WCHAR fmt_010ld[] = {'%','0','1','0','l','d','\0'}; static const WCHAR res_010ld[] = {'-','0','0','0','0','0','0','0','0','1', '\0'}; static const WCHAR fmt_I64x[] = {'%','I','6','4','x',0}; + static const WCHAR fmt_dot3S[] = {'%','.','3','S',0}; + static const WCHAR fmt__4S[] = {'%','-','4','S',0}; + static const WCHAR stars[] = {'*', 0x2606, 0x2605, 0}; + static const WCHAR nul_spc[] = {'*', 0, ' ', ' ', 0}; + WCHAR def_spc[] = {'*','?', 0x2605, ' ', 0}; WCHAR buf[25], fmt[25], res[25]; + char stars_mb[8], partial00[8], partialFF[8]; + const struct { + const char *input; + const WCHAR *fmt; + const WCHAR *str; + int rc; + } + testcase[] = { + { stars_mb, fmt_dot3S, stars, 3 }, + { partial00, fmt__4S, nul_spc, 4 }, + { partialFF, fmt__4S, def_spc, 4 }, + }; + CPINFOEXW cpinfoex; unsigned int i; int rc; @@ -150,6 +168,36 @@ static void wsprintfWTest(void) ok(rc == lstrlenW(res), "%u: wsprintfW length failure: rc=%d\n", i, rc); ok(!lstrcmpW(buf, res), "%u: wrong result [%s]\n", i, wine_dbgstr_w(buf)); } + + if (!GetCPInfoExW(CP_ACP, 0, &cpinfoex) || cpinfoex.MaxCharSize <= 1) + { + skip("Multi-byte wsprintfW test isn't available for the current codepage\n"); + return; + } + def_spc[1] = cpinfoex.UnicodeDefaultChar; + + rc = WideCharToMultiByte(CP_ACP, 0, stars, -1, stars_mb, sizeof(stars_mb), NULL, NULL); + ok(rc == 6, "expected 6, got %d\n", rc); + strcpy(partial00, stars_mb); + partial00[2] = '\0'; + strcpy(partialFF, stars_mb); + partialFF[2] = 0xff; + + for (i = 0; i < ARRAY_SIZE(testcase); i++) + { + memset(buf, 0x11, sizeof(buf)); + rc = wsprintfW(buf, testcase[i].fmt, testcase[i].input); + + todo_wine_if (i == 2) + ok(rc == testcase[i].rc, + "%u: expected %d, got %d\n", + i, testcase[i].rc, rc); + + todo_wine ok(!memcmp(buf, testcase[i].str, (testcase[i].rc + 1) * sizeof(WCHAR)), + "%u: expected %s, got %s\n", i, + wine_dbgstr_wn(testcase[i].str, testcase[i].rc + 1), + wine_dbgstr_wn(buf, rc + 1)); + } } /* Test if the CharUpper / CharLower functions return true 16 bit results,

1 0

Akihiro Sagawa : user32: Fix wsprintfW %S conversion.
by Alexandre Julliard 10 Feb '20

10 Feb '20

Module: wine Branch: master Commit: fa8a9a81e6a42a249f48c8b1073ebf9d5d79e9fd URL: https://source.winehq.org/git/wine.git/?a=commit;h=fa8a9a81e6a42a249f48c8b1… Author: Akihiro Sagawa <sagawa.aki(a)gmail.com> Date: Sun Feb 9 20:51:37 2020 +0900 user32: Fix wsprintfW %S conversion. Signed-off-by: Akihiro Sagawa <sagawa.aki(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/user32/tests/wsprintf.c | 3 +-- dlls/user32/wsprintf.c | 27 ++++++++++++++++++++++++--- 2 files changed, 25 insertions(+), 5 deletions(-) diff --git a/dlls/user32/tests/wsprintf.c b/dlls/user32/tests/wsprintf.c index e5317bdef0..c7be43a08f 100644 --- a/dlls/user32/tests/wsprintf.c +++ b/dlls/user32/tests/wsprintf.c @@ -188,12 +188,11 @@ static void wsprintfWTest(void) memset(buf, 0x11, sizeof(buf)); rc = wsprintfW(buf, testcase[i].fmt, testcase[i].input); - todo_wine_if (i == 2) ok(rc == testcase[i].rc, "%u: expected %d, got %d\n", i, testcase[i].rc, rc); - todo_wine ok(!memcmp(buf, testcase[i].str, (testcase[i].rc + 1) * sizeof(WCHAR)), + ok(!memcmp(buf, testcase[i].str, (testcase[i].rc + 1) * sizeof(WCHAR)), "%u: expected %s, got %s\n", i, wine_dbgstr_wn(testcase[i].str, testcase[i].rc + 1), wine_dbgstr_wn(buf, rc + 1)); diff --git a/dlls/user32/wsprintf.c b/dlls/user32/wsprintf.c index 478583d926..e5e6c10dbb 100644 --- a/dlls/user32/wsprintf.c +++ b/dlls/user32/wsprintf.c @@ -259,8 +259,22 @@ static UINT WPRINTF_GetLen( WPRINTF_FORMAT *format, WPRINTF_DATA *arg, return (format->precision = 1); case WPR_STRING: if (!arg->lpcstr_view) arg->lpcstr_view = null_stringA; - for (len = 0; !format->precision || (len < format->precision); len++) - if (!*(arg->lpcstr_view + len)) break; + if (dst_is_wide) + { + LPCSTR p = arg->lpcstr_view; + for (len = 0; (!format->precision || len < format->precision) && *p; p++) + { + /* This isn't applicable for UTF-8 and UTF-7 */ + if (IsDBCSLeadByte( *p )) p++; + len++; + if (!*p) break; + } + } + else + { + for (len = 0; !format->precision || (len < format->precision); len++) + if (!*(arg->lpcstr_view + len)) break; + } if (len > maxlen) len = maxlen; return (format->precision = len); case WPR_WSTRING: @@ -494,7 +508,14 @@ static INT wvsnprintfW( LPWSTR buffer, UINT maxlen, LPCWSTR spec, __ms_va_list a case WPR_STRING: { LPCSTR ptr = argData.lpcstr_view; - for (i = 0; i < len; i++) *p++ = (BYTE)*ptr++; + for (i = 0; i < len; i++) + { + WCHAR buf[2]; /* for LeadByte + NUL case, we need 2 WCHARs. */ + int ret, mb_len = IsDBCSLeadByte( *ptr ) ? 2 : 1; + ret = MultiByteToWideChar( CP_ACP, 0, ptr, mb_len, buf, ARRAY_SIZE( buf )); + *p++ = buf[ret - 1]; + ptr += mb_len; + } } break; case WPR_WSTRING:

1 0

Hermes Belusca-Maito : atl: Fix the ATL_WNDCLASSINFOW::m_szAutoName member definition and construction.
by Alexandre Julliard 10 Feb '20

10 Feb '20

Module: wine Branch: master Commit: 5608682dc9c0f30cca0bfb24705e9b82b6a7aecc URL: https://source.winehq.org/git/wine.git/?a=commit;h=5608682dc9c0f30cca0bfb24… Author: Hermes Belusca-Maito <hermes.belusca(a)sfr.fr> Date: Wed Jan 15 02:09:33 2020 +0100 atl: Fix the ATL_WNDCLASSINFOW::m_szAutoName member definition and construction. Signed-off-by: Hermes Belusca-Maito <hermes.belusca(a)sfr.fr> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/atl/atl30.c | 9 ++++----- dlls/atl/tests/module.c | 51 +++++++++++++++++++++++++++++++++++++++++++++++++ include/atlwin.h | 4 ++-- 3 files changed, 57 insertions(+), 7 deletions(-) diff --git a/dlls/atl/atl30.c b/dlls/atl/atl30.c index 29b29d4cbe..b015ea4b74 100644 --- a/dlls/atl/atl30.c +++ b/dlls/atl/atl30.c @@ -313,7 +313,7 @@ ATOM WINAPI AtlModuleRegisterWndClassInfoA(_ATL_MODULEA *pm, _ATL_WNDCLASSINFOA if (!wci->m_wc.lpszClassName) { - sprintf(wci->m_szAutoName, "ATL%08x", PtrToUint(wci)); + sprintf(wci->m_szAutoName, "ATL:%p", wci); TRACE("auto-generated class name %s\n", wci->m_szAutoName); wci->m_wc.lpszClassName = wci->m_szAutoName; } @@ -350,8 +350,8 @@ ATOM WINAPI AtlModuleRegisterWndClassInfoA(_ATL_MODULEA *pm, _ATL_WNDCLASSINFOA * NOTES * Can be called multiple times without error, unlike RegisterClassEx(). * - * If the class name is NULL, then a class with a name of "ATLxxxxxxxx" is - * registered, where the 'x's represent a unique value. + * If the class name is NULL, then a class with a name of "ATL:xxxxxxxx" is + * registered, where 'xxxxxxxx' represents a unique hexadecimal value. * */ ATOM WINAPI AtlModuleRegisterWndClassInfoW(_ATL_MODULEW *pm, _ATL_WNDCLASSINFOW *wci, WNDPROC *pProc) @@ -372,8 +372,7 @@ ATOM WINAPI AtlModuleRegisterWndClassInfoW(_ATL_MODULEW *pm, _ATL_WNDCLASSINFOW if (!wci->m_wc.lpszClassName) { - static const WCHAR szFormat[] = {'A','T','L','%','0','8','x',0}; - swprintf(wci->m_szAutoName, ARRAY_SIZE(wci->m_szAutoName), szFormat, PtrToUint(wci)); + swprintf(wci->m_szAutoName, ARRAY_SIZE(wci->m_szAutoName), L"ATL:%p", wci); TRACE("auto-generated class name %s\n", debugstr_w(wci->m_szAutoName)); wci->m_wc.lpszClassName = wci->m_szAutoName; } diff --git a/dlls/atl/tests/module.c b/dlls/atl/tests/module.c index 6250f9b2cb..db8bd28742 100644 --- a/dlls/atl/tests/module.c +++ b/dlls/atl/tests/module.c @@ -25,6 +25,7 @@ #define COBJMACROS #include <atlbase.h> +#include <atlwin.h> #include <wine/test.h> @@ -113,6 +114,55 @@ static void test_winmodule(void) ok(winmod.m_pCreateWndList == create_data+1, "winmod.m_pCreateWndList != create_data\n"); } +static void test_winclassinfo(void) +{ + _ATL_MODULEW winmod; + HRESULT hres; + int len, expectedLen; + ATOM atom; + WNDPROC wndProc; + _ATL_WNDCLASSINFOW wci = + { + /* .m_wc = */ + { + sizeof(WNDCLASSEXW), + CS_VREDRAW | CS_HREDRAW, + DefWindowProcW, + 0, + 0, + NULL, + NULL, + LoadCursorW(NULL, (LPCWSTR)IDC_ARROW), + (HBRUSH)(COLOR_BTNFACE + 1), + NULL, + NULL, /* LPCSTR lpszClassName; <-- We force ATL class name generation */ + NULL + }, + /* .m_lpszOrigName = */ NULL, + /* .pWndProc = */ NULL, + /* .m_lpszCursorID = */ (LPCWSTR)IDC_ARROW, + /* .m_bSystemCursor = */ TRUE, + /* .m_atom = */ 0, + /* .m_szAutoName = */ L"" + }; + + winmod.cbSize = sizeof(winmod); + winmod.m_pCreateWndList = (void*)0xdeadbeef; + hres = AtlModuleInit(&winmod, NULL, NULL); + ok(hres == S_OK, "AtlModuleInit failed: %08x\n", hres); + ok(!winmod.m_pCreateWndList, "winmod.m_pCreateWndList = %p\n", winmod.m_pCreateWndList); + + atom = AtlModuleRegisterWndClassInfoW(&winmod, &wci, &wndProc); + ok(atom, "AtlModuleRegisterWndClassInfoA failed: %08x\n", atom); + ok(atom == wci.m_atom, "(atom = %08x) is != than (wci.m_atom = %08x)\n", atom, wci.m_atom); + + ok(wcsncmp(wci.m_szAutoName, L"ATL:", 4) == 0, "wci.m_szAutoName = '%ls', expected starting with 'ATL:'\n", wci.m_szAutoName); + + len = wcslen(wci.m_szAutoName); + expectedLen = sizeof("ATL:") + sizeof(void *) * 2 - 1; + ok(len == expectedLen, "wci.m_szAutoName has length %d, expected length %d\n", len, expectedLen); +} + static DWORD_PTR cb_val; static void WINAPI term_callback(DWORD_PTR dw) @@ -159,5 +209,6 @@ START_TEST(module) { test_StructSize(); test_winmodule(); + test_winclassinfo(); test_term(); } diff --git a/include/atlwin.h b/include/atlwin.h index 386177ba61..de31f403ba 100644 --- a/include/atlwin.h +++ b/include/atlwin.h @@ -29,7 +29,7 @@ typedef struct _ATL_WNDCLASSINFOA_TAG LPCSTR m_lpszCursorID; BOOL m_bSystemCursor; ATOM m_atom; - CHAR m_szAutoName[14]; + CHAR m_szAutoName[sizeof("ATL:") + sizeof(void *) * 2]; } _ATL_WNDCLASSINFOA; typedef struct _ATL_WNDCLASSINFOW_TAG @@ -40,7 +40,7 @@ typedef struct _ATL_WNDCLASSINFOW_TAG LPCWSTR m_lpszCursorID; BOOL m_bSystemCursor; ATOM m_atom; - WCHAR m_szAutoName[14]; + WCHAR m_szAutoName[sizeof("ATL:") + sizeof(void *) * 2]; } _ATL_WNDCLASSINFOW; ATOM WINAPI AtlModuleRegisterWndClassInfoA(_ATL_MODULEA *pm, _ATL_WNDCLASSINFOA *wci, WNDPROC *pProc);

1 0

Zebediah Figura : qedit/samplegrabber: Don't overwrite the filter media type in sample_grabber_sink_connect().
by Alexandre Julliard 10 Feb '20

10 Feb '20

Module: wine Branch: master Commit: a5f547420f9d180edff961c15b69474cb111860b URL: https://source.winehq.org/git/wine.git/?a=commit;h=a5f547420f9d180edff961c1… Author: Zebediah Figura <z.figura12(a)gmail.com> Date: Fri Feb 7 23:51:52 2020 -0600 qedit/samplegrabber: Don't overwrite the filter media type in sample_grabber_sink_connect(). Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/qedit/samplegrabber.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/dlls/qedit/samplegrabber.c b/dlls/qedit/samplegrabber.c index f0fa70708a..322cbf0400 100644 --- a/dlls/qedit/samplegrabber.c +++ b/dlls/qedit/samplegrabber.c @@ -254,7 +254,7 @@ SampleGrabber_ISampleGrabber_GetConnectedMediaType(ISampleGrabber *iface, AM_MED if (!filter->sink.pin.peer) return VFW_E_NOT_CONNECTED; - CopyMediaType(mt, &filter->filter_mt); + CopyMediaType(mt, &filter->sink.pin.mt); return S_OK; } @@ -519,9 +519,6 @@ static HRESULT sample_grabber_sink_connect(struct strmbase_sink *iface, && !IsEqualGUID(&filter->filter_mt.formattype, &mt->formattype)) return VFW_E_TYPE_NOT_ACCEPTED; - FreeMediaType(&filter->filter_mt); - CopyMediaType(&filter->filter_mt, mt); - return S_OK; }

1 0

Zebediah Figura : qedit/samplegrabber: Implement sample_grabber_source_query_accept().
by Alexandre Julliard 10 Feb '20

10 Feb '20

Module: wine Branch: master Commit: cdf7d4ff9a6fea44c3d06f02d31821bbc4c9416f URL: https://source.winehq.org/git/wine.git/?a=commit;h=cdf7d4ff9a6fea44c3d06f02… Author: Zebediah Figura <z.figura12(a)gmail.com> Date: Fri Feb 7 23:51:53 2020 -0600 qedit/samplegrabber: Implement sample_grabber_source_query_accept(). Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/qedit/samplegrabber.c | 38 ++++++---- dlls/qedit/tests/samplegrabber.c | 154 ++++++++++++++++----------------------- 2 files changed, 85 insertions(+), 107 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=cdf7d4ff9a6fea44c3d0…

1 0