July 2020 - Wine-commits - list.winehq.org

Vijay Kiran Kamuju : include: Add IXACT3SoundBank definition.
by Alexandre Julliard 02 Jul '20

02 Jul '20

Module: wine Branch: master Commit: 56f3ca3f767c2cd6a22139c393fd5051be588a71 URL: https://source.winehq.org/git/wine.git/?a=commit;h=56f3ca3f767c2cd6a22139c3… Author: Vijay Kiran Kamuju <infyquest(a)gmail.com> Date: Wed Jul 1 23:19:03 2020 +0200 include: Add IXACT3SoundBank definition. Signed-off-by: Vijay Kiran Kamuju <infyquest(a)gmail.com> Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- include/xact3.h | 43 +++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 43 insertions(+) diff --git a/include/xact3.h b/include/xact3.h index 8b9c3967cf..cdb91d145d 100644 --- a/include/xact3.h +++ b/include/xact3.h @@ -542,6 +542,49 @@ DECLARE_INTERFACE(IXACT3Wave) #define IXACT3Wave_GetProperties(p,a) (p)->GetProperties(a) #endif +#define XACT_FLAG_SOUNDBANK_STOP_IMMEDIATE XACT_FLAG_STOP_IMMEDIATE +#define XACT_SOUNDBANKSTATE_INUSE XACT_STATE_INUSE + +/***************************************************************************** + * IXACT3SoundBank interface + */ +#define INTERFACE IXACT3SoundBank +DECLARE_INTERFACE(IXACT3SoundBank) +{ + /*** IXACT3SoundBank methods ***/ + STDMETHOD_(XACTINDEX,GetCueIndex)(THIS_ PCSTR szFriendlyName) PURE; + STDMETHOD(GetNumCues)(THIS_ XACTINDEX *pnNumCues) PURE; + STDMETHOD(GetCueProperties)(THIS_ XACTINDEX nCueIndex, LPXACT_CUE_PROPERTIES pProperties) PURE; + STDMETHOD(Prepare)(THIS_ XACTINDEX nCueIndex, DWORD dwFlags, XACTTIME timeOffset, IXACT3Cue **ppCue) PURE; + STDMETHOD(Play)(THIS_ XACTINDEX nCueIndex, DWORD dwFlags, XACTTIME timeOffset, IXACT3Cue **ppCue) PURE; + STDMETHOD(Stop)(THIS_ XACTINDEX nCueIndex, DWORD dwFlags) PURE; + STDMETHOD(Destroy)(THIS) PURE; + STDMETHOD(GetState)(THIS_ DWORD *pdwState) PURE; +}; +#undef INTERFACE + +#if !defined(__cplusplus) || defined(CINTERFACE) +/*** IXACT3SoundBank methods ***/ +#define IXACT3SoundBank_GetCueIndex(p,a) (p)->lpVtbl->GetCueIndex(p,a) +#define IXACT3SoundBank_GetNumCues(p,a) (p)->lpVtbl->GetNumCues(p,a) +#define IXACT3SoundBank_GetCueProperties(p,a,b) (p)->lpVtbl->GetCueProperties(p,a,b) +#define IXACT3SoundBank_Prepare(p,a,b,c,d) (p)->lpVtbl->Prepare(p,a,b,c,d) +#define IXACT3SoundBank_Play(p,a,b,c,d) (p)->lpVtbl->Play(p,a,b,c,d) +#define IXACT3SoundBank_Stop(p,a,b) (p)->lpVtbl->Stop(p,a,b) +#define IXACT3SoundBank_Destroy(p) (p)->lpVtbl->Destroy(p) +#define IXACT3SoundBank_GetState(p,a) (p)->lpVtbl->GetState(p,a) +#else +/*** IXACT3SoundBank methods ***/ +#define IXACT3SoundBank_GetCueIndex(p,a) (p)->GetCueIndex(a) +#define IXACT3SoundBank_GetNumCues(p,a) (p)->GetNumCues(a) +#define IXACT3SoundBank_GetCueProperties(p,a,b) (p)->GetCueProperties(a,b) +#define IXACT3SoundBank_Prepare(p,a,b,c,d) (p)->Prepare(a,b,c,d) +#define IXACT3SoundBank_Play(p,a,b,c,d) (p)->Play(a,b,c,d) +#define IXACT3SoundBank_Stop(p,a,b) (p)->Stop(a,b) +#define IXACT3SoundBank_Destroy(p) (p)->Destroy() +#define IXACT3SoundBank_GetState(p,a) (p)->GetState(a) +#endif + #define XACT_FLAG_ENGINE_CREATE_MANAGEDATA XACT_FLAG_MANAGEDATA #define XACT_FLAG_ENGINE_STOP_IMMEDIATE XACT_FLAG_STOP_IMMEDIATE

1 0

Vijay Kiran Kamuju : include: Add IXACT3WaveBank definition.
by Alexandre Julliard 02 Jul '20

02 Jul '20

Module: wine Branch: master Commit: b1d78184f0746732126c5e2ae7a2c14d2644b247 URL: https://source.winehq.org/git/wine.git/?a=commit;h=b1d78184f0746732126c5e2a… Author: Vijay Kiran Kamuju <infyquest(a)gmail.com> Date: Wed Jul 1 23:26:19 2020 +0200 include: Add IXACT3WaveBank definition. Signed-off-by: Vijay Kiran Kamuju <infyquest(a)gmail.com> Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- include/xact3.h | 44 ++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 44 insertions(+) diff --git a/include/xact3.h b/include/xact3.h index cdb91d145d..d66874a511 100644 --- a/include/xact3.h +++ b/include/xact3.h @@ -585,6 +585,50 @@ DECLARE_INTERFACE(IXACT3SoundBank) #define IXACT3SoundBank_GetState(p,a) (p)->GetState(a) #endif +#define XACT_WAVEBANKSTATE_INUSE XACT_STATE_INUSE +#define XACT_WAVEBANKSTATE_PREPARED XACT_STATE_PREPARED +#define XACT_WAVEBANKSTATE_PREPAREFAILED XACT_STATE_PREPAREFAILED + +/***************************************************************************** + * IXACT3WaveBank interface + */ +#define INTERFACE IXACT3WaveBank +DECLARE_INTERFACE(IXACT3WaveBank) +{ + /*** IXACT3WaveBank methods ***/ + STDMETHOD(Destroy)(THIS) PURE; + STDMETHOD(GetNumWaves)(THIS_ XACTINDEX *pnNumWaves) PURE; + STDMETHOD_(XACTINDEX,GetWaveIndex)(THIS_ PCSTR szFriendlyName) PURE; + STDMETHOD(GetWaveProperties)(THIS_ XACTINDEX nWaveIndex, LPXACT_WAVE_PROPERTIES pWaveProperties) PURE; + STDMETHOD(Prepare)(THIS_ XACTINDEX nWaveIndex, DWORD dwFlags, DWORD dwPlayOffset, XACTLOOPCOUNT nLoopCount, IXACT3Wave **ppWave) PURE; + STDMETHOD(Play)(THIS_ XACTINDEX nWaveIndex, DWORD dwFlags, DWORD dwPlayOffset, XACTLOOPCOUNT nLoopCount, IXACT3Wave **ppWave) PURE; + STDMETHOD(Stop)(THIS_ XACTINDEX nWaveIndex, DWORD dwFlags) PURE; + STDMETHOD(GetState)(THIS_ DWORD *pdwState) PURE; +}; +#undef INTERFACE + +#if !defined(__cplusplus) || defined(CINTERFACE) +/*** IXACT3WaveBank methods ***/ +#define IXACT3WaveBank_Destroy(p) (p)->lpVtbl->Destroy(p) +#define IXACT3WaveBank_GetNumWaves(p,a) (p)->lpVtbl->GetNumCues(p,a) +#define IXACT3WaveBank_GetWaveIndex(p,a) (p)->lpVtbl->GetWaveIndex(p,a) +#define IXACT3WaveBank_GetWaveProperties(p,a,b) (p)->lpVtbl->GetWaveProperties(p,a,b) +#define IXACT3WaveBank_Prepare(p,a,b,c,d,e) (p)->lpVtbl->Prepare(p,a,b,c,d,e) +#define IXACT3WaveBank_Play(p,a,b,c,d,e) (p)->lpVtbl->Play(p,a,b,c,d,e) +#define IXACT3WaveBank_Stop(p,a,b) (p)->lpVtbl->Stop(p,a,b) +#define IXACT3WaveBank_GetState(p,a) (p)->lpVtbl->GetState(p,a) +#else +/*** IXACT3WaveBank methods ***/ +#define IXACT3WaveBank_Destroy(p) (p)->Destroy() +#define IXACT3WaveBank_GetNumWaves(p,a) (p)->GetNumWaves(a) +#define IXACT3WaveBank_GetWaveIndex(p,a) (p)->GetWaveIndex(a) +#define IXACT3WaveBank_GetWaveProperties(p,a,b) (p)->GetWaveProperties(a,b) +#define IXACT3WaveBank_Prepare(p,a,b,c,d,e) (p)->Prepare(a,b,c,d,e) +#define IXACT3WaveBank_Play(p,a,b,c,d,e) (p)->Play(a,b,c,d,e) +#define IXACT3WaveBank_Stop(p,a,b) (p)->Stop(a,b) +#define IXACT3WaveBank_GetState(p,a) (p)->GetState(a) +#endif + #define XACT_FLAG_ENGINE_CREATE_MANAGEDATA XACT_FLAG_MANAGEDATA #define XACT_FLAG_ENGINE_STOP_IMMEDIATE XACT_FLAG_STOP_IMMEDIATE

1 0

Shawn M. Chapla : advapi32: Add RegRenameKey stub.
by Alexandre Julliard 02 Jul '20

02 Jul '20

Module: wine Branch: master Commit: 1e8cfc016e92c609ee23340d42bdefbb8e7f126f URL: https://source.winehq.org/git/wine.git/?a=commit;h=1e8cfc016e92c609ee23340d… Author: Shawn M. Chapla <schapla(a)codeweavers.com> Date: Wed Jul 1 19:34:44 2020 -0400 advapi32: Add RegRenameKey stub. Signed-off-by: Shawn M. Chapla <schapla(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/advapi32/advapi32.spec | 2 +- dlls/advapi32/registry.c | 11 +++++++++++ 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/dlls/advapi32/advapi32.spec b/dlls/advapi32/advapi32.spec index 64b0288dc9..fcef859a7c 100644 --- a/dlls/advapi32/advapi32.spec +++ b/dlls/advapi32/advapi32.spec @@ -676,7 +676,7 @@ @ stdcall -import RegQueryValueExW(long wstr ptr ptr ptr ptr) @ stdcall RegQueryValueW(long wstr ptr ptr) @ stub RegRemapPreDefKey -# @ stub RegRenameKey +@ stdcall RegRenameKey(long wstr wstr) @ stdcall RegReplaceKeyA(long str str str) @ stdcall RegReplaceKeyW(long wstr wstr wstr) @ stdcall -import RegRestoreKeyA(long str long) diff --git a/dlls/advapi32/registry.c b/dlls/advapi32/registry.c index 7cfdbaa53b..ba24d648ff 100644 --- a/dlls/advapi32/registry.c +++ b/dlls/advapi32/registry.c @@ -507,6 +507,17 @@ LSTATUS WINAPI RegReplaceKeyW( HKEY hkey, LPCWSTR lpSubKey, LPCWSTR lpNewFile, } +/****************************************************************************** + * RegRenameKey [ADVAPI32.@] + * + */ +LSTATUS WINAPI RegRenameKey( HKEY hkey, LPCWSTR lpSubKey, LPCWSTR lpNewName ) +{ + FIXME("(%p,%s,%s): stub\n", hkey, debugstr_w(lpSubKey), debugstr_w(lpNewName)); + return ERROR_CALL_NOT_IMPLEMENTED; +} + + /****************************************************************************** * RegReplaceKeyA [ADVAPI32.@] *

1 0

Hans Leidekker : iphlpapi: Return gateway address 0.0.0.0/255.255.255.255 from GetAdaptersInfo if it's not set.
by Alexandre Julliard 02 Jul '20

02 Jul '20

Module: wine Branch: master Commit: 3e0369970d90b5ca42d2e1f7dc5810fec5477587 URL: https://source.winehq.org/git/wine.git/?a=commit;h=3e0369970d90b5ca42d2e1f7… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Thu Jul 2 10:23:27 2020 +0200 iphlpapi: Return gateway address 0.0.0.0/255.255.255.255 from GetAdaptersInfo if it's not set. Signed-off-by: Hans Leidekker <hans(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/iphlpapi/iphlpapi_main.c | 2 ++ dlls/iphlpapi/tests/iphlpapi.c | 9 ++++++--- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/dlls/iphlpapi/iphlpapi_main.c b/dlls/iphlpapi/iphlpapi_main.c index ff9d0d3a53..c039086229 100644 --- a/dlls/iphlpapi/iphlpapi_main.c +++ b/dlls/iphlpapi/iphlpapi_main.c @@ -742,6 +742,8 @@ DWORD WINAPI GetAdaptersInfo(PIP_ADAPTER_INFO pAdapterInfo, PULONG pOutBufLen) } /* Find first router through this interface, which we'll assume * is the default gateway for this adapter */ + strcpy(ptr->GatewayList.IpAddress.String, "0.0.0.0"); + strcpy(ptr->GatewayList.IpMask.String, "255.255.255.255"); for (i = 0; i < routeTable->dwNumEntries; i++) if (routeTable->table[i].dwForwardIfIndex == ptr->Index && routeTable->table[i].u1.ForwardType == diff --git a/dlls/iphlpapi/tests/iphlpapi.c b/dlls/iphlpapi/tests/iphlpapi.c index d5690c11ee..6965ae8457 100644 --- a/dlls/iphlpapi/tests/iphlpapi.c +++ b/dlls/iphlpapi/tests/iphlpapi.c @@ -1120,10 +1120,13 @@ static void testGetAdaptersInfo(void) apiReturn); ptr = buf; while (ptr) { - ok(ptr->IpAddressList.IpAddress.String[0], "A valid IP must be present\n"); + ok(ptr->IpAddressList.IpAddress.String[0], "A valid IP address must be present\n"); ok(ptr->IpAddressList.IpMask.String[0], "A valid mask must be present\n"); - trace("Adapter '%s', IP %s, Mask %s\n", ptr->AdapterName, - ptr->IpAddressList.IpAddress.String, ptr->IpAddressList.IpMask.String); + ok(ptr->GatewayList.IpAddress.String[0], "A valid IP address must be present\n"); + ok(ptr->GatewayList.IpMask.String[0], "A valid mask must be present\n"); + trace("adapter '%s', address %s/%s gateway %s/%s\n", ptr->AdapterName, + ptr->IpAddressList.IpAddress.String, ptr->IpAddressList.IpMask.String, + ptr->GatewayList.IpAddress.String, ptr->GatewayList.IpMask.String); ptr = ptr->Next; } HeapFree(GetProcessHeap(), 0, buf);

1 0

Huw Davies : ntdll: Pass the start of the string to compose_string().
by Alexandre Julliard 02 Jul '20

02 Jul '20

Module: wine Branch: master Commit: 25d6abb951e111fd4da1130fef16749ae6981540 URL: https://source.winehq.org/git/wine.git/?a=commit;h=25d6abb951e111fd4da1130f… Author: Huw Davies <huw(a)codeweavers.com> Date: Thu Jul 2 10:44:16 2020 +0100 ntdll: Pass the start of the string to compose_string(). Fixes a regression caused by 520040dc4a287fd62d7d5161c083cee990c3d6e6. Signed-off-by: Huw Davies <huw(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/ntdll/unix/env.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/ntdll/unix/env.c b/dlls/ntdll/unix/env.c index 789a398405..eb75e6e949 100644 --- a/dlls/ntdll/unix/env.c +++ b/dlls/ntdll/unix/env.c @@ -557,7 +557,7 @@ DWORD ntdll_umbstowcs( const char *src, DWORD srclen, WCHAR *dst, DWORD dstlen ) } reslen = dstlen - (dstend - dst); #ifdef __APPLE__ /* work around broken Mac OS X filesystem that enforces NFD */ - if (reslen && nfc_table) reslen = compose_string( nfc_table, dst, reslen ); + if (reslen && nfc_table) reslen = compose_string( nfc_table, dst - reslen, reslen ); #endif } return reslen;

1 0

Piotr Caban : msi: Fix use after free error in TransformView_set_row.
by Alexandre Julliard 02 Jul '20

02 Jul '20

Module: wine Branch: master Commit: 6a0a0d2a0b15bffa9d4a5b41e75be6765e731d69 URL: https://source.winehq.org/git/wine.git/?a=commit;h=6a0a0d2a0b15bffa9d4a5b41… Author: Piotr Caban <piotr(a)codeweavers.com> Date: Wed Jul 1 10:43:00 2020 +0200 msi: Fix use after free error in TransformView_set_row. Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> Signed-off-by: Hans Leidekker <hans(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/msi/table.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/dlls/msi/table.c b/dlls/msi/table.c index d4912ab3ae..3febcb3aa9 100644 --- a/dlls/msi/table.c +++ b/dlls/msi/table.c @@ -2341,7 +2341,7 @@ static UINT TransformView_set_row( MSIVIEW *view, UINT row, MSIRECORD *rec, UINT L"INSERT INTO `_TransformView` (`Table`, `Column`, `Row`, `Data`, `Current`) VALUES ('"; MSITABLEVIEW *tv = (MSITABLEVIEW*)view; - WCHAR buf[256], *query = buf; + WCHAR buf[256], *query; MSIRECORD *old_rec; MSIQUERY *q; WCHAR *key; @@ -2409,6 +2409,10 @@ static UINT TransformView_set_row( MSIVIEW *view, UINT row, MSIRECORD *rec, UINT return ERROR_OUTOFMEMORY; } } + else + { + query = buf; + } memcpy( query, query_pfx, p * sizeof(WCHAR) ); len = wcslen( tv->name );

1 0

Piotr Caban : msi: Remove no longer needed parameter from TABLE_remove_column.
by Alexandre Julliard 02 Jul '20

02 Jul '20

Module: wine Branch: master Commit: d579b17eb425ac5e28f9263ebf302ea2282996ec URL: https://source.winehq.org/git/wine.git/?a=commit;h=d579b17eb425ac5e28f9263e… Author: Piotr Caban <piotr(a)codeweavers.com> Date: Wed Jul 1 10:43:05 2020 +0200 msi: Remove no longer needed parameter from TABLE_remove_column. Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> Signed-off-by: Hans Leidekker <hans(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/msi/table.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/dlls/msi/table.c b/dlls/msi/table.c index 3febcb3aa9..27f3763d34 100644 --- a/dlls/msi/table.c +++ b/dlls/msi/table.c @@ -1949,7 +1949,7 @@ static UINT TABLE_add_ref(struct tagMSIVIEW *view) return InterlockedIncrement(&tv->table->ref_count); } -static UINT TABLE_remove_column(struct tagMSIVIEW *view, LPCWSTR table, UINT number) +static UINT TABLE_remove_column(struct tagMSIVIEW *view, UINT number) { MSITABLEVIEW *tv = (MSITABLEVIEW*)view; MSIRECORD *rec = NULL; @@ -1974,7 +1974,7 @@ static UINT TABLE_remove_column(struct tagMSIVIEW *view, LPCWSTR table, UINT num if (!rec) return ERROR_OUTOFMEMORY; - MSI_RecordSetStringW(rec, 1, table); + MSI_RecordSetStringW(rec, 1, tv->name); MSI_RecordSetInteger(rec, 2, number); r = TABLE_CreateView(tv->db, szColumns, &columns); @@ -1992,7 +1992,7 @@ static UINT TABLE_remove_column(struct tagMSIVIEW *view, LPCWSTR table, UINT num if (r != ERROR_SUCCESS) goto done; - msi_update_table_columns(tv->db, table); + msi_update_table_columns(tv->db, tv->name); done: msiobj_release(&rec->hdr); @@ -2016,8 +2016,7 @@ static UINT TABLE_release(struct tagMSIVIEW *view) { if (tv->table->colinfo[i].type & MSITYPE_TEMPORARY) { - r = TABLE_remove_column(view, tv->table->colinfo[i].tablename, - tv->table->colinfo[i].number); + r = TABLE_remove_column(view, tv->table->colinfo[i].number); if (r != ERROR_SUCCESS) break; } @@ -2145,8 +2144,7 @@ static UINT TABLE_drop(struct tagMSIVIEW *view) for (i = tv->table->col_count - 1; i >= 0; i--) { - r = TABLE_remove_column(view, tv->table->colinfo[i].tablename, - tv->table->colinfo[i].number); + r = TABLE_remove_column(view, tv->table->colinfo[i].number); if (r != ERROR_SUCCESS) return r; }

1 0

Piotr Caban : msi: Add support for appending data to _TransformView table.
by Alexandre Julliard 02 Jul '20

02 Jul '20

Module: wine Branch: master Commit: 3459c90cd6a49e817213b6e6764bdfafa7d4bcc7 URL: https://source.winehq.org/git/wine.git/?a=commit;h=3459c90cd6a49e817213b6e6… Author: Piotr Caban <piotr(a)codeweavers.com> Date: Wed Jul 1 10:43:08 2020 +0200 msi: Add support for appending data to _TransformView table. Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> Signed-off-by: Hans Leidekker <hans(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/msi/table.c | 48 ++++++++++++++++++++++++++++-------------------- 1 file changed, 28 insertions(+), 20 deletions(-) diff --git a/dlls/msi/table.c b/dlls/msi/table.c index 27f3763d34..612a369597 100644 --- a/dlls/msi/table.c +++ b/dlls/msi/table.c @@ -2336,7 +2336,7 @@ static UINT TransformView_fetch_stream( MSIVIEW *view, UINT row, UINT col, IStre static UINT TransformView_set_row( MSIVIEW *view, UINT row, MSIRECORD *rec, UINT mask ) { static const WCHAR query_pfx[] = - L"INSERT INTO `_TransformView` (`Table`, `Column`, `Row`, `Data`, `Current`) VALUES ('"; + L"INSERT INTO `_TransformView` (`new`, `Table`, `Column`, `Row`, `Data`, `Current`) VALUES (1, '"; MSITABLEVIEW *tv = (MSITABLEVIEW*)view; WCHAR buf[256], *query; @@ -2372,7 +2372,7 @@ static UINT TransformView_set_row( MSIVIEW *view, UINT row, MSIRECORD *rec, UINT if (tv->columns[i].type & MSITYPE_KEY) continue; - qlen = p = wcslen( query_pfx ); + qlen = p = ARRAY_SIZE( query_pfx ) - 1; qlen += wcslen( tv->name ) + 3; /* strlen("','") */ qlen += wcslen( tv->columns[i].colname ) + 3; qlen += wcslen( key ) + 3; @@ -2481,7 +2481,7 @@ static UINT TransformView_set_row( MSIVIEW *view, UINT row, MSIRECORD *rec, UINT static UINT TransformView_create_table( MSITABLEVIEW *tv, MSIRECORD *rec ) { static const WCHAR query_fmt[] = - L"INSERT INTO `_TransformView` (`Table`, `Column`) VALUES ('%s', 'CREATE')"; + L"INSERT INTO `_TransformView` (`Table`, `Column`, `new`) VALUES ('%s', 'CREATE', 1)"; WCHAR buf[256], *query = buf; const WCHAR *name; @@ -2516,7 +2516,7 @@ static UINT TransformView_create_table( MSITABLEVIEW *tv, MSIRECORD *rec ) static UINT TransformView_add_column( MSITABLEVIEW *tv, MSIRECORD *rec ) { static const WCHAR query_pfx[] = - L"INSERT INTO `_TransformView` (`Table`, `Current`, `Column`, `Data`) VALUES ('"; + L"INSERT INTO `_TransformView` (`new`, `Table`, `Current`, `Column`, `Data`) VALUES (1, '"; WCHAR buf[256], *query = buf; UINT i, p, len, r, qlen; @@ -2569,7 +2569,7 @@ static UINT TransformView_add_column( MSITABLEVIEW *tv, MSIRECORD *rec ) static UINT TransformView_insert_row( MSIVIEW *view, MSIRECORD *rec, UINT row, BOOL temporary ) { static const WCHAR query_fmt[] = - L"INSERT INTO `_TransformView` (`Table`, `Column`, `Row`) VALUES ('%s', 'INSERT', '%s')"; + L"INSERT INTO `_TransformView` (`new`, `Table`, `Column`, `Row`) VALUES (1, '%s', 'INSERT', '%s')"; MSITABLEVIEW *tv = (MSITABLEVIEW*)view; WCHAR buf[256], *query = buf; @@ -2617,7 +2617,7 @@ static UINT TransformView_insert_row( MSIVIEW *view, MSIRECORD *rec, UINT row, B static UINT TransformView_drop_table( MSITABLEVIEW *tv, UINT row ) { - static const WCHAR query_pfx[] = L"INSERT INTO `_TransformView` ( `Table`, `Column` ) VALUES ( '"; + static const WCHAR query_pfx[] = L"INSERT INTO `_TransformView` ( `new`, `Table`, `Column` ) VALUES ( 1, '"; static const WCHAR query_sfx[] = L"', 'DROP' )"; WCHAR buf[256], *query = buf; @@ -2661,7 +2661,7 @@ static UINT TransformView_drop_table( MSITABLEVIEW *tv, UINT row ) static UINT TransformView_delete_row( MSIVIEW *view, UINT row ) { - static const WCHAR query_pfx[] = L"INSERT INTO `_TransformView` ( `Table`, `Column`, `Row`) VALUES ( '"; + static const WCHAR query_pfx[] = L"INSERT INTO `_TransformView` ( `new`, `Table`, `Column`, `Row`) VALUES ( 1, '"; static const WCHAR query_column[] = L"', 'DELETE', '"; static const WCHAR query_sfx[] = L"')"; @@ -2780,7 +2780,7 @@ static const MSIVIEWOPS transform_view_ops = UINT TransformView_Create( MSIDATABASE *db, string_table *st, LPCWSTR name, MSIVIEW **view ) { static const WCHAR query_pfx[] = L"SELECT `Column`, `Data`, `Current` FROM `_TransformView` WHERE `Table`='"; - static const WCHAR query_sfx[] = L"' AND `Row` IS NULL AND `Current` IS NOT NULL"; + static const WCHAR query_sfx[] = L"' AND `Row` IS NULL AND `Current` IS NOT NULL AND `new` = 1"; WCHAR buf[256], *query = buf; UINT r, len, name_len, size, add_col; @@ -3392,7 +3392,7 @@ UINT msi_table_apply_transform( MSIDATABASE *db, IStorage *stg, int err_cond ) UINT ret = ERROR_FUNCTION_FAILED; UINT bytes_per_strref; BOOL property_update = FALSE; - BOOL free_transform_view = FALSE; + MSIVIEW *transform_view = NULL; TRACE("%p %p\n", db, stg ); @@ -3472,11 +3472,19 @@ UINT msi_table_apply_transform( MSIDATABASE *db, IStorage *stg, int err_cond ) if (r == ERROR_SUCCESS) MSI_ViewClose( query ); msiobj_release( &query->hdr ); + if (r != ERROR_BAD_QUERY_SYNTAX && r != ERROR_SUCCESS) + goto end; + + if (TABLE_CreateView(db, L"_TransformView", &transform_view) != ERROR_SUCCESS) + goto end; + if (r == ERROR_BAD_QUERY_SYNTAX) - FIXME( "support adding to _TransformView\n" ); + transform_view->ops->add_ref( transform_view ); + + r = transform_view->ops->add_column( transform_view, L"new", + MSITYPE_TEMPORARY | MSITYPE_NULLABLE | 0x402 /* INT */, FALSE ); if (r != ERROR_SUCCESS) goto end; - free_transform_view = TRUE; } /* @@ -3520,16 +3528,16 @@ end: IEnumSTATSTG_Release( stgenum ); if ( strings ) msi_destroy_stringtable( strings ); - if (ret != ERROR_SUCCESS && free_transform_view) + if (transform_view) { - MSIQUERY *query; - if (MSI_DatabaseOpenViewW( db, L"ALTER TABLE `_TransformView` FREE", - &query ) == ERROR_SUCCESS) - { - if (MSI_ViewExecute( query, NULL ) == ERROR_SUCCESS) - MSI_ViewClose( query ); - msiobj_release( &query->hdr ); - } + struct tagMSITABLE *table = ((MSITABLEVIEW*)transform_view)->table; + + if (ret != ERROR_SUCCESS) + transform_view->ops->release( transform_view ); + + if (!wcscmp(table->colinfo[table->col_count - 1].colname, L"new")) + TABLE_remove_column( transform_view, table->colinfo[table->col_count - 1].number ); + transform_view->ops->delete( transform_view ); } return ret;

1 0

Piotr Caban : msi: Test adding new feature in patch.
by Alexandre Julliard 02 Jul '20

02 Jul '20

Module: wine Branch: master Commit: cc8bc83e9ecd2aba8e322a974af268e715fbd372 URL: https://source.winehq.org/git/wine.git/?a=commit;h=cc8bc83e9ecd2aba8e322a97… Author: Piotr Caban <piotr(a)codeweavers.com> Date: Wed Jul 1 10:43:13 2020 +0200 msi: Test adding new feature in patch. Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> Signed-off-by: Hans Leidekker <hans(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/msi/tests/patch.c | 126 ++++++++++++++++++++++++++++++------------------- 1 file changed, 77 insertions(+), 49 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=cc8bc83e9ecd2aba8e32…

1 0

Henri Verbeet : vkd3d-compiler: Print a slightly more elaborate usage message.
by Alexandre Julliard 02 Jul '20

02 Jul '20

Module: vkd3d Branch: master Commit: e3e76867ca671ffa3bc43b4ed8fb3d9e28faa83f URL: https://source.winehq.org/git/vkd3d.git/?a=commit;h=e3e76867ca671ffa3bc43b4… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Thu Jul 2 18:31:12 2020 +0430 vkd3d-compiler: Print a slightly more elaborate usage message. Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- programs/vkd3d-compiler/main.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/programs/vkd3d-compiler/main.c b/programs/vkd3d-compiler/main.c index 48ca42a..03dc322 100644 --- a/programs/vkd3d-compiler/main.c +++ b/programs/vkd3d-compiler/main.c @@ -98,12 +98,13 @@ compiler_options[] = static void print_usage(const char *program_name) { - unsigned int i; + static const char usage[] = + "[options...] file\n" + "Options:\n" + " -o <file> Write the output to <file>.\n" + " --strip-debug Strip debug information from the output.\n"; - fprintf(stderr, "usage: %s", program_name); - for (i = 0; i < ARRAY_SIZE(compiler_options); ++i) - fprintf(stderr, " [%s]", compiler_options[i].name); - fprintf(stderr, " [-o <out_spirv_filename>] <dxbc_filename>\n"); + fprintf(stderr, "Usage: %s %s", program_name, usage); } struct options

1 0