August 2020 - Wine-commits - list.winehq.org

Zebediah Figura : winegstreamer: Fix a leak in gstdecoder_source_get_media_type().
by Alexandre Julliard 31 Aug '20

31 Aug '20

Module: wine Branch: master Commit: 0c34a2c97a9e21847eb965ef869e345be7503266 URL: https://source.winehq.org/git/wine.git/?a=commit;h=0c34a2c97a9e21847eb965ef… Author: Zebediah Figura <z.figura12(a)gmail.com> Date: Sat Aug 29 12:37:36 2020 -0500 winegstreamer: Fix a leak in gstdecoder_source_get_media_type(). Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/winegstreamer/gstdemux.c | 1 + 1 file changed, 1 insertion(+) diff --git a/dlls/winegstreamer/gstdemux.c b/dlls/winegstreamer/gstdemux.c index e8f65a0e6e..2c9aafd7a6 100644 --- a/dlls/winegstreamer/gstdemux.c +++ b/dlls/winegstreamer/gstdemux.c @@ -1713,6 +1713,7 @@ static HRESULT gstdecoder_source_get_media_type(struct gstdemux_source *pin, gst_caps_unref(caps); return S_OK; } + FreeMediaType(mt); } if (!strcmp(type, "video/x-raw") && index < ARRAY_SIZE(video_formats))

1 0

Zebediah Figura : amstream/tests: Avoid leaking "stream" in test_find_pin().
by Alexandre Julliard 31 Aug '20

31 Aug '20

Module: wine Branch: master Commit: b02de178ebef84ba8686f3e55cc3fd1a1a39f9b8 URL: https://source.winehq.org/git/wine.git/?a=commit;h=b02de178ebef84ba8686f3e5… Author: Zebediah Figura <z.figura12(a)gmail.com> Date: Sat Aug 29 12:37:37 2020 -0500 amstream/tests: Avoid leaking "stream" in test_find_pin(). Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/amstream/tests/amstream.c | 1 + 1 file changed, 1 insertion(+) diff --git a/dlls/amstream/tests/amstream.c b/dlls/amstream/tests/amstream.c index f4c033a180..746a956303 100644 --- a/dlls/amstream/tests/amstream.c +++ b/dlls/amstream/tests/amstream.c @@ -1766,6 +1766,7 @@ static void test_find_pin(void) IPin_Release(pin2); IPin_Release(pin); + IMediaStream_Release(stream); IMediaStreamFilter_Release(filter); ref = IAMMultiMediaStream_Release(mmstream); ok(!ref, "Got outstanding refcount %d.\n", ref);

1 0

Zebediah Figura : amstream/tests: Get rid of test_renderfile().
by Alexandre Julliard 31 Aug '20

31 Aug '20

Module: wine Branch: master Commit: 5f71e720fd7532e72b6e506d5a856d63f51959b7 URL: https://source.winehq.org/git/wine.git/?a=commit;h=5f71e720fd7532e72b6e506d… Author: Zebediah Figura <z.figura12(a)gmail.com> Date: Sat Aug 29 12:37:38 2020 -0500 amstream/tests: Get rid of test_renderfile(). It's not testing anything anymore that's not tested elsewhere. Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/amstream/tests/amstream.c | 122 ----------------------------------------- 1 file changed, 122 deletions(-) diff --git a/dlls/amstream/tests/amstream.c b/dlls/amstream/tests/amstream.c index 746a956303..b9b4092197 100644 --- a/dlls/amstream/tests/amstream.c +++ b/dlls/amstream/tests/amstream.c @@ -102,9 +102,6 @@ static void _expect_ref(IUnknown* obj, ULONG ref, int line) ok_(__FILE__,line)(rc == ref, "expected refcount %d, got %d\n", ref, rc); } -static IDirectDraw7* pdd7; -static IDirectDrawSurface7* pdds7; - static IAMMultiMediaStream *create_ammultimediastream(void) { IAMMultiMediaStream *stream = NULL; @@ -114,50 +111,6 @@ static IAMMultiMediaStream *create_ammultimediastream(void) return stream; } -static int create_directdraw(void) -{ - HRESULT hr; - IDirectDraw* pdd = NULL; - DDSURFACEDESC2 ddsd; - - hr = DirectDrawCreate(NULL, &pdd, NULL); - ok(hr==DD_OK, "DirectDrawCreate returned: %x\n", hr); - if (hr != DD_OK) - goto error; - - hr = IDirectDraw_QueryInterface(pdd, &IID_IDirectDraw7, (LPVOID*)&pdd7); - ok(hr==DD_OK, "QueryInterface returned: %x\n", hr); - if (hr != DD_OK) goto error; - - hr = IDirectDraw7_SetCooperativeLevel(pdd7, GetDesktopWindow(), DDSCL_NORMAL); - ok(hr==DD_OK, "SetCooperativeLevel returned: %x\n", hr); - - ZeroMemory(&ddsd, sizeof(ddsd)); - ddsd.dwSize = sizeof(ddsd); - ddsd.dwFlags = DDSD_CAPS; - ddsd.ddsCaps.dwCaps = DDSCAPS_PRIMARYSURFACE; - hr = IDirectDraw7_CreateSurface(pdd7, &ddsd, &pdds7, NULL); - ok(hr==DD_OK, "CreateSurface returned: %x\n", hr); - - return TRUE; - -error: - if (pdds7) - IDirectDrawSurface7_Release(pdds7); - if (pdd7) - IDirectDraw7_Release(pdd7); - if (pdd) - IDirectDraw_Release(pdd); - - return FALSE; -} - -static void release_directdraw(void) -{ - IDirectDrawSurface7_Release(pdds7); - IDirectDraw7_Release(pdd7); -} - static ULONG get_refcount(void *iface) { IUnknown *unknown = iface; @@ -449,74 +402,6 @@ static void test_mmstream_get_duration(const WCHAR *test_avi_path) ok(!ref, "Got outstanding refcount %d.\n", ref); } -static void test_renderfile(const WCHAR *test_avi_path) -{ - IAMMultiMediaStream *pams; - HRESULT hr; - IMediaStream *pvidstream = NULL; - IDirectDrawMediaStream *pddstream = NULL; - IDirectDrawStreamSample *pddsample = NULL; - IDirectDrawSurface *surface; - RECT rect; - - if (!(pams = create_ammultimediastream())) - return; - if (!create_directdraw()) - { - IAMMultiMediaStream_Release(pams); - return; - } - - hr = IAMMultiMediaStream_Initialize(pams, STREAMTYPE_READ, 0, NULL); - ok(hr==S_OK, "IAMMultiMediaStream_Initialize returned: %x\n", hr); - - hr = IAMMultiMediaStream_AddMediaStream(pams, (IUnknown*)pdd7, &MSPID_PrimaryVideo, 0, NULL); - ok(hr==S_OK, "IAMMultiMediaStream_AddMediaStream returned: %x\n", hr); - - hr = IAMMultiMediaStream_AddMediaStream(pams, NULL, &MSPID_PrimaryAudio, AMMSF_ADDDEFAULTRENDERER, NULL); - ok(hr == S_OK || hr == VFW_E_NO_AUDIO_HARDWARE, "Got hr %#x.\n", hr); - - hr = IAMMultiMediaStream_OpenFile(pams, test_avi_path, 0); - ok(hr==S_OK, "IAMMultiMediaStream_OpenFile returned: %x\n", hr); - - hr = IAMMultiMediaStream_GetMediaStream(pams, &MSPID_PrimaryVideo, &pvidstream); - ok(hr==S_OK, "IAMMultiMediaStream_GetMediaStream returned: %x\n", hr); - if (FAILED(hr)) goto error; - - hr = IMediaStream_QueryInterface(pvidstream, &IID_IDirectDrawMediaStream, (LPVOID*)&pddstream); - ok(hr==S_OK, "IMediaStream_QueryInterface returned: %x\n", hr); - if (FAILED(hr)) goto error; - - hr = IDirectDrawMediaStream_CreateSample(pddstream, NULL, NULL, 0, &pddsample); - ok(hr == S_OK, "IDirectDrawMediaStream_CreateSample returned: %x\n", hr); - - surface = NULL; - hr = IDirectDrawStreamSample_GetSurface(pddsample, &surface, &rect); - ok(hr == S_OK, "got 0x%08x\n", hr); - ok(surface != NULL, "Expected non-NULL surface.\n"); - IDirectDrawSurface_Release(surface); - IDirectDrawStreamSample_Release(pddsample); - - hr = IDirectDrawSurface7_QueryInterface(pdds7, &IID_IDirectDrawSurface, (void**)&surface); - ok(hr == S_OK, "got 0x%08x\n", hr); - - EXPECT_REF(surface, 1); - hr = IDirectDrawMediaStream_CreateSample(pddstream, surface, &rect, 0, &pddsample); - ok(hr == S_OK, "IDirectDrawMediaStream_CreateSample returned: %x\n", hr); - EXPECT_REF(surface, 2); - IDirectDrawStreamSample_Release(pddsample); - IDirectDrawSurface_Release(surface); - -error: - if (pddstream) - IDirectDrawMediaStream_Release(pddstream); - if (pvidstream) - IMediaStream_Release(pvidstream); - - release_directdraw(); - IAMMultiMediaStream_Release(pams); -} - static const GUID test_mspid = {0x88888888}; struct teststream @@ -1405,11 +1290,6 @@ static void test_media_streams(void) if (!(pams = create_ammultimediastream())) return; - if (!create_directdraw()) - { - IAMMultiMediaStream_Release(pams); - return; - } hr = IAMMultiMediaStream_Initialize(pams, STREAMTYPE_READ, 0, NULL); ok(hr == S_OK, "IAMMultiMediaStream_Initialize returned: %x\n", hr); @@ -1604,7 +1484,6 @@ static void test_media_streams(void) if (media_stream_filter) IMediaStreamFilter_Release(media_stream_filter); - release_directdraw(); IAMMultiMediaStream_Release(pams); } @@ -5906,7 +5785,6 @@ START_TEST(amstream) test_openfile(test_avi_path); test_mmstream_get_duration(test_avi_path); - test_renderfile(test_avi_path); unload_resource(test_avi_path);

1 0

Louis Lenders : ntdll: RtlConvertToAutoInheritSecurityObject is NTSTATUS, not BOOL.
by Alexandre Julliard 31 Aug '20

31 Aug '20

Module: wine Branch: master Commit: 518d06404ad70aa9812a77d019a18fe79c16f831 URL: https://source.winehq.org/git/wine.git/?a=commit;h=518d06404ad70aa9812a77d0… Author: Louis Lenders <xerox.xerox2000x(a)gmail.com> Date: Mon Aug 31 08:37:32 2020 +0200 ntdll: RtlConvertToAutoInheritSecurityObject is NTSTATUS, not BOOL. Signed-off-by: Louis Lenders <xerox.xerox2000x(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/ntdll/sec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/ntdll/sec.c b/dlls/ntdll/sec.c index 70828a76c6..c0f962f056 100644 --- a/dlls/ntdll/sec.c +++ b/dlls/ntdll/sec.c @@ -1707,7 +1707,7 @@ NTSTATUS WINAPI RtlQueryInformationAcl( return status; } -BOOL WINAPI RtlConvertToAutoInheritSecurityObject( +NTSTATUS WINAPI RtlConvertToAutoInheritSecurityObject( PSECURITY_DESCRIPTOR pdesc, PSECURITY_DESCRIPTOR cdesc, PSECURITY_DESCRIPTOR* ndesc, @@ -1717,5 +1717,5 @@ BOOL WINAPI RtlConvertToAutoInheritSecurityObject( { FIXME("%p %p %p %p %d %p - stub\n", pdesc, cdesc, ndesc, objtype, isdir, genmap); - return FALSE; + return STATUS_NOT_IMPLEMENTED; }

1 0

Alexandre Julliard : kernel32: Move the initial process breakpoint to LdrInitializeThunk().
by Alexandre Julliard 31 Aug '20

31 Aug '20

Module: wine Branch: master Commit: 2b40969c58a099f958c58909b666915991a42979 URL: https://source.winehq.org/git/wine.git/?a=commit;h=2b40969c58a099f958c58909… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Mon Aug 31 11:30:41 2020 +0200 kernel32: Move the initial process breakpoint to LdrInitializeThunk(). Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/kernel32/process.c | 16 -------------- dlls/ntdll/loader.c | 24 ++++++++++++++++++++ dlls/ntdll/tests/exception.c | 52 ++++++++++++++++++++++++++++++++++++++++---- 3 files changed, 72 insertions(+), 20 deletions(-) diff --git a/dlls/kernel32/process.c b/dlls/kernel32/process.c index bf8f056ada..9d725e1a43 100644 --- a/dlls/kernel32/process.c +++ b/dlls/kernel32/process.c @@ -136,8 +136,6 @@ void CDECL start_process( LPTHREAD_START_ROUTINE entry, PEB *peb ) void CDECL __wine_start_process( LPTHREAD_START_ROUTINE entry, PEB *peb ) #endif { - BOOL being_debugged; - if (!entry) { ERR( "%s doesn't have an entry point, it cannot be executed\n", @@ -148,20 +146,6 @@ void CDECL __wine_start_process( LPTHREAD_START_ROUTINE entry, PEB *peb ) TRACE_(relay)( "\1Starting process %s (entryproc=%p)\n", debugstr_w(peb->ProcessParameters->ImagePathName.Buffer), entry ); - __TRY - { - if (!CheckRemoteDebuggerPresent( GetCurrentProcess(), &being_debugged )) - being_debugged = FALSE; - - SetLastError( 0 ); /* clear error code */ - if (being_debugged) DbgBreakPoint(); - } - __EXCEPT_ALL - { - /* do nothing */ - } - __ENDTRY - __TRY { ExitThread( call_process_entry( peb, entry )); diff --git a/dlls/ntdll/loader.c b/dlls/ntdll/loader.c index 8e76e39fa5..57fc75cef4 100644 --- a/dlls/ntdll/loader.c +++ b/dlls/ntdll/loader.c @@ -3407,6 +3407,29 @@ PIMAGE_NT_HEADERS WINAPI RtlImageNtHeader(HMODULE hModule) return ret; } +/*********************************************************************** + * process_breakpoint + * + * Trigger a debug breakpoint if the process is being debugged. + */ +static void process_breakpoint(void) +{ + DWORD_PTR port = 0; + + NtQueryInformationProcess( GetCurrentProcess(), ProcessDebugPort, &port, sizeof(port), NULL ); + if (!port) return; + + __TRY + { + DbgBreakPoint(); + } + __EXCEPT_ALL + { + /* do nothing */ + } + __ENDTRY +} + /****************************************************************** * LdrInitializeThunk (NTDLL.@) @@ -3494,6 +3517,7 @@ void WINAPI LdrInitializeThunk( CONTEXT *context, ULONG_PTR unknown2, ULONG_PTR if (wm->ldr.TlsIndex != -1) call_tls_callbacks( wm->ldr.DllBase, DLL_PROCESS_ATTACH ); if (wm->ldr.Flags & LDR_WINE_INTERNAL) unix_funcs->init_builtin_dll( wm->ldr.DllBase ); if (wm->ldr.ActivationContext) RtlDeactivateActivationContext( 0, cookie ); + process_breakpoint(); } else { diff --git a/dlls/ntdll/tests/exception.c b/dlls/ntdll/tests/exception.c index ca0dec2a62..a9b32f0586 100644 --- a/dlls/ntdll/tests/exception.c +++ b/dlls/ntdll/tests/exception.c @@ -1049,7 +1049,18 @@ static void test_debugger(void) ok(FALSE, "got way too many exceptions, probably caught in an infinite loop, terminating child\n"); pNtTerminateProcess(pi.hProcess, 1); } - else if (counter >= 2) /* skip startup breakpoint */ + else if (counter < 2) /* startup breakpoint */ + { + /* breakpoint is inside ntdll */ + void *ntdll = GetModuleHandleA( "ntdll.dll" ); + IMAGE_NT_HEADERS *nt = RtlImageNtHeader( ntdll ); + + ok( (char *)ctx.Eip >= (char *)ntdll && + (char *)ctx.Eip < (char *)ntdll + nt->OptionalHeader.SizeOfImage, + "wrong eip %p ntdll %p-%p\n", (void *)ctx.Eip, ntdll, + (char *)ntdll + nt->OptionalHeader.SizeOfImage ); + } + else { if (stage == 1) { @@ -3223,7 +3234,18 @@ static void test_debugger(void) ok(FALSE, "got way too many exceptions, probably caught in an infinite loop, terminating child\n"); pNtTerminateProcess(pi.hProcess, 1); } - else if (counter >= 2) /* skip startup breakpoint */ + else if (counter < 2) /* startup breakpoint */ + { + /* breakpoint is inside ntdll */ + void *ntdll = GetModuleHandleA( "ntdll.dll" ); + IMAGE_NT_HEADERS *nt = RtlImageNtHeader( ntdll ); + + ok( (char *)ctx.Rip >= (char *)ntdll && + (char *)ctx.Rip < (char *)ntdll + nt->OptionalHeader.SizeOfImage, + "wrong rip %p ntdll %p-%p\n", (void *)ctx.Rip, ntdll, + (char *)ntdll + nt->OptionalHeader.SizeOfImage ); + } + else { if (stage == 1) { @@ -4083,7 +4105,18 @@ static void test_debugger(void) ok(FALSE, "got way too many exceptions, probably caught in an infinite loop, terminating child\n"); pNtTerminateProcess(pi.hProcess, 1); } - else if (counter >= 2) /* skip startup breakpoint */ + else if (counter < 2) /* startup breakpoint */ + { + /* breakpoint is inside ntdll */ + void *ntdll = GetModuleHandleA( "ntdll.dll" ); + IMAGE_NT_HEADERS *nt = RtlImageNtHeader( ntdll ); + + ok( (char *)ctx.Pc >= (char *)ntdll && + (char *)ctx.Pc < (char *)ntdll + nt->OptionalHeader.SizeOfImage, + "wrong pc %p ntdll %p-%p\n", (void *)ctx.Pc, ntdll, + (char *)ntdll + nt->OptionalHeader.SizeOfImage ); + } + else { #if 0 /* RtlRaiseException test disabled for now */ if (stage == 1) @@ -5010,7 +5043,18 @@ static void test_debugger(void) ok(FALSE, "got way too many exceptions, probably caught in an infinite loop, terminating child\n"); pNtTerminateProcess(pi.hProcess, 1); } - else if (counter >= 2) /* skip startup breakpoint */ + else if (counter < 2) /* startup breakpoint */ + { + /* breakpoint is inside ntdll */ + void *ntdll = GetModuleHandleA( "ntdll.dll" ); + IMAGE_NT_HEADERS *nt = RtlImageNtHeader( ntdll ); + + ok( (char *)ctx.Pc >= (char *)ntdll && + (char *)ctx.Pc < (char *)ntdll + nt->OptionalHeader.SizeOfImage, + "wrong pc %p ntdll %p-%p\n", (void *)ctx.Pc, ntdll, + (char *)ntdll + nt->OptionalHeader.SizeOfImage ); + } + else { #if 0 /* RtlRaiseException test disabled for now */ if (stage == 1)

1 0

Georg Lehmann : winex11.drv: Use vkGetPhysicalDeviceProperties2KHR to get gpu properties.
by Alexandre Julliard 31 Aug '20

31 Aug '20

Module: wine Branch: master Commit: 586f68f414924b1e41fec10a72b1aacced068885 URL: https://source.winehq.org/git/wine.git/?a=commit;h=586f68f414924b1e41fec10a… Author: Georg Lehmann <dadschoorse(a)gmail.com> Date: Sat Aug 29 23:57:40 2020 +0200 winex11.drv: Use vkGetPhysicalDeviceProperties2KHR to get gpu properties. vkGetPhysicalDeviceProperties2 is a Vulkan 1.1 function but wine uses a 1.0 instance, so use the extension function instead. Signed-off-by: Georg Lehmann <dadschoorse(a)gmail.com> Signed-off-by: Zhiyi Zhang <zzhang(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/winex11.drv/xrandr.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/dlls/winex11.drv/xrandr.c b/dlls/winex11.drv/xrandr.c index faeb4d98d9..6c16fb29ec 100644 --- a/dlls/winex11.drv/xrandr.c +++ b/dlls/winex11.drv/xrandr.c @@ -552,7 +552,7 @@ static BOOL get_gpu_properties_from_vulkan( struct x11drv_gpu *gpu, const XRRPro }; const struct vulkan_funcs *vulkan_funcs = get_vulkan_driver( WINE_VULKAN_DRIVER_VERSION ); VkResult (*pvkGetRandROutputDisplayEXT)( VkPhysicalDevice, Display *, RROutput, VkDisplayKHR * ); - PFN_vkGetPhysicalDeviceProperties2 pvkGetPhysicalDeviceProperties2; + PFN_vkGetPhysicalDeviceProperties2KHR pvkGetPhysicalDeviceProperties2KHR; PFN_vkEnumeratePhysicalDevices pvkEnumeratePhysicalDevices; uint32_t device_count, device_idx, output_idx; VkPhysicalDevice *vk_physical_devices = NULL; @@ -587,7 +587,7 @@ static BOOL get_gpu_properties_from_vulkan( struct x11drv_gpu *gpu, const XRRPro } LOAD_VK_FUNC(vkEnumeratePhysicalDevices) - LOAD_VK_FUNC(vkGetPhysicalDeviceProperties2) + LOAD_VK_FUNC(vkGetPhysicalDeviceProperties2KHR) LOAD_VK_FUNC(vkGetRandROutputDisplayEXT) #undef LOAD_VK_FUNC @@ -624,7 +624,7 @@ static BOOL get_gpu_properties_from_vulkan( struct x11drv_gpu *gpu, const XRRPro properties2.sType = VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_PROPERTIES_2; properties2.pNext = &id; - pvkGetPhysicalDeviceProperties2( vk_physical_devices[device_idx], &properties2 ); + pvkGetPhysicalDeviceProperties2KHR( vk_physical_devices[device_idx], &properties2 ); memcpy( &gpu->vulkan_uuid, id.deviceUUID, sizeof(id.deviceUUID) ); /* Ignore Khronos vendor IDs */ if (properties2.properties.vendorID < 0x10000)

1 0

Paul Gofman : ntdll: Implement RtlGetExtendedContextLength().
by Alexandre Julliard 31 Aug '20

31 Aug '20

Module: wine Branch: master Commit: 2de4f12b33724af2f90607a0626d75e8fbf8e4da URL: https://source.winehq.org/git/wine.git/?a=commit;h=2de4f12b33724af2f90607a0… Author: Paul Gofman <pgofman(a)codeweavers.com> Date: Mon Aug 31 12:31:56 2020 +0300 ntdll: Implement RtlGetExtendedContextLength(). Signed-off-by: Paul Gofman <pgofman(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- .../api-ms-win-core-xstate-l1-1-0.spec | 2 +- dlls/ntdll/exception.c | 71 ++++++++++ dlls/ntdll/ntdll.spec | 2 + dlls/ntdll/tests/exception.c | 147 ++++++++++++++++++++- dlls/ntoskrnl.exe/ntoskrnl.exe.spec | 2 + include/ddk/wdm.h | 7 +- 6 files changed, 227 insertions(+), 4 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=2de4f12b33724af2f906…

1 0

Paul Gofman : kernel32: Implement InitializeContext[2]().
by Alexandre Julliard 31 Aug '20

31 Aug '20

Module: wine Branch: master Commit: 2d544ff8a038ac20c278d0e8f2de4c5478ff6d95 URL: https://source.winehq.org/git/wine.git/?a=commit;h=2d544ff8a038ac20c278d0e8… Author: Paul Gofman <pgofman(a)codeweavers.com> Date: Mon Aug 31 12:31:57 2020 +0300 kernel32: Implement InitializeContext[2](). Signed-off-by: Paul Gofman <pgofman(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- .../api-ms-win-core-xstate-l1-1-0.spec | 2 +- .../api-ms-win-core-xstate-l2-1-0.spec | 2 +- dlls/kernel32/kernel32.spec | 3 +- dlls/kernelbase/kernelbase.spec | 3 +- dlls/kernelbase/memory.c | 49 +++ dlls/ntdll/exception.c | 76 ++++- dlls/ntdll/ntdll.spec | 2 + dlls/ntdll/tests/exception.c | 361 +++++++++++++++++++-- dlls/ntoskrnl.exe/ntoskrnl.exe.spec | 2 + include/ddk/wdm.h | 2 + include/winbase.h | 2 + 11 files changed, 462 insertions(+), 42 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=2d544ff8a038ac20c278…

1 0

Paul Gofman : kernel32: Implement LocateXStateFeature().
by Alexandre Julliard 31 Aug '20

31 Aug '20

Module: wine Branch: master Commit: ff88ed8b0652e8fc202893c65258a012e650ebbe URL: https://source.winehq.org/git/wine.git/?a=commit;h=ff88ed8b0652e8fc202893c6… Author: Paul Gofman <pgofman(a)codeweavers.com> Date: Mon Aug 31 12:31:58 2020 +0300 kernel32: Implement LocateXStateFeature(). Signed-off-by: Paul Gofman <pgofman(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- .../api-ms-win-core-xstate-l1-1-0.spec | 2 +- .../api-ms-win-core-xstate-l2-1-0.spec | 2 +- dlls/kernel32/kernel32.spec | 2 +- dlls/kernelbase/kernelbase.spec | 2 +- dlls/kernelbase/memory.c | 51 +++++++++++ dlls/ntdll/exception.c | 44 +++++++++ dlls/ntdll/ntdll.spec | 2 + dlls/ntdll/tests/exception.c | 102 ++++++++++++++++++++- dlls/ntoskrnl.exe/ntoskrnl.exe.spec | 2 + include/ddk/wdm.h | 2 + include/winbase.h | 1 + 11 files changed, 206 insertions(+), 6 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=ff88ed8b0652e8fc2028…

1 0

Paul Gofman : ntdll: Implement RtlLocateLegacyContext().
by Alexandre Julliard 31 Aug '20

31 Aug '20

Module: wine Branch: master Commit: 3803997349efdd2860263d08bd9d71bc0702cd2c URL: https://source.winehq.org/git/wine.git/?a=commit;h=3803997349efdd2860263d08… Author: Paul Gofman <pgofman(a)codeweavers.com> Date: Mon Aug 31 12:31:59 2020 +0300 ntdll: Implement RtlLocateLegacyContext(). Signed-off-by: Paul Gofman <pgofman(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- .../api-ms-win-core-xstate-l1-1-0.spec | 2 +- dlls/ntdll/exception.c | 11 +++++++++++ dlls/ntdll/ntdll.spec | 1 + dlls/ntdll/tests/exception.c | 14 ++++++++++++++ dlls/ntoskrnl.exe/ntoskrnl.exe.spec | 1 + include/ddk/wdm.h | 1 + 6 files changed, 29 insertions(+), 1 deletion(-) diff --git a/dlls/api-ms-win-core-xstate-l1-1-0/api-ms-win-core-xstate-l1-1-0.spec b/dlls/api-ms-win-core-xstate-l1-1-0/api-ms-win-core-xstate-l1-1-0.spec index 4d8d580387..b933eca226 100644 --- a/dlls/api-ms-win-core-xstate-l1-1-0/api-ms-win-core-xstate-l1-1-0.spec +++ b/dlls/api-ms-win-core-xstate-l1-1-0/api-ms-win-core-xstate-l1-1-0.spec @@ -4,5 +4,5 @@ @ stub RtlGetExtendedFeaturesMask @ stdcall RtlInitializeExtendedContext(ptr long ptr) ntdll.RtlInitializeExtendedContext @ stdcall RtlLocateExtendedFeature(ptr long ptr) ntdll.RtlLocateExtendedFeature -@ stub RtlLocateLegacyContext +@ stdcall RtlLocateLegacyContext(ptr ptr) ntdll.RtlLocateLegacyContext @ stub RtlSetExtendedFeaturesMask diff --git a/dlls/ntdll/exception.c b/dlls/ntdll/exception.c index cb9481322b..0e7e3b959e 100644 --- a/dlls/ntdll/exception.c +++ b/dlls/ntdll/exception.c @@ -850,3 +850,14 @@ void * WINAPI RtlLocateExtendedFeature( CONTEXT_EX *context_ex, ULONG feature_id { return RtlLocateExtendedFeature2( context_ex, feature_id, &user_shared_data->XState, length ); } + +/********************************************************************** + * RtlLocateLegacyContext (NTDLL.@) + */ +void * WINAPI RtlLocateLegacyContext( CONTEXT_EX *context_ex, ULONG *length ) +{ + if (length) + *length = context_ex->Legacy.Length; + + return (BYTE *)context_ex + context_ex->Legacy.Offset; +} diff --git a/dlls/ntdll/ntdll.spec b/dlls/ntdll/ntdll.spec index 0829cc43a9..042ec1f99b 100644 --- a/dlls/ntdll/ntdll.spec +++ b/dlls/ntdll/ntdll.spec @@ -828,6 +828,7 @@ @ stdcall RtlLocaleNameToLcid(wstr ptr long) @ stdcall RtlLocateExtendedFeature(ptr long ptr) @ stdcall RtlLocateExtendedFeature2(ptr long ptr ptr) +@ stdcall RtlLocateLegacyContext(ptr ptr) # @ stub RtlLockBootStatusData @ stdcall RtlLockHeap(long) # @ stub RtlLockMemoryStreamRegion diff --git a/dlls/ntdll/tests/exception.c b/dlls/ntdll/tests/exception.c index 242ca9c61a..a1600a60c8 100644 --- a/dlls/ntdll/tests/exception.c +++ b/dlls/ntdll/tests/exception.c @@ -52,6 +52,7 @@ static NTSTATUS (WINAPI *pRtlInitializeExtendedContext)(void *context, ULONG co static NTSTATUS (WINAPI *pRtlInitializeExtendedContext2)(void *context, ULONG context_flags, CONTEXT_EX **context_ex, ULONG64 compaction_mask); static void * (WINAPI *pRtlLocateExtendedFeature)(CONTEXT_EX *context_ex, ULONG feature_id, ULONG *length); +static void * (WINAPI *pRtlLocateLegacyContext)(CONTEXT_EX *context_ex, ULONG *length); static NTSTATUS (WINAPI *pNtReadVirtualMemory)(HANDLE, const void*, void*, SIZE_T, SIZE_T*); static NTSTATUS (WINAPI *pNtTerminateProcess)(HANDLE handle, LONG exit_code); static NTSTATUS (WINAPI *pNtQueryInformationProcess)(HANDLE, PROCESSINFOCLASS, PVOID, ULONG, PULONG); @@ -6307,6 +6308,18 @@ static void test_extended_context(void) ok(!context_ex->XState.Length, "Got unexpected Length %#x, flags %#x.\n", context_ex->XState.Length, flags); + if (0) + { + /* Crashes on Windows. */ + pRtlLocateLegacyContext(NULL, NULL); + } + p = pRtlLocateLegacyContext(context_ex, NULL); + ok(p == context, "Got unexpected p %p, flags %#x.\n", p, flags); + length2 = 0xdeadbeef; + p = pRtlLocateLegacyContext(context_ex, &length2); + ok(p == context && length2 == context_ex->Legacy.Length, + "Got unexpected p %p, length %#x, flags %#x.\n", p, length2, flags); + length2 = expected_length; for (j = 0; j < context_arch[test].flags_offset; ++j) { @@ -6738,6 +6751,7 @@ START_TEST(exception) X(RtlInitializeExtendedContext); X(RtlInitializeExtendedContext2); X(RtlLocateExtendedFeature); + X(RtlLocateLegacyContext); #undef X #define X(f) p##f = (void*)GetProcAddress(hkernel32, #f) diff --git a/dlls/ntoskrnl.exe/ntoskrnl.exe.spec b/dlls/ntoskrnl.exe/ntoskrnl.exe.spec index 6666031cc6..a900796359 100644 --- a/dlls/ntoskrnl.exe/ntoskrnl.exe.spec +++ b/dlls/ntoskrnl.exe/ntoskrnl.exe.spec @@ -1176,6 +1176,7 @@ @ stdcall RtlLocalTimeToSystemTime(ptr ptr) @ stdcall RtlLocateExtendedFeature(ptr long ptr) @ stdcall RtlLocateExtendedFeature2(ptr long ptr ptr) +@ stdcall RtlLocateLegacyContext(ptr ptr) @ stub RtlLockBootStatusData @ stdcall RtlLookupAtomInAtomTable(ptr wstr ptr) @ stub RtlLookupElementGenericTable diff --git a/include/ddk/wdm.h b/include/ddk/wdm.h index 893db4df20..2115627d3a 100644 --- a/include/ddk/wdm.h +++ b/include/ddk/wdm.h @@ -1842,6 +1842,7 @@ NTSTATUS WINAPI RtlInitializeExtendedContext2(void*,ULONG,CONTEXT_EX**,ULONG64) ULONG64 WINAPI RtlGetEnabledExtendedFeatures(ULONG64); NTSTATUS WINAPI RtlGetExtendedContextLength(ULONG,ULONG*); NTSTATUS WINAPI RtlGetExtendedContextLength2(ULONG,ULONG*,ULONG64); +void * WINAPI RtlLocateLegacyContext(CONTEXT_EX*,ULONG*); void * WINAPI RtlLocateExtendedFeature(CONTEXT_EX*,ULONG,ULONG*); void * WINAPI RtlLocateExtendedFeature2(CONTEXT_EX*,ULONG,XSTATE_CONFIGURATION*,ULONG*); #endif

1 0