November 2021 - Wine-commits

Alexandre Julliard : include: Don't include stdlib.h in wine/port.h.
by Alexandre Julliard 03 Nov '21

03 Nov '21

Module: wine Branch: master Commit: ef9a0f3bc35d24db0d097aba838f6b8fd6e507f1 URL: https://source.winehq.org/git/wine.git/?a=commit;h=ef9a0f3bc35d24db0d097aba… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Wed Nov 3 10:43:13 2021 +0100 include: Don't include stdlib.h in wine/port.h. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/bcrypt/gnutls.c | 1 + dlls/mountmgr.sys/device.c | 1 + dlls/mountmgr.sys/mountmgr.c | 1 + dlls/netapi32/unixlib.c | 1 + dlls/secur32/schannel_gnutls.c | 1 + dlls/winevulkan/make_vulkan | 5 +++-- dlls/winevulkan/vulkan_thunks.c | 3 ++- include/wine/port.h | 1 - 8 files changed, 10 insertions(+), 4 deletions(-) diff --git a/dlls/bcrypt/gnutls.c b/dlls/bcrypt/gnutls.c index a015d85f85d..863b47f50eb 100644 --- a/dlls/bcrypt/gnutls.c +++ b/dlls/bcrypt/gnutls.c @@ -28,6 +28,7 @@ #ifdef HAVE_GNUTLS_CIPHER_INIT #include <stdarg.h> +#include <stdlib.h> #include <assert.h> #include <gnutls/gnutls.h> #include <gnutls/crypto.h> diff --git a/dlls/mountmgr.sys/device.c b/dlls/mountmgr.sys/device.c index aa6db175e69..23134787ba0 100644 --- a/dlls/mountmgr.sys/device.c +++ b/dlls/mountmgr.sys/device.c @@ -25,6 +25,7 @@ #include <errno.h> #include <stdarg.h> #include <stdio.h> +#include <stdlib.h> #include <fcntl.h> #include <unistd.h> #include <sys/time.h> diff --git a/dlls/mountmgr.sys/mountmgr.c b/dlls/mountmgr.sys/mountmgr.c index 27f642df7e8..2dff533f221 100644 --- a/dlls/mountmgr.sys/mountmgr.c +++ b/dlls/mountmgr.sys/mountmgr.c @@ -31,6 +31,7 @@ #endif #include <stdarg.h> +#include <stdlib.h> #include <unistd.h> #ifdef HAVE_SYS_STAT_H #include <sys/stat.h> diff --git a/dlls/netapi32/unixlib.c b/dlls/netapi32/unixlib.c index 565327ba4b1..0c86b619c99 100644 --- a/dlls/netapi32/unixlib.c +++ b/dlls/netapi32/unixlib.c @@ -29,6 +29,7 @@ #ifdef SONAME_LIBNETAPI #include <stdarg.h> +#include <stdlib.h> #include <fcntl.h> #include <errno.h> #ifdef HAVE_SYS_WAIT_H diff --git a/dlls/secur32/schannel_gnutls.c b/dlls/secur32/schannel_gnutls.c index 4d8109721ce..b817a37c4a4 100644 --- a/dlls/secur32/schannel_gnutls.c +++ b/dlls/secur32/schannel_gnutls.c @@ -28,6 +28,7 @@ #include <stdarg.h> #include <stdio.h> +#include <stdlib.h> #include <errno.h> #ifdef SONAME_LIBGNUTLS #include <gnutls/gnutls.h> diff --git a/dlls/winevulkan/make_vulkan b/dlls/winevulkan/make_vulkan index e84442d7a79..f88f15b49dd 100755 --- a/dlls/winevulkan/make_vulkan +++ b/dlls/winevulkan/make_vulkan @@ -2673,8 +2673,9 @@ class VkGenerator(object): f.write("#pragma makedep unix\n") f.write("#endif\n\n") - f.write("#include \"config.h\"\n") - f.write("#include \"wine/port.h\"\n\n") + f.write("#include \"config.h\"\n\n") + + f.write("#include <stdlib.h>\n\n") f.write("#include \"vulkan_private.h\"\n\n") diff --git a/dlls/winevulkan/vulkan_thunks.c b/dlls/winevulkan/vulkan_thunks.c index 97dbc4664ec..eeda463d7a7 100644 --- a/dlls/winevulkan/vulkan_thunks.c +++ b/dlls/winevulkan/vulkan_thunks.c @@ -14,7 +14,8 @@ #endif #include "config.h" -#include "wine/port.h" + +#include <stdlib.h> #include "vulkan_private.h" diff --git a/include/wine/port.h b/include/wine/port.h index 8520fbc05b1..694032a33bc 100644 --- a/include/wine/port.h +++ b/include/wine/port.h @@ -30,7 +30,6 @@ #endif #include <sys/types.h> -#include <stdlib.h> /****************************************************************

1 0

Alexandre Julliard : include: Don't include wine/port.h in Unix libraries.
by Alexandre Julliard 03 Nov '21

03 Nov '21

Module: wine Branch: master Commit: ef6e33f89f94e1fc109bb6c415d7c80f141619d5 URL: https://source.winehq.org/git/wine.git/?a=commit;h=ef6e33f89f94e1fc109bb6c4… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Wed Nov 3 10:43:50 2021 +0100 include: Don't include wine/port.h in Unix libraries. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/bcrypt/gnutls.c | 3 ++- dlls/dwrite/freetype.c | 4 +++- dlls/kerberos/unixlib.c | 5 ++++- dlls/netapi32/unixlib.c | 7 ++----- dlls/odbc32/unixlib.c | 3 ++- dlls/secur32/schannel_gnutls.c | 3 ++- dlls/win32u/dibdrv/opengl.c | 4 +++- dlls/win32u/freetype.c | 7 +++---- dlls/winebus.sys/bus_iohid.c | 2 +- dlls/winebus.sys/bus_sdl.c | 8 ++++---- include/wine/port.h | 4 ++++ 11 files changed, 30 insertions(+), 20 deletions(-) diff --git a/dlls/bcrypt/gnutls.c b/dlls/bcrypt/gnutls.c index 863b47f50eb..d7b4499c692 100644 --- a/dlls/bcrypt/gnutls.c +++ b/dlls/bcrypt/gnutls.c @@ -23,13 +23,14 @@ #endif #include "config.h" -#include "wine/port.h" #ifdef HAVE_GNUTLS_CIPHER_INIT #include <stdarg.h> #include <stdlib.h> #include <assert.h> +#include <sys/types.h> +#include <dlfcn.h> #include <gnutls/gnutls.h> #include <gnutls/crypto.h> #include <gnutls/abstract.h> diff --git a/dlls/dwrite/freetype.c b/dlls/dwrite/freetype.c index ca29b0d97bd..1ece99e08c9 100644 --- a/dlls/dwrite/freetype.c +++ b/dlls/dwrite/freetype.c @@ -23,7 +23,9 @@ #endif #include "config.h" -#include "wine/port.h" + +#include <sys/types.h> +#include <dlfcn.h> #ifdef HAVE_FT2BUILD_H #include <ft2build.h> diff --git a/dlls/kerberos/unixlib.c b/dlls/kerberos/unixlib.c index cceb99b2b36..a735a1c6a47 100644 --- a/dlls/kerberos/unixlib.c +++ b/dlls/kerberos/unixlib.c @@ -26,10 +26,13 @@ #endif #include "config.h" + #if defined(SONAME_LIBKRB5) && defined(SONAME_LIBGSSAPI_KRB5) -#include "wine/port.h" #include <stdarg.h> +#include <sys/types.h> +#include <dlfcn.h> + #ifdef HAVE_KRB5_KRB5_H # include <krb5/krb5.h> #endif diff --git a/dlls/netapi32/unixlib.c b/dlls/netapi32/unixlib.c index 0c86b619c99..4e77808cb86 100644 --- a/dlls/netapi32/unixlib.c +++ b/dlls/netapi32/unixlib.c @@ -24,7 +24,6 @@ #endif #include "config.h" -#include "wine/port.h" #ifdef SONAME_LIBNETAPI @@ -32,12 +31,10 @@ #include <stdlib.h> #include <fcntl.h> #include <errno.h> -#ifdef HAVE_SYS_WAIT_H +#include <sys/types.h> #include <sys/wait.h> -#endif -#ifdef HAVE_UNISTD_H #include <unistd.h> -#endif +#include <dlfcn.h> #include "ntstatus.h" #define WIN32_NO_STATUS diff --git a/dlls/odbc32/unixlib.c b/dlls/odbc32/unixlib.c index 4bc8708f486..8458406d8c0 100644 --- a/dlls/odbc32/unixlib.c +++ b/dlls/odbc32/unixlib.c @@ -29,10 +29,11 @@ #endif #include "config.h" -#include "wine/port.h" #include <stdarg.h> #include <stdlib.h> +#include <sys/types.h> +#include <dlfcn.h> #include "ntstatus.h" #define WIN32_NO_STATUS diff --git a/dlls/secur32/schannel_gnutls.c b/dlls/secur32/schannel_gnutls.c index b817a37c4a4..5f7ea3842a0 100644 --- a/dlls/secur32/schannel_gnutls.c +++ b/dlls/secur32/schannel_gnutls.c @@ -24,12 +24,13 @@ #endif #include "config.h" -#include "wine/port.h" #include <stdarg.h> #include <stdio.h> #include <stdlib.h> #include <errno.h> +#include <sys/types.h> +#include <dlfcn.h> #ifdef SONAME_LIBGNUTLS #include <gnutls/gnutls.h> #include <gnutls/crypto.h> diff --git a/dlls/win32u/dibdrv/opengl.c b/dlls/win32u/dibdrv/opengl.c index 9504e8efd25..5d3ee471497 100644 --- a/dlls/win32u/dibdrv/opengl.c +++ b/dlls/win32u/dibdrv/opengl.c @@ -23,7 +23,9 @@ #endif #include "config.h" -#include "wine/port.h" + +#include <sys/types.h> +#include <dlfcn.h> #include "ntstatus.h" #define WIN32_NO_STATUS diff --git a/dlls/win32u/freetype.c b/dlls/win32u/freetype.c index 70415d8a157..3894478a846 100644 --- a/dlls/win32u/freetype.c +++ b/dlls/win32u/freetype.c @@ -26,14 +26,13 @@ #endif #include "config.h" -#include "wine/port.h" #include <stdarg.h> #include <stdlib.h> +#include <sys/types.h> +#include <sys/stat.h> #include <fcntl.h> -#ifdef HAVE_SYS_STAT_H -# include <sys/stat.h> -#endif +#include <dlfcn.h> #ifdef HAVE_SYS_MMAN_H # include <sys/mman.h> #endif diff --git a/dlls/winebus.sys/bus_iohid.c b/dlls/winebus.sys/bus_iohid.c index 4412a4bf6dd..eef882b52e8 100644 --- a/dlls/winebus.sys/bus_iohid.c +++ b/dlls/winebus.sys/bus_iohid.c @@ -22,9 +22,9 @@ #endif #include "config.h" -#include "wine/port.h" #include <stdarg.h> +#include <sys/types.h> #if defined(HAVE_IOKIT_HID_IOHIDLIB_H) #define DWORD UInt32 diff --git a/dlls/winebus.sys/bus_sdl.c b/dlls/winebus.sys/bus_sdl.c index d172d5382fd..c01648ce67e 100644 --- a/dlls/winebus.sys/bus_sdl.c +++ b/dlls/winebus.sys/bus_sdl.c @@ -23,14 +23,14 @@ #endif #include "config.h" -#include "wine/port.h" + #include <errno.h> #include <fcntl.h> #include <stdarg.h> #include <stdlib.h> -#ifdef HAVE_UNISTD_H -# include <unistd.h> -#endif +#include <unistd.h> +#include <sys/types.h> +#include <dlfcn.h> #ifdef HAVE_SDL_H # include <SDL.h> #endif diff --git a/include/wine/port.h b/include/wine/port.h index 694032a33bc..0405b8d63ad 100644 --- a/include/wine/port.h +++ b/include/wine/port.h @@ -29,6 +29,10 @@ # error You must include port.h before all other headers #endif +#ifdef WINE_UNIX_LIB +# error port.h should not be used in Unix libraries +#endif + #include <sys/types.h>

1 0

Paul Gofman : ntdll: Allocate DDAG node for module.
by Alexandre Julliard 03 Nov '21

03 Nov '21

Module: wine Branch: master Commit: 41c7652bbefd8099a47fdc110d24c6c91861cd93 URL: https://source.winehq.org/git/wine.git/?a=commit;h=41c7652bbefd8099a47fdc11… Author: Paul Gofman <pgofman(a)codeweavers.com> Date: Tue Nov 2 13:26:40 2021 +0300 ntdll: Allocate DDAG node for module. Signed-off-by: Paul Gofman <pgofman(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/kernel32/tests/module.c | 6 +++--- dlls/ntdll/loader.c | 14 ++++++++++++++ 2 files changed, 17 insertions(+), 3 deletions(-) diff --git a/dlls/kernel32/tests/module.c b/dlls/kernel32/tests/module.c index fd369ff33e9..7c4b690fb39 100644 --- a/dlls/kernel32/tests/module.c +++ b/dlls/kernel32/tests/module.c @@ -1358,7 +1358,7 @@ static void test_ddag_node(void) if (!(node = mod->DdagNode)) { - skip( "DdagNode is NULL, skipping tests.\n" ); + win_skip( "DdagNode is NULL, skipping tests.\n" ); return; } @@ -1376,11 +1376,11 @@ static void test_ddag_node(void) ok( !node->IncomingDependencies.Tail, "Expected empty incoming dependencies list.\n" ); /* node->Dependencies.Tail is NULL on Windows 10 1507-1607 32 bit test, maybe due to broken structure layout. */ - ok( !!node->Dependencies.Tail || broken( sizeof(void *) == 4 && !node->Dependencies.Tail), + todo_wine ok( !!node->Dependencies.Tail || broken( sizeof(void *) == 4 && !node->Dependencies.Tail ), "Expected nonempty dependencies list.\n" ); if (!node->Dependencies.Tail) { - win_skip( "Empty dependencies list.\n" ); + skip( "Empty dependencies list.\n" ); return; } ok( node->LoadCount == -1, "Got unexpected LoadCount %d.\n", node->LoadCount ); diff --git a/dlls/ntdll/loader.c b/dlls/ntdll/loader.c index dd41d6b66d2..ebb0f4250f9 100644 --- a/dlls/ntdll/loader.c +++ b/dlls/ntdll/loader.c @@ -1232,6 +1232,16 @@ static WINE_MODREF *alloc_module( HMODULE hModule, const UNICODE_STRING *nt_name RtlFreeHeap( GetProcessHeap(), 0, wm ); return NULL; } + + if (!(wm->ldr.DdagNode = RtlAllocateHeap( GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(*wm->ldr.DdagNode) ))) + { + RtlFreeHeap( GetProcessHeap(), 0, buffer ); + RtlFreeHeap( GetProcessHeap(), 0, wm ); + return NULL; + } + InitializeListHead(&wm->ldr.DdagNode->Modules); + InsertTailList(&wm->ldr.DdagNode->Modules, &wm->ldr.NodeModuleLink); + memcpy( buffer, nt_name->Buffer + 4 /* \??\ prefix */, nt_name->Length - 4 * sizeof(WCHAR) ); buffer[nt_name->Length/sizeof(WCHAR) - 4] = 0; if ((p = wcsrchr( buffer, '\\' ))) p++; @@ -3518,6 +3528,10 @@ static void free_modref( WINE_MODREF *wm ) if (wm->ldr.InInitializationOrderLinks.Flink) RemoveEntryList(&wm->ldr.InInitializationOrderLinks); + RemoveEntryList(&wm->ldr.NodeModuleLink); + if (IsListEmpty(&wm->ldr.DdagNode->Modules)) + RtlFreeHeap( GetProcessHeap(), 0, wm->ldr.DdagNode ); + TRACE(" unloading %s\n", debugstr_w(wm->ldr.FullDllName.Buffer)); if (!TRACE_ON(module)) TRACE_(loaddll)("Unloaded module %s : %s\n",

1 0

Paul Gofman : ntdll: Pass DDAG node to process_attach().
by Alexandre Julliard 03 Nov '21

03 Nov '21

Module: wine Branch: master Commit: 06f925c59942ba5613b0aac15172ea2516aee46b URL: https://source.winehq.org/git/wine.git/?a=commit;h=06f925c59942ba5613b0aac1… Author: Paul Gofman <pgofman(a)codeweavers.com> Date: Tue Nov 2 13:26:41 2021 +0300 ntdll: Pass DDAG node to process_attach(). Signed-off-by: Paul Gofman <pgofman(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/ntdll/loader.c | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/dlls/ntdll/loader.c b/dlls/ntdll/loader.c index ebb0f4250f9..093ec75476d 100644 --- a/dlls/ntdll/loader.c +++ b/dlls/ntdll/loader.c @@ -187,7 +187,7 @@ static WINE_MODREF *last_failed_modref; static NTSTATUS load_dll( const WCHAR *load_path, const WCHAR *libname, const WCHAR *default_ext, DWORD flags, WINE_MODREF** pwm ); -static NTSTATUS process_attach( WINE_MODREF *wm, LPVOID lpReserved ); +static NTSTATUS process_attach( LDR_DDAG_NODE *node, LPVOID lpReserved ); static FARPROC find_ordinal_export( HMODULE module, const IMAGE_EXPORT_DIRECTORY *exports, DWORD exp_size, DWORD ordinal, LPCWSTR load_path ); static FARPROC find_named_export( HMODULE module, const IMAGE_EXPORT_DIRECTORY *exports, @@ -648,7 +648,7 @@ static FARPROC find_forwarded_export( HMODULE module, const char *forward, LPCWS WINE_MODREF **deps = grow_module_deps( current_modref, 1 ); if (deps) deps[current_modref->nDeps++] = wm; } - else if (process_attach( wm, NULL ) != STATUS_SUCCESS) + else if (process_attach( wm->ldr.DdagNode, NULL ) != STATUS_SUCCESS) { LdrUnloadDll( wm->ldr.DllBase ); wm = NULL; @@ -1438,14 +1438,19 @@ static NTSTATUS MODULE_InitDLL( WINE_MODREF *wm, UINT reason, LPVOID lpReserved * * The loader_section must be locked while calling this function. */ -static NTSTATUS process_attach( WINE_MODREF *wm, LPVOID lpReserved ) +static NTSTATUS process_attach( LDR_DDAG_NODE *node, LPVOID lpReserved ) { NTSTATUS status = STATUS_SUCCESS; + LDR_DATA_TABLE_ENTRY *mod; ULONG_PTR cookie; + WINE_MODREF *wm; int i; if (process_detaching) return status; + mod = CONTAINING_RECORD( node->Modules.Flink, LDR_DATA_TABLE_ENTRY, NodeModuleLink ); + wm = CONTAINING_RECORD( mod, WINE_MODREF, ldr ); + /* prevent infinite recursion in case of cyclical dependencies */ if ( ( wm->ldr.Flags & LDR_LOAD_IN_PROGRESS ) || ( wm->ldr.Flags & LDR_PROCESS_ATTACHED ) ) @@ -1462,7 +1467,7 @@ static NTSTATUS process_attach( WINE_MODREF *wm, LPVOID lpReserved ) for ( i = 0; i < wm->nDeps; i++ ) { if (!wm->deps[i]) continue; - if ((status = process_attach( wm->deps[i], lpReserved )) != STATUS_SUCCESS) break; + if ((status = process_attach( wm->deps[i]->ldr.DdagNode, lpReserved )) != STATUS_SUCCESS) break; } if (!wm->ldr.InInitializationOrderLinks.Flink) @@ -2994,7 +2999,7 @@ NTSTATUS WINAPI DECLSPEC_HOTPATCH LdrLoadDll(LPCWSTR path_name, DWORD flags, if (nts == STATUS_SUCCESS && !(wm->ldr.Flags & LDR_DONT_RESOLVE_REFS)) { - nts = process_attach( wm, NULL ); + nts = process_attach( wm->ldr.DdagNode, NULL ); if (nts != STATUS_SUCCESS) { LdrUnloadDll(wm->ldr.DllBase); @@ -3957,7 +3962,7 @@ void WINAPI LdrInitializeThunk( CONTEXT *context, ULONG_PTR unknown2, ULONG_PTR for (i = 0; i < wm->nDeps; i++) { if (!wm->deps[i]) continue; - if ((status = process_attach( wm->deps[i], context )) != STATUS_SUCCESS) + if ((status = process_attach( wm->deps[i]->ldr.DdagNode, context )) != STATUS_SUCCESS) { if (last_failed_modref) ERR( "%s failed to initialize, aborting\n",

1 0

Paul Gofman : ntdll: Store module dependencies in DDAG structure.
by Alexandre Julliard 03 Nov '21

03 Nov '21

Module: wine Branch: master Commit: 0dd37b02f99f5090dd855343fcd8a99496047f3e URL: https://source.winehq.org/git/wine.git/?a=commit;h=0dd37b02f99f5090dd855343… Author: Paul Gofman <pgofman(a)codeweavers.com> Date: Tue Nov 2 13:26:42 2021 +0300 ntdll: Store module dependencies in DDAG structure. Signed-off-by: Paul Gofman <pgofman(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/kernel32/tests/module.c | 12 +-- dlls/ntdll/loader.c | 201 +++++++++++++++++++++++++++++++------------ include/winternl.h | 4 +- 3 files changed, 152 insertions(+), 65 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=0dd37b02f99f5090dd85…

1 0

Paul Gofman : ntdll: Factor out is_import_dll_system() function.
by Alexandre Julliard 03 Nov '21

03 Nov '21

Module: wine Branch: master Commit: 250c113169217933b1fffa8024fa958f71b8aee7 URL: https://source.winehq.org/git/wine.git/?a=commit;h=250c113169217933b1fffa80… Author: Paul Gofman <pgofman(a)codeweavers.com> Date: Tue Nov 2 13:26:43 2021 +0300 ntdll: Factor out is_import_dll_system() function. Signed-off-by: Paul Gofman <pgofman(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/ntdll/loader.c | 21 ++++++++++++--------- 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/dlls/ntdll/loader.c b/dlls/ntdll/loader.c index a016aa86ebf..2b4b428a0fd 100644 --- a/dlls/ntdll/loader.c +++ b/dlls/ntdll/loader.c @@ -585,6 +585,16 @@ static WINE_MODREF *find_fileid_module( const struct file_id *id ) return NULL; } +/*********************************************************************** + * is_import_dll_system + */ +static BOOL is_import_dll_system( LDR_DATA_TABLE_ENTRY *mod, const IMAGE_IMPORT_DESCRIPTOR *import ) +{ + const char *name = get_rva( mod->DllBase, import->Name ); + + return !strcmp( name, "ntdll.dll" ) || !strcmp( name, "kernel32.dll" ); +} + /********************************************************************** * insert_single_list_tail */ @@ -1066,7 +1076,6 @@ static BOOL is_dll_native_subsystem( LDR_DATA_TABLE_ENTRY *mod, const IMAGE_NT_H { const IMAGE_IMPORT_DESCRIPTOR *imports; DWORD i, size; - WCHAR buffer[16]; if (nt->OptionalHeader.Subsystem != IMAGE_SUBSYSTEM_NATIVE) return FALSE; if (nt->OptionalHeader.SectionAlignment < page_size) return TRUE; @@ -1076,17 +1085,11 @@ static BOOL is_dll_native_subsystem( LDR_DATA_TABLE_ENTRY *mod, const IMAGE_NT_H IMAGE_DIRECTORY_ENTRY_IMPORT, &size ))) { for (i = 0; imports[i].Name; i++) - { - const char *name = get_rva( mod->DllBase, imports[i].Name ); - DWORD len = strlen(name); - if (len * sizeof(WCHAR) >= sizeof(buffer)) continue; - ascii_to_unicode( buffer, name, len + 1 ); - if (!wcsicmp( buffer, L"ntdll.dll" ) || !wcsicmp( buffer, L"kernel32.dll" )) + if (is_import_dll_system( mod, &imports[i] )) { - TRACE( "%s imports %s, assuming not native\n", debugstr_w(filename), debugstr_w(buffer) ); + TRACE( "%s imports system dll, assuming not native\n", debugstr_w(filename) ); return FALSE; } - } } return TRUE; }

1 0

Paul Gofman : ntdll: Don't add dependencies for system dlls.
by Alexandre Julliard 03 Nov '21

03 Nov '21

Module: wine Branch: master Commit: aa234f3a58cb9871d058792408b2d3e64f051873 URL: https://source.winehq.org/git/wine.git/?a=commit;h=aa234f3a58cb9871d0587924… Author: Paul Gofman <pgofman(a)codeweavers.com> Date: Tue Nov 2 13:26:44 2021 +0300 ntdll: Don't add dependencies for system dlls. Signed-off-by: Paul Gofman <pgofman(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/kernel32/tests/module.c | 4 ++-- dlls/ntdll/loader.c | 17 ++++++++++++++++- 2 files changed, 18 insertions(+), 3 deletions(-) diff --git a/dlls/kernel32/tests/module.c b/dlls/kernel32/tests/module.c index 466ff3e8d38..2ee23595f55 100644 --- a/dlls/kernel32/tests/module.c +++ b/dlls/kernel32/tests/module.c @@ -1409,7 +1409,7 @@ static void test_ddag_node(void) } mod2 = CONTAINING_RECORD(dep_node->Modules.Flink, LDR_DATA_TABLE_ENTRY, NodeModuleLink); - todo_wine ok( !lstrcmpW( mod2->BaseDllName.Buffer, expected_exe_dependencies[i].dllname ), + ok( !lstrcmpW( mod2->BaseDllName.Buffer, expected_exe_dependencies[i].dllname ), "Got unexpected module %s.\n", debugstr_w(mod2->BaseDllName.Buffer)); se2 = dep_node->IncomingDependencies.Tail; @@ -1428,7 +1428,7 @@ static void test_ddag_node(void) winetest_pop_context(); prev_node = dep_node; } - todo_wine ok( se == node->Dependencies.Tail, "Expected end of the list.\n" ); + ok( se == node->Dependencies.Tail, "Expected end of the list.\n" ); } START_TEST(module) diff --git a/dlls/ntdll/loader.c b/dlls/ntdll/loader.c index 2b4b428a0fd..255d5afef79 100644 --- a/dlls/ntdll/loader.c +++ b/dlls/ntdll/loader.c @@ -182,6 +182,8 @@ static WINE_MODREF *cached_modref; static WINE_MODREF *current_modref; static WINE_MODREF *last_failed_modref; +static LDR_DDAG_NODE *node_ntdll, *node_kernel32; + static NTSTATUS load_dll( const WCHAR *load_path, const WCHAR *libname, const WCHAR *default_ext, DWORD flags, WINE_MODREF** pwm ); static NTSTATUS process_attach( LDR_DDAG_NODE *node, LPVOID lpReserved ); @@ -1280,7 +1282,10 @@ static NTSTATUS fixup_imports( WINE_MODREF *wm, LPCWSTR load_path ) imp = NULL; status = STATUS_DLL_NOT_FOUND; } - else add_module_dependency_after( wm->ldr.DdagNode, imp->ldr.DdagNode, dep_after ); + else if (!is_import_dll_system( &wm->ldr, &imports[i] )) + { + add_module_dependency_after( wm->ldr.DdagNode, imp->ldr.DdagNode, dep_after ); + } } current_modref = prev; if (wm->ldr.ActivationContext) RtlDeactivateActivationContext( 0, cookie ); @@ -2076,6 +2081,7 @@ static void build_ntdll_module(void) wm = alloc_module( meminfo.AllocationBase, &nt_name, TRUE ); assert( wm ); wm->ldr.Flags &= ~LDR_DONT_RESOLVE_REFS; + node_ntdll = wm->ldr.DdagNode; if (TRACE_ON(relay)) RELAY_SetupDLL( meminfo.AllocationBase ); } @@ -4004,6 +4010,7 @@ void WINAPI LdrInitializeThunk( CONTEXT *context, ULONG_PTR unknown2, ULONG_PTR NtTerminateProcess( GetCurrentProcess(), status ); } kernel32_handle = kernel32->ldr.DllBase; + node_kernel32 = kernel32->ldr.DdagNode; RtlInitAnsiString( &func_name, "BaseThreadInitThunk" ); if ((status = LdrGetProcedureAddress( kernel32_handle, &func_name, 0, (void **)&pBaseThreadInitThunk )) != STATUS_SUCCESS) @@ -4053,6 +4060,14 @@ void WINAPI LdrInitializeThunk( CONTEXT *context, ULONG_PTR unknown2, ULONG_PTR if (wm->ldr.ActivationContext) RtlActivateActivationContext( 0, wm->ldr.ActivationContext, &cookie ); + if ((status = process_attach( node_ntdll, context )) + || (status = process_attach( node_kernel32, context ))) + { + ERR( "Initializing system dll for %s failed, status %x\n", + debugstr_w(NtCurrentTeb()->Peb->ProcessParameters->ImagePathName.Buffer), status ); + NtTerminateProcess( GetCurrentProcess(), status ); + } + if ((status = walk_node_dependencies( wm->ldr.DdagNode, context, process_attach ))) { if (last_failed_modref)

1 0

Jactry Zeng : include: Add IMapView interface.
by Alexandre Julliard 03 Nov '21

03 Nov '21

Module: wine Branch: master Commit: b74523bb347b6e9c6362287cc67e0c25c758d971 URL: https://source.winehq.org/git/wine.git/?a=commit;h=b74523bb347b6e9c6362287c… Author: Jactry Zeng <jzeng(a)codeweavers.com> Date: Fri Oct 29 16:52:53 2021 +0800 include: Add IMapView interface. Signed-off-by: Jactry Zeng <jzeng(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- include/windows.foundation.collections.idl | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/include/windows.foundation.collections.idl b/include/windows.foundation.collections.idl index b0b9430048b..876e15336a2 100644 --- a/include/windows.foundation.collections.idl +++ b/include/windows.foundation.collections.idl @@ -74,6 +74,18 @@ cpp_quote("#endif") namespace Collections { + [ + contract(Windows.Foundation.FoundationContract, 1.0), + uuid(e480ce40-a338-4ada-adcf-272272e48cb9) + ] + interface IMapView<K, V> : IInspectable + { + HRESULT Lookup([in] K key, [out] V *value); + [propget] HRESULT Size([out] unsigned int *size); + HRESULT HasKey([in] K key, [out] boolean *found); + HRESULT Split([out] IMapView<K, V> **first, [out] IMapView<K, V> **second); + } + [ contract(Windows.Foundation.FoundationContract, 1.0), uuid(6a79e863-4300-459a-9966-cbb660963ee1)

1 0

Jactry Zeng : include: Add IRandomAccessStreamWithContentType interface.
by Alexandre Julliard 03 Nov '21

03 Nov '21

Module: wine Branch: master Commit: a5eb23bd1779ac36be7c24fe4bafce8deb5e176a URL: https://source.winehq.org/git/wine.git/?a=commit;h=a5eb23bd1779ac36be7c24fe… Author: Jactry Zeng <jzeng(a)codeweavers.com> Date: Fri Oct 29 16:52:54 2021 +0800 include: Add IRandomAccessStreamWithContentType interface. Signed-off-by: Jactry Zeng <jzeng(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- include/Makefile.in | 1 + include/windows.storage.streams.idl | 70 +++++++++++++++++++++++++++++++++++++ 2 files changed, 71 insertions(+) diff --git a/include/Makefile.in b/include/Makefile.in index 71d1b497b6d..ff7aa1b0ff5 100644 --- a/include/Makefile.in +++ b/include/Makefile.in @@ -776,6 +776,7 @@ SOURCES = \ windows.h \ windows.media.devices.idl \ windows.media.speechsynthesis.idl \ + windows.storage.streams.idl \ windows.system.idl \ windows.system.userprofile.idl \ windowscontracts.idl \ diff --git a/include/windows.storage.streams.idl b/include/windows.storage.streams.idl new file mode 100644 index 00000000000..59b15761af0 --- /dev/null +++ b/include/windows.storage.streams.idl @@ -0,0 +1,70 @@ +/* + * Copyright 2021 Jactry Zeng for CodeWeavers + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA + */ + +#ifdef __WIDL__ +#pragma winrt ns_prefix +#endif + +import "inspectable.idl"; +import "eventtoken.idl"; +import "windows.foundation.idl"; + +namespace Windows +{ + namespace Foundation + { + interface IClosable; + } +} + +namespace Windows +{ + namespace Storage + { + namespace Streams + { + interface IContentTypeProvider; + interface IInputStream; + interface IOutputStream; + interface IRandomAccessStream; + interface IRandomAccessStreamWithContentType; + } + } +} + +namespace Windows +{ + namespace Storage + { + namespace Streams + { + [ + uuid(cc254827-4b3d-438f-9232-10c76bc7e038), + ] + interface IRandomAccessStreamWithContentType : IInspectable + requires + Windows.Storage.Streams.IRandomAccessStream, + Windows.Foundation.IClosable, + Windows.Storage.Streams.IInputStream, + Windows.Storage.Streams.IOutputStream, + Windows.Storage.Streams.IContentTypeProvider + { + } + } + } +}

1 0

Jactry Zeng : include: Add IDeviceInformation interface.
by Alexandre Julliard 03 Nov '21

03 Nov '21

Module: wine Branch: master Commit: dc65dfe362e53a9f1f1435e83de89489684ad7e9 URL: https://source.winehq.org/git/wine.git/?a=commit;h=dc65dfe362e53a9f1f1435e8… Author: Jactry Zeng <jzeng(a)codeweavers.com> Date: Fri Oct 29 16:52:55 2021 +0800 include: Add IDeviceInformation interface. Signed-off-by: Jactry Zeng <jzeng(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- include/windows.devices.enumeration.idl | 123 ++++++++++++++++++++++++++++++++ 1 file changed, 123 insertions(+) diff --git a/include/windows.devices.enumeration.idl b/include/windows.devices.enumeration.idl index 9aa2aaba441..20e4df9d33d 100644 --- a/include/windows.devices.enumeration.idl +++ b/include/windows.devices.enumeration.idl @@ -24,13 +24,57 @@ import "inspectable.idl"; import "asyncinfo.idl"; import "eventtoken.idl"; import "windowscontracts.idl"; +import "windows.storage.streams.idl"; import "windows.foundation.idl"; namespace Windows { namespace Devices { namespace Enumeration { + typedef enum Panel Panel; + + interface IDeviceInformation; interface IDeviceInformationStatics; interface IDeviceInformationStatics2; + interface IDeviceInformationUpdate; + interface IEnclosureLocation; + + runtimeclass DeviceInformation; + runtimeclass DeviceInformationUpdate; + runtimeclass DeviceThumbnail; + runtimeclass EnclosureLocation; + } + } +} + +namespace Windows +{ + namespace Devices + { + namespace Enumeration + { + declare + { + interface Windows.Foundation.AsyncOperationCompletedHandler<Windows.Devices.Enumeration.DeviceInformation *>; + interface Windows.Foundation.AsyncOperationCompletedHandler<Windows.Devices.Enumeration.DeviceThumbnail *>; + interface Windows.Foundation.Collections.IMapView<HSTRING, IInspectable *>; + interface Windows.Foundation.IAsyncOperation<Windows.Devices.Enumeration.DeviceInformation *>; + interface Windows.Foundation.IAsyncOperation<Windows.Devices.Enumeration.DeviceThumbnail *>; + } + } + } +} + +namespace Windows +{ + namespace Storage + { + namespace Streams + { + interface IContentTypeProvider; + interface IInputStream; + interface IOutputStream; + interface IRandomAccessStream; + interface IRandomAccessStreamWithContentType; } } } @@ -38,6 +82,55 @@ namespace Windows { namespace Windows { namespace Devices { namespace Enumeration { + enum Panel + { + Unknown = 0, + Front = 1, + Back = 2, + Top = 3, + Bottom = 4, + Left = 5, + Right = 6 + }; + + [ + exclusiveto(Windows.Devices.Enumeration.DeviceInformation), + uuid(aba0fb95-4398-489d-8e44-e6130927011f) + ] + interface IDeviceInformation : IInspectable + { + [propget] HRESULT Id([out, retval] HSTRING *value); + [propget] HRESULT Name([out, retval] HSTRING *value); + [propget] HRESULT IsEnabled([out, retval] boolean *value); + [propget] HRESULT IsDefault([out, retval] boolean *value); + [propget] HRESULT EnclosureLocation([out, retval] Windows.Devices.Enumeration.EnclosureLocation **value); + [propget] HRESULT Properties([out, retval] Windows.Foundation.Collections.IMapView<HSTRING, IInspectable *> **value); + HRESULT Update([in] Windows.Devices.Enumeration.DeviceInformationUpdate *info); + HRESULT GetThumbnailAsync([out, retval] Windows.Foundation.IAsyncOperation<Windows.Devices.Enumeration.DeviceThumbnail *> **operation); + HRESULT GetGlyphThumbnailAsync([out, retval] Windows.Foundation.IAsyncOperation<Windows.Devices.Enumeration.DeviceThumbnail *> **operation); + } + + [ + exclusiveto(Windows.Devices.Enumeration.DeviceInformationUpdate), + uuid(8f315305-d972-44b7-a37e-9e822c78213b) + ] + interface IDeviceInformationUpdate : IInspectable + { + [propget] HRESULT Id([out, retval] HSTRING *value); + [propget] HRESULT Properties([out, retval] Windows.Foundation.Collections.IMapView<HSTRING, IInspectable *> **value); + } + + [ + exclusiveto(Windows.Devices.Enumeration.EnclosureLocation), + uuid(42340a27-5810-459c-aabb-c65e1f813ecf) + ] + interface IEnclosureLocation : IInspectable + { + [propget] HRESULT InDock([out, retval] boolean *value); + [propget] HRESULT InLid([out, retval] boolean *value); + [propget] HRESULT Panel([out, retval] Windows.Devices.Enumeration.Panel *value); + } + [ contract(Windows.Foundation.UniversalApiContract, 1.0), marshaling_behavior(agile), @@ -50,6 +143,36 @@ namespace Windows { [default] interface Windows.Devices.Enumeration.IDeviceInformation; [contract(Windows.Foundation.UniversalApiContract, 1.0)] interface Windows.Devices.Enumeration.IDeviceInformation2; } + + [ + marshaling_behavior(agile), + ] + runtimeclass DeviceInformationUpdate + { + [default] interface Windows.Devices.Enumeration.IDeviceInformationUpdate; + interface Windows.Devices.Enumeration.IDeviceInformationUpdate2; + } + + [ + marshaling_behavior(agile), + ] + runtimeclass DeviceThumbnail + { + [default] interface Windows.Storage.Streams.IRandomAccessStreamWithContentType; + interface Windows.Storage.Streams.IContentTypeProvider; + interface Windows.Storage.Streams.IRandomAccessStream; + interface Windows.Storage.Streams.IOutputStream; + interface Windows.Foundation.IClosable; + interface Windows.Storage.Streams.IInputStream; + } + + [ + marshaling_behavior(agile) + ] + runtimeclass EnclosureLocation + { + [default] interface Windows.Devices.Enumeration.IEnclosureLocation; + } } } }

1 0