February 2021 - Wine-commits

Jacek Caban : winebuild: Remove no longer needed stack alignment in x86_64 syscall dispatcher.
by Alexandre Julliard 17 Feb '21

17 Feb '21

Module: wine Branch: master Commit: 877f06d123354827640109dd25185eb8d3f608be URL: https://source.winehq.org/git/wine.git/?a=commit;h=877f06d123354827640109dd… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Mon Feb 15 21:57:48 2021 +0100 winebuild: Remove no longer needed stack alignment in x86_64 syscall dispatcher. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- tools/winebuild/import.c | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/tools/winebuild/import.c b/tools/winebuild/import.c index fda1fe90541..cddc5a2251f 100644 --- a/tools/winebuild/import.c +++ b/tools/winebuild/import.c @@ -1528,25 +1528,23 @@ void output_syscalls( DLLSPEC *spec ) output( "\tleaq -0x38(%%rbp),%%rbx\n" ); output( "\tmovq %%rbx,0x328(%%rcx)\n" ); /* amd64_thread_data()->syscall_frame */ output( "\tcmpq $%u,%%rax\n", count ); - output( "\tjae 4f\n" ); + output( "\tjae 3f\n" ); output( "\tleaq .Lsyscall_args(%%rip),%%rcx\n" ); output( "\tmovzbl (%%rcx,%%rax),%%ecx\n" ); output( "\tsubq $0x20,%%rcx\n" ); - output( "\tja 1f\n" ); - output( "\tandq $~15,%%rsp\n\t" ); - output( "\tjmp 2f\n" ); - output( "1:\tsubq %%rcx,%%rsp\n" ); + output( "\tjbe 1f\n" ); + output( "\tsubq %%rcx,%%rsp\n" ); output( "\tshrq $3,%%rcx\n" ); output( "\tleaq 0x38(%%rbp),%%rsi\n" ); output( "\tandq $~15,%%rsp\n\t" ); output( "\tmovq %%rsp,%%rdi\n" ); output( "\tcld\n" ); output( "\trep; movsq\n" ); - output( "2:\tmovq %%r10,%%rcx\n" ); + output( "1:\tmovq %%r10,%%rcx\n" ); output( "\tsubq $0x20,%%rsp\n" ); output( "\tleaq .Lsyscall_table(%%rip),%%r10\n" ); output( "\tcallq *(%%r10,%%rax,8)\n" ); - output( "3:\tmovq %%gs:0x30,%%rcx\n" ); + output( "2:\tmovq %%gs:0x30,%%rcx\n" ); output( "\tmovq $0,0x328(%%rcx)\n" ); output( "\tmovq -0x18(%%rbp),%%rdi\n" ); output_cfi( ".cfi_same_value %%rdi" ); @@ -1559,8 +1557,8 @@ void output_syscalls( DLLSPEC *spec ) output_cfi( ".cfi_adjust_cfa_offset -8" ); output_cfi( ".cfi_same_value %%rbp" ); output( "\tret\n" ); - output( "4:\tmovl $0x%x,%%eax\n", invalid_param ); - output( "\tjmp 3b\n" ); + output( "3:\tmovl $0x%x,%%eax\n", invalid_param ); + output( "\tjmp 2b\n" ); break; case CPU_ARM: output( "\tpush {r5-r11,lr}\n" );

1 0

Jacek Caban : ntdll: Reserve space for all registers in x86_64 syscall frame.
by Alexandre Julliard 17 Feb '21

17 Feb '21

Module: wine Branch: master Commit: 6d2f08cfcbef38750403e1ea7075d99ad1a5a3ca URL: https://source.winehq.org/git/wine.git/?a=commit;h=6d2f08cfcbef38750403e1ea… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Mon Feb 15 21:57:55 2021 +0100 ntdll: Reserve space for all registers in x86_64 syscall frame. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/ntdll/unix/signal_x86_64.c | 47 ++++++++++++++++++++++++++++------------- tools/winebuild/import.c | 32 ++++++++++++++-------------- 2 files changed, 48 insertions(+), 31 deletions(-) diff --git a/dlls/ntdll/unix/signal_x86_64.c b/dlls/ntdll/unix/signal_x86_64.c index 5da1a467b71..824cfb4febe 100644 --- a/dlls/ntdll/unix/signal_x86_64.c +++ b/dlls/ntdll/unix/signal_x86_64.c @@ -275,20 +275,37 @@ C_ASSERT( sizeof(struct syscall_xsave) == 0x200 ); struct syscall_frame { - ULONG64 r12; - ULONG64 r13; - ULONG64 r14; - ULONG64 r15; - ULONG64 rdi; - ULONG64 rsi; - ULONG64 rbx; - ULONG64 rbp; + ULONG64 rax; /* 0000 */ + ULONG64 rbx; /* 0008 */ + ULONG64 rcx; /* 0010 */ + ULONG64 rdx; /* 0018 */ + ULONG64 rsi; /* 0020 */ + ULONG64 rdi; /* 0028 */ + ULONG64 r8; /* 0030 */ + ULONG64 r9; /* 0038 */ + ULONG64 r10; /* 0040 */ + ULONG64 r11; /* 0048 */ + ULONG64 r12; /* 0050 */ + ULONG64 r13; /* 0058 */ + ULONG64 r14; /* 0060 */ + ULONG64 r15; /* 0068 */ + ULONG64 rip; /* 0070 */ + WORD cs; /* 0078 */ + WORD ds; /* 007a */ + WORD es; /* 007c */ + WORD fs; /* 007e */ + ULONG64 eflags; /* 0080 */ + ULONG64 rsp; /* 0088 */ + WORD ss; /* 0090 */ + WORD gs; /* 0092 */ + WORD pad[2]; /* 0094 */ + ULONG64 rbp; /* 0098 */ ULONG64 thunk_addr; ULONG64 ret_addr; }; /* Should match the offset in call_user_apc_dispatcher(). */ -C_ASSERT( offsetof( struct syscall_frame, ret_addr ) == 0x48); +C_ASSERT( offsetof( struct syscall_frame, ret_addr ) == 0xa8); struct amd64_thread_data { @@ -2087,7 +2104,7 @@ __ASM_GLOBAL_FUNC( call_user_apc_dispatcher, "movq 0x98(%rcx),%rdx\n\t" /* context->Rsp */ "jmp 2f\n\t" "1:\tmovq 0x328(%rbx),%rax\n\t" /* amd64_thread_data()->syscall_frame */ - "leaq 0x48(%rax),%rdx\n\t" /* &amd64_thread_data()->syscall_frame->ret_addr */ + "leaq 0xa8(%rax),%rdx\n\t" /* &amd64_thread_data()->syscall_frame->ret_addr */ "2:\tsubq $0x510,%rdx\n\t" /* sizeof(struct apc_stack_layout) */ "andq $~0xf,%rdx\n\t" "addq $8,%rsp\n\t" /* pop return address */ @@ -2135,12 +2152,12 @@ __ASM_GLOBAL_FUNC( call_raise_user_exception_dispatcher, "leaq -0x200(%rax),%r8\n\t" "andq $~63,%r8\n\t" "fxrstor64 (%r8)\n\t" - "movq 0x20(%rax),%rdi\n\t" /* frame->rdi */ - "movq 0x28(%rax),%rsi\n\t" /* frame->rsi */ - "movq 0x30(%rax),%rbx\n\t" /* frame->rbx */ - "movq 0x38(%rax),%rbp\n\t" /* frame->rbp */ + "movq 0x8(%rax),%rbx\n\t" /* frame->rbx */ + "movq 0x20(%rax),%rsi\n\t" /* frame->rsi */ + "movq 0x28(%rax),%rdi\n\t" /* frame->rdi */ + "movq 0x98(%rax),%rbp\n\t" /* frame->rbp */ "movq $0,0x328(%rdx)\n\t" - "leaq 0x48(%rax),%rsp\n\t" + "leaq 0xa8(%rax),%rsp\n\t" "jmpq *%rcx" ) diff --git a/tools/winebuild/import.c b/tools/winebuild/import.c index cddc5a2251f..c70470251a4 100644 --- a/tools/winebuild/import.c +++ b/tools/winebuild/import.c @@ -1508,24 +1508,24 @@ void output_syscalls( DLLSPEC *spec ) output_cfi( ".cfi_rel_offset %%rbp,0" ); output( "\tmovq %%rsp,%%rbp\n" ); output_cfi( ".cfi_def_cfa_register %%rbp" ); - output( "\tleaq -0x238(%%rbp),%%rsp\n" ); + output( "\tleaq -0x2a8(%%rbp),%%rsp\n" ); output( "\tandq $~63,%%rsp\n" ); - output( "\tmovq %%gs:0x30,%%rcx\n" ); - output( "\tmovq %%r12,-0x38(%%rbp)\n" ); - output( "\tmovq %%r13,-0x30(%%rbp)\n" ); - output( "\tmovq %%r14,-0x28(%%rbp)\n" ); - output( "\tmovq %%r15,-0x20(%%rbp)\n" ); - output( "\tmovq %%rdi,-0x18(%%rbp)\n" ); - output_cfi( ".cfi_rel_offset %%rdi,-24" ); - output( "\tmovq %%rsi,-0x10(%%rbp)\n" ); - output_cfi( ".cfi_rel_offset %%rsi,-16" ); - output( "\tmovq %%rbx,-0x08(%%rbp)\n" ); - output_cfi( ".cfi_rel_offset %%rbx,-8" ); + output( "\tmovq %%rbx,-0x90(%%rbp)\n" ); + output_cfi( ".cfi_rel_offset %%rbx,-144" ); + output( "\tmovq %%rsi,-0x78(%%rbp)\n" ); + output_cfi( ".cfi_rel_offset %%rsi,-120" ); + output( "\tmovq %%rdi,-0x70(%%rbp)\n" ); + output_cfi( ".cfi_rel_offset %%rdi,-112" ); + output( "\tmovq %%r12,-0x48(%%rbp)\n" ); + output( "\tmovq %%r13,-0x40(%%rbp)\n" ); + output( "\tmovq %%r14,-0x38(%%rbp)\n" ); + output( "\tmovq %%r15,-0x30(%%rbp)\n" ); output( "\tfxsave64 (%%rsp)\n" ); /* Legends of Runeterra hooks the first system call return instruction, and * depends on us returning to it. Adjust the return address accordingly. */ output( "\tsubq $0xb,0x8(%%rbp)\n" ); - output( "\tleaq -0x38(%%rbp),%%rbx\n" ); + output( "\tmovq %%gs:0x30,%%rcx\n" ); + output( "\tleaq -0x98(%%rbp),%%rbx\n" ); output( "\tmovq %%rbx,0x328(%%rcx)\n" ); /* amd64_thread_data()->syscall_frame */ output( "\tcmpq $%u,%%rax\n", count ); output( "\tjae 3f\n" ); @@ -1546,11 +1546,11 @@ void output_syscalls( DLLSPEC *spec ) output( "\tcallq *(%%r10,%%rax,8)\n" ); output( "2:\tmovq %%gs:0x30,%%rcx\n" ); output( "\tmovq $0,0x328(%%rcx)\n" ); - output( "\tmovq -0x18(%%rbp),%%rdi\n" ); + output( "\tmovq -0x70(%%rbp),%%rdi\n" ); output_cfi( ".cfi_same_value %%rdi" ); - output( "\tmovq -0x10(%%rbp),%%rsi\n" ); + output( "\tmovq -0x78(%%rbp),%%rsi\n" ); output_cfi( ".cfi_same_value %%rsi" ); - output( "\tmovq -0x8(%%rbp),%%rbx\n" ); + output( "\tmovq -0x90(%%rbp),%%rbx\n" ); output_cfi( ".cfi_same_value %%rbx" ); output_cfi( ".cfi_def_cfa_register %%rsp" ); output( "\tleave\n" );

1 0

Henri Verbeet : vkd3d-shader: Introduce a helper to print d3d-asm unsigned integer literals.
by Alexandre Julliard 17 Feb '21

17 Feb '21

Module: vkd3d Branch: master Commit: 66694cd38570c598058106feb0b172ebf110ead4 URL: https://source.winehq.org/git/vkd3d.git/?a=commit;h=66694cd38570c598058106f… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Wed Feb 17 12:21:11 2021 +0100 vkd3d-shader: Introduce a helper to print d3d-asm unsigned integer literals. Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- libs/vkd3d-shader/trace.c | 42 ++++++++++++++++++++++++------------------ 1 file changed, 24 insertions(+), 18 deletions(-) diff --git a/libs/vkd3d-shader/trace.c b/libs/vkd3d-shader/trace.c index 35e684b..8194363 100644 --- a/libs/vkd3d-shader/trace.c +++ b/libs/vkd3d-shader/trace.c @@ -714,6 +714,12 @@ static void shader_print_int_literal(struct vkd3d_d3d_asm_compiler *compiler, vkd3d_string_buffer_printf(&compiler->buffer, "%s%d%s", prefix, i, suffix); } +static void shader_print_uint_literal(struct vkd3d_d3d_asm_compiler *compiler, + const char *prefix, unsigned int i, const char *suffix) +{ + vkd3d_string_buffer_printf(&compiler->buffer, "%s%u%s", prefix, i, suffix); +} + static void shader_print_subscript(struct vkd3d_d3d_asm_compiler *compiler, unsigned int offset, const struct vkd3d_shader_src_param *rel_addr) { @@ -723,7 +729,7 @@ static void shader_print_subscript(struct vkd3d_d3d_asm_compiler *compiler, shader_dump_src_param(compiler, rel_addr); vkd3d_string_buffer_printf(&compiler->buffer, " + "); } - vkd3d_string_buffer_printf(&compiler->buffer, "%u]", offset); + shader_print_uint_literal(compiler, "", offset, "]"); } static void shader_dump_register(struct vkd3d_d3d_asm_compiler *compiler, const struct vkd3d_shader_register *reg) @@ -959,7 +965,7 @@ static void shader_dump_register(struct vkd3d_d3d_asm_compiler *compiler, const case VKD3D_DATA_RESOURCE: case VKD3D_DATA_SAMPLER: case VKD3D_DATA_UINT: - shader_addline(buffer, "%u", reg->u.immconst_uint[0]); + shader_print_uint_literal(compiler, "", reg->u.immconst_uint[0], ""); break; default: shader_addline(buffer, "<unhandled data type %#x>", reg->data_type); @@ -985,9 +991,10 @@ static void shader_dump_register(struct vkd3d_d3d_asm_compiler *compiler, const case VKD3D_DATA_RESOURCE: case VKD3D_DATA_SAMPLER: case VKD3D_DATA_UINT: - shader_addline(buffer, "%u, %u, %u, %u", - reg->u.immconst_uint[0], reg->u.immconst_uint[1], - reg->u.immconst_uint[2], reg->u.immconst_uint[3]); + shader_print_uint_literal(compiler, "", reg->u.immconst_uint[0], ""); + shader_print_uint_literal(compiler, ", ", reg->u.immconst_uint[1], ""); + shader_print_uint_literal(compiler, ", ", reg->u.immconst_uint[2], ""); + shader_print_uint_literal(compiler, ", ", reg->u.immconst_uint[3], ""); break; default: shader_addline(buffer, "<unhandled data type %#x>", reg->data_type); @@ -1351,7 +1358,7 @@ static void shader_dump_instruction_flags(struct vkd3d_d3d_asm_compiler *compile static void shader_dump_register_space(struct vkd3d_d3d_asm_compiler *compiler, unsigned int register_space) { if (shader_ver_ge(&compiler->shader_version, 5, 1)) - vkd3d_string_buffer_printf(&compiler->buffer, ", space=%u", register_space); + shader_print_uint_literal(compiler, ", space=", register_space, ""); } static void shader_print_opcode(struct vkd3d_d3d_asm_compiler *compiler, enum vkd3d_shader_opcode opcode) @@ -1434,14 +1441,14 @@ static void shader_dump_instruction(struct vkd3d_d3d_asm_compiler *compiler, case VKD3DSIH_DCL_INDEX_RANGE: vkd3d_string_buffer_printf(buffer, " "); shader_dump_dst_param(compiler, &ins->declaration.index_range.dst); - shader_addline(buffer, " %u", ins->declaration.index_range.register_count); + shader_print_uint_literal(compiler, " ", ins->declaration.index_range.register_count, ""); break; case VKD3DSIH_DCL_INDEXABLE_TEMP: vkd3d_string_buffer_printf(buffer, " %sx%u%s", compiler->colours.reg, ins->declaration.indexable_temp.register_idx, compiler->colours.reset); shader_print_subscript(compiler, ins->declaration.indexable_temp.register_size, NULL); - vkd3d_string_buffer_printf(buffer, ", %u", ins->declaration.indexable_temp.component_count); + shader_print_uint_literal(compiler, ", ", ins->declaration.indexable_temp.component_count, ""); break; case VKD3DSIH_DCL_INPUT_PS: @@ -1498,7 +1505,7 @@ static void shader_dump_instruction(struct vkd3d_d3d_asm_compiler *compiler, case VKD3DSIH_DCL_RESOURCE_STRUCTURED: vkd3d_string_buffer_printf(buffer, " "); shader_dump_dst_param(compiler, &ins->declaration.structured_resource.resource.reg); - shader_addline(buffer, ", %u", ins->declaration.structured_resource.byte_stride); + shader_print_uint_literal(compiler, ", ", ins->declaration.structured_resource.byte_stride, ""); shader_dump_register_space(compiler, ins->declaration.structured_resource.resource.register_space); break; @@ -1517,7 +1524,7 @@ static void shader_dump_instruction(struct vkd3d_d3d_asm_compiler *compiler, case VKD3DSIH_DCL_INPUT_CONTROL_POINT_COUNT: case VKD3DSIH_DCL_OUTPUT_CONTROL_POINT_COUNT: case VKD3DSIH_DCL_VERTICES_OUT: - vkd3d_string_buffer_printf(buffer, " %u", ins->declaration.count); + shader_print_uint_literal(compiler, " ", ins->declaration.count, ""); break; case VKD3DSIH_DCL_TESSELLATOR_DOMAIN: @@ -1538,21 +1545,20 @@ static void shader_dump_instruction(struct vkd3d_d3d_asm_compiler *compiler, case VKD3DSIH_DCL_TGSM_RAW: vkd3d_string_buffer_printf(buffer, " "); shader_dump_dst_param(compiler, &ins->declaration.tgsm_raw.reg); - shader_addline(buffer, ", %u", ins->declaration.tgsm_raw.byte_count); + shader_print_uint_literal(compiler, ", ", ins->declaration.tgsm_raw.byte_count, ""); break; case VKD3DSIH_DCL_TGSM_STRUCTURED: vkd3d_string_buffer_printf(buffer, " "); shader_dump_dst_param(compiler, &ins->declaration.tgsm_structured.reg); - shader_addline(buffer, ", %u, %u", ins->declaration.tgsm_structured.byte_stride, - ins->declaration.tgsm_structured.structure_count); + shader_print_uint_literal(compiler, ", ", ins->declaration.tgsm_structured.byte_stride, ""); + shader_print_uint_literal(compiler, ", ", ins->declaration.tgsm_structured.structure_count, ""); break; case VKD3DSIH_DCL_THREAD_GROUP: - vkd3d_string_buffer_printf(buffer, " %u, %u, %u", - ins->declaration.thread_group_size.x, - ins->declaration.thread_group_size.y, - ins->declaration.thread_group_size.z); + shader_print_uint_literal(compiler, " ", ins->declaration.thread_group_size.x, ""); + shader_print_uint_literal(compiler, ", ", ins->declaration.thread_group_size.y, ""); + shader_print_uint_literal(compiler, ", ", ins->declaration.thread_group_size.z, ""); break; case VKD3DSIH_DCL_UAV_RAW: @@ -1566,7 +1572,7 @@ static void shader_dump_instruction(struct vkd3d_d3d_asm_compiler *compiler, shader_dump_uav_flags(compiler, ins->flags); shader_addline(buffer, " "); shader_dump_dst_param(compiler, &ins->declaration.structured_resource.resource.reg); - shader_addline(buffer, ", %u", ins->declaration.structured_resource.byte_stride); + shader_print_uint_literal(compiler, ", ", ins->declaration.structured_resource.byte_stride, ""); shader_dump_register_space(compiler, ins->declaration.structured_resource.resource.register_space); break;

1 0

Henri Verbeet : vkd3d-shader: Add some colour to d3d-asm register names.
by Alexandre Julliard 17 Feb '21

17 Feb '21

Module: vkd3d Branch: master Commit: be024a7e1720bb721f624df5aac4cc4e1bec1327 URL: https://source.winehq.org/git/vkd3d.git/?a=commit;h=be024a7e1720bb721f624df… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Wed Feb 17 12:21:07 2021 +0100 vkd3d-shader: Add some colour to d3d-asm register names. Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- libs/vkd3d-shader/trace.c | 33 +++++++++++++++++++++++++-------- 1 file changed, 25 insertions(+), 8 deletions(-) diff --git a/libs/vkd3d-shader/trace.c b/libs/vkd3d-shader/trace.c index fb5370a..f8b7923 100644 --- a/libs/vkd3d-shader/trace.c +++ b/libs/vkd3d-shader/trace.c @@ -304,6 +304,7 @@ struct vkd3d_d3d_asm_colours { const char *reset; const char *opcode; + const char *reg; }; struct vkd3d_d3d_asm_compiler @@ -709,6 +710,7 @@ static void shader_dump_register(struct vkd3d_d3d_asm_compiler *compiler, const static const char * const rastout_reg_names[] = {"oPos", "oFog", "oPts"}; static const char * const misctype_reg_names[] = {"vPos", "vFace"}; + shader_addline(buffer, "%s", compiler->colours.reg); switch (reg->type) { case VKD3DSPR_TEMP: @@ -918,7 +920,7 @@ static void shader_dump_register(struct vkd3d_d3d_asm_compiler *compiler, const if (reg->type == VKD3DSPR_IMMCONST) { - shader_addline(buffer, "("); + shader_addline(buffer, "%s(", compiler->colours.reset); switch (reg->immconst_type) { case VKD3D_IMMCONST_SCALAR: @@ -987,7 +989,7 @@ static void shader_dump_register(struct vkd3d_d3d_asm_compiler *compiler, const && reg->type == VKD3DSPR_INPUT); if (printbrackets) - shader_addline(buffer, "["); + shader_addline(buffer, "%s[", compiler->colours.reset); if (reg->idx[0].rel_addr) { shader_dump_src_param(compiler, reg->idx[0].rel_addr); @@ -996,6 +998,8 @@ static void shader_dump_register(struct vkd3d_d3d_asm_compiler *compiler, const shader_addline(buffer, "%u", offset); if (printbrackets) shader_addline(buffer, "]"); + else + shader_addline(buffer, "%s", compiler->colours.reset); /* For CBs in sm < 5.1 we move the buffer offset from idx[1] to idx[2] * to normalise it with 5.1. @@ -1023,10 +1027,18 @@ static void shader_dump_register(struct vkd3d_d3d_asm_compiler *compiler, const shader_addline(buffer, "%u]", reg->idx[2].offset); } } + else + { + shader_addline(buffer, "%s", compiler->colours.reset); + } if (reg->type == VKD3DSPR_FUNCTIONPOINTER) shader_addline(buffer, "[%u]", reg->u.fp_body_idx); } + else + { + shader_addline(buffer, "%s", compiler->colours.reset); + } } static void shader_dump_dst_param(struct vkd3d_d3d_asm_compiler *compiler, @@ -1423,8 +1435,8 @@ static void shader_dump_instruction(struct vkd3d_d3d_asm_compiler *compiler, break; case VKD3DSIH_DCL_INDEXABLE_TEMP: - vkd3d_string_buffer_printf(buffer, " x%u[%u], %u", - ins->declaration.indexable_temp.register_idx, + vkd3d_string_buffer_printf(buffer, " %sx%u%s[%u], %u", compiler->colours.reg, + ins->declaration.indexable_temp.register_idx, compiler->colours.reset, ins->declaration.indexable_temp.register_size, ins->declaration.indexable_temp.component_count); break; @@ -1554,20 +1566,23 @@ static void shader_dump_instruction(struct vkd3d_d3d_asm_compiler *compiler, break; case VKD3DSIH_DEF: - vkd3d_string_buffer_printf(buffer, " c%u = %.8e, %.8e, %.8e, %.8e", - shader_get_float_offset(ins->dst[0].reg.type, ins->dst[0].reg.idx[0].offset), + vkd3d_string_buffer_printf(buffer, " %sc%u%s = %.8e, %.8e, %.8e, %.8e", + compiler->colours.reg, shader_get_float_offset(ins->dst[0].reg.type, + ins->dst[0].reg.idx[0].offset), compiler->colours.reset, ins->src[0].reg.u.immconst_float[0], ins->src[0].reg.u.immconst_float[1], ins->src[0].reg.u.immconst_float[2], ins->src[0].reg.u.immconst_float[3]); break; case VKD3DSIH_DEFI: - vkd3d_string_buffer_printf(buffer, " i%u = %d, %d, %d, %d", ins->dst[0].reg.idx[0].offset, + vkd3d_string_buffer_printf(buffer, " %si%u%s = %d, %d, %d, %d", + compiler->colours.reg, ins->dst[0].reg.idx[0].offset, compiler->colours.reset, ins->src[0].reg.u.immconst_uint[0], ins->src[0].reg.u.immconst_uint[1], ins->src[0].reg.u.immconst_uint[2], ins->src[0].reg.u.immconst_uint[3]); break; case VKD3DSIH_DEFB: - vkd3d_string_buffer_printf(buffer, " b%u = %s", ins->dst[0].reg.idx[0].offset, + vkd3d_string_buffer_printf(buffer, " %sb%u%s = %s", compiler->colours.reg, + ins->dst[0].reg.idx[0].offset, compiler->colours.reset, ins->src[0].reg.u.immconst_uint[0] ? "true" : "false"); break; @@ -1627,11 +1642,13 @@ enum vkd3d_result vkd3d_dxbc_binary_to_text(void *data, { .reset = "", .opcode = "", + .reg = "", }; static const struct vkd3d_d3d_asm_colours colours = { .reset = "\x1b[m", .opcode = "\x1b[96;1m", + .reg = "\x1b[96m", }; formatting = VKD3D_SHADER_COMPILE_OPTION_FORMATTING_INDENT

1 0

Henri Verbeet : vkd3d-shader: Introduce a helper to print d3d-asm subscripts.
by Alexandre Julliard 17 Feb '21

17 Feb '21

Module: vkd3d Branch: master Commit: 401b51f88800f973f12ab735cb8f8df82bc3d4f5 URL: https://source.winehq.org/git/vkd3d.git/?a=commit;h=401b51f88800f973f12ab73… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Wed Feb 17 12:21:08 2021 +0100 vkd3d-shader: Introduce a helper to print d3d-asm subscripts. Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- libs/vkd3d-shader/trace.c | 75 +++++++++++++++++++++-------------------------- 1 file changed, 33 insertions(+), 42 deletions(-) diff --git a/libs/vkd3d-shader/trace.c b/libs/vkd3d-shader/trace.c index f8b7923..b5abe22 100644 --- a/libs/vkd3d-shader/trace.c +++ b/libs/vkd3d-shader/trace.c @@ -702,6 +702,18 @@ static void shader_dump_decl_usage(struct vkd3d_d3d_asm_compiler *compiler, static void shader_dump_src_param(struct vkd3d_d3d_asm_compiler *compiler, const struct vkd3d_shader_src_param *param); +static void shader_print_subscript(struct vkd3d_d3d_asm_compiler *compiler, + unsigned int offset, const struct vkd3d_shader_src_param *rel_addr) +{ + vkd3d_string_buffer_printf(&compiler->buffer, "["); + if (rel_addr) + { + shader_dump_src_param(compiler, rel_addr); + vkd3d_string_buffer_printf(&compiler->buffer, " + "); + } + vkd3d_string_buffer_printf(&compiler->buffer, "%u]", offset); +} + static void shader_dump_register(struct vkd3d_d3d_asm_compiler *compiler, const struct vkd3d_shader_register *reg) { struct vkd3d_string_buffer *buffer = &compiler->buffer; @@ -981,51 +993,28 @@ static void shader_dump_register(struct vkd3d_d3d_asm_compiler *compiler, const { if (offset != ~0u) { - bool printbrackets = reg->idx[0].rel_addr - || reg->type == VKD3DSPR_INCONTROLPOINT - || reg->type == VKD3DSPR_IMMCONSTBUFFER - || ((compiler->shader_version.type == VKD3D_SHADER_TYPE_GEOMETRY - || compiler->shader_version.type == VKD3D_SHADER_TYPE_HULL) - && reg->type == VKD3DSPR_INPUT); - - if (printbrackets) - shader_addline(buffer, "%s[", compiler->colours.reset); - if (reg->idx[0].rel_addr) + if (reg->idx[0].rel_addr || reg->type == VKD3DSPR_IMMCONSTBUFFER + || reg->type == VKD3DSPR_INCONTROLPOINT || (reg->type == VKD3DSPR_INPUT + && (compiler->shader_version.type == VKD3D_SHADER_TYPE_GEOMETRY + || compiler->shader_version.type == VKD3D_SHADER_TYPE_HULL))) { - shader_dump_src_param(compiler, reg->idx[0].rel_addr); - shader_addline(buffer, " + "); + vkd3d_string_buffer_printf(buffer, "%s", compiler->colours.reset); + shader_print_subscript(compiler, offset, reg->idx[0].rel_addr); } - shader_addline(buffer, "%u", offset); - if (printbrackets) - shader_addline(buffer, "]"); else - shader_addline(buffer, "%s", compiler->colours.reset); + { + vkd3d_string_buffer_printf(buffer, "%u%s", offset, compiler->colours.reset); + } /* For CBs in sm < 5.1 we move the buffer offset from idx[1] to idx[2] * to normalise it with 5.1. * Here we should ignore it if it's a CB in sm < 5.1. */ if (reg->idx[1].offset != ~0u && (reg->type != VKD3DSPR_CONSTBUFFER || shader_ver_ge(&compiler->shader_version, 5, 1))) - { - shader_addline(buffer, "["); - if (reg->idx[1].rel_addr) - { - shader_dump_src_param(compiler, reg->idx[1].rel_addr); - shader_addline(buffer, " + "); - } - shader_addline(buffer, "%u]", reg->idx[1].offset); - } + shader_print_subscript(compiler, reg->idx[1].offset, reg->idx[1].rel_addr); if (reg->idx[2].offset != ~0u) - { - shader_addline(buffer, "["); - if (reg->idx[2].rel_addr) - { - shader_dump_src_param(compiler, reg->idx[2].rel_addr); - shader_addline(buffer, " + "); - } - shader_addline(buffer, "%u]", reg->idx[2].offset); - } + shader_print_subscript(compiler, reg->idx[2].offset, reg->idx[2].rel_addr); } else { @@ -1033,7 +1022,7 @@ static void shader_dump_register(struct vkd3d_d3d_asm_compiler *compiler, const } if (reg->type == VKD3DSPR_FUNCTIONPOINTER) - shader_addline(buffer, "[%u]", reg->u.fp_body_idx); + shader_print_subscript(compiler, reg->u.fp_body_idx, NULL); } else { @@ -1392,7 +1381,7 @@ static void shader_dump_instruction(struct vkd3d_d3d_asm_compiler *compiler, vkd3d_string_buffer_printf(buffer, " "); shader_dump_register(compiler, &ins->declaration.cb.src.reg); if (shader_ver_ge(&compiler->shader_version, 5, 1)) - shader_addline(buffer, "[%u]", ins->declaration.cb.size); + shader_print_subscript(compiler, ins->declaration.cb.size, NULL); shader_addline(buffer, ", %s", ins->flags & VKD3DSI_INDEXED_DYNAMIC ? "dynamicIndexed" : "immediateIndexed"); shader_dump_register_space(compiler, ins->declaration.cb.register_space); @@ -1435,10 +1424,10 @@ static void shader_dump_instruction(struct vkd3d_d3d_asm_compiler *compiler, break; case VKD3DSIH_DCL_INDEXABLE_TEMP: - vkd3d_string_buffer_printf(buffer, " %sx%u%s[%u], %u", compiler->colours.reg, - ins->declaration.indexable_temp.register_idx, compiler->colours.reset, - ins->declaration.indexable_temp.register_size, - ins->declaration.indexable_temp.component_count); + vkd3d_string_buffer_printf(buffer, " %sx%u%s", compiler->colours.reg, + ins->declaration.indexable_temp.register_idx, compiler->colours.reset); + shader_print_subscript(compiler, ins->declaration.indexable_temp.register_size, NULL); + vkd3d_string_buffer_printf(buffer, ", %u", ins->declaration.indexable_temp.component_count); break; case VKD3DSIH_DCL_INPUT_PS: @@ -1480,8 +1469,10 @@ static void shader_dump_instruction(struct vkd3d_d3d_asm_compiler *compiler, break; case VKD3DSIH_DCL_INTERFACE: - vkd3d_string_buffer_printf(buffer, " fp%u[%u][%u] = {...}", ins->declaration.fp.index, - ins->declaration.fp.array_size, ins->declaration.fp.body_count); + vkd3d_string_buffer_printf(buffer, " fp%u", ins->declaration.fp.index); + shader_print_subscript(compiler, ins->declaration.fp.array_size, NULL); + shader_print_subscript(compiler, ins->declaration.fp.body_count, NULL); + vkd3d_string_buffer_printf(buffer, " = {...}"); break; case VKD3DSIH_DCL_RESOURCE_RAW:

1 0

Henri Verbeet : vkd3d-shader: Introduce a helper to print d3d-asm floating-point literals.
by Alexandre Julliard 17 Feb '21

17 Feb '21

Module: vkd3d Branch: master Commit: 8ff88d454416cd027efc505a2b180664838b2675 URL: https://source.winehq.org/git/vkd3d.git/?a=commit;h=8ff88d454416cd027efc505… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Wed Feb 17 12:21:09 2021 +0100 vkd3d-shader: Introduce a helper to print d3d-asm floating-point literals. Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- libs/vkd3d-shader/trace.c | 29 +++++++++++++++++++---------- 1 file changed, 19 insertions(+), 10 deletions(-) diff --git a/libs/vkd3d-shader/trace.c b/libs/vkd3d-shader/trace.c index b5abe22..b9fc34b 100644 --- a/libs/vkd3d-shader/trace.c +++ b/libs/vkd3d-shader/trace.c @@ -702,6 +702,12 @@ static void shader_dump_decl_usage(struct vkd3d_d3d_asm_compiler *compiler, static void shader_dump_src_param(struct vkd3d_d3d_asm_compiler *compiler, const struct vkd3d_shader_src_param *param); +static void shader_print_float_literal(struct vkd3d_d3d_asm_compiler *compiler, + const char *prefix, float f, const char *suffix) +{ + vkd3d_string_buffer_printf(&compiler->buffer, "%s%.8e%s", prefix, f, suffix); +} + static void shader_print_subscript(struct vkd3d_d3d_asm_compiler *compiler, unsigned int offset, const struct vkd3d_shader_src_param *rel_addr) { @@ -939,7 +945,7 @@ static void shader_dump_register(struct vkd3d_d3d_asm_compiler *compiler, const switch (reg->data_type) { case VKD3D_DATA_FLOAT: - shader_addline(buffer, "%.8e", reg->u.immconst_float[0]); + shader_print_float_literal(compiler, "", reg->u.immconst_float[0], ""); break; case VKD3D_DATA_INT: shader_addline(buffer, "%d", reg->u.immconst_uint[0]); @@ -959,9 +965,10 @@ static void shader_dump_register(struct vkd3d_d3d_asm_compiler *compiler, const switch (reg->data_type) { case VKD3D_DATA_FLOAT: - shader_addline(buffer, "%.8e, %.8e, %.8e, %.8e", - reg->u.immconst_float[0], reg->u.immconst_float[1], - reg->u.immconst_float[2], reg->u.immconst_float[3]); + shader_print_float_literal(compiler, "", reg->u.immconst_float[0], ""); + shader_print_float_literal(compiler, ", ", reg->u.immconst_float[1], ""); + shader_print_float_literal(compiler, ", ", reg->u.immconst_float[2], ""); + shader_print_float_literal(compiler, ", ", reg->u.immconst_float[3], ""); break; case VKD3D_DATA_INT: shader_addline(buffer, "%d, %d, %d, %d", @@ -1401,7 +1408,7 @@ static void shader_dump_instruction(struct vkd3d_d3d_asm_compiler *compiler, break; case VKD3DSIH_DCL_HS_MAX_TESSFACTOR: - vkd3d_string_buffer_printf(buffer, " %.8e", ins->declaration.max_tessellation_factor); + shader_print_float_literal(compiler, " ", ins->declaration.max_tessellation_factor, ""); break; case VKD3DSIH_DCL_IMMEDIATE_CONSTANT_BUFFER: @@ -1557,11 +1564,13 @@ static void shader_dump_instruction(struct vkd3d_d3d_asm_compiler *compiler, break; case VKD3DSIH_DEF: - vkd3d_string_buffer_printf(buffer, " %sc%u%s = %.8e, %.8e, %.8e, %.8e", - compiler->colours.reg, shader_get_float_offset(ins->dst[0].reg.type, - ins->dst[0].reg.idx[0].offset), compiler->colours.reset, - ins->src[0].reg.u.immconst_float[0], ins->src[0].reg.u.immconst_float[1], - ins->src[0].reg.u.immconst_float[2], ins->src[0].reg.u.immconst_float[3]); + vkd3d_string_buffer_printf(buffer, " %sc%u%s", compiler->colours.reg, + shader_get_float_offset(ins->dst[0].reg.type, ins->dst[0].reg.idx[0].offset), + compiler->colours.reset); + shader_print_float_literal(compiler, " = ", ins->src[0].reg.u.immconst_float[0], ""); + shader_print_float_literal(compiler, ", ", ins->src[0].reg.u.immconst_float[1], ""); + shader_print_float_literal(compiler, ", ", ins->src[0].reg.u.immconst_float[2], ""); + shader_print_float_literal(compiler, ", ", ins->src[0].reg.u.immconst_float[3], ""); break; case VKD3DSIH_DEFI:

1 0

Henri Verbeet : vkd3d-shader: Introduce a helper to print d3d-asm integer literals.
by Alexandre Julliard 17 Feb '21

17 Feb '21

Module: vkd3d Branch: master Commit: 03c34076e8edf9145259630a7dfae095dc3dc149 URL: https://source.winehq.org/git/vkd3d.git/?a=commit;h=03c34076e8edf9145259630… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Wed Feb 17 12:21:10 2021 +0100 vkd3d-shader: Introduce a helper to print d3d-asm integer literals. Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- libs/vkd3d-shader/trace.c | 30 ++++++++++++++++++++---------- 1 file changed, 20 insertions(+), 10 deletions(-) diff --git a/libs/vkd3d-shader/trace.c b/libs/vkd3d-shader/trace.c index b9fc34b..35e684b 100644 --- a/libs/vkd3d-shader/trace.c +++ b/libs/vkd3d-shader/trace.c @@ -708,6 +708,12 @@ static void shader_print_float_literal(struct vkd3d_d3d_asm_compiler *compiler, vkd3d_string_buffer_printf(&compiler->buffer, "%s%.8e%s", prefix, f, suffix); } +static void shader_print_int_literal(struct vkd3d_d3d_asm_compiler *compiler, + const char *prefix, int i, const char *suffix) +{ + vkd3d_string_buffer_printf(&compiler->buffer, "%s%d%s", prefix, i, suffix); +} + static void shader_print_subscript(struct vkd3d_d3d_asm_compiler *compiler, unsigned int offset, const struct vkd3d_shader_src_param *rel_addr) { @@ -948,7 +954,7 @@ static void shader_dump_register(struct vkd3d_d3d_asm_compiler *compiler, const shader_print_float_literal(compiler, "", reg->u.immconst_float[0], ""); break; case VKD3D_DATA_INT: - shader_addline(buffer, "%d", reg->u.immconst_uint[0]); + shader_print_int_literal(compiler, "", reg->u.immconst_uint[0], ""); break; case VKD3D_DATA_RESOURCE: case VKD3D_DATA_SAMPLER: @@ -971,9 +977,10 @@ static void shader_dump_register(struct vkd3d_d3d_asm_compiler *compiler, const shader_print_float_literal(compiler, ", ", reg->u.immconst_float[3], ""); break; case VKD3D_DATA_INT: - shader_addline(buffer, "%d, %d, %d, %d", - reg->u.immconst_uint[0], reg->u.immconst_uint[1], - reg->u.immconst_uint[2], reg->u.immconst_uint[3]); + shader_print_int_literal(compiler, "", reg->u.immconst_uint[0], ""); + shader_print_int_literal(compiler, ", ", reg->u.immconst_uint[1], ""); + shader_print_int_literal(compiler, ", ", reg->u.immconst_uint[2], ""); + shader_print_int_literal(compiler, ", ", reg->u.immconst_uint[3], ""); break; case VKD3D_DATA_RESOURCE: case VKD3D_DATA_SAMPLER: @@ -1574,10 +1581,12 @@ static void shader_dump_instruction(struct vkd3d_d3d_asm_compiler *compiler, break; case VKD3DSIH_DEFI: - vkd3d_string_buffer_printf(buffer, " %si%u%s = %d, %d, %d, %d", - compiler->colours.reg, ins->dst[0].reg.idx[0].offset, compiler->colours.reset, - ins->src[0].reg.u.immconst_uint[0], ins->src[0].reg.u.immconst_uint[1], - ins->src[0].reg.u.immconst_uint[2], ins->src[0].reg.u.immconst_uint[3]); + vkd3d_string_buffer_printf(buffer, " %si%u%s", compiler->colours.reg, + ins->dst[0].reg.idx[0].offset, compiler->colours.reset); + shader_print_int_literal(compiler, " = ", ins->src[0].reg.u.immconst_uint[0], ""); + shader_print_int_literal(compiler, ", ", ins->src[0].reg.u.immconst_uint[1], ""); + shader_print_int_literal(compiler, ", ", ins->src[0].reg.u.immconst_uint[2], ""); + shader_print_int_literal(compiler, ", ", ins->src[0].reg.u.immconst_uint[3], ""); break; case VKD3DSIH_DEFB: @@ -1590,8 +1599,9 @@ static void shader_dump_instruction(struct vkd3d_d3d_asm_compiler *compiler, shader_dump_instruction_flags(compiler, ins); if (vkd3d_shader_instruction_has_texel_offset(ins)) { - shader_addline(buffer, "(%d,%d,%d)", - ins->texel_offset.u, ins->texel_offset.v, ins->texel_offset.w); + shader_print_int_literal(compiler, "(", ins->texel_offset.u, ""); + shader_print_int_literal(compiler, ",", ins->texel_offset.v, ""); + shader_print_int_literal(compiler, ",", ins->texel_offset.w, ")"); } if (ins->resource_type != VKD3D_SHADER_RESOURCE_NONE)

1 0

Alexandre Julliard : kernelbase: Don't use wine/server.h.
by Alexandre Julliard 16 Feb '21

16 Feb '21

Module: wine Branch: master Commit: 4dacf60a6a31aac8b04c8696b75c9b30fdf471d7 URL: https://source.winehq.org/git/wine.git/?a=commit;h=4dacf60a6a31aac8b04c8696… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Feb 16 11:43:27 2021 +0100 kernelbase: Don't use wine/server.h. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/kernelbase/sync.c | 1 - dlls/kernelbase/volume.c | 1 - 2 files changed, 2 deletions(-) diff --git a/dlls/kernelbase/sync.c b/dlls/kernelbase/sync.c index f4bee2d134b..ab963c62221 100644 --- a/dlls/kernelbase/sync.c +++ b/dlls/kernelbase/sync.c @@ -37,7 +37,6 @@ #include "kernelbase.h" #include "wine/asm.h" #include "wine/exception.h" -#include "wine/server.h" #include "wine/debug.h" WINE_DEFAULT_DEBUG_CHANNEL(sync); diff --git a/dlls/kernelbase/volume.c b/dlls/kernelbase/volume.c index 7daf9c98823..a0d1bb705b3 100644 --- a/dlls/kernelbase/volume.c +++ b/dlls/kernelbase/volume.c @@ -38,7 +38,6 @@ #include "ddk/mountmgr.h" #include "ddk/wdm.h" #include "kernelbase.h" -#include "wine/server.h" #include "wine/debug.h" WINE_DEFAULT_DEBUG_CHANNEL(volume);

1 0

Alexandre Julliard : kernel32: Don't use wine/server.h.
by Alexandre Julliard 16 Feb '21

16 Feb '21

Module: wine Branch: master Commit: e11f6e0eb3d30d1c20a735bd4629341f2f8c90a4 URL: https://source.winehq.org/git/wine.git/?a=commit;h=e11f6e0eb3d30d1c20a735bd… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Feb 16 11:43:40 2021 +0100 kernel32: Don't use wine/server.h. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/kernel32/comm.c | 3 +-- dlls/kernel32/console.c | 4 ++-- dlls/kernel32/process.c | 1 - 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/dlls/kernel32/comm.c b/dlls/kernel32/comm.c index 209a490b623..e9dd0feac58 100644 --- a/dlls/kernel32/comm.c +++ b/dlls/kernel32/comm.c @@ -24,13 +24,12 @@ #include "windef.h" #include "winbase.h" +#include "winternl.h" #include "winnls.h" #include "winerror.h" #include "winioctl.h" #include "ddk/ntddser.h" -#include "wine/server.h" - #include "wine/debug.h" WINE_DEFAULT_DEBUG_CHANNEL(comm); diff --git a/dlls/kernel32/console.c b/dlls/kernel32/console.c index 7b3a07f0de5..8c61d28e8c6 100644 --- a/dlls/kernel32/console.c +++ b/dlls/kernel32/console.c @@ -33,11 +33,11 @@ #define WIN32_NO_STATUS #include "windef.h" #include "winbase.h" +#include "winternl.h" #include "winnls.h" #include "winerror.h" #include "wincon.h" #include "wine/condrv.h" -#include "wine/server.h" #include "wine/exception.h" #include "wine/debug.h" #include "excpt.h" @@ -59,7 +59,7 @@ HWND WINAPI GetConsoleWindow(void) ret = DeviceIoControl( RtlGetCurrentPeb()->ProcessParameters->ConsoleHandle, IOCTL_CONDRV_GET_INPUT_INFO, NULL, 0, &info, sizeof(info), NULL, NULL ); - return ret ? wine_server_ptr_handle(info.win) : NULL; + return ret ? LongToHandle( info.win ) : NULL; } diff --git a/dlls/kernel32/process.c b/dlls/kernel32/process.c index 756d1ef3f87..41a5b34af19 100644 --- a/dlls/kernel32/process.c +++ b/dlls/kernel32/process.c @@ -36,7 +36,6 @@ #include "psapi.h" #include "ddk/wdm.h" #include "wine/exception.h" -#include "wine/server.h" #include "wine/asm.h" #include "wine/debug.h"

1 0

Alexandre Julliard : krnl386.exe: Don't use wine/server.h.
by Alexandre Julliard 16 Feb '21

16 Feb '21

Module: wine Branch: master Commit: 4a17ca008ec01029cc6d3ab6ac8a2ca037203beb URL: https://source.winehq.org/git/wine.git/?a=commit;h=4a17ca008ec01029cc6d3ab6… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Feb 16 11:43:48 2021 +0100 krnl386.exe: Don't use wine/server.h. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/krnl386.exe16/int21.c | 1 - dlls/krnl386.exe16/selector.c | 1 - dlls/krnl386.exe16/vxd.c | 1 - 3 files changed, 3 deletions(-) diff --git a/dlls/krnl386.exe16/int21.c b/dlls/krnl386.exe16/int21.c index 24909eadddc..5129fbd8eb6 100644 --- a/dlls/krnl386.exe16/int21.c +++ b/dlls/krnl386.exe16/int21.c @@ -37,7 +37,6 @@ #include "dosexe.h" #include "winerror.h" #include "winuser.h" -#include "wine/server.h" #include "wine/debug.h" #include "wine/exception.h" diff --git a/dlls/krnl386.exe16/selector.c b/dlls/krnl386.exe16/selector.c index 26c86f06a9f..ab5881c8927 100644 --- a/dlls/krnl386.exe16/selector.c +++ b/dlls/krnl386.exe16/selector.c @@ -21,7 +21,6 @@ #include <string.h> #include "wine/winbase16.h" -#include "wine/server.h" #include "wine/debug.h" #include "kernel16_private.h" diff --git a/dlls/krnl386.exe16/vxd.c b/dlls/krnl386.exe16/vxd.c index c259cd60775..5d280fb2fda 100644 --- a/dlls/krnl386.exe16/vxd.c +++ b/dlls/krnl386.exe16/vxd.c @@ -35,7 +35,6 @@ #include "winioctl.h" #include "kernel16_private.h" #include "dosexe.h" -#include "wine/server.h" #include "wine/debug.h" WINE_DEFAULT_DEBUG_CHANNEL(vxd);

1 0