March 2021 - Wine-commits - list.winehq.org

Nikolay Sivov : wbemdisp: Downgrade failing interface queries to warnings.
by Alexandre Julliard 03 Mar '21

03 Mar '21

Module: wine Branch: master Commit: a0c624c2b16e150ef7ba12aa58c58608f8903ef5 URL: https://source.winehq.org/git/wine.git/?a=commit;h=a0c624c2b16e150ef7ba12aa… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Wed Mar 3 09:04:27 2021 +0300 wbemdisp: Downgrade failing interface queries to warnings. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Hans Leidekker <hans(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/wbemdisp/locator.c | 24 ++++++++++++------------ dlls/wbemdisp/main.c | 2 +- 2 files changed, 13 insertions(+), 13 deletions(-) diff --git a/dlls/wbemdisp/locator.c b/dlls/wbemdisp/locator.c index dcec47faa6e..ed6a13c2df8 100644 --- a/dlls/wbemdisp/locator.c +++ b/dlls/wbemdisp/locator.c @@ -181,7 +181,7 @@ static HRESULT WINAPI property_QueryInterface( ISWbemProperty *iface, REFIID rii } else { - FIXME( "interface %s not implemented\n", debugstr_guid(riid) ); + WARN( "interface %s not implemented\n", debugstr_guid(riid) ); return E_NOINTERFACE; } ISWbemProperty_AddRef( iface ); @@ -380,7 +380,7 @@ static HRESULT WINAPI propertyset_QueryInterface( ISWbemPropertySet *iface, } else { - FIXME( "interface %s not implemented\n", debugstr_guid(riid) ); + WARN( "interface %s not implemented\n", debugstr_guid(riid) ); return E_NOINTERFACE; } ISWbemPropertySet_AddRef( iface ); @@ -592,7 +592,7 @@ static HRESULT WINAPI method_QueryInterface( ISWbemMethod *iface, REFIID riid, v } else { - FIXME( "interface %s not implemented\n", debugstr_guid(riid) ); + WARN( "interface %s not implemented\n", debugstr_guid(riid) ); return E_NOINTERFACE; } ISWbemMethod_AddRef( iface ); @@ -816,7 +816,7 @@ static HRESULT WINAPI methodset_QueryInterface( ISWbemMethodSet *iface, REFIID r } else { - FIXME( "interface %s not implemented\n", debugstr_guid(riid) ); + WARN( "interface %s not implemented\n", debugstr_guid(riid) ); return E_NOINTERFACE; } ISWbemMethodSet_AddRef( iface ); @@ -1047,7 +1047,7 @@ static HRESULT WINAPI object_QueryInterface( } else { - FIXME( "interface %s not implemented\n", debugstr_guid(riid) ); + WARN( "interface %s not implemented\n", debugstr_guid(riid) ); return E_NOINTERFACE; } ISWbemObject_AddRef( iface ); @@ -1748,7 +1748,7 @@ static HRESULT WINAPI objectset_QueryInterface( } else { - FIXME( "interface %s not implemented\n", debugstr_guid(riid) ); + WARN( "interface %s not implemented\n", debugstr_guid(riid) ); return E_NOINTERFACE; } ISWbemObjectSet_AddRef( iface ); @@ -2015,7 +2015,7 @@ static HRESULT WINAPI enumvar_QueryInterface( } else { - FIXME( "interface %s not implemented\n", debugstr_guid(riid) ); + WARN( "interface %s not implemented\n", debugstr_guid(riid) ); return E_NOINTERFACE; } IEnumVARIANT_AddRef( iface ); @@ -2144,7 +2144,7 @@ static HRESULT WINAPI services_QueryInterface( } else { - FIXME( "interface %s not implemented\n", debugstr_guid(riid) ); + WARN( "interface %s not implemented\n", debugstr_guid(riid) ); return E_NOINTERFACE; } ISWbemServices_AddRef( iface ); @@ -2649,7 +2649,7 @@ static HRESULT WINAPI locator_QueryInterface( } else { - FIXME( "interface %s not implemented\n", debugstr_guid(riid) ); + WARN( "interface %s not implemented\n", debugstr_guid(riid) ); return E_NOINTERFACE; } ISWbemLocator_AddRef( iface ); @@ -2888,7 +2888,7 @@ static HRESULT WINAPI security_QueryInterface( } else { - FIXME( "interface %s not implemented\n", debugstr_guid(riid) ); + WARN( "interface %s not implemented\n", debugstr_guid(riid) ); return E_NOINTERFACE; } ISWbemSecurity_AddRef( iface ); @@ -3100,7 +3100,7 @@ static HRESULT WINAPI namedvalue_QueryInterface( } else { - FIXME( "interface %s not implemented\n", debugstr_guid(riid) ); + WARN( "interface %s not implemented\n", debugstr_guid(riid) ); return E_NOINTERFACE; } ISWbemNamedValue_AddRef( iface ); @@ -3277,7 +3277,7 @@ static HRESULT WINAPI namedvalueset_QueryInterface( } else { - FIXME( "interface %s not implemented\n", debugstr_guid(riid) ); + WARN( "interface %s not implemented\n", debugstr_guid(riid) ); return E_NOINTERFACE; } ISWbemNamedValueSet_AddRef( iface ); diff --git a/dlls/wbemdisp/main.c b/dlls/wbemdisp/main.c index 624017f5382..7e73d546531 100644 --- a/dlls/wbemdisp/main.c +++ b/dlls/wbemdisp/main.c @@ -211,7 +211,7 @@ static HRESULT WINAPI factory_QueryInterface( IClassFactory *iface, REFIID riid, *obj = iface; return S_OK; } - FIXME( "interface %s not implemented\n", debugstr_guid(riid) ); + WARN( "interface %s not implemented\n", debugstr_guid(riid) ); return E_NOINTERFACE; }

1 0

Nikolay Sivov : wbemdisp: Forward ISWbemNamedValueSet::DeleteAll() to context object.
by Alexandre Julliard 03 Mar '21

03 Mar '21

Module: wine Branch: master Commit: b938f54b1e9af22640b310a07f66d91018f36ea5 URL: https://source.winehq.org/git/wine.git/?a=commit;h=b938f54b1e9af22640b310a0… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Wed Mar 3 09:04:28 2021 +0300 wbemdisp: Forward ISWbemNamedValueSet::DeleteAll() to context object. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Hans Leidekker <hans(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/wbemdisp/locator.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/dlls/wbemdisp/locator.c b/dlls/wbemdisp/locator.c index ed6a13c2df8..76312e72fc3 100644 --- a/dlls/wbemdisp/locator.c +++ b/dlls/wbemdisp/locator.c @@ -3467,9 +3467,11 @@ static HRESULT WINAPI namedvalueset_Clone( static HRESULT WINAPI namedvalueset_DeleteAll( ISWbemNamedValueSet *iface ) { - FIXME("\n"); + struct namedvalueset *set = impl_from_ISWbemNamedValueSet( iface ); - return E_NOTIMPL; + TRACE("%p\n", set); + + return IWbemContext_DeleteAll( set->context ); } static const ISWbemNamedValueSetVtbl namedvalueset_vtbl =

1 0

Nikolay Sivov : wbemdisp: Forward ISWbemNamedValueSet::Remove() to context object method.
by Alexandre Julliard 03 Mar '21

03 Mar '21

Module: wine Branch: master Commit: 2ed349488c4c93c68635004bd419fee3455d210f URL: https://source.winehq.org/git/wine.git/?a=commit;h=2ed349488c4c93c68635004b… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Wed Mar 3 09:04:29 2021 +0300 wbemdisp: Forward ISWbemNamedValueSet::Remove() to context object method. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Hans Leidekker <hans(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/wbemdisp/locator.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/dlls/wbemdisp/locator.c b/dlls/wbemdisp/locator.c index 76312e72fc3..3e2566d5220 100644 --- a/dlls/wbemdisp/locator.c +++ b/dlls/wbemdisp/locator.c @@ -3450,9 +3450,11 @@ static HRESULT WINAPI namedvalueset_Remove( BSTR name, LONG flags ) { - FIXME("\n"); + struct namedvalueset *set = impl_from_ISWbemNamedValueSet( iface ); - return E_NOTIMPL; + TRACE("%p, %s, %#x\n", set, debugstr_w(name), flags); + + return IWbemContext_DeleteValue( set->context, name, flags ); } static HRESULT WINAPI namedvalueset_Clone(

1 0

Nikolay Sivov : wbemprox: Keep context object per services instance.
by Alexandre Julliard 03 Mar '21

03 Mar '21

Module: wine Branch: master Commit: 4a97c6b03c68357c96fe9db6d7fcc69b8a44f3f0 URL: https://source.winehq.org/git/wine.git/?a=commit;h=4a97c6b03c68357c96fe9db6… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Wed Mar 3 09:05:48 2021 +0300 wbemprox: Keep context object per services instance. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Hans Leidekker <hans(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/wbemprox/services.c | 12 ++++++++---- dlls/wbemprox/tests/services.c | 24 ++++++++++++++++++++++++ dlls/wbemprox/wbemlocator.c | 6 +++--- dlls/wbemprox/wbemprox_private.h | 2 +- 4 files changed, 36 insertions(+), 8 deletions(-) diff --git a/dlls/wbemprox/services.c b/dlls/wbemprox/services.c index eff5148ef29..19e03fa152b 100644 --- a/dlls/wbemprox/services.c +++ b/dlls/wbemprox/services.c @@ -210,6 +210,7 @@ struct wbem_services CRITICAL_SECTION cs; WCHAR *namespace; struct async_header *async; + IWbemContext *context; }; static inline struct wbem_services *impl_from_IWbemServices( IWbemServices *iface ) @@ -243,6 +244,8 @@ static ULONG WINAPI wbem_services_Release( } ws->cs.DebugInfo->Spare[0] = 0; DeleteCriticalSection( &ws->cs ); + if (ws->context) + IWbemContext_Release( ws->context ); heap_free( ws->namespace ); heap_free( ws ); } @@ -293,7 +296,7 @@ static HRESULT WINAPI wbem_services_OpenNamespace( if ((wcsicmp( strNamespace, L"cimv2" ) && wcsicmp( strNamespace, L"default" )) || ws->namespace) return WBEM_E_INVALID_NAMESPACE; - return WbemServices_create( L"cimv2", (void **)ppWorkingNamespace ); + return WbemServices_create( L"cimv2", NULL, (void **)ppWorkingNamespace ); } static HRESULT WINAPI wbem_services_CancelAsyncCall( @@ -933,21 +936,22 @@ static const IWbemServicesVtbl wbem_services_vtbl = wbem_services_ExecMethodAsync }; -HRESULT WbemServices_create( const WCHAR *namespace, LPVOID *ppObj ) +HRESULT WbemServices_create( const WCHAR *namespace, IWbemContext *context, LPVOID *ppObj ) { struct wbem_services *ws; TRACE("(%p)\n", ppObj); - ws = heap_alloc( sizeof(*ws) ); + ws = heap_alloc_zero( sizeof(*ws) ); if (!ws) return E_OUTOFMEMORY; ws->IWbemServices_iface.lpVtbl = &wbem_services_vtbl; ws->refs = 1; ws->namespace = heap_strdupW( namespace ); - ws->async = NULL; InitializeCriticalSection( &ws->cs ); ws->cs.DebugInfo->Spare[0] = (DWORD_PTR)(__FILE__ ": wbemprox_services.cs"); + if (context) + IWbemContext_Clone( context, &ws->context ); *ppObj = &ws->IWbemServices_iface; diff --git a/dlls/wbemprox/tests/services.c b/dlls/wbemprox/tests/services.c index ebbc766d6c5..da985de01fa 100644 --- a/dlls/wbemprox/tests/services.c +++ b/dlls/wbemprox/tests/services.c @@ -24,6 +24,15 @@ #include "wbemcli.h" #include "wine/test.h" +#define EXPECT_REF(obj,ref) _expect_ref((IUnknown*)obj, ref, __LINE__) +static void _expect_ref(IUnknown* obj, ULONG ref, int line) +{ + ULONG rc; + IUnknown_AddRef(obj); + rc = IUnknown_Release(obj); + ok_(__FILE__,line)(rc == ref, "expected refcount %d, got %d\n", ref, rc); +} + static void test_IClientSecurity(void) { HRESULT hr; @@ -124,6 +133,7 @@ static void test_IWbemLocator(void) }; IWbemLocator *locator; IWbemServices *services; + IWbemContext *context; unsigned int i; HRESULT hr; BSTR resource; @@ -146,6 +156,20 @@ static void test_IWbemLocator(void) SysFreeString( resource ); if (hr == S_OK) IWbemServices_Release( services ); } + + hr = CoCreateInstance( &CLSID_WbemContext, NULL, CLSCTX_INPROC_SERVER, &IID_IWbemContext, (void **)&context ); + ok(hr == S_OK, "Failed to create context object, hr %#x.\n", hr); + + EXPECT_REF(context, 1); + resource = SysAllocString( L"root\\default" ); + hr = IWbemLocator_ConnectServer( locator, resource, NULL, NULL, NULL, 0, NULL, context, &services ); + ok(hr == S_OK, "Failed to connect, hr %#x.\n", hr); + SysFreeString( resource ); + EXPECT_REF(context, 1); + IWbemServices_Release( services ); + + IWbemContext_Release( context ); + IWbemLocator_Release( locator ); } diff --git a/dlls/wbemprox/wbemlocator.c b/dlls/wbemprox/wbemlocator.c index 9b6f2cbc741..5e86f2be86d 100644 --- a/dlls/wbemprox/wbemlocator.c +++ b/dlls/wbemprox/wbemlocator.c @@ -161,14 +161,14 @@ static HRESULT WINAPI wbem_locator_ConnectServer( const BSTR Locale, LONG SecurityFlags, const BSTR Authority, - IWbemContext *pCtx, + IWbemContext *context, IWbemServices **ppNamespace) { HRESULT hr; WCHAR *server, *namespace; TRACE("%p, %s, %s, %s, %s, 0x%08x, %s, %p, %p)\n", iface, debugstr_w(NetworkResource), debugstr_w(User), - debugstr_w(Password), debugstr_w(Locale), SecurityFlags, debugstr_w(Authority), pCtx, ppNamespace); + debugstr_w(Password), debugstr_w(Locale), SecurityFlags, debugstr_w(Authority), context, ppNamespace); hr = parse_resource( NetworkResource, &server, &namespace ); if (hr != S_OK) return hr; @@ -187,7 +187,7 @@ static HRESULT WINAPI wbem_locator_ConnectServer( if (SecurityFlags) FIXME("unsupported flags\n"); - hr = WbemServices_create( namespace, (void **)ppNamespace ); + hr = WbemServices_create( namespace, context, (void **)ppNamespace ); heap_free( namespace ); heap_free( server ); if (SUCCEEDED( hr )) diff --git a/dlls/wbemprox/wbemprox_private.h b/dlls/wbemprox/wbemprox_private.h index bae4b5d20c5..7e1efe65874 100644 --- a/dlls/wbemprox/wbemprox_private.h +++ b/dlls/wbemprox/wbemprox_private.h @@ -236,7 +236,7 @@ HRESULT create_signature( const WCHAR *, const WCHAR *, enum param_direction, IWbemClassObject ** ) DECLSPEC_HIDDEN; HRESULT WbemLocator_create(LPVOID *) DECLSPEC_HIDDEN; -HRESULT WbemServices_create(const WCHAR *, LPVOID *) DECLSPEC_HIDDEN; +HRESULT WbemServices_create(const WCHAR *, IWbemContext *, LPVOID *) DECLSPEC_HIDDEN; HRESULT WbemContext_create(void **) DECLSPEC_HIDDEN; HRESULT create_class_object(const WCHAR *, IEnumWbemClassObject *, UINT, struct record *, IWbemClassObject **) DECLSPEC_HIDDEN;

1 0

Nikolay Sivov : wbemprox: Implement context object cloning.
by Alexandre Julliard 03 Mar '21

03 Mar '21

Module: wine Branch: master Commit: 1be967df936b831018841119500aaa5fe546c49b URL: https://source.winehq.org/git/wine.git/?a=commit;h=1be967df936b831018841119… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Wed Mar 3 09:05:49 2021 +0300 wbemprox: Implement context object cloning. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Hans Leidekker <hans(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/wbemprox/services.c | 27 +++++++++++++++++++++++++-- 1 file changed, 25 insertions(+), 2 deletions(-) diff --git a/dlls/wbemprox/services.c b/dlls/wbemprox/services.c index 19e03fa152b..7de97dbae64 100644 --- a/dlls/wbemprox/services.c +++ b/dlls/wbemprox/services.c @@ -1039,9 +1039,32 @@ static HRESULT WINAPI wbem_context_Clone( IWbemContext *iface, IWbemContext **newcopy ) { - FIXME("%p, %p\n", iface, newcopy); + struct wbem_context *context = impl_from_IWbemContext( iface ); + struct wbem_context_value *value; + IWbemContext *cloned_context; + HRESULT hr; - return E_NOTIMPL; + TRACE("%p, %p\n", iface, newcopy); + + if (SUCCEEDED(hr = WbemContext_create( (void **)&cloned_context ))) + { + LIST_FOR_EACH_ENTRY( value, &context->values, struct wbem_context_value, entry ) + { + if (FAILED(hr = IWbemContext_SetValue( cloned_context, value->name, 0, &value->value ))) break; + } + } + + if (SUCCEEDED(hr)) + { + *newcopy = cloned_context; + } + else + { + *newcopy = NULL; + IWbemContext_Release( cloned_context ); + } + + return hr; } static HRESULT WINAPI wbem_context_GetNames(

1 0

Hugh McMaster : winetest: Ensure sticky table header doesn't cover anchor-link target.
by Alexandre Julliard 03 Mar '21

03 Mar '21

Module: tools Branch: master Commit: e9ca45c7f90e6baa5dec6f84a7d4a8e4c414ec02 URL: https://source.winehq.org/git/tools.git/?a=commit;h=e9ca45c7f90e6baa5dec6f8… Author: Hugh McMaster <hugh.mcmaster(a)outlook.com> Date: Wed Mar 3 19:57:10 2021 +1100 winetest: Ensure sticky table header doesn't cover anchor-link target. Signed-off-by: Hugh McMaster <hugh.mcmaster(a)outlook.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- winetest/summary.css | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/winetest/summary.css b/winetest/summary.css index d01a227..2bc9b44 100644 --- a/winetest/summary.css +++ b/winetest/summary.css @@ -36,6 +36,12 @@ div.main, div.group { width: 100%; border: 1px solid #601919; } +div.main table.report td.test a { + scroll-margin-top: 4.25ex; +} +div.group table.report td.test a { + scroll-margin-top: 7.75ex; +} div.navbar { padding: 0; width: 100%;

1 0

Francois Gouget : xactengine3_7: Add a trailing linefeed to ERR() messages.
by Alexandre Julliard 02 Mar '21

02 Mar '21

Module: wine Branch: master Commit: f8983ea419bcc326b54aaa0f5869c92a7070e7d1 URL: https://source.winehq.org/git/wine.git/?a=commit;h=f8983ea419bcc326b54aaa0f… Author: Francois Gouget <fgouget(a)free.fr> Date: Tue Mar 2 20:18:31 2021 +0100 xactengine3_7: Add a trailing linefeed to ERR() messages. Signed-off-by: Francois Gouget <fgouget(a)free.fr> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/xactengine3_7/xact_dll.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/dlls/xactengine3_7/xact_dll.c b/dlls/xactengine3_7/xact_dll.c index 8b9ee33ab5c..3fbb4875930 100644 --- a/dlls/xactengine3_7/xact_dll.c +++ b/dlls/xactengine3_7/xact_dll.c @@ -253,7 +253,7 @@ static HRESULT WINAPI IXACT3SoundBankImpl_Prepare(IXACT3SoundBank *iface, if (!cue) { FACTCue_Destroy(fcue); - ERR("Failed to allocate XACT3CueImpl!"); + ERR("Failed to allocate XACT3CueImpl!\n"); return E_OUTOFMEMORY; } @@ -295,7 +295,7 @@ static HRESULT WINAPI IXACT3SoundBankImpl_Play(IXACT3SoundBank *iface, if (!cue) { FACTCue_Destroy(fcue); - ERR("Failed to allocate XACT3CueImpl!"); + ERR("Failed to allocate XACT3CueImpl!\n"); return E_OUTOFMEMORY; } @@ -543,7 +543,7 @@ static HRESULT WINAPI IXACT3WaveBankImpl_Prepare(IXACT3WaveBank *iface, if (!wave) { FACTWave_Destroy(fwave); - ERR("Failed to allocate XACT3WaveImpl!"); + ERR("Failed to allocate XACT3WaveImpl!\n"); return E_OUTOFMEMORY; } @@ -585,7 +585,7 @@ static HRESULT WINAPI IXACT3WaveBankImpl_Play(IXACT3WaveBank *iface, if (!wave) { FACTWave_Destroy(fwave); - ERR("Failed to allocate XACT3WaveImpl!"); + ERR("Failed to allocate XACT3WaveImpl!\n"); return E_OUTOFMEMORY; } @@ -870,7 +870,7 @@ static HRESULT WINAPI IXACT3EngineImpl_CreateSoundBank(IXACT3Engine *iface, if (!sb) { FACTSoundBank_Destroy(fsb); - ERR("Failed to allocate XACT3SoundBankImpl!"); + ERR("Failed to allocate XACT3SoundBankImpl!\n"); return E_OUTOFMEMORY; } @@ -907,7 +907,7 @@ static HRESULT WINAPI IXACT3EngineImpl_CreateInMemoryWaveBank(IXACT3Engine *ifac if (!wb) { FACTWaveBank_Destroy(fwb); - ERR("Failed to allocate XACT3WaveBankImpl!"); + ERR("Failed to allocate XACT3WaveBankImpl!\n"); return E_OUTOFMEMORY; } @@ -955,7 +955,7 @@ static HRESULT WINAPI IXACT3EngineImpl_CreateStreamingWaveBank(IXACT3Engine *ifa if (!wb) { FACTWaveBank_Destroy(fwb); - ERR("Failed to allocate XACT3WaveBankImpl!"); + ERR("Failed to allocate XACT3WaveBankImpl!\n"); return E_OUTOFMEMORY; }

1 0

Francois Gouget : winevulkan: Add a trailing linefeed to FIXME() messages.
by Alexandre Julliard 02 Mar '21

02 Mar '21

Module: wine Branch: master Commit: 949e4e764b40111560b9a2785d0b2e7863e1f946 URL: https://source.winehq.org/git/wine.git/?a=commit;h=949e4e764b40111560b9a278… Author: Francois Gouget <fgouget(a)free.fr> Date: Tue Mar 2 20:18:44 2021 +0100 winevulkan: Add a trailing linefeed to FIXME() messages. Signed-off-by: Francois Gouget <fgouget(a)free.fr> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/winevulkan/vulkan.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/dlls/winevulkan/vulkan.c b/dlls/winevulkan/vulkan.c index a7f5462c432..dc3c9688df7 100644 --- a/dlls/winevulkan/vulkan.c +++ b/dlls/winevulkan/vulkan.c @@ -1507,7 +1507,7 @@ static inline VkTimeDomainEXT get_performance_counter_time_domain(void) return VK_TIME_DOMAIN_CLOCK_MONOTONIC_EXT; # endif #else - FIXME("No mapping for VK_TIME_DOMAIN_QUERY_PERFORMANCE_COUNTER_EXT on this platform."); + FIXME("No mapping for VK_TIME_DOMAIN_QUERY_PERFORMANCE_COUNTER_EXT on this platform.\n"); return VK_TIME_DOMAIN_QUERY_PERFORMANCE_COUNTER_EXT; #endif } @@ -1536,7 +1536,7 @@ static inline uint64_t convert_timestamp(VkTimeDomainEXT host_domain, VkTimeDoma && target_domain == VK_TIME_DOMAIN_QUERY_PERFORMANCE_COUNTER_EXT) return convert_monotonic_timestamp(value); - FIXME("Couldn't translate between host domain %d and target domain %d", host_domain, target_domain); + FIXME("Couldn't translate between host domain %d and target domain %d\n", host_domain, target_domain); return value; } @@ -1609,7 +1609,7 @@ VkResult WINAPI wine_vkGetPhysicalDeviceCalibrateableTimeDomainsEXT(VkPhysicalDe else if (host_time_domains[i] == VK_TIME_DOMAIN_CLOCK_MONOTONIC_RAW_EXT) supports_monotonic_raw = TRUE; else - FIXME("Unknown time domain %d", host_time_domains[i]); + FIXME("Unknown time domain %d\n", host_time_domains[i]); } heap_free(host_time_domains); @@ -1622,7 +1622,7 @@ VkResult WINAPI wine_vkGetPhysicalDeviceCalibrateableTimeDomainsEXT(VkPhysicalDe else if (supports_monotonic && performance_counter_domain == VK_TIME_DOMAIN_CLOCK_MONOTONIC_EXT) out_time_domains[out_time_domain_count++] = VK_TIME_DOMAIN_QUERY_PERFORMANCE_COUNTER_EXT; else - FIXME("VK_TIME_DOMAIN_QUERY_PERFORMANCE_COUNTER_EXT not supported on this platform."); + FIXME("VK_TIME_DOMAIN_QUERY_PERFORMANCE_COUNTER_EXT not supported on this platform.\n"); /* Forward the device domain time */ if (supports_device)

1 0

Gijs Vermeulen : include: Fix IWMSyncReader2 uuid.
by Alexandre Julliard 02 Mar '21

02 Mar '21

Module: wine Branch: master Commit: 6170749eab344feb469fcc13e0febf02d511aef5 URL: https://source.winehq.org/git/wine.git/?a=commit;h=6170749eab344feb469fcc13… Author: Gijs Vermeulen <gijsvrm(a)gmail.com> Date: Mon Mar 1 12:15:27 2021 +0100 include: Fix IWMSyncReader2 uuid. Signed-off-by: Gijs Vermeulen <gijsvrm(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- include/wmsdkidl.idl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/wmsdkidl.idl b/include/wmsdkidl.idl index d1e0445470d..716abe056db 100644 --- a/include/wmsdkidl.idl +++ b/include/wmsdkidl.idl @@ -1093,7 +1093,7 @@ interface IWMReaderAllocatorEx : IUnknown [ object, - uuid(faed3d21-1b6b-4af7-8bc6-3e189bbc187b), + uuid(faed3d21-1b6b-4af7-8cb6-3e189bbc187b), pointer_default( unique ), local ]

1 0

Gijs Vermeulen : wmvcore: Upgrade to IWMSyncReader2.
by Alexandre Julliard 02 Mar '21

02 Mar '21

Module: wine Branch: master Commit: 7fa74fa78e2f8fedeea6fa3c796f0f2eb202825e URL: https://source.winehq.org/git/wine.git/?a=commit;h=7fa74fa78e2f8fedeea6fa3c… Author: Gijs Vermeulen <gijsvrm(a)gmail.com> Date: Mon Mar 1 12:15:28 2021 +0100 wmvcore: Upgrade to IWMSyncReader2. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=50740 Signed-off-by: Gijs Vermeulen <gijsvrm(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/wmvcore/reader.c | 168 +++++++++++++++++++++++++++++++++----------------- 1 file changed, 111 insertions(+), 57 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=7fa74fa78e2f8fedeea6…

1 0