April 2021 - Wine-commits - list.winehq.org

Alexandre Julliard : makefiles: Install PE fake dlls in the architecture-specific directory.
by Alexandre Julliard 26 Apr '21

26 Apr '21

Module: wine Branch: master Commit: 893febda143ccf4e4499d411fd28ab2f225aea09 URL: https://source.winehq.org/git/wine.git/?a=commit;h=893febda143ccf4e4499d411… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Mon Apr 26 16:56:34 2021 +0200 makefiles: Install PE fake dlls in the architecture-specific directory. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/ntdll/loader.c | 6 ------ dlls/setupapi/fakedll.c | 6 ------ tools/makedep.c | 2 +- 3 files changed, 1 insertion(+), 13 deletions(-) diff --git a/dlls/ntdll/loader.c b/dlls/ntdll/loader.c index 85ae6aac15f..b76a8137a1b 100644 --- a/dlls/ntdll/loader.c +++ b/dlls/ntdll/loader.c @@ -2669,12 +2669,6 @@ static NTSTATUS find_builtin_without_file( const WCHAR *name, UNICODE_STRING *ne status = open_dll_file( new_name, pwm, mapping, image_info, id ); if (status == STATUS_IMAGE_MACHINE_TYPE_MISMATCH) found_image = TRUE; else if (status != STATUS_DLL_NOT_FOUND) goto done; - new_name->Length = len; - RtlAppendUnicodeToString( new_name, L"\\fakedlls\\" ); - RtlAppendUnicodeToString( new_name, name ); - status = open_dll_file( new_name, pwm, mapping, image_info, id ); - if (status == STATUS_IMAGE_MACHINE_TYPE_MISMATCH) found_image = TRUE; - else if (status != STATUS_DLL_NOT_FOUND) goto done; RtlFreeUnicodeString( new_name ); } if (found_image) status = STATUS_IMAGE_MACHINE_TYPE_MISMATCH; diff --git a/dlls/setupapi/fakedll.c b/dlls/setupapi/fakedll.c index 68d0bd0bc69..203d7c393ce 100644 --- a/dlls/setupapi/fakedll.c +++ b/dlls/setupapi/fakedll.c @@ -474,9 +474,6 @@ static void *load_fake_dll( const WCHAR *name, SIZE_T *size ) if ((res = read_file( ptr, &data, size ))) break; ptr = prepend( file + pos, path, lstrlenW(path) ); if ((res = read_file( ptr, &data, size ))) break; - ptr = prepend( file + pos, L"\\fakedlls", 9 ); - ptr = prepend( ptr, path, lstrlenW(path) ); - if ((res = read_file( ptr, &data, size ))) break; } done: @@ -1042,9 +1039,6 @@ static BOOL create_wildcard_dlls( const WCHAR *dirname, const WCHAR *wildcard, B install_lib_dir( dest, file, wildcard, NULL, delete ); lstrcpyW( file, path ); install_lib_dir( dest, file, wildcard, NULL, delete ); - lstrcpyW( file, path ); - lstrcatW( file, L"\\fakedlls" ); - install_lib_dir( dest, file, wildcard, NULL, delete ); } HeapFree( GetProcessHeap(), 0, file ); HeapFree( GetProcessHeap(), 0, dest ); diff --git a/tools/makedep.c b/tools/makedep.c index a6d525a92e8..0092f22b3b0 100644 --- a/tools/makedep.c +++ b/tools/makedep.c @@ -3315,7 +3315,7 @@ static void output_module( struct makefile *make ) add_install_rule( make, make->module, strmake( "%s%s", make->module, dll_ext ), strmake( "p$(dlldir)/%s%s", make->module, dll_ext )); add_install_rule( make, make->module, strmake( "%s.fake", make->module ), - strmake( "d$(dlldir)/fakedlls/%s", make->module )); + strmake( "d%s/%s", pe_dir, make->module )); output( "%s%s %s.fake:", module_path, dll_ext, module_path ); } else

1 0

Henri Verbeet : wined3d: Correct the wined3d_device_set_blend_state() .spec entry.
by Alexandre Julliard 26 Apr '21

26 Apr '21

Module: wine Branch: master Commit: e6d9538c7d098dfa404c42d9020e4fde803e0e87 URL: https://source.winehq.org/git/wine.git/?a=commit;h=e6d9538c7d098dfa404c42d9… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Mon Apr 26 13:41:33 2021 +0200 wined3d: Correct the wined3d_device_set_blend_state() .spec entry. Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/wined3d/wined3d.spec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/wined3d/wined3d.spec b/dlls/wined3d/wined3d.spec index 203ffd67b89..3d10509c389 100644 --- a/dlls/wined3d/wined3d.spec +++ b/dlls/wined3d/wined3d.spec @@ -95,7 +95,7 @@ @ cdecl wined3d_device_release_focus_window(ptr) @ cdecl wined3d_device_reset(ptr ptr ptr ptr long) @ cdecl wined3d_device_set_base_vertex_index(ptr long) -@ cdecl wined3d_device_set_blend_state(ptr ptr ptr) +@ cdecl wined3d_device_set_blend_state(ptr ptr ptr long) @ cdecl wined3d_device_set_clip_status(ptr ptr) @ cdecl wined3d_device_set_compute_shader(ptr ptr) @ cdecl wined3d_device_set_constant_buffer(ptr long long ptr)

1 0

Henri Verbeet : wined3d: Correct the wined3d_device_set_depth_stencil_state() .spec entry.
by Alexandre Julliard 26 Apr '21

26 Apr '21

Module: wine Branch: master Commit: 0184f1d2422a14eafa015e8c2b6984f897811894 URL: https://source.winehq.org/git/wine.git/?a=commit;h=0184f1d2422a14eafa015e8c… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Mon Apr 26 13:41:34 2021 +0200 wined3d: Correct the wined3d_device_set_depth_stencil_state() .spec entry. Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/wined3d/wined3d.spec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/wined3d/wined3d.spec b/dlls/wined3d/wined3d.spec index 3d10509c389..1ea837cc59a 100644 --- a/dlls/wined3d/wined3d.spec +++ b/dlls/wined3d/wined3d.spec @@ -104,7 +104,7 @@ @ cdecl wined3d_device_set_cs_uav(ptr long ptr long) @ cdecl wined3d_device_set_cursor_position(ptr long long long) @ cdecl wined3d_device_set_cursor_properties(ptr long long ptr long) -@ cdecl wined3d_device_set_depth_stencil_state(ptr ptr) +@ cdecl wined3d_device_set_depth_stencil_state(ptr ptr long) @ cdecl wined3d_device_set_depth_stencil_view(ptr ptr) @ cdecl wined3d_device_set_dialog_box_mode(ptr long) @ cdecl wined3d_device_set_domain_shader(ptr ptr)

1 0

Henri Verbeet : ntdll: Clear ret->Buffer on failure in get_env_var() (Valgrind).
by Alexandre Julliard 26 Apr '21

26 Apr '21

Module: wine Branch: master Commit: b9070e115369118a8655f6e6c306ff51af31a242 URL: https://source.winehq.org/git/wine.git/?a=commit;h=b9070e115369118a8655f6e6… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Mon Apr 26 13:41:35 2021 +0200 ntdll: Clear ret->Buffer on failure in get_env_var() (Valgrind). Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/ntdll/loader.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/dlls/ntdll/loader.c b/dlls/ntdll/loader.c index b76a8137a1b..ee453700e51 100644 --- a/dlls/ntdll/loader.c +++ b/dlls/ntdll/loader.c @@ -2616,7 +2616,11 @@ static NTSTATUS get_env_var( const WCHAR *name, SIZE_T extra, UNICODE_STRING *re return status; } RtlFreeHeap( GetProcessHeap(), 0, ret->Buffer ); - if (status != STATUS_BUFFER_TOO_SMALL) return status; + if (status != STATUS_BUFFER_TOO_SMALL) + { + ret->Buffer = NULL; + return status; + } size = len + 1 + extra; } }

1 0

Henri Verbeet : explorer: Initialise window->pidl to NULL in shellwindows_Register().
by Alexandre Julliard 26 Apr '21

26 Apr '21

Module: wine Branch: master Commit: 6b49b50bbe16b6100a8efd0f1b6417279fa8574b URL: https://source.winehq.org/git/wine.git/?a=commit;h=6b49b50bbe16b6100a8efd0f… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Mon Apr 26 13:41:36 2021 +0200 explorer: Initialise window->pidl to NULL in shellwindows_Register(). Since array_reserve() doesn't. Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- programs/explorer/desktop.c | 1 + 1 file changed, 1 insertion(+) diff --git a/programs/explorer/desktop.c b/programs/explorer/desktop.c index 94d178880a8..51d1535aea6 100644 --- a/programs/explorer/desktop.c +++ b/programs/explorer/desktop.c @@ -1219,6 +1219,7 @@ static HRESULT WINAPI shellwindows_Register(IShellWindows *iface, window->hwnd = hwnd; window->class = class; *cookie = window->cookie = ++cookie_counter; + window->pidl = NULL; LeaveCriticalSection(&sw->cs); return S_OK;

1 0

Alex Henrie : kernel32: Print processor group in Get(Active|Maximum)ProcessorCount.
by Alexandre Julliard 26 Apr '21

26 Apr '21

Module: wine Branch: master Commit: 1e9757778c04679a51c7f5cbf425d794e2e3ade1 URL: https://source.winehq.org/git/wine.git/?a=commit;h=1e9757778c04679a51c7f5cb… Author: Alex Henrie <alexhenrie24(a)gmail.com> Date: Mon Apr 26 01:19:14 2021 -0600 kernel32: Print processor group in Get(Active|Maximum)ProcessorCount. Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/kernel32/process.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/kernel32/process.c b/dlls/kernel32/process.c index f07a997bea3..b31d73bc5a5 100644 --- a/dlls/kernel32/process.c +++ b/dlls/kernel32/process.c @@ -620,7 +620,7 @@ DWORD WINAPI GetActiveProcessorCount(WORD group) { DWORD cpus = system_info.NumberOfProcessors; - FIXME("semi-stub, returning %u\n", cpus); + FIXME("(0x%x): semi-stub, returning %u\n", group, cpus); return cpus; } @@ -631,7 +631,7 @@ DWORD WINAPI GetMaximumProcessorCount(WORD group) { DWORD cpus = system_info.NumberOfProcessors; - FIXME("semi-stub, returning %u\n", cpus); + FIXME("(0x%x): semi-stub, returning %u\n", group, cpus); return cpus; }

1 0

Rémi Bernon : mscoree: Initialize parsed_config_file private_path.
by Alexandre Julliard 26 Apr '21

26 Apr '21

Module: wine Branch: master Commit: 7cc8df67c31322df65ef3069f2e7c0e82856080c URL: https://source.winehq.org/git/wine.git/?a=commit;h=7cc8df67c31322df65ef3069… Author: Rémi Bernon <rbernon(a)codeweavers.com> Date: Thu Apr 22 21:06:16 2021 +0200 mscoree: Initialize parsed_config_file private_path. In case of error we may free uninitialized pointer otherwise. Signed-off-by: Rémi Bernon <rbernon(a)codeweavers.com> Signed-off-by: Esme Povirk <esme(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/mscoree/config.c | 1 + 1 file changed, 1 insertion(+) diff --git a/dlls/mscoree/config.c b/dlls/mscoree/config.c index 38f304f3df8..b6aa647d876 100644 --- a/dlls/mscoree/config.c +++ b/dlls/mscoree/config.c @@ -617,6 +617,7 @@ static const struct ISAXErrorHandlerVtbl ConfigFileHandlerErrorVtbl = static void init_config(parsed_config_file *config) { list_init(&config->supported_runtimes); + config->private_path = NULL; } static HRESULT parse_config(VARIANT input, parsed_config_file *result)

1 0

Ziqing Hui : windowscodecs: Add stub for DdsFrameEncode.
by Alexandre Julliard 26 Apr '21

26 Apr '21

Module: wine Branch: master Commit: 0737c3c2159fc59850966d4238bac4ff0ba3e449 URL: https://source.winehq.org/git/wine.git/?a=commit;h=0737c3c2159fc59850966d42… Author: Ziqing Hui <zhui(a)codeweavers.com> Date: Sat Apr 24 14:07:14 2021 +0800 windowscodecs: Add stub for DdsFrameEncode. Signed-off-by: Ziqing Hui <zhui(a)codeweavers.com> Signed-off-by: Esme Povirk <esme(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/windowscodecs/ddsformat.c | 234 ++++++++++++++++++++++++++++++++++++++++- 1 file changed, 231 insertions(+), 3 deletions(-) diff --git a/dlls/windowscodecs/ddsformat.c b/dlls/windowscodecs/ddsformat.c index 873d4f1bb1f..ef6571842dd 100644 --- a/dlls/windowscodecs/ddsformat.c +++ b/dlls/windowscodecs/ddsformat.c @@ -169,6 +169,18 @@ typedef struct DdsEncoder { BOOL committed; } DdsEncoder; +typedef struct DdsFrameEncode { + IWICBitmapFrameEncode IWICBitmapFrameEncode_iface; + LONG ref; + DdsEncoder *parent; + BOOL initialized; + BOOL frame_created; + UINT width; + UINT height; + double dpi_x; + double dpi_y; +} DdsFrameEncode; + static struct dds_format { DDS_PIXELFORMAT pixel_format; const GUID *wic_format; @@ -698,6 +710,11 @@ static inline DdsEncoder *impl_from_IWICBitmapEncoder(IWICBitmapEncoder *iface) return CONTAINING_RECORD(iface, DdsEncoder, IWICBitmapEncoder_iface); } +static inline DdsFrameEncode *impl_from_IWICBitmapFrameEncode(IWICBitmapFrameEncode *iface) +{ + return CONTAINING_RECORD(iface, DdsFrameEncode, IWICBitmapFrameEncode_iface); +} + static HRESULT WINAPI DdsFrameDecode_QueryInterface(IWICBitmapFrameDecode *iface, REFIID iid, void **ppv) { @@ -1482,6 +1499,185 @@ static const IWICWineDecoderVtbl DdsDecoder_Wine_Vtbl = { DdsDecoder_Wine_Initialize }; +static HRESULT WINAPI DdsFrameEncode_QueryInterface(IWICBitmapFrameEncode *iface, REFIID iid, void **ppv) +{ + DdsFrameEncode *This = impl_from_IWICBitmapFrameEncode(iface); + TRACE("(%p,%s,%p)\n", iface, debugstr_guid(iid), ppv); + + if (!ppv) return E_INVALIDARG; + + if (IsEqualIID(&IID_IUnknown, iid) || + IsEqualIID(&IID_IWICBitmapFrameEncode, iid)) + { + *ppv = &This->IWICBitmapFrameEncode_iface; + } + else + { + *ppv = NULL; + return E_NOINTERFACE; + } + + IUnknown_AddRef((IUnknown*)*ppv); + return S_OK; +} + +static ULONG WINAPI DdsFrameEncode_AddRef(IWICBitmapFrameEncode *iface) +{ + DdsFrameEncode *This = impl_from_IWICBitmapFrameEncode(iface); + ULONG ref = InterlockedIncrement(&This->ref); + + TRACE("(%p) refcount=%u\n", iface, ref); + + return ref; +} + +static ULONG WINAPI DdsFrameEncode_Release(IWICBitmapFrameEncode *iface) +{ + DdsFrameEncode *This = impl_from_IWICBitmapFrameEncode(iface); + ULONG ref = InterlockedDecrement(&This->ref); + + TRACE("(%p) refcount=%u\n", iface, ref); + + if (ref == 0) + { + IWICBitmapEncoder_Release(&This->parent->IWICBitmapEncoder_iface); + HeapFree(GetProcessHeap(), 0, This); + } + + return ref; +} + +static HRESULT WINAPI DdsFrameEncode_Initialize(IWICBitmapFrameEncode *iface, + IPropertyBag2 *encoderOptions) +{ + FIXME("(%p,%p): stub\n", iface, encoderOptions); + return E_NOTIMPL; +} + +static HRESULT WINAPI DdsFrameEncode_SetSize(IWICBitmapFrameEncode *iface, + UINT width, UINT height) +{ + DdsFrameEncode *This = impl_from_IWICBitmapFrameEncode(iface); + HRESULT hr; + + TRACE("(%p,%u,%u)\n", iface, width, height); + + EnterCriticalSection(&This->parent->lock); + + if (!This->initialized || This->frame_created) + { + hr = WINCODEC_ERR_WRONGSTATE; + } + else + { + This->width = width; + This->height = height; + hr = S_OK; + } + + LeaveCriticalSection(&This->parent->lock); + + return hr; +} + +static HRESULT WINAPI DdsFrameEncode_SetResolution(IWICBitmapFrameEncode *iface, + double dpiX, double dpiY) +{ + DdsFrameEncode *This = impl_from_IWICBitmapFrameEncode(iface); + HRESULT hr; + + TRACE("(%p,%0.2f,%0.2f)\n", iface, dpiX, dpiY); + + EnterCriticalSection(&This->parent->lock); + + if (!This->initialized || This->frame_created) + { + hr = WINCODEC_ERR_WRONGSTATE; + } + else + { + This->dpi_x = dpiX; + This->dpi_y = dpiY; + hr = S_OK; + } + + LeaveCriticalSection(&This->parent->lock); + + return hr; +} + +static HRESULT WINAPI DdsFrameEncode_SetPixelFormat(IWICBitmapFrameEncode *iface, + WICPixelFormatGUID *pixelFormat) +{ + FIXME("(%p,%s): stub\n", iface, debugstr_guid(pixelFormat)); + return E_NOTIMPL; +} + +static HRESULT WINAPI DdsFrameEncode_SetColorContexts(IWICBitmapFrameEncode *iface, + UINT count, IWICColorContext **colorContext) +{ + FIXME("(%p,%u,%p): stub\n", iface, count, colorContext); + return E_NOTIMPL; +} + +static HRESULT WINAPI DdsFrameEncode_SetPalette(IWICBitmapFrameEncode *iface, + IWICPalette *palette) +{ + FIXME("(%p,%p): stub\n", iface, palette); + return E_NOTIMPL; +} + +static HRESULT WINAPI DdsFrameEncode_SetThumbnail(IWICBitmapFrameEncode *iface, + IWICBitmapSource *thumbnail) +{ + TRACE("(%p,%p)\n", iface, thumbnail); + return WINCODEC_ERR_UNSUPPORTEDOPERATION; +} + +static HRESULT WINAPI DdsFrameEncode_WritePixels(IWICBitmapFrameEncode *iface, + UINT lineCount, UINT stride, UINT bufferSize, BYTE *pixels) +{ + FIXME("(%p,%u,%u,%u,%p): stub\n", iface, lineCount, stride, bufferSize, pixels); + return E_NOTIMPL; +} + +static HRESULT WINAPI DdsFrameEncode_WriteSource(IWICBitmapFrameEncode *iface, + IWICBitmapSource *bitmapSource, WICRect *rc) +{ + FIXME("(%p,%p,%s): stub\n", iface, bitmapSource, debug_wic_rect(rc)); + return E_NOTIMPL; +} + +static HRESULT WINAPI DdsFrameEncode_Commit(IWICBitmapFrameEncode *iface) +{ + FIXME("(%p): stub\n", iface); + return E_NOTIMPL; +} + +static HRESULT WINAPI DdsFrameEncode_GetMetadataQueryWriter(IWICBitmapFrameEncode *iface, + IWICMetadataQueryWriter **metadataQueryWriter) +{ + FIXME("(%p,%p): stub\n", iface, metadataQueryWriter); + return E_NOTIMPL; +} + +static const IWICBitmapFrameEncodeVtbl DdsFrameEncode_Vtbl = { + DdsFrameEncode_QueryInterface, + DdsFrameEncode_AddRef, + DdsFrameEncode_Release, + DdsFrameEncode_Initialize, + DdsFrameEncode_SetSize, + DdsFrameEncode_SetResolution, + DdsFrameEncode_SetPixelFormat, + DdsFrameEncode_SetColorContexts, + DdsFrameEncode_SetPalette, + DdsFrameEncode_SetThumbnail, + DdsFrameEncode_WritePixels, + DdsFrameEncode_WriteSource, + DdsFrameEncode_Commit, + DdsFrameEncode_GetMetadataQueryWriter +}; + HRESULT DdsDecoder_CreateInstance(REFIID iid, void** ppv) { DdsDecoder *This; @@ -1628,10 +1824,42 @@ static HRESULT WINAPI DdsEncoder_SetPreview(IWICBitmapEncoder *iface, IWICBitmap } static HRESULT WINAPI DdsEncoder_CreateNewFrame(IWICBitmapEncoder *iface, - IWICBitmapFrameEncode **ppIFrameEncode, IPropertyBag2 **ppIEncoderOptions) + IWICBitmapFrameEncode **frameEncode, IPropertyBag2 **encoderOptions) { - FIXME("(%p,%p,%p): stub\n", iface, ppIFrameEncode, ppIEncoderOptions); - return E_NOTIMPL; + DdsEncoder *This = impl_from_IWICBitmapEncoder(iface); + DdsFrameEncode *result; + HRESULT hr; + + TRACE("(%p,%p,%p)\n", iface, frameEncode, encoderOptions); + + EnterCriticalSection(&This->lock); + + if (!This->stream) + { + hr = WINCODEC_ERR_WRONGSTATE; + goto end; + } + + result = HeapAlloc(GetProcessHeap(), 0, sizeof(*result)); + if (!result) + { + hr = E_OUTOFMEMORY; + goto end; + } + + result->IWICBitmapFrameEncode_iface.lpVtbl = &DdsFrameEncode_Vtbl; + result->ref = 1; + result->parent = This; + result->initialized = FALSE; + result->frame_created = FALSE; + IWICBitmapEncoder_AddRef(iface); + + *frameEncode = &result->IWICBitmapFrameEncode_iface; + hr = S_OK; + +end: + LeaveCriticalSection(&This->lock); + return hr; } static HRESULT WINAPI DdsEncoder_Commit(IWICBitmapEncoder *iface)

1 0

Sven Baars : dwrite: Fix some memory leaks (Coverity).
by Alexandre Julliard 26 Apr '21

26 Apr '21

Module: wine Branch: master Commit: 7ed4810a0ea06f19b2de82f765a916e6faffd1cc URL: https://source.winehq.org/git/wine.git/?a=commit;h=7ed4810a0ea06f19b2de82f7… Author: Sven Baars <sbaars(a)codeweavers.com> Date: Sat Apr 24 13:24:06 2021 +0200 dwrite: Fix some memory leaks (Coverity). Signed-off-by: Sven Baars <sbaars(a)codeweavers.com> Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/dwrite/font.c | 3 +++ dlls/dwrite/main.c | 1 + 2 files changed, 4 insertions(+) diff --git a/dlls/dwrite/font.c b/dlls/dwrite/font.c index 44a61aba1ef..d25ba2dd06b 100644 --- a/dlls/dwrite/font.c +++ b/dlls/dwrite/font.c @@ -4484,7 +4484,10 @@ HRESULT create_font_collection(IDWriteFactory7 *factory, IDWriteFontFileEnumerat } if (FAILED(hr)) + { + release_font_data(font_data); break; + } } IDWriteFontFileStream_Release(stream); diff --git a/dlls/dwrite/main.c b/dlls/dwrite/main.c index 825e323b468..2a0b69400f4 100644 --- a/dlls/dwrite/main.c +++ b/dlls/dwrite/main.c @@ -1590,6 +1590,7 @@ static HRESULT create_system_path_list(WCHAR ***ret, unsigned int *ret_count) index++; } + heap_free(value); heap_free(name); *ret = paths;

1 0

Sven Baars : ddraw/tests: Move a misplaced assignment (Coverity).
by Alexandre Julliard 26 Apr '21

26 Apr '21

Module: wine Branch: master Commit: 50c541176f9120ec463d91ada59a167bae36d402 URL: https://source.winehq.org/git/wine.git/?a=commit;h=50c541176f9120ec463d91ad… Author: Sven Baars <sbaars(a)codeweavers.com> Date: Sat Apr 24 13:24:05 2021 +0200 ddraw/tests: Move a misplaced assignment (Coverity). Signed-off-by: Sven Baars <sbaars(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/ddraw/tests/ddraw2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/ddraw/tests/ddraw2.c b/dlls/ddraw/tests/ddraw2.c index 5536625abdd..a1d4dd942fa 100644 --- a/dlls/ddraw/tests/ddraw2.c +++ b/dlls/ddraw/tests/ddraw2.c @@ -1342,9 +1342,9 @@ static void test_depth_blit(const GUID *device_guid) hr = IDirectDrawSurface_GetSurfaceDesc(ds1, &ddsd_existing); ok(hr == D3D_OK, "Got unexpected hr %#x.\n", hr); ddsd_new.dwFlags = DDSD_CAPS | DDSD_WIDTH | DDSD_HEIGHT | DDSD_PIXELFORMAT; + ddsd_new.ddsCaps.dwCaps = DDSCAPS_ZBUFFER; if (is_software_device_type(device_guid)) ddsd_new.ddsCaps.dwCaps |= DDSCAPS_SYSTEMMEMORY; - ddsd_new.ddsCaps.dwCaps = DDSCAPS_ZBUFFER; ddsd_new.dwWidth = ddsd_existing.dwWidth; ddsd_new.dwHeight = ddsd_existing.dwHeight; ddsd_new.ddpfPixelFormat = ddsd_existing.ddpfPixelFormat;

1 0