July 2021 - Wine-commits - list.winehq.org

Huw Davies : mountmgr.sys: Move dhcp lookup to a worker thread.
by Alexandre Julliard 06 Jul '21

06 Jul '21

Module: wine Branch: master Commit: 715edfb0b2c42ae79a60300b87eca000c6e59cd2 URL: https://source.winehq.org/git/wine.git/?a=commit;h=715edfb0b2c42ae79a60300b… Author: Huw Davies <huw(a)codeweavers.com> Date: Tue Jul 6 10:11:47 2021 +0100 mountmgr.sys: Move dhcp lookup to a worker thread. While this is a reasonable change per se, the motivation is to avoid a deadlock when mountmgr.sys calls into iphlpapi and further into nsiproxy.sys via the nsi device. nsiproxy.sys is hosted by the same process as mountmgr.sys so is unable to handle the request while it is also waiting for that same request to return. The correct long-term solution is for mountmgr.sys to call the netio.sys versions of the iphlpapi functions. These will call the kernel-side versions of the nsi functions without going through the nsi device. Signed-off-by: Huw Davies <huw(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/mountmgr.sys/mountmgr.c | 46 +++++++++++++++++++++++++++++--------------- 1 file changed, 31 insertions(+), 15 deletions(-) diff --git a/dlls/mountmgr.sys/mountmgr.c b/dlls/mountmgr.sys/mountmgr.c index 61d51d8e61d..b94944a350c 100644 --- a/dlls/mountmgr.sys/mountmgr.c +++ b/dlls/mountmgr.sys/mountmgr.c @@ -286,32 +286,48 @@ static NTSTATUS define_unix_drive( const void *in_buff, SIZE_T insize ) } /* implementation of IOCTL_MOUNTMGR_QUERY_DHCP_REQUEST_PARAMS */ -static NTSTATUS query_dhcp_request_params( void *buff, SIZE_T insize, - SIZE_T outsize, IO_STATUS_BLOCK *iosb ) +static void WINAPI query_dhcp_request_params( TP_CALLBACK_INSTANCE *instance, void *context ) { - struct mountmgr_dhcp_request_params *query = buff; - ULONG i, offset; + IRP *irp = context; + struct mountmgr_dhcp_request_params *query = irp->AssociatedIrp.SystemBuffer; + IO_STACK_LOCATION *irpsp = IoGetCurrentIrpStackLocation( irp ); + SIZE_T insize = irpsp->Parameters.DeviceIoControl.InputBufferLength; + SIZE_T outsize = irpsp->Parameters.DeviceIoControl.OutputBufferLength; + ULONG i, offset = 0; /* sanity checks */ if (FIELD_OFFSET(struct mountmgr_dhcp_request_params, params[query->count]) > insize || - !memchrW( query->adapter, 0, ARRAY_SIZE(query->adapter) )) return STATUS_INVALID_PARAMETER; + !memchrW( query->adapter, 0, ARRAY_SIZE(query->adapter) )) + { + irp->IoStatus.u.Status = STATUS_INVALID_PARAMETER; + goto err; + } + for (i = 0; i < query->count; i++) - if (query->params[i].offset + query->params[i].size > insize) return STATUS_INVALID_PARAMETER; + if (query->params[i].offset + query->params[i].size > insize) + { + irp->IoStatus.u.Status = STATUS_INVALID_PARAMETER; + goto err; + } + offset = FIELD_OFFSET(struct mountmgr_dhcp_request_params, params[query->count]); for (i = 0; i < query->count; i++) { - offset += get_dhcp_request_param( query->adapter, &query->params[i], buff, offset, outsize - offset ); + offset += get_dhcp_request_param( query->adapter, &query->params[i], (char *)query, offset, outsize - offset ); if (offset > outsize) { if (offset >= sizeof(query->size)) query->size = offset; - iosb->Information = sizeof(query->size); - return STATUS_MORE_ENTRIES; + offset = sizeof(query->size); + irp->IoStatus.u.Status = STATUS_MORE_ENTRIES; + goto err; } } + irp->IoStatus.u.Status = STATUS_SUCCESS; - iosb->Information = offset; - return STATUS_SUCCESS; +err: + irp->IoStatus.Information = offset; + IoCompleteRequest( irp, IO_NO_INCREMENT ); } /* implementation of Wine extension to use host APIs to find symbol file by GUID */ @@ -929,10 +945,10 @@ static NTSTATUS WINAPI mountmgr_ioctl( DEVICE_OBJECT *device, IRP *irp ) status = STATUS_INVALID_PARAMETER; break; } - status = query_dhcp_request_params( irp->AssociatedIrp.SystemBuffer, - irpsp->Parameters.DeviceIoControl.InputBufferLength, - irpsp->Parameters.DeviceIoControl.OutputBufferLength, - &irp->IoStatus ); + + if (TrySubmitThreadpoolCallback( query_dhcp_request_params, irp, NULL )) + return (irp->IoStatus.u.Status = STATUS_PENDING); + status = STATUS_NO_MEMORY; break; #ifdef __APPLE__ case IOCTL_MOUNTMGR_QUERY_SYMBOL_FILE:

1 0

Huw Davies : iphlpapi: Implement ConvertInterfaceIndexToLuid() on top of nsi.
by Alexandre Julliard 06 Jul '21

06 Jul '21

Module: wine Branch: master Commit: a124b765b1377fea8a2fe88dc1ae191c8bf83b3f URL: https://source.winehq.org/git/wine.git/?a=commit;h=a124b765b1377fea8a2fe88d… Author: Huw Davies <huw(a)codeweavers.com> Date: Tue Jul 6 10:11:48 2021 +0100 iphlpapi: Implement ConvertInterfaceIndexToLuid() on top of nsi. Signed-off-by: Huw Davies <huw(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/iphlpapi/Makefile.in | 2 +- dlls/iphlpapi/iphlpapi_main.c | 18 ++++++++---------- 2 files changed, 9 insertions(+), 11 deletions(-) diff --git a/dlls/iphlpapi/Makefile.in b/dlls/iphlpapi/Makefile.in index 3a2227f5ebb..3db17289bf4 100644 --- a/dlls/iphlpapi/Makefile.in +++ b/dlls/iphlpapi/Makefile.in @@ -1,6 +1,6 @@ MODULE = iphlpapi.dll IMPORTLIB = iphlpapi -IMPORTS = advapi32 +IMPORTS = advapi32 nsi uuid EXTRALIBS = $(RESOLV_LIBS) $(KSTAT_LIBS) $(PROCSTAT_LIBS) C_SRCS = \ diff --git a/dlls/iphlpapi/iphlpapi_main.c b/dlls/iphlpapi/iphlpapi_main.c index b6b96165027..05f3c3b9b76 100644 --- a/dlls/iphlpapi/iphlpapi_main.c +++ b/dlls/iphlpapi/iphlpapi_main.c @@ -56,7 +56,9 @@ #include "netioapi.h" #include "tcpestats.h" #include "ip2string.h" +#include "netiodef.h" +#include "wine/nsi.h" #include "wine/debug.h" #include "wine/unicode.h" @@ -3183,20 +3185,16 @@ DWORD WINAPI ConvertInterfaceGuidToLuid(const GUID *guid, NET_LUID *luid) */ DWORD WINAPI ConvertInterfaceIndexToLuid(NET_IFINDEX index, NET_LUID *luid) { - MIB_IFROW row; + DWORD err; - TRACE("(%u %p)\n", index, luid); + TRACE( "(%u %p)\n", index, luid ); if (!luid) return ERROR_INVALID_PARAMETER; - memset( luid, 0, sizeof(*luid) ); - - row.dwIndex = index; - if (GetIfEntry( &row )) return ERROR_FILE_NOT_FOUND; - luid->Info.Reserved = 0; - luid->Info.NetLuidIndex = index; - luid->Info.IfType = row.dwType; - return NO_ERROR; + err = NsiGetParameter( 1, &NPI_MS_NDIS_MODULEID, NSI_NDIS_INDEX_LUID_TABLE, &index, sizeof(index), + NSI_PARAM_TYPE_STATIC, luid, sizeof(*luid), 0 ); + if (err) luid->Value = 0; + return err; } /******************************************************************

1 0

Huw Davies : iphlpapi: Implement ConvertInterfaceLuidToIndex() on top of nsi.
by Alexandre Julliard 06 Jul '21

06 Jul '21

Module: wine Branch: master Commit: 4add1d79e7ccf389b93229fec8c8994c4406424e URL: https://source.winehq.org/git/wine.git/?a=commit;h=4add1d79e7ccf389b93229fe… Author: Huw Davies <huw(a)codeweavers.com> Date: Tue Jul 6 10:11:49 2021 +0100 iphlpapi: Implement ConvertInterfaceLuidToIndex() on top of nsi. Signed-off-by: Huw Davies <huw(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/iphlpapi/iphlpapi_main.c | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/dlls/iphlpapi/iphlpapi_main.c b/dlls/iphlpapi/iphlpapi_main.c index 05f3c3b9b76..4d3ee86da0b 100644 --- a/dlls/iphlpapi/iphlpapi_main.c +++ b/dlls/iphlpapi/iphlpapi_main.c @@ -3223,18 +3223,17 @@ DWORD WINAPI ConvertInterfaceLuidToGuid(const NET_LUID *luid, GUID *guid) */ DWORD WINAPI ConvertInterfaceLuidToIndex(const NET_LUID *luid, NET_IFINDEX *index) { - DWORD ret; - MIB_IFROW row; + DWORD err; - TRACE("(%p %p)\n", luid, index); + TRACE( "(%p %p)\n", luid, index ); if (!luid || !index) return ERROR_INVALID_PARAMETER; - row.dwIndex = luid->Info.NetLuidIndex; - if ((ret = GetIfEntry( &row ))) return ret; - - *index = luid->Info.NetLuidIndex; - return NO_ERROR; + err = NsiGetParameter( 1, &NPI_MS_NDIS_MODULEID, NSI_NDIS_IFINFO_TABLE, luid, sizeof(*luid), + NSI_PARAM_TYPE_STATIC, index, sizeof(*index), + FIELD_OFFSET(struct nsi_ndis_ifinfo_static, if_index) ); + if (err) *index = 0; + return err; } /******************************************************************

1 0

Huw Davies : iphlpapi: Implement ConvertInterfaceGuidToLuid() on top of nsi.
by Alexandre Julliard 06 Jul '21

06 Jul '21

Module: wine Branch: master Commit: 13e596b3fefd4c1846f0c763c20696cf2cb3c021 URL: https://source.winehq.org/git/wine.git/?a=commit;h=13e596b3fefd4c1846f0c763… Author: Huw Davies <huw(a)codeweavers.com> Date: Tue Jul 6 10:11:50 2021 +0100 iphlpapi: Implement ConvertInterfaceGuidToLuid() on top of nsi. Signed-off-by: Huw Davies <huw(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/iphlpapi/iphlpapi_main.c | 29 ++++++++++++++++++++--------- 1 file changed, 20 insertions(+), 9 deletions(-) diff --git a/dlls/iphlpapi/iphlpapi_main.c b/dlls/iphlpapi/iphlpapi_main.c index 4d3ee86da0b..ee5718e5d26 100644 --- a/dlls/iphlpapi/iphlpapi_main.c +++ b/dlls/iphlpapi/iphlpapi_main.c @@ -3164,20 +3164,31 @@ ULONG WINAPI GetTcp6Table2(PMIB_TCP6TABLE2 table, PULONG size, BOOL order) */ DWORD WINAPI ConvertInterfaceGuidToLuid(const GUID *guid, NET_LUID *luid) { - DWORD ret; - MIB_IFROW row; + struct nsi_ndis_ifinfo_static *data; + DWORD err, count, i; + NET_LUID *keys; - TRACE("(%s %p)\n", debugstr_guid(guid), luid); + TRACE( "(%s %p)\n", debugstr_guid(guid), luid ); if (!guid || !luid) return ERROR_INVALID_PARAMETER; + luid->Value = 0; - row.dwIndex = guid->Data1; - if ((ret = GetIfEntry( &row ))) return ret; + err = NsiAllocateAndGetTable( 1, &NPI_MS_NDIS_MODULEID, NSI_NDIS_IFINFO_TABLE, (void **)&keys, sizeof(*keys), + NULL, 0, NULL, 0, (void **)&data, sizeof(*data), &count, 0 ); + if (err) return err; - luid->Info.Reserved = 0; - luid->Info.NetLuidIndex = guid->Data1; - luid->Info.IfType = row.dwType; - return NO_ERROR; + err = ERROR_INVALID_PARAMETER; + for (i = 0; i < count; i++) + { + if (IsEqualGUID( &data[i].if_guid, guid )) + { + luid->Value = keys[i].Value; + err = ERROR_SUCCESS; + break; + } + } + NsiFreeTable( keys, NULL, NULL, data ); + return err; } /******************************************************************

1 0

Huw Davies : iphlpapi: Implement ConvertInterfaceLuidToGuid() on top of nsi.
by Alexandre Julliard 06 Jul '21

06 Jul '21

Module: wine Branch: master Commit: 3bee9c080b620329b223f7ac6fda55a685c8b95e URL: https://source.winehq.org/git/wine.git/?a=commit;h=3bee9c080b620329b223f7ac… Author: Huw Davies <huw(a)codeweavers.com> Date: Tue Jul 6 10:11:51 2021 +0100 iphlpapi: Implement ConvertInterfaceLuidToGuid() on top of nsi. Signed-off-by: Huw Davies <huw(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/iphlpapi/iphlpapi_main.c | 17 +++++++---------- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/dlls/iphlpapi/iphlpapi_main.c b/dlls/iphlpapi/iphlpapi_main.c index ee5718e5d26..403b51391af 100644 --- a/dlls/iphlpapi/iphlpapi_main.c +++ b/dlls/iphlpapi/iphlpapi_main.c @@ -3213,20 +3213,17 @@ DWORD WINAPI ConvertInterfaceIndexToLuid(NET_IFINDEX index, NET_LUID *luid) */ DWORD WINAPI ConvertInterfaceLuidToGuid(const NET_LUID *luid, GUID *guid) { - DWORD ret; - MIB_IFROW row; + DWORD err; - TRACE("(%p %p)\n", luid, guid); + TRACE( "(%p %p)\n", luid, guid ); if (!luid || !guid) return ERROR_INVALID_PARAMETER; - row.dwIndex = luid->Info.NetLuidIndex; - if ((ret = GetIfEntry( &row ))) return ret; - - memset( guid, 0, sizeof(*guid) ); - guid->Data1 = luid->Info.NetLuidIndex; - memcpy( guid->Data4+2, "NetDev", 6 ); - return NO_ERROR; + err = NsiGetParameter( 1, &NPI_MS_NDIS_MODULEID, NSI_NDIS_IFINFO_TABLE, luid, sizeof(*luid), + NSI_PARAM_TYPE_STATIC, guid, sizeof(*guid), + FIELD_OFFSET(struct nsi_ndis_ifinfo_static, if_guid) ); + if (err) memset( guid, 0, sizeof(*guid) ); + return err; } /******************************************************************

1 0

Huw Davies : iphlpapi/tests: Run the interface conversion tests on all interfaces.
by Alexandre Julliard 06 Jul '21

06 Jul '21

Module: wine Branch: master Commit: e4e70f6755915dffdc8d6c0a60072572d14c5fcc URL: https://source.winehq.org/git/wine.git/?a=commit;h=e4e70f6755915dffdc8d6c0a… Author: Huw Davies <huw(a)codeweavers.com> Date: Tue Jul 6 10:11:52 2021 +0100 iphlpapi/tests: Run the interface conversion tests on all interfaces. Signed-off-by: Huw Davies <huw(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/iphlpapi/tests/iphlpapi.c | 341 ++++++++++++++++++----------------------- 1 file changed, 153 insertions(+), 188 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=e4e70f6755915dffdc8d…

1 0

Hugh McMaster : reg/tests: Split 'import' syntax tests into a separate function.
by Alexandre Julliard 06 Jul '21

06 Jul '21

Module: wine Branch: master Commit: e3d14e66f71193faeb532c28b5b5565d5ea9b12f URL: https://source.winehq.org/git/wine.git/?a=commit;h=e3d14e66f71193faeb532c28… Author: Hugh McMaster <hugh.mcmaster(a)outlook.com> Date: Tue Jul 6 23:06:20 2021 +1000 reg/tests: Split 'import' syntax tests into a separate function. Signed-off-by: Hugh McMaster <hugh.mcmaster(a)outlook.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- programs/reg/tests/import.c | 22 ++++++++++++++-------- 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/programs/reg/tests/import.c b/programs/reg/tests/import.c index ace45cf5984..598319628dc 100644 --- a/programs/reg/tests/import.c +++ b/programs/reg/tests/import.c @@ -93,15 +93,9 @@ BOOL import_reg(const char *file, unsigned line, const char *contents, BOOL unic /* Unit tests */ -static void test_import(void) +static void test_command_syntax(void) { - DWORD r, dword = 0x123, type, size; - char buffer[24]; - HKEY hkey, subkey = NULL; - LONG err; - BYTE hex[8]; - - delete_tree(HKEY_CURRENT_USER, KEY_BASE, 0); + DWORD r; run_reg_exe("reg import", &r); ok(r == REG_EXIT_FAILURE, "got exit code %d, expected 1\n", r); @@ -120,6 +114,17 @@ static void test_import(void) run_reg_exe("reg import a.reg b.reg", &r); ok(r == REG_EXIT_FAILURE, "got exit code %d, expected 1\n", r); +} + +static void test_import(void) +{ + DWORD r, dword = 0x123, type, size; + char buffer[24]; + HKEY hkey, subkey = NULL; + LONG err; + BYTE hex[8]; + + delete_tree(HKEY_CURRENT_USER, KEY_BASE, 0); /* Test file contents */ test_import_str("regedit\n", &r); @@ -3602,6 +3607,7 @@ START_TEST(import) return; } + test_command_syntax(); test_import(); test_unicode_import(); test_import_with_whitespace();

1 0

Alex Henrie : api-ms-win-core-featurestaging-l1-1-0: Add DLL.
by Alexandre Julliard 06 Jul '21

06 Jul '21

Module: wine Branch: master Commit: 78dd8404c4a8393331a0d16461d9bc252b96a266 URL: https://source.winehq.org/git/wine.git/?a=commit;h=78dd8404c4a8393331a0d164… Author: Alex Henrie <alexhenrie24(a)gmail.com> Date: Fri Jul 2 00:53:27 2021 -0600 api-ms-win-core-featurestaging-l1-1-0: Add DLL. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=51329 Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- configure | 2 ++ configure.ac | 1 + dlls/api-ms-win-core-featurestaging-l1-1-0/Makefile.in | 1 + .../api-ms-win-core-featurestaging-l1-1-0.spec | 5 +++++ tools/make_specfiles | 4 ++++ 5 files changed, 13 insertions(+) diff --git a/configure b/configure index f9dce332f63..27a33234eb7 100755 --- a/configure +++ b/configure @@ -948,6 +948,7 @@ enable_api_ms_win_core_errorhandling_l1_1_0 enable_api_ms_win_core_errorhandling_l1_1_1 enable_api_ms_win_core_errorhandling_l1_1_2 enable_api_ms_win_core_errorhandling_l1_1_3 +enable_api_ms_win_core_featurestaging_l1_1_0 enable_api_ms_win_core_fibers_l1_1_0 enable_api_ms_win_core_fibers_l1_1_1 enable_api_ms_win_core_file_ansi_l2_1_0 @@ -20096,6 +20097,7 @@ wine_fn_config_makefile dlls/api-ms-win-core-errorhandling-l1-1-0 enable_api_ms_ wine_fn_config_makefile dlls/api-ms-win-core-errorhandling-l1-1-1 enable_api_ms_win_core_errorhandling_l1_1_1 wine_fn_config_makefile dlls/api-ms-win-core-errorhandling-l1-1-2 enable_api_ms_win_core_errorhandling_l1_1_2 wine_fn_config_makefile dlls/api-ms-win-core-errorhandling-l1-1-3 enable_api_ms_win_core_errorhandling_l1_1_3 +wine_fn_config_makefile dlls/api-ms-win-core-featurestaging-l1-1-0 enable_api_ms_win_core_featurestaging_l1_1_0 wine_fn_config_makefile dlls/api-ms-win-core-fibers-l1-1-0 enable_api_ms_win_core_fibers_l1_1_0 wine_fn_config_makefile dlls/api-ms-win-core-fibers-l1-1-1 enable_api_ms_win_core_fibers_l1_1_1 wine_fn_config_makefile dlls/api-ms-win-core-file-ansi-l2-1-0 enable_api_ms_win_core_file_ansi_l2_1_0 diff --git a/configure.ac b/configure.ac index 1d0f09ad7e1..b889947b65b 100644 --- a/configure.ac +++ b/configure.ac @@ -2768,6 +2768,7 @@ WINE_CONFIG_MAKEFILE(dlls/api-ms-win-core-errorhandling-l1-1-0) WINE_CONFIG_MAKEFILE(dlls/api-ms-win-core-errorhandling-l1-1-1) WINE_CONFIG_MAKEFILE(dlls/api-ms-win-core-errorhandling-l1-1-2) WINE_CONFIG_MAKEFILE(dlls/api-ms-win-core-errorhandling-l1-1-3) +WINE_CONFIG_MAKEFILE(dlls/api-ms-win-core-featurestaging-l1-1-0) WINE_CONFIG_MAKEFILE(dlls/api-ms-win-core-fibers-l1-1-0) WINE_CONFIG_MAKEFILE(dlls/api-ms-win-core-fibers-l1-1-1) WINE_CONFIG_MAKEFILE(dlls/api-ms-win-core-file-ansi-l2-1-0) diff --git a/dlls/api-ms-win-core-featurestaging-l1-1-0/Makefile.in b/dlls/api-ms-win-core-featurestaging-l1-1-0/Makefile.in new file mode 100644 index 00000000000..cb2eb1c8d56 --- /dev/null +++ b/dlls/api-ms-win-core-featurestaging-l1-1-0/Makefile.in @@ -0,0 +1 @@ +MODULE = api-ms-win-core-featurestaging-l1-1-0.dll diff --git a/dlls/api-ms-win-core-featurestaging-l1-1-0/api-ms-win-core-featurestaging-l1-1-0.spec b/dlls/api-ms-win-core-featurestaging-l1-1-0/api-ms-win-core-featurestaging-l1-1-0.spec new file mode 100644 index 00000000000..ab5127b7dfd --- /dev/null +++ b/dlls/api-ms-win-core-featurestaging-l1-1-0/api-ms-win-core-featurestaging-l1-1-0.spec @@ -0,0 +1,5 @@ +@ stub GetFeatureEnabledState +@ stub RecordFeatureError +@ stub RecordFeatureUsage +@ stub SubscribeFeatureStateChangeNotification +@ stub UnsubscribeFeatureStateChangeNotification diff --git a/tools/make_specfiles b/tools/make_specfiles index e6a831025c6..d782beb27d7 100755 --- a/tools/make_specfiles +++ b/tools/make_specfiles @@ -355,6 +355,10 @@ my @dll_groups = "secur32", "sspicli", ], + [ + "shcore", + "api-ms-win-core-featurestaging-l1-1-0", + ], [ "shcore", "shell32",

1 0

Eric Pouech : dbghelp: Correctly initialize the module_pair structure in SymGetTypeFromName.
by Alexandre Julliard 06 Jul '21

06 Jul '21

Module: wine Branch: master Commit: 71e2ab0ed3e18b5b6f521176803844c2aa1f5871 URL: https://source.winehq.org/git/wine.git/?a=commit;h=71e2ab0ed3e18b5b6f521176… Author: Eric Pouech <eric.pouech(a)gmail.com> Date: Fri Jul 2 10:21:01 2021 +0200 dbghelp: Correctly initialize the module_pair structure in SymGetTypeFromName. Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/dbghelp/type.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/dlls/dbghelp/type.c b/dlls/dbghelp/type.c index 4b332b9106d..374b69aeb08 100644 --- a/dlls/dbghelp/type.c +++ b/dlls/dbghelp/type.c @@ -921,12 +921,12 @@ BOOL WINAPI SymGetTypeInfo(HANDLE hProcess, DWORD64 ModBase, BOOL WINAPI SymGetTypeFromName(HANDLE hProcess, ULONG64 BaseOfDll, PCSTR Name, PSYMBOL_INFO Symbol) { - struct process* pcs = process_find_by_handle(hProcess); struct module_pair pair; struct symt* type; - if (!pcs) return FALSE; - pair.requested = module_find_by_addr(pcs, BaseOfDll, DMT_UNKNOWN); + pair.pcs = process_find_by_handle(hProcess); + if (!pair.pcs) return FALSE; + pair.requested = module_find_by_addr(pair.pcs, BaseOfDll, DMT_UNKNOWN); if (!module_get_debug(&pair)) return FALSE; type = symt_find_type_by_name(pair.effective, SymTagNull, Name); if (!type) return FALSE;

1 0

Eric Pouech : dbghelp/tests: Try to fix failure in current dbghelp tests.
by Alexandre Julliard 06 Jul '21

06 Jul '21

Module: wine Branch: master Commit: beb13143072eee47a2a718e1b275b0f0e20e4cf8 URL: https://source.winehq.org/git/wine.git/?a=commit;h=beb13143072eee47a2a718e1… Author: Eric Pouech <eric.pouech(a)gmail.com> Date: Fri Jul 2 10:49:10 2021 +0200 dbghelp/tests: Try to fix failure in current dbghelp tests. Testbot failures in previous SymGetTypeFromName patch have nothing to do with that former patch. Trying to address errouneous test. Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/dbghelp/tests/dbghelp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/dbghelp/tests/dbghelp.c b/dlls/dbghelp/tests/dbghelp.c index 214adb7b16b..a243d047d18 100644 --- a/dlls/dbghelp/tests/dbghelp.c +++ b/dlls/dbghelp/tests/dbghelp.c @@ -106,7 +106,7 @@ static void test_stack_walk(void) addr = (void *)(DWORD_PTR)frame.AddrPC.Offset; - if (addr > (char *)stack_walk_thread && addr < (char *)stack_walk_thread + 0x100) + if (!found_our_frame && addr > (char *)stack_walk_thread && addr < (char *)stack_walk_thread + 0x100) { found_our_frame = TRUE;

1 0