December 2022 - Wine-commits

Alexandre Julliard : ntdll: Match a timezone change happening at 23:59:59 with the following day.
by Alexandre Julliard 19 Dec '22

19 Dec '22

Module: wine Branch: master Commit: 501ac4d496e9fb10fab3ec7c891ae2ce530e2b94 URL: https://gitlab.winehq.org/wine/wine/-/commit/501ac4d496e9fb10fab3ec7c891ae2… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Mon Dec 19 16:37:25 2022 +0100 ntdll: Match a timezone change happening at 23:59:59 with the following day. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53595 --- dlls/ntdll/unix/system.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/dlls/ntdll/unix/system.c b/dlls/ntdll/unix/system.c index b9be2f53752..b9762fd278f 100644 --- a/dlls/ntdll/unix/system.c +++ b/dlls/ntdll/unix/system.c @@ -2039,6 +2039,11 @@ static BOOL match_tz_date( const RTL_SYSTEM_TIME *st, const RTL_SYSTEM_TIME *reg if (!reg_st->wYear) /* date in a day-of-week format */ wDay = weekday_to_mday(st->wYear - 1900, reg_st->wDay, reg_st->wMonth - 1, reg_st->wDayOfWeek); + /* special case for 23:59:59.999, match with 0:00:00.000 on the following day */ + if (!reg_st->wYear && reg_st->wHour == 23 && reg_st->wMinute == 59 && + reg_st->wSecond == 59 && reg_st->wMilliseconds == 999) + return (st->wDay == wDay + 1 && !st->wHour && !st->wMinute && !st->wSecond && !st->wMilliseconds); + return (st->wDay == wDay && st->wHour == reg_st->wHour && st->wMinute == reg_st->wMinute &&

1 0

Alexandre Julliard : d3d8/tests: Mark a zero-size pixel test as todo.
by Alexandre Julliard 19 Dec '22

19 Dec '22

Module: wine Branch: master Commit: 28eafda808c5c426ebc54580607ae714bad1a8f2 URL: https://gitlab.winehq.org/wine/wine/-/commit/28eafda808c5c426ebc54580607ae7… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Mon Dec 19 15:15:09 2022 +0100 d3d8/tests: Mark a zero-size pixel test as todo. It fails on the Gitlab CI. --- dlls/d3d8/tests/visual.c | 1 + 1 file changed, 1 insertion(+) diff --git a/dlls/d3d8/tests/visual.c b/dlls/d3d8/tests/visual.c index 434474b292d..ea2d96378f7 100644 --- a/dlls/d3d8/tests/visual.c +++ b/dlls/d3d8/tests/visual.c @@ -7833,6 +7833,7 @@ static void test_pointsize(void) * it does the "useful" thing on all the drivers I tried. */ /* On WARP it does draw some pixels, most of the time. */ color = getPixelColor(device, 64, 64); + todo_wine_if(!color_match(color, 0x0000ffff, 0)) ok(color_match(color, 0x0000ffff, 0) || broken(color_match(color, 0x00ff0000, 0)) || broken(color_match(color, 0x00ffff00, 0))

1 0

Alexandre Julliard : d3d9/tests: Mark a zero-size pixel test as todo.
by Alexandre Julliard 19 Dec '22

19 Dec '22

Module: wine Branch: master Commit: ab8d0dafde662d2c912c7f115c151b78e5b91597 URL: https://gitlab.winehq.org/wine/wine/-/commit/ab8d0dafde662d2c912c7f115c151b… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Mon Dec 19 15:15:32 2022 +0100 d3d9/tests: Mark a zero-size pixel test as todo. It fails on the Gitlab CI. --- dlls/d3d9/tests/visual.c | 1 + 1 file changed, 1 insertion(+) diff --git a/dlls/d3d9/tests/visual.c b/dlls/d3d9/tests/visual.c index d1bcaf39c14..f630a074ea0 100644 --- a/dlls/d3d9/tests/visual.c +++ b/dlls/d3d9/tests/visual.c @@ -12220,6 +12220,7 @@ static void test_pointsize(void) * it does the "useful" thing on all the drivers I tried. */ /* On WARP it does draw some pixels, most of the time. */ color = getPixelColor(device, 64, 64); + todo_wine_if(!color_match(color, 0x0000ffff, 0)) ok(color_match(color, 0x0000ffff, 0) || broken(color_match(color, 0x00ff0000, 0)) || broken(color_match(color, 0x00ffff00, 0))

1 0

Gerald Pfeifer : libwine: Only define exe_link when needed.
by Alexandre Julliard 19 Dec '22

19 Dec '22

Module: wine Branch: master Commit: 208b824ecd24a22c0dd0cb9cbeaaefda3d78e4cd URL: https://gitlab.winehq.org/wine/wine/-/commit/208b824ecd24a22c0dd0cb9cbeaaef… Author: Gerald Pfeifer <gerald(a)pfeifer.com> Date: Sat Dec 17 02:21:13 2022 +0100 libwine: Only define exe_link when needed. Revision 24b26f8bd6a49c855eec417a6585d44c9458e3ec changed FreeBSD (and DragonFly) not to use /proc any longer. Hence we also do not need the exe_link variable on those two platforms, either. Avoid declaring it there. (This avoids a compiler warning with GCC 12.) --- libs/wine/config.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libs/wine/config.c b/libs/wine/config.c index 4eb446258cc..34ede6ed0a6 100644 --- a/libs/wine/config.c +++ b/libs/wine/config.c @@ -60,7 +60,7 @@ static void fatal_error( const char *err, ... ) __attribute__((noreturn,format( #if defined(__linux__) || defined(__FreeBSD_kernel__) || defined(__NetBSD__) static const char exe_link[] = "/proc/self/exe"; -#else +#elif ! defined (__FreeBSD__) && ! defined(__DragonFly__) static const char exe_link[] = ""; #endif

1 0

Akihiro Sagawa : po: Update Japanese translation.
by Alexandre Julliard 19 Dec '22

19 Dec '22

Module: wine Branch: master Commit: 2b1cfcd011b0c4b068903e0aff3d40114c7da7c1 URL: https://gitlab.winehq.org/wine/wine/-/commit/2b1cfcd011b0c4b068903e0aff3d40… Author: Akihiro Sagawa <sagawa.aki(a)gmail.com> Date: Sun Dec 18 19:29:41 2022 +0900 po: Update Japanese translation. --- po/ja.po | 260 +++++++++++++++++++++------------------------------------------ 1 file changed, 86 insertions(+), 174 deletions(-)

1 0

Michael Stefaniuc : dmime: Split the segment object creation into a separate helper.
by Alexandre Julliard 19 Dec '22

19 Dec '22

Module: wine Branch: master Commit: 354ccf3fdb342e45f81b0d8f0ba9816e6932613b URL: https://gitlab.winehq.org/wine/wine/-/commit/354ccf3fdb342e45f81b0d8f0ba981… Author: Michael Stefaniuc <mstefani(a)winehq.org> Date: Sat Dec 17 23:00:33 2022 +0100 dmime: Split the segment object creation into a separate helper. --- dlls/dmime/segment.c | 52 +++++++++++++++++++++++++++++++--------------------- 1 file changed, 31 insertions(+), 21 deletions(-) diff --git a/dlls/dmime/segment.c b/dlls/dmime/segment.c index b1dd21c1242..b7d7f2142b8 100644 --- a/dlls/dmime/segment.c +++ b/dlls/dmime/segment.c @@ -826,28 +826,38 @@ static const IPersistStreamVtbl persiststream_vtbl = { unimpl_IPersistStream_GetSizeMax }; +IDirectMusicSegment8Impl *create_segment(void) +{ + IDirectMusicSegment8Impl *obj; + + if (!(obj = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(*obj)))) + return NULL; + + obj->IDirectMusicSegment8_iface.lpVtbl = &dmsegment8_vtbl; + obj->ref = 1; + dmobject_init(&obj->dmobj, &CLSID_DirectMusicSegment, (IUnknown *)&obj->IDirectMusicSegment8_iface); + obj->dmobj.IDirectMusicObject_iface.lpVtbl = &dmobject_vtbl; + obj->dmobj.IPersistStream_iface.lpVtbl = &persiststream_vtbl; + list_init (&obj->Tracks); + + DMIME_LockModule(); + + return obj; +} + /* for ClassFactory */ -HRESULT create_dmsegment(REFIID lpcGUID, void **ppobj) +HRESULT create_dmsegment(REFIID guid, void **ret_iface) { - IDirectMusicSegment8Impl* obj; - HRESULT hr; + IDirectMusicSegment8Impl *obj; + HRESULT hr; - obj = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(IDirectMusicSegment8Impl)); - if (NULL == obj) { - *ppobj = NULL; - return E_OUTOFMEMORY; - } - obj->IDirectMusicSegment8_iface.lpVtbl = &dmsegment8_vtbl; - obj->ref = 1; - dmobject_init(&obj->dmobj, &CLSID_DirectMusicSegment, - (IUnknown *)&obj->IDirectMusicSegment8_iface); - obj->dmobj.IDirectMusicObject_iface.lpVtbl = &dmobject_vtbl; - obj->dmobj.IPersistStream_iface.lpVtbl = &persiststream_vtbl; - list_init (&obj->Tracks); - - DMIME_LockModule(); - hr = IDirectMusicSegment8_QueryInterface(&obj->IDirectMusicSegment8_iface, lpcGUID, ppobj); - IDirectMusicSegment8_Release(&obj->IDirectMusicSegment8_iface); - - return hr; + if (!(obj = create_segment())) { + *ret_iface = NULL; + return E_OUTOFMEMORY; + } + + hr = IDirectMusicSegment8_QueryInterface(&obj->IDirectMusicSegment8_iface, guid, ret_iface); + IDirectMusicSegment8_Release(&obj->IDirectMusicSegment8_iface); + + return hr; }

1 0

Michael Stefaniuc : dmime: Implement the IDirectMusicSegment8_Clone() method.
by Alexandre Julliard 19 Dec '22

19 Dec '22

Module: wine Branch: master Commit: c92d01016b2034f3b173a5186cfa42f6bab87f72 URL: https://gitlab.winehq.org/wine/wine/-/commit/c92d01016b2034f3b173a5186cfa42… Author: Michael Stefaniuc <mstefani(a)winehq.org> Date: Sat Dec 17 23:01:38 2022 +0100 dmime: Implement the IDirectMusicSegment8_Clone() method. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53941 --- dlls/dmime/segment.c | 50 +++++++++++++++++++++++++++++++++++++++++++++----- 1 file changed, 45 insertions(+), 5 deletions(-) diff --git a/dlls/dmime/segment.c b/dlls/dmime/segment.c index b7d7f2142b8..bf44c5e73b3 100644 --- a/dlls/dmime/segment.c +++ b/dlls/dmime/segment.c @@ -35,6 +35,8 @@ typedef struct IDirectMusicSegment8Impl { struct list Tracks; } IDirectMusicSegment8Impl; +IDirectMusicSegment8Impl *create_segment(void); + static inline IDirectMusicSegment8Impl *impl_from_IDirectMusicSegment8(IDirectMusicSegment8 *iface) { return CONTAINING_RECORD(iface, IDirectMusicSegment8Impl, IDirectMusicSegment8_iface); @@ -410,12 +412,50 @@ static HRESULT WINAPI IDirectMusicSegment8Impl_SetParam(IDirectMusicSegment8 *if return S_OK; } -static HRESULT WINAPI IDirectMusicSegment8Impl_Clone(IDirectMusicSegment8 *iface, - MUSIC_TIME mtStart, MUSIC_TIME mtEnd, IDirectMusicSegment **ppSegment) +static HRESULT WINAPI IDirectMusicSegment8Impl_Clone(IDirectMusicSegment8 *iface, MUSIC_TIME start, MUSIC_TIME end, + IDirectMusicSegment **segment) { - IDirectMusicSegment8Impl *This = impl_from_IDirectMusicSegment8(iface); - FIXME("(%p, %ld, %ld, %p): stub\n", This, mtStart, mtEnd, ppSegment); - return S_OK; + IDirectMusicSegment8Impl *This = impl_from_IDirectMusicSegment8(iface); + IDirectMusicSegment8Impl *clone; + IDirectMusicTrack *track; + DMUS_PRIVATE_SEGMENT_TRACK *track_item, *cloned_item; + HRESULT hr; + BOOL track_clone_fail = FALSE; + + TRACE("(%p, %ld, %ld, %p)\n", This, start, end, segment); + + if (!segment) + return E_POINTER; + + if (!(clone = create_segment())) { + *segment = NULL; + return E_OUTOFMEMORY; + } + + clone->header = This->header; + clone->pGraph = This->pGraph; + if (clone->pGraph) + IDirectMusicGraph_AddRef(clone->pGraph); + + LIST_FOR_EACH_ENTRY(track_item, &This->Tracks, DMUS_PRIVATE_SEGMENT_TRACK, entry) { + if (SUCCEEDED(hr = IDirectMusicTrack_Clone(track_item->pTrack, start, end, &track))) { + if ((cloned_item = HeapAlloc(GetProcessHeap(), 0, sizeof(*cloned_item)))) { + cloned_item->dwGroupBits = track_item->dwGroupBits; + cloned_item->flags = track_item->flags; + cloned_item->pTrack = track; + list_add_tail(&clone->Tracks, &cloned_item->entry); + continue; + } else { + IDirectMusicTrack_Release(track); + } + } + WARN("Failed to clone track %p: %#lx\n", track_item->pTrack, hr); + track_clone_fail = TRUE; + } + + *segment = (IDirectMusicSegment *)&clone->IDirectMusicSegment8_iface; + + return track_clone_fail ? S_FALSE : S_OK; } static HRESULT WINAPI IDirectMusicSegment8Impl_SetStartPoint(IDirectMusicSegment8 *iface,

1 0

Michael Stefaniuc : dmcompos: Return a valid pointer from ComposeSegmentFromTemplate().
by Alexandre Julliard 19 Dec '22

19 Dec '22

Module: wine Branch: master Commit: 3f0afe8e5ca286b6b26e7a20b16e47f8a99a2a96 URL: https://gitlab.winehq.org/wine/wine/-/commit/3f0afe8e5ca286b6b26e7a20b16e47… Author: Michael Stefaniuc <mstefani(a)winehq.org> Date: Sat Dec 17 23:38:41 2022 +0100 dmcompos: Return a valid pointer from ComposeSegmentFromTemplate(). Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53941 --- dlls/dmcompos/composer.c | 36 +++++++++++++++++++++++++++++++----- 1 file changed, 31 insertions(+), 5 deletions(-) diff --git a/dlls/dmcompos/composer.c b/dlls/dmcompos/composer.c index a13a77bff94..a2a58396ee5 100644 --- a/dlls/dmcompos/composer.c +++ b/dlls/dmcompos/composer.c @@ -77,12 +77,38 @@ static ULONG WINAPI IDirectMusicComposerImpl_Release(IDirectMusicComposer *iface /* IDirectMusicComposerImpl IDirectMusicComposer part: */ static HRESULT WINAPI IDirectMusicComposerImpl_ComposeSegmentFromTemplate(IDirectMusicComposer *iface, - IDirectMusicStyle *pStyle, IDirectMusicSegment *pTemplate, WORD wActivity, - IDirectMusicChordMap *pChordMap, IDirectMusicSegment **ppSegment) + IDirectMusicStyle *style, IDirectMusicSegment *template, WORD activity, IDirectMusicChordMap *chordmap, + IDirectMusicSegment **segment) { - IDirectMusicComposerImpl *This = impl_from_IDirectMusicComposer(iface); - FIXME("(%p, %p, %p, %d, %p, %p): stub\n", This, pStyle, pTemplate, wActivity, pChordMap, ppSegment); - return S_OK; + IDirectMusicComposerImpl *This = impl_from_IDirectMusicComposer(iface); + IDirectMusicTrack *track; + HRESULT hr; + + FIXME("(%p, %p, %p, %d, %p, %p): semi-stub\n", This, style, template, activity, chordmap, segment); + + if (!segment) + return E_POINTER; + if (!template) + return E_INVALIDARG; + + if (!style) { + hr = IDirectMusicSegment_GetTrack(template, &CLSID_DirectMusicStyleTrack, 0xFFFFFFFF, + DMUS_SEG_ANYTRACK, &track); + if (FAILED(hr)) + return E_INVALIDARG; + else + IDirectMusicTrack_Release(track); /* Temp to not leak memory */ + } + if (!chordmap) { + hr = IDirectMusicSegment_GetTrack(template, &CLSID_DirectMusicChordMapTrack, 0xFFFFFFFF, + DMUS_SEG_ANYTRACK, &track); + if (FAILED(hr)) + return E_INVALIDARG; + else + IDirectMusicTrack_Release(track); /* Temp to not leak memory */ + } + + return IDirectMusicSegment_Clone(template, -1, 0, segment); } static HRESULT WINAPI IDirectMusicComposerImpl_ComposeSegmentFromShape(IDirectMusicComposer *iface,

1 0

Ryan Hendrickson : wined3d: Recognize AMD as a vendor string.
by Alexandre Julliard 19 Dec '22

19 Dec '22

Module: wine Branch: master Commit: 07ca9e9a81aa07280bddeb841bc1d56bc04fed25 URL: https://gitlab.winehq.org/wine/wine/-/commit/07ca9e9a81aa07280bddeb841bc1d5… Author: Ryan Hendrickson <ryan.hendrickson(a)alum.mit.edu> Date: Sun Dec 18 17:09:10 2022 -0500 wined3d: Recognize AMD as a vendor string. --- dlls/wined3d/adapter_gl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/dlls/wined3d/adapter_gl.c b/dlls/wined3d/adapter_gl.c index f3810bad440..8cd8a883975 100644 --- a/dlls/wined3d/adapter_gl.c +++ b/dlls/wined3d/adapter_gl.c @@ -1216,6 +1216,7 @@ static enum wined3d_pci_vendor wined3d_guess_card_vendor(const char *gl_vendor_s if (strstr(gl_vendor_string, "ATI") || strstr(gl_vendor_string, "Advanced Micro Devices, Inc.") || strstr(gl_vendor_string, "X.Org R300 Project") + || strstr(gl_vendor_string, "AMD") || strstr(gl_renderer, "AMD") || strstr(gl_renderer, "FirePro") || strstr(gl_renderer, "Radeon")

1 0

Gerald Pfeifer : winebus.sys: Fix the build without HAVE_SYS_INOTIFY_H.
by Alexandre Julliard 19 Dec '22

19 Dec '22

Module: wine Branch: master Commit: 443805b10a7b774767a564320c222aa9d183458d URL: https://gitlab.winehq.org/wine/wine/-/commit/443805b10a7b774767a564320c222a… Author: Gerald Pfeifer <gerald(a)pfeifer.com> Date: Sat Dec 17 00:31:54 2022 +0100 winebus.sys: Fix the build without HAVE_SYS_INOTIFY_H. find_device_from_devnode was unnecessarily guarded by HAVE_SYS_INOTIFY_H, alas its use in process_monitor_event was not, so linking failed. Simply make find_device_from_devnode generally available. --- dlls/winebus.sys/bus_udev.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/dlls/winebus.sys/bus_udev.c b/dlls/winebus.sys/bus_udev.c index 71b9ef84530..3cd8bfd1ceb 100644 --- a/dlls/winebus.sys/bus_udev.c +++ b/dlls/winebus.sys/bus_udev.c @@ -260,6 +260,16 @@ static struct base_device *find_device_from_fd(int fd) return NULL; } +static struct base_device *find_device_from_devnode(const char *path) +{ + struct base_device *impl; + + LIST_FOR_EACH_ENTRY(impl, &device_list, struct base_device, unix_device.entry) + if (!strcmp(impl->devnode, path)) return impl; + + return NULL; +} + static void hidraw_device_destroy(struct unix_device *iface) { struct hidraw_device *impl = hidraw_impl_from_unix_device(iface); @@ -1546,16 +1556,6 @@ static int create_inotify(void) return fd; } -static struct base_device *find_device_from_devnode(const char *path) -{ - struct base_device *impl; - - LIST_FOR_EACH_ENTRY(impl, &device_list, struct base_device, unix_device.entry) - if (!strcmp(impl->devnode, path)) return impl; - - return NULL; -} - static void maybe_remove_devnode(const char *base, const char *dir) { struct base_device *impl;

1 0