February 2022 - Wine-commits

Jacek Caban : win32u: Move NtUserClipCursor implementation from user32.
by Alexandre Julliard 14 Feb '22

14 Feb '22

Module: wine Branch: master Commit: 91c095cd46fa5158764b5d70c02196f45bf8271c URL: https://source.winehq.org/git/wine.git/?a=commit;h=91c095cd46fa5158764b5d70… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Mon Feb 14 14:07:25 2022 +0100 win32u: Move NtUserClipCursor implementation from user32. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Huw Davies <huw(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/user32/cursoricon.c | 49 -------------------------------------------- dlls/user32/user32.spec | 2 +- dlls/user32/winpos.c | 2 +- dlls/win32u/cursoricon.c | 48 +++++++++++++++++++++++++++++++++++++++++++ dlls/win32u/driver.c | 6 ++++++ dlls/win32u/gdiobj.c | 1 + dlls/win32u/sysparams.c | 6 +++--- dlls/win32u/win32u.spec | 2 +- dlls/win32u/win32u_private.h | 5 +++++ dlls/win32u/wrappers.c | 6 ++++++ include/ntuser.h | 1 + 11 files changed, 73 insertions(+), 55 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=91c095cd46fa5158764b…

1 0

Jacek Caban : win32u: Move GetClipCursor implementation from user32.
by Alexandre Julliard 14 Feb '22

14 Feb '22

Module: wine Branch: master Commit: 1af4919a3f161c66c16feb6ab1ebeda9dfb7f287 URL: https://source.winehq.org/git/wine.git/?a=commit;h=1af4919a3f161c66c16feb6a… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Mon Feb 14 14:07:34 2022 +0100 win32u: Move GetClipCursor implementation from user32. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Huw Davies <huw(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/user32/cursoricon.c | 27 +-------------------------- dlls/win32u/cursoricon.c | 28 ++++++++++++++++++++++++++++ dlls/win32u/sysparams.c | 2 ++ dlls/win32u/win32u_private.h | 4 ++++ include/ntuser.h | 1 + 5 files changed, 36 insertions(+), 26 deletions(-) diff --git a/dlls/user32/cursoricon.c b/dlls/user32/cursoricon.c index 32c04852bf9..59c50ae53d8 100644 --- a/dlls/user32/cursoricon.c +++ b/dlls/user32/cursoricon.c @@ -1947,32 +1947,7 @@ HCURSOR WINAPI DECLSPEC_HOTPATCH SetCursor( HCURSOR hCursor /* [in] Handle of cu */ BOOL WINAPI DECLSPEC_HOTPATCH GetClipCursor( RECT *rect ) { - DPI_AWARENESS_CONTEXT context; - UINT dpi; - BOOL ret; - - if (!rect) return FALSE; - - SERVER_START_REQ( set_cursor ) - { - req->flags = 0; - if ((ret = !wine_server_call( req ))) - { - rect->left = reply->new_clip.left; - rect->top = reply->new_clip.top; - rect->right = reply->new_clip.right; - rect->bottom = reply->new_clip.bottom; - } - } - SERVER_END_REQ; - - if (ret && (dpi = get_thread_dpi())) - { - context = SetThreadDpiAwarenessContext( DPI_AWARENESS_CONTEXT_PER_MONITOR_AWARE ); - *rect = map_dpi_rect( *rect, get_monitor_dpi( MonitorFromRect( rect, MONITOR_DEFAULTTOPRIMARY )), dpi ); - SetThreadDpiAwarenessContext( context ); - } - return ret; + return NtUserCallOneParam( (UINT_PTR)rect, NtUserGetClipCursor ); } diff --git a/dlls/win32u/cursoricon.c b/dlls/win32u/cursoricon.c index 7b23dfb7d0b..cafea198809 100644 --- a/dlls/win32u/cursoricon.c +++ b/dlls/win32u/cursoricon.c @@ -127,3 +127,31 @@ BOOL WINAPI NtUserClipCursor( const RECT *rect ) if (ret) user_driver->pClipCursor( &new_rect ); return ret; } + +BOOL get_clip_cursor( RECT *rect ) +{ + UINT dpi; + BOOL ret; + + if (!rect) return FALSE; + + SERVER_START_REQ( set_cursor ) + { + req->flags = 0; + if ((ret = !wine_server_call( req ))) + { + rect->left = reply->new_clip.left; + rect->top = reply->new_clip.top; + rect->right = reply->new_clip.right; + rect->bottom = reply->new_clip.bottom; + } + } + SERVER_END_REQ; + + if (ret && (dpi = get_thread_dpi())) + { + HMONITOR monitor = monitor_from_rect( rect, MONITOR_DEFAULTTOPRIMARY, 0 ); + *rect = map_dpi_rect( *rect, get_monitor_dpi( monitor ), dpi ); + } + return ret; +} diff --git a/dlls/win32u/sysparams.c b/dlls/win32u/sysparams.c index d57203e330c..f409921785f 100644 --- a/dlls/win32u/sysparams.c +++ b/dlls/win32u/sysparams.c @@ -4462,6 +4462,8 @@ ULONG_PTR WINAPI NtUserCallOneParam( ULONG_PTR arg, ULONG code ) { switch(code) { + case NtUserGetClipCursor: + return get_clip_cursor( (RECT *)arg ); case NtUserGetSysColor: return get_sys_color( arg ); case NtUserRealizePalette: diff --git a/dlls/win32u/win32u_private.h b/dlls/win32u/win32u_private.h index ee26d4af52a..6594d7b10b7 100644 --- a/dlls/win32u/win32u_private.h +++ b/dlls/win32u/win32u_private.h @@ -241,6 +241,10 @@ struct unix_funcs struct window_surface *surface ); }; +/* cursoricon.c */ +extern BOOL get_clip_cursor( RECT *rect ) DECLSPEC_HIDDEN; + +/* sysparams.c */ extern RECT get_display_rect( const WCHAR *display ) DECLSPEC_HIDDEN; extern UINT get_monitor_dpi( HMONITOR monitor ) DECLSPEC_HIDDEN; extern UINT get_system_dpi(void) DECLSPEC_HIDDEN; diff --git a/include/ntuser.h b/include/ntuser.h index b2aa11f90fd..11bc0bbcb44 100644 --- a/include/ntuser.h +++ b/include/ntuser.h @@ -52,6 +52,7 @@ struct enum_display_monitor_params /* NtUserCallOneParam codes, not compatible with Windows */ enum { + NtUserGetClipCursor, NtUserGetSysColor, NtUserGetSysColorBrush, NtUserGetSysColorPen,

1 0

Zebediah Figura : kernelbase: Include the null terminator in the length passed to WideCharToMultiByte() in UrlGetPartA().
by Alexandre Julliard 14 Feb '22

14 Feb '22

Module: wine Branch: master Commit: 149b6869a26d0efd0c272566d050f392ebd3952c URL: https://source.winehq.org/git/wine.git/?a=commit;h=149b6869a26d0efd0c272566… Author: Zebediah Figura <zfigura(a)codeweavers.com> Date: Sun Feb 13 12:43:59 2022 -0600 kernelbase: Include the null terminator in the length passed to WideCharToMultiByte() in UrlGetPartA(). Signed-off-by: Zebediah Figura <zfigura(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/kernelbase/path.c | 4 ++-- dlls/shlwapi/tests/url.c | 8 +++----- 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/dlls/kernelbase/path.c b/dlls/kernelbase/path.c index 7cfff358fdb..15280a7ea4b 100644 --- a/dlls/kernelbase/path.c +++ b/dlls/kernelbase/path.c @@ -4148,10 +4148,10 @@ HRESULT WINAPI UrlGetPartA(const char *url, char *out, DWORD *out_len, DWORD par return hr; } - len2 = WideCharToMultiByte(CP_ACP, 0, outW, len, NULL, 0, NULL, NULL); + len2 = WideCharToMultiByte(CP_ACP, 0, outW, len + 1, NULL, 0, NULL, NULL); if (len2 > *out_len) { - *out_len = len2 + 1; + *out_len = len2; heap_free(inW); return E_POINTER; } diff --git a/dlls/shlwapi/tests/url.c b/dlls/shlwapi/tests/url.c index 212ee039a0b..b4b66aec2f1 100644 --- a/dlls/shlwapi/tests/url.c +++ b/dlls/shlwapi/tests/url.c @@ -782,7 +782,7 @@ static void test_UrlGetPart(void) size = 1; strcpy(buffer, "x"); hr = UrlGetPartA(url, buffer, &size, part, flags); - todo_wine_if (tests[i].todo_hr || !strcmp(url, "http://host?a:b(a)c:d")) + todo_wine_if (tests[i].todo_hr) { if (tests[i].hr == S_OK) ok(hr == E_POINTER, "Got hr %#x.\n", hr); @@ -807,11 +807,9 @@ static void test_UrlGetPart(void) } else { - todo_wine_if (hr == S_OK) - ok(size == 1, "Got size %u.\n", size); + ok(size == 1, "Got size %u.\n", size); } - todo_wine_if (hr == S_OK) - ok(!strcmp(buffer, "x"), "Got result %s.\n", debugstr_a(buffer)); + ok(!strcmp(buffer, "x"), "Got result %s.\n", debugstr_a(buffer)); } size = sizeof(buffer);

1 0

Zebediah Figura : kernelbase: Ignore URL_PARTFLAG_KEEPSCHEME when used with URL_PART_SCHEME or URL_PART_QUERY.
by Alexandre Julliard 14 Feb '22

14 Feb '22

Module: wine Branch: master Commit: 2db68d819183a5c90f1d00b2051e7339d7523291 URL: https://source.winehq.org/git/wine.git/?a=commit;h=2db68d819183a5c90f1d00b2… Author: Zebediah Figura <zfigura(a)codeweavers.com> Date: Sun Feb 13 12:44:00 2022 -0600 kernelbase: Ignore URL_PARTFLAG_KEEPSCHEME when used with URL_PART_SCHEME or URL_PART_QUERY. Signed-off-by: Zebediah Figura <zfigura(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/kernelbase/path.c | 2 ++ dlls/shlwapi/tests/url.c | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/dlls/kernelbase/path.c b/dlls/kernelbase/path.c index 15280a7ea4b..e716351b0bc 100644 --- a/dlls/kernelbase/path.c +++ b/dlls/kernelbase/path.c @@ -4334,6 +4334,7 @@ HRESULT WINAPI UrlGetPartW(const WCHAR *url, WCHAR *out, DWORD *out_len, DWORD p switch (part) { case URL_PART_SCHEME: + flags &= ~URL_PARTFLAG_KEEPSCHEME; if (!pl.scheme_len) { *out_len = 0; @@ -4404,6 +4405,7 @@ HRESULT WINAPI UrlGetPartW(const WCHAR *url, WCHAR *out, DWORD *out_len, DWORD p break; case URL_PART_QUERY: + flags &= ~URL_PARTFLAG_KEEPSCHEME; if (!pl.query_len) { *out_len = 0; diff --git a/dlls/shlwapi/tests/url.c b/dlls/shlwapi/tests/url.c index b4b66aec2f1..b2b20b94b1b 100644 --- a/dlls/shlwapi/tests/url.c +++ b/dlls/shlwapi/tests/url.c @@ -614,7 +614,7 @@ static void test_UrlGetPart(void) {"http://foo:bar(a)localhost:21/internal.php?query=x&return=y", URL_PART_PORT, 0, S_OK, "21"}, {"http://foo:bar(a)localhost:21/internal.php?query=x&return=y", URL_PART_QUERY, 0, S_OK, "query=x&return=y", .todo_result = TRUE}, {"http://foo:bar(a)localhost:21/internal.php#anchor", URL_PART_QUERY, 0, S_FALSE, ""}, - {"http://foo:bar(a)localhost:21/internal.php?query=x&return=y", URL_PART_SCHEME, URL_PARTFLAG_KEEPSCHEME, S_OK, "http", .todo_result = TRUE}, + {"http://foo:bar(a)localhost:21/internal.php?query=x&return=y", URL_PART_SCHEME, URL_PARTFLAG_KEEPSCHEME, S_OK, "http"}, {"http://foo:bar(a)localhost:21/internal.php?query=x&return=y", URL_PART_USERNAME, URL_PARTFLAG_KEEPSCHEME, S_OK, "http:foo"}, {"http://foo:bar(a)localhost:21/internal.php?query=x&return=y", URL_PART_PASSWORD, URL_PARTFLAG_KEEPSCHEME, S_OK, "http:bar"}, {"http://foo:bar(a)localhost:21/internal.php?query=x&return=y", URL_PART_HOSTNAME, URL_PARTFLAG_KEEPSCHEME, S_OK, "http:localhost"},

1 0

Zebediah Figura : kernelbase: Ignore URL_PARTFLAG_KEEPSCHEME for file URLs.
by Alexandre Julliard 14 Feb '22

14 Feb '22

Module: wine Branch: master Commit: 05e82ba113a4f8cc7fbb87c42ab556cd028d6eba URL: https://source.winehq.org/git/wine.git/?a=commit;h=05e82ba113a4f8cc7fbb87c4… Author: Zebediah Figura <zfigura(a)codeweavers.com> Date: Sun Feb 13 12:44:01 2022 -0600 kernelbase: Ignore URL_PARTFLAG_KEEPSCHEME for file URLs. Signed-off-by: Zebediah Figura <zfigura(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/kernelbase/path.c | 2 +- dlls/shlwapi/tests/url.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/dlls/kernelbase/path.c b/dlls/kernelbase/path.c index e716351b0bc..c3d3e734cf7 100644 --- a/dlls/kernelbase/path.c +++ b/dlls/kernelbase/path.c @@ -4420,7 +4420,7 @@ HRESULT WINAPI UrlGetPartW(const WCHAR *url, WCHAR *out, DWORD *out_len, DWORD p return E_INVALIDARG; } - if (flags == URL_PARTFLAG_KEEPSCHEME) + if (flags == URL_PARTFLAG_KEEPSCHEME && scheme != URL_SCHEME_FILE) { if (!pl.scheme || !pl.scheme_len) { diff --git a/dlls/shlwapi/tests/url.c b/dlls/shlwapi/tests/url.c index b2b20b94b1b..4fb4e36c3b6 100644 --- a/dlls/shlwapi/tests/url.c +++ b/dlls/shlwapi/tests/url.c @@ -683,7 +683,7 @@ static void test_UrlGetPart(void) {"http:///index.html", URL_PART_HOSTNAME, 0, S_FALSE, ""}, {"http:///index.html", URL_PART_HOSTNAME, URL_PARTFLAG_KEEPSCHEME, S_OK, "http:", .todo_hr = TRUE}, {"file://h o s t/c:/windows/file", URL_PART_HOSTNAME, 0, S_OK, "h o s t"}, - {"file://h o s t/c:/windows/file", URL_PART_HOSTNAME, URL_PARTFLAG_KEEPSCHEME, S_OK, "h o s t", .todo_result = TRUE}, + {"file://h o s t/c:/windows/file", URL_PART_HOSTNAME, URL_PARTFLAG_KEEPSCHEME, S_OK, "h o s t"}, {"file://foo:bar(a)localhost:21/file?query=x", URL_PART_USERNAME, 0, E_FAIL, .todo_hr = TRUE}, {"file://foo:bar(a)localhost:21/file?query=x", URL_PART_PASSWORD, 0, E_FAIL, .todo_hr = TRUE}, {"file://foo:bar(a)localhost:21/file?query=x", URL_PART_HOSTNAME, 0, S_OK, "foo:bar(a)localhost:21", .todo_result = TRUE}, @@ -737,7 +737,7 @@ static void test_UrlGetPart(void) {"vbscript://hostname/", URL_PART_HOSTNAME, 0, E_FAIL}, {"wais://hostname/", URL_PART_HOSTNAME, 0, E_FAIL}, - {"file://hostname/", URL_PART_HOSTNAME, URL_PARTFLAG_KEEPSCHEME, S_OK, "hostname", .todo_result = TRUE}, + {"file://hostname/", URL_PART_HOSTNAME, URL_PARTFLAG_KEEPSCHEME, S_OK, "hostname"}, {"ftp://hostname/", URL_PART_HOSTNAME, URL_PARTFLAG_KEEPSCHEME, S_OK, "ftp:hostname"}, {"gopher://hostname/", URL_PART_HOSTNAME, URL_PARTFLAG_KEEPSCHEME, S_OK, "gopher:hostname"}, {"http://hostname/", URL_PART_HOSTNAME, URL_PARTFLAG_KEEPSCHEME, S_OK, "http:hostname"},

1 0

Zebediah Figura : kernelbase: Also parse hostnames for news schemes in UrlGetPart().
by Alexandre Julliard 14 Feb '22

14 Feb '22

Module: wine Branch: master Commit: 0df41c35357ba9eef4324c1f05f3e07d69ffa57b URL: https://source.winehq.org/git/wine.git/?a=commit;h=0df41c35357ba9eef4324c1f… Author: Zebediah Figura <zfigura(a)codeweavers.com> Date: Sun Feb 13 12:44:02 2022 -0600 kernelbase: Also parse hostnames for news schemes in UrlGetPart(). Signed-off-by: Zebediah Figura <zfigura(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/kernelbase/path.c | 9 ++++++--- dlls/shlwapi/tests/url.c | 15 +++++++-------- 2 files changed, 13 insertions(+), 11 deletions(-) diff --git a/dlls/kernelbase/path.c b/dlls/kernelbase/path.c index c3d3e734cf7..7d145e5198e 100644 --- a/dlls/kernelbase/path.c +++ b/dlls/kernelbase/path.c @@ -4347,12 +4347,15 @@ HRESULT WINAPI UrlGetPartW(const WCHAR *url, WCHAR *out, DWORD *out_len, DWORD p case URL_PART_HOSTNAME: switch (scheme) { + case URL_SCHEME_FILE: case URL_SCHEME_FTP: - case URL_SCHEME_HTTP: case URL_SCHEME_GOPHER: - case URL_SCHEME_TELNET: - case URL_SCHEME_FILE: + case URL_SCHEME_HTTP: case URL_SCHEME_HTTPS: + case URL_SCHEME_TELNET: + case URL_SCHEME_NEWS: + case URL_SCHEME_NNTP: + case URL_SCHEME_SNEWS: break; default: *out_len = 0; diff --git a/dlls/shlwapi/tests/url.c b/dlls/shlwapi/tests/url.c index 4fb4e36c3b6..6a312ecff87 100644 --- a/dlls/shlwapi/tests/url.c +++ b/dlls/shlwapi/tests/url.c @@ -728,11 +728,11 @@ static void test_UrlGetPart(void) {"local://hostname/", URL_PART_HOSTNAME, 0, E_FAIL}, {"mailto://hostname/", URL_PART_HOSTNAME, 0, E_FAIL}, {"mk://hostname/", URL_PART_HOSTNAME, 0, E_FAIL}, - {"news://hostname/", URL_PART_HOSTNAME, 0, S_OK, "hostname", .todo_hr = TRUE}, - {"nntp://hostname/", URL_PART_HOSTNAME, 0, S_OK, "hostname", .todo_hr = TRUE}, + {"news://hostname/", URL_PART_HOSTNAME, 0, S_OK, "hostname"}, + {"nntp://hostname/", URL_PART_HOSTNAME, 0, S_OK, "hostname"}, {"res://hostname/", URL_PART_HOSTNAME, 0, E_FAIL}, {"shell://hostname/", URL_PART_HOSTNAME, 0, E_FAIL}, - {"snews://hostname/", URL_PART_HOSTNAME, 0, S_OK, "hostname", .todo_hr = TRUE}, + {"snews://hostname/", URL_PART_HOSTNAME, 0, S_OK, "hostname"}, {"telnet://hostname/", URL_PART_HOSTNAME, 0, S_OK, "hostname"}, {"vbscript://hostname/", URL_PART_HOSTNAME, 0, E_FAIL}, {"wais://hostname/", URL_PART_HOSTNAME, 0, E_FAIL}, @@ -742,9 +742,9 @@ static void test_UrlGetPart(void) {"gopher://hostname/", URL_PART_HOSTNAME, URL_PARTFLAG_KEEPSCHEME, S_OK, "gopher:hostname"}, {"http://hostname/", URL_PART_HOSTNAME, URL_PARTFLAG_KEEPSCHEME, S_OK, "http:hostname"}, {"https://hostname/", URL_PART_HOSTNAME, URL_PARTFLAG_KEEPSCHEME, S_OK, "https:hostname"}, - {"news://hostname/", URL_PART_HOSTNAME, URL_PARTFLAG_KEEPSCHEME, S_OK, "news:hostname", .todo_hr = TRUE}, - {"nntp://hostname/", URL_PART_HOSTNAME, URL_PARTFLAG_KEEPSCHEME, S_OK, "nntp:hostname", .todo_hr = TRUE}, - {"snews://hostname/", URL_PART_HOSTNAME, URL_PARTFLAG_KEEPSCHEME, S_OK, "snews:hostname", .todo_hr = TRUE}, + {"news://hostname/", URL_PART_HOSTNAME, URL_PARTFLAG_KEEPSCHEME, S_OK, "news:hostname"}, + {"nntp://hostname/", URL_PART_HOSTNAME, URL_PARTFLAG_KEEPSCHEME, S_OK, "nntp:hostname"}, + {"snews://hostname/", URL_PART_HOSTNAME, URL_PARTFLAG_KEEPSCHEME, S_OK, "snews:hostname"}, {"telnet://hostname/", URL_PART_HOSTNAME, URL_PARTFLAG_KEEPSCHEME, S_OK, "telnet:hostname"}, }; @@ -876,8 +876,7 @@ static void test_UrlGetPart(void) { ok(size == wcslen(bufferW), "Got size %u.\n", size); MultiByteToWideChar(CP_ACP, 0, buffer, -1, expectW, ARRAY_SIZE(expectW)); - todo_wine_if (strstr(url, "news") || strstr(url, "nntp")) - ok(!wcscmp(bufferW, expectW), "Got result %s.\n", debugstr_w(bufferW)); + ok(!wcscmp(bufferW, expectW), "Got result %s.\n", debugstr_w(bufferW)); } else {

1 0

Zebediah Figura : kernelbase: Do not initialize output params on failure in UrlGetPart().
by Alexandre Julliard 14 Feb '22

14 Feb '22

Module: wine Branch: master Commit: 1747b0b1d5958ae6f51cb5293d975cafa8a04412 URL: https://source.winehq.org/git/wine.git/?a=commit;h=1747b0b1d5958ae6f51cb529… Author: Zebediah Figura <zfigura(a)codeweavers.com> Date: Sun Feb 13 12:44:03 2022 -0600 kernelbase: Do not initialize output params on failure in UrlGetPart(). Signed-off-by: Zebediah Figura <zfigura(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/kernelbase/path.c | 14 +++++++------- dlls/shlwapi/tests/url.c | 13 ++++++++----- 2 files changed, 15 insertions(+), 12 deletions(-) diff --git a/dlls/kernelbase/path.c b/dlls/kernelbase/path.c index 7d145e5198e..b753ce3dd2e 100644 --- a/dlls/kernelbase/path.c +++ b/dlls/kernelbase/path.c @@ -4321,8 +4321,6 @@ HRESULT WINAPI UrlGetPartW(const WCHAR *url, WCHAR *out, DWORD *out_len, DWORD p if (!url || !out || !out_len || !*out_len) return E_INVALIDARG; - *out = '\0'; - addr = wcschr(url, ':'); if (!addr) scheme = URL_SCHEME_UNKNOWN; @@ -4337,6 +4335,7 @@ HRESULT WINAPI UrlGetPartW(const WCHAR *url, WCHAR *out, DWORD *out_len, DWORD p flags &= ~URL_PARTFLAG_KEEPSCHEME; if (!pl.scheme_len) { + *out = '\0'; *out_len = 0; return S_FALSE; } @@ -4358,18 +4357,19 @@ HRESULT WINAPI UrlGetPartW(const WCHAR *url, WCHAR *out, DWORD *out_len, DWORD p case URL_SCHEME_SNEWS: break; default: - *out_len = 0; return E_FAIL; } if (scheme == URL_SCHEME_FILE && (!pl.hostname_len || (pl.hostname_len == 1 && *(pl.hostname + 1) == ':'))) { + *out = '\0'; *out_len = 0; return S_FALSE; } if (!pl.hostname_len) { + *out = '\0'; *out_len = 0; return S_FALSE; } @@ -4380,6 +4380,7 @@ HRESULT WINAPI UrlGetPartW(const WCHAR *url, WCHAR *out, DWORD *out_len, DWORD p case URL_PART_USERNAME: if (!pl.username_len) { + *out = '\0'; *out_len = 0; return S_FALSE; } @@ -4390,6 +4391,7 @@ HRESULT WINAPI UrlGetPartW(const WCHAR *url, WCHAR *out, DWORD *out_len, DWORD p case URL_PART_PASSWORD: if (!pl.password_len) { + *out = '\0'; *out_len = 0; return S_FALSE; } @@ -4400,6 +4402,7 @@ HRESULT WINAPI UrlGetPartW(const WCHAR *url, WCHAR *out, DWORD *out_len, DWORD p case URL_PART_PORT: if (!pl.port_len) { + *out = '\0'; *out_len = 0; return S_FALSE; } @@ -4411,6 +4414,7 @@ HRESULT WINAPI UrlGetPartW(const WCHAR *url, WCHAR *out, DWORD *out_len, DWORD p flags &= ~URL_PARTFLAG_KEEPSCHEME; if (!pl.query_len) { + *out = '\0'; *out_len = 0; return S_FALSE; } @@ -4419,17 +4423,13 @@ HRESULT WINAPI UrlGetPartW(const WCHAR *url, WCHAR *out, DWORD *out_len, DWORD p break; default: - *out_len = 0; return E_INVALIDARG; } if (flags == URL_PARTFLAG_KEEPSCHEME && scheme != URL_SCHEME_FILE) { if (!pl.scheme || !pl.scheme_len) - { - *out_len = 0; return E_FAIL; - } schaddr = pl.scheme; schsize = pl.scheme_len; if (*out_len < schsize + size + 2) diff --git a/dlls/shlwapi/tests/url.c b/dlls/shlwapi/tests/url.c index 6a312ecff87..729b069a772 100644 --- a/dlls/shlwapi/tests/url.c +++ b/dlls/shlwapi/tests/url.c @@ -845,7 +845,7 @@ static void test_UrlGetPart(void) ok(hr == (tests[i].hr == S_FALSE ? S_OK : tests[i].hr), "Got hr %#x.\n", hr); } - if (hr == S_OK) + if (SUCCEEDED(hr)) { ok(!size, "Got size %u.\n", size); ok(!buffer[0], "Got result %s.\n", debugstr_a(buffer)); @@ -862,9 +862,9 @@ static void test_UrlGetPart(void) } else { - todo_wine ok(size == 1, "Got size %u.\n", size); + ok(size == 1, "Got size %u.\n", size); } - todo_wine ok(!wcscmp(bufferW, L"x"), "Got result %s.\n", debugstr_w(bufferW)); + ok(!wcscmp(bufferW, L"x"), "Got result %s.\n", debugstr_w(bufferW)); } size = ARRAY_SIZE(bufferW); @@ -880,8 +880,11 @@ static void test_UrlGetPart(void) } else { - todo_wine ok(size == ARRAY_SIZE(bufferW), "Got size %u.\n", size); - todo_wine ok(!wcscmp(bufferW, L"x"), "Got result %s.\n", debugstr_w(bufferW)); + todo_wine_if (strchr(url, '"') && part == URL_PART_USERNAME) + { + ok(size == ARRAY_SIZE(bufferW), "Got size %u.\n", size); + ok(!wcscmp(bufferW, L"x"), "Got result %s.\n", debugstr_w(bufferW)); + } } winetest_pop_context();

1 0

Eric Pouech : mapi32: Enable compilation with long types.
by Alexandre Julliard 14 Feb '22

14 Feb '22

Module: wine Branch: master Commit: 5ec2a8b90cf680e939bfc1e1c717b330e48a90a7 URL: https://source.winehq.org/git/wine.git/?a=commit;h=5ec2a8b90cf680e939bfc1e1… Author: Eric Pouech <eric.pouech(a)gmail.com> Date: Mon Feb 14 09:26:49 2022 +0100 mapi32: Enable compilation with long types. Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/mapi32/Makefile.in | 1 - dlls/mapi32/mapi32_main.c | 16 ++++++++-------- dlls/mapi32/prop.c | 48 +++++++++++++++++++++++------------------------ dlls/mapi32/sendmail.c | 6 +++--- dlls/mapi32/util.c | 18 +++++++++--------- 5 files changed, 44 insertions(+), 45 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=5ec2a8b90cf680e939bf…

1 0

Eric Pouech : mciavi32: Enable compilation with long types.
by Alexandre Julliard 14 Feb '22

14 Feb '22

Module: wine Branch: master Commit: 365b208fde30fb27ab7872c330c6410ba98c3b4d URL: https://source.winehq.org/git/wine.git/?a=commit;h=365b208fde30fb27ab7872c3… Author: Eric Pouech <eric.pouech(a)gmail.com> Date: Mon Feb 14 09:26:56 2022 +0100 mciavi32: Enable compilation with long types. Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/mciavi32/Makefile.in | 1 - dlls/mciavi32/info.c | 50 +++++++++---------- dlls/mciavi32/mciavi.c | 60 +++++++++++----------- dlls/mciavi32/mmoutput.c | 124 +++++++++++++++++++++++----------------------- dlls/mciavi32/wnd.c | 10 ++-- 5 files changed, 122 insertions(+), 123 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=365b208fde30fb27ab78…

1 0

Eric Pouech : mcicda: Enable compilation with long types.
by Alexandre Julliard 14 Feb '22

14 Feb '22

Module: wine Branch: master Commit: dee729aea8858075a34a96a31465f74f96bee768 URL: https://source.winehq.org/git/wine.git/?a=commit;h=dee729aea8858075a34a96a3… Author: Eric Pouech <eric.pouech(a)gmail.com> Date: Mon Feb 14 09:27:01 2022 +0100 mcicda: Enable compilation with long types. Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/mcicda/Makefile.in | 1 - dlls/mcicda/mcicda.c | 82 ++++++++++++++++++++++++------------------------- 2 files changed, 41 insertions(+), 42 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=dee729aea8858075a34a…

1 0