June 2022 - Wine-commits - list.winehq.org

Francois Gouget : testbot: Slightly simplify $Job->Restart().
by Alexandre Julliard 06 Jun '22

06 Jun '22

Module: tools Branch: master Commit: 4358c8d349975c68401be7431a44c9bd2c0d3b1c URL: https://source.winehq.org/git/tools.git/?a=commit;h=4358c8d349975c68401be74… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Mon Jun 6 02:58:37 2022 +0200 testbot: Slightly simplify $Job->Restart(). Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- testbot/lib/WineTestBot/Jobs.pm | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/testbot/lib/WineTestBot/Jobs.pm b/testbot/lib/WineTestBot/Jobs.pm index 778a0f4..1eb7bb7 100644 --- a/testbot/lib/WineTestBot/Jobs.pm +++ b/testbot/lib/WineTestBot/Jobs.pm @@ -417,11 +417,9 @@ sub Restart($) return "This job is already " . $self->Status; } - my $Steps = $self->Steps; - foreach my $Step (@{$Steps->GetSortedItems()}) + foreach my $Step (@{$self->Steps->GetSortedItems()}) { - my $Tasks = $Step->Tasks; - foreach my $Task (@{$Tasks->GetItems()}) + foreach my $Task (@{$Step->Tasks->GetItems()}) { $Task->Status("queued"); $Task->Started(undef);

1 0

Francois Gouget : testbot: Access the master columns directly instead of going through GetMasterKey().
by Alexandre Julliard 06 Jun '22

06 Jun '22

Module: tools Branch: master Commit: 2da4c9bf6bb4466fb745ec00231f3d56cfafae09 URL: https://source.winehq.org/git/tools.git/?a=commit;h=2da4c9bf6bb4466fb745ec0… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Mon Jun 6 02:59:13 2022 +0200 testbot: Access the master columns directly instead of going through GetMasterKey(). We now have read-only access to them. This makes the code more readable. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- testbot/lib/WineTestBot/Steps.pm | 5 ++--- testbot/lib/WineTestBot/StepsTasks.pm | 6 ++---- testbot/lib/WineTestBot/Tasks.pm | 6 ++---- 3 files changed, 6 insertions(+), 11 deletions(-) diff --git a/testbot/lib/WineTestBot/Steps.pm b/testbot/lib/WineTestBot/Steps.pm index 860dc49..d2e2831 100644 --- a/testbot/lib/WineTestBot/Steps.pm +++ b/testbot/lib/WineTestBot/Steps.pm @@ -154,9 +154,8 @@ sub GetFullFileName($;$) $FileName = $self->FileName if (!defined $FileName); return undef if (!defined $FileName); - my ($JobId, $StepNo) = @{$self->GetMasterKey()}; - my $Path = "$DataDir/jobs/$JobId/"; - foreach my $StepNo ($StepNo, $self->PreviousNo) + my $Path = "$DataDir/jobs/". $self->JobId ."/"; + foreach my $StepNo ($self->No, $self->PreviousNo) { next if (!$StepNo); my $Full = "$Path$StepNo/$FileName"; diff --git a/testbot/lib/WineTestBot/StepsTasks.pm b/testbot/lib/WineTestBot/StepsTasks.pm index 0b1655a..5970c87 100644 --- a/testbot/lib/WineTestBot/StepsTasks.pm +++ b/testbot/lib/WineTestBot/StepsTasks.pm @@ -37,8 +37,7 @@ use WineTestBot::Missions; sub GetStepDir($) { my ($self) = @_; - my ($JobId, $_StepTaskId) = @{$self->GetMasterKey()}; - return "$DataDir/jobs/$JobId/". $self->StepNo; + return "$DataDir/jobs/". $self->JobId ."/". $self->StepNo; } # Keep in sync with WineTestBot::Step::GetFullFileName() @@ -49,8 +48,7 @@ sub GetFullFileName($;$) $FileName = $self->FileName if (!defined $FileName); return undef if (!defined $FileName); - my ($JobId, $_StepTaskId) = @{$self->GetMasterKey()}; - my $Path = "$DataDir/jobs/$JobId/"; + my $Path = "$DataDir/jobs/". $self->JobId ."/"; foreach my $StepNo ($self->StepNo, $self->PreviousNo) { next if (!$StepNo); diff --git a/testbot/lib/WineTestBot/Tasks.pm b/testbot/lib/WineTestBot/Tasks.pm index 50ce960..c80b432 100644 --- a/testbot/lib/WineTestBot/Tasks.pm +++ b/testbot/lib/WineTestBot/Tasks.pm @@ -142,8 +142,7 @@ sub GetReportNames($) sub GetRefReportName($$) { my ($self, $ReportName) = @_; - my ($JobId, $_StepNo, $_TaskNo) = @{$self->GetMasterKey()}; - return sprintf("%s-job%06d-%s", $self->VM->Name, $JobId, $ReportName); + return sprintf("%s-job%06d-%s", $self->VM->Name, $self->JobId, $ReportName); } sub GetRefReportPaths($$;$$) @@ -240,13 +239,12 @@ sub Run($$) { my ($self, $Step) = @_; - my ($JobId, $StepNo, $TaskNo) = @{$self->GetMasterKey()}; my $Script = $Step->Type eq "reconfig" ? "Reconfig" : $self->VM->Type eq "wine" ? "WineTest" : $Step->Type eq "build" ? "Build" : "Task"; my $Args = ["$BinDir/${ProjectName}Run$Script.pl", "--log-only", - $JobId, $StepNo, $TaskNo]; + $self->JobId, $self->StepNo, $self->No]; my $ErrMessage = $self->VM->Run("running", $Args, $self->Timeout + $TimeoutMargin,

1 0

Francois Gouget : testbot/orm: Simplify CombineKey() and SplitKey() a bit.
by Alexandre Julliard 06 Jun '22

06 Jun '22

Module: tools Branch: master Commit: 71c7c8376cbb98272b9fed71b35b88cfcd82c141 URL: https://source.winehq.org/git/tools.git/?a=commit;h=71c7c8376cbb98272b9fed7… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Mon Jun 6 02:59:20 2022 +0200 testbot/orm: Simplify CombineKey() and SplitKey() a bit. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- testbot/lib/ObjectModel/Collection.pm | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/testbot/lib/ObjectModel/Collection.pm b/testbot/lib/ObjectModel/Collection.pm index 63d470b..1a48eec 100644 --- a/testbot/lib/ObjectModel/Collection.pm +++ b/testbot/lib/ObjectModel/Collection.pm @@ -462,18 +462,14 @@ sub IsEmpty($) sub CombineKey($@) { - my $self = shift; - - my $CombinedKey = join("#@#", @_); - return $CombinedKey; + my $_self = shift; + return join("#@#", @_); } sub SplitKey($$) { - my ($self, $CombinedKey) = @_; - - my @KeyComponents = split /#@#/, $CombinedKey; - return @KeyComponents; + my ($_self, $CombinedKey) = @_; + return split /#@#/, $CombinedKey; } =pod

1 0

Francois Gouget : testbot: Simplify building a slash-separated Item identifiers.
by Alexandre Julliard 06 Jun '22

06 Jun '22

Module: tools Branch: master Commit: 8c1869ddae04fe3582e46f79cc4e56c3ee600d41 URL: https://source.winehq.org/git/tools.git/?a=commit;h=8c1869ddae04fe3582e46f7… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Mon Jun 6 02:59:28 2022 +0200 testbot: Simplify building a slash-separated Item identifiers. This also fixes the task id in the GetReportNames() error messages. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- testbot/bin/Janitor.pl | 2 +- testbot/lib/ObjectModel/Item.pm | 19 +++++++++++++++++++ testbot/lib/WineTestBot/Steps.pm | 3 +-- testbot/lib/WineTestBot/Tasks.pm | 13 +++++-------- 4 files changed, 26 insertions(+), 11 deletions(-) diff --git a/testbot/bin/Janitor.pl b/testbot/bin/Janitor.pl index ab72ac1..af1123a 100755 --- a/testbot/bin/Janitor.pl +++ b/testbot/bin/Janitor.pl @@ -205,7 +205,7 @@ if (%DeletedVMs) { if (exists $DeletedVMs{$Task->VM->Name}) { - Trace "Keeping the ", $Task->VM->Name, " VM for task ", join("/", @{$Task->GetMasterKey()}), "\n"; + Trace "Keeping the ", $Task->VM->Name, " VM for task ", $Task->GetSlashKey(), "\n"; delete $DeletedVMs{$Task->VM->Name}; last if (!%DeletedVMs); } diff --git a/testbot/lib/ObjectModel/Item.pm b/testbot/lib/ObjectModel/Item.pm index 0b1da92..39c80cc 100644 --- a/testbot/lib/ObjectModel/Item.pm +++ b/testbot/lib/ObjectModel/Item.pm @@ -350,6 +350,25 @@ sub GetMasterKey($) return (\@MasterColNames, \@MasterColValues); } +=pod +=over 12 + +=item C<GetSlashKey()> + +Returns a string containing all the slash-separated key components. + +This can be used to display the key in the GUI or to build file paths (assuming +the key components can be trusted). + +=back +=cut + +sub GetSlashKey($) +{ + my ($self) = @_; + return join("/", @{$self->GetMasterKey()}); # drops the column names +} + sub ResetModified($) { my ($self) = @_; diff --git a/testbot/lib/WineTestBot/Steps.pm b/testbot/lib/WineTestBot/Steps.pm index d2e2831..48d0209 100644 --- a/testbot/lib/WineTestBot/Steps.pm +++ b/testbot/lib/WineTestBot/Steps.pm @@ -128,8 +128,7 @@ sub Validate($) sub GetDir($) { my ($self) = @_; - my ($JobId, $StepNo) = @{$self->GetMasterKey()}; - return "$DataDir/jobs/$JobId/$StepNo"; + return "$DataDir/jobs/". $self->GetSlashKey(); } sub CreateDir($) diff --git a/testbot/lib/WineTestBot/Tasks.pm b/testbot/lib/WineTestBot/Tasks.pm index c80b432..a7d9e82 100644 --- a/testbot/lib/WineTestBot/Tasks.pm +++ b/testbot/lib/WineTestBot/Tasks.pm @@ -91,8 +91,7 @@ sub InitializeNew($$) sub GetDir($) { my ($self) = @_; - my ($JobId, $StepNo, $TaskNo) = @{$self->GetMasterKey()}; - return "$DataDir/jobs/$JobId/$StepNo/$TaskNo"; + return "$DataDir/jobs/". $self->GetSlashKey(); } sub CreateDir($) @@ -118,13 +117,11 @@ sub GetReportNames($) return ($ErrMessage, undef, undef) if (defined $ErrMessage); if (!@$Missions) { - my @TaskKey = $self->GetMasterKey(); - return ("Task @TaskKey has no mission", undef, undef); + return ("Task ". $self->GetSlashKey() ." has no mission", undef, undef); } if (@$Missions > 1) { - my @TaskKey = $self->GetMasterKey(); - return ("Task @TaskKey should not have missions for multiple tasks\n", undef); + return ("Task ". $self->GetSlashKey() ." should not have missions for multiple tasks\n", undef); } my $TaskMissions = $Missions->[0]; @@ -275,7 +272,6 @@ sub UpdateStatus($$) if ($Status eq "running" and ($VM->Status ne "running" or !$VM->HasRunningChild())) { - my ($JobId, $StepNo, $TaskNo) = @{$self->GetMasterKey()}; my $OldUMask = umask(002); my $TaskDir = $self->CreateDir(); if (open TASKLOG, ">>", "$TaskDir/testbot.log") @@ -286,7 +282,8 @@ sub UpdateStatus($$) umask($OldUMask); require WineTestBot::Log; - WineTestBot::Log::LogMsg("Child process for task $JobId/$StepNo/$TaskNo died unexpectedly\n"); + WineTestBot::Log::LogMsg("Child process for task ", $self->GetSlashKey(), + " died unexpectedly\n"); # A crash probably indicates a bug in the task script but getting stuck # could happen due to network issues. So requeue the task like its script

1 0

Francois Gouget : testbot/cgi: Tweak the CollectionBlock master columns iterations.
by Alexandre Julliard 06 Jun '22

06 Jun '22

Module: tools Branch: master Commit: 729f60d174304629b3f848c7f597044ec4a870f4 URL: https://source.winehq.org/git/tools.git/?a=commit;h=729f60d174304629b3f848c… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Mon Jun 6 02:59:33 2022 +0200 testbot/cgi: Tweak the CollectionBlock master columns iterations. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- testbot/lib/ObjectModel/CGI/CollectionBlock.pm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/testbot/lib/ObjectModel/CGI/CollectionBlock.pm b/testbot/lib/ObjectModel/CGI/CollectionBlock.pm index 336c7cd..e8156a1 100644 --- a/testbot/lib/ObjectModel/CGI/CollectionBlock.pm +++ b/testbot/lib/ObjectModel/CGI/CollectionBlock.pm @@ -243,7 +243,7 @@ sub GetDetailsLink($$) my ($MasterColNames, $MasterColValues) = $Row->{Item}->GetMasterCols(); if (defined $MasterColNames) { - foreach my $ColIndex (0 .. @$MasterColNames - 1) + foreach my $ColIndex (0..$#{$MasterColNames}) { $Row->{DetailsLink} .= "&". $MasterColNames->[$ColIndex] ."=". uri_escape($MasterColValues->[$ColIndex]); @@ -385,7 +385,7 @@ sub GenerateFormStart($) my ($MasterColNames, $MasterColValues) = $self->{Collection}->GetMasterCols(); if (defined($MasterColNames)) { - foreach my $ColIndex (0..scalar @$MasterColNames - 1) + foreach my $ColIndex (0..$#{$MasterColNames}) { print "<div><input type='hidden' name='", $MasterColNames->[$ColIndex], "' value='", $self->escapeHTML($MasterColValues->[$ColIndex]), @@ -684,7 +684,7 @@ sub OnAction($$) my ($MasterColNames, $MasterColValues) = $self->{Collection}->GetMasterCols(); if (defined($MasterColNames)) { - foreach my $ColIndex (0 .. @$MasterColNames - 1) + foreach my $ColIndex (0..$#{$MasterColNames}) { $Target .= ($ColIndex == 0 ? "?" : "&") . $MasterColNames->[$ColIndex] . "=" . uri_escape($MasterColValues->[$ColIndex]);

1 0

Francois Gouget : winetest: Apply a couple of spelling fixes.
by Alexandre Julliard 06 Jun '22

06 Jun '22

Module: tools Branch: master Commit: d773793d717dc2cbac0550580ce10b3e6eb1dc76 URL: https://source.winehq.org/git/tools.git/?a=commit;h=d773793d717dc2cbac05505… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Mon Jun 6 05:56:04 2022 +0200 winetest: Apply a couple of spelling fixes. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- winetest/build-patterns | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/winetest/build-patterns b/winetest/build-patterns index 0bad351..0bab171 100755 --- a/winetest/build-patterns +++ b/winetest/build-patterns @@ -1477,7 +1477,7 @@ EOF <li>Related bugs should have the source and testcase keywords, and their description should contain module:unit, module/unit or module/tests/unit. </ul> -The patterns are grouped according to the likelyhood that they contain new failures: +The patterns are grouped according to the likelihood that they contain new failures: <ul>"; my @listids = ("summary", "recent", "newmode", "regular", "old", @@ -1499,7 +1499,7 @@ EOF $tests{0}->{desc} .= "</ul>"; if (!$nolist) { - my @table = ("<details><summary>Page cutomization</summary> + my @table = ("<details><summary>Page customization</summary> <div class='detailsbox'>This section lets you select the reports to show on this page. <label><input id='reruns' type='checkbox' checked> Hide WineTest reruns</label> "); if (!$subpage or $subpage eq "-tb-win")

1 0

Alexandre Julliard : packaging: Remove Fedora 34.
by Alexandre Julliard 06 Jun '22

06 Jun '22

Module: tools Branch: master Commit: c1e94015e48925b719964fa63c8908b272502d1f URL: https://source.winehq.org/git/tools.git/?a=commit;h=c1e94015e48925b719964fa… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Sat Jun 4 10:30:45 2022 +0200 packaging: Remove Fedora 34. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- packaging/obs/obs-sync | 2 +- packaging/obs/rsync-filter | 1 - packaging/obs/yum.conf | 4 ---- 3 files changed, 1 insertion(+), 6 deletions(-) diff --git a/packaging/obs/obs-sync b/packaging/obs/obs-sync index 831c2b1..226da8a 100755 --- a/packaging/obs/obs-sync +++ b/packaging/obs/obs-sync @@ -199,7 +199,7 @@ publish_files () cd $basedir -distros="34 35 36 buster bullseye bookworm bionic focal impish jammy" +distros="35 36 buster bullseye bookworm bionic focal impish jammy" dry_run= build=1 diff --git a/packaging/obs/rsync-filter b/packaging/obs/rsync-filter index 220e0fd..80331b2 100644 --- a/packaging/obs/rsync-filter +++ b/packaging/obs/rsync-filter @@ -1,5 +1,4 @@ + /fedora -+ /fedora/34 + /fedora/35 + /fedora/36 - /fedora/* diff --git a/packaging/obs/yum.conf b/packaging/obs/yum.conf index 4ad17e2..b9340f3 100644 --- a/packaging/obs/yum.conf +++ b/packaging/obs/yum.conf @@ -4,10 +4,6 @@ debuglevel=0 logfile=/var/log/yum.log gpgcheck=1 -[fedora-34] -name = Fedora 34 -baseurl=https://download.opensuse.org/repositories/Emulators:/Wine:/Fedora/Fedora_34 - [fedora-35] name = Fedora 35 baseurl=https://download.opensuse.org/repositories/Emulators:/Wine:/Fedora/…

1 0

Jeremy White : gitlab: Respect READ_ONLY for mailtogitlab.py as well.
by Alexandre Julliard 06 Jun '22

06 Jun '22

Module: tools Branch: master Commit: dd97169f1220d1457bf5eb41b6499c54bbfac788 URL: https://source.winehq.org/git/tools.git/?a=commit;h=dd97169f1220d1457bf5eb4… Author: Jeremy White <jwhite(a)codeweavers.com> Date: Fri Jun 3 10:16:09 2022 -0500 gitlab: Respect READ_ONLY for mailtogitlab.py as well. --- gitlab/gitlab-to-mail/mailtogitlab.py | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/gitlab/gitlab-to-mail/mailtogitlab.py b/gitlab/gitlab-to-mail/mailtogitlab.py index d3eeee7..ecc73fc 100755 --- a/gitlab/gitlab-to-mail/mailtogitlab.py +++ b/gitlab/gitlab-to-mail/mailtogitlab.py @@ -139,8 +139,11 @@ def post_discussion_note(mr_iid, note, replyto): did = find_discussion(mr_iid, replyto) if did: url += f"/{did}/notes" - r = requests.post(url, headers={"PRIVATE-TOKEN": settings.GITLAB_TOKEN}, data={'body': note, 'note_id': replyto}) - r.raise_for_status() + if settings.READ_ONLY: + print(f"Post: {url} (note_id: {replyto})\nBody:\n{note}\n---\n") + else: + r = requests.post(url, headers={"PRIVATE-TOKEN": settings.GITLAB_TOKEN}, data={'body': note, 'note_id': replyto}) + r.raise_for_status() def main():

1 0

Jeremy White : gitlab: Handle email encoded in a non utf-8 charset.
by Alexandre Julliard 06 Jun '22

06 Jun '22

Module: tools Branch: master Commit: 001ed5565377ccde1ecbbce75806a0a65bd31348 URL: https://source.winehq.org/git/tools.git/?a=commit;h=001ed5565377ccde1ecbbce… Author: Jeremy White <jwhite(a)codeweavers.com> Date: Fri Jun 3 10:16:47 2022 -0500 gitlab: Handle email encoded in a non utf-8 charset. See https://www.winehq.org/pipermail/wine-devel/2022-June/218864.html. --- gitlab/gitlab-to-mail/mailtogitlab.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/gitlab/gitlab-to-mail/mailtogitlab.py b/gitlab/gitlab-to-mail/mailtogitlab.py index ecc73fc..bc9944a 100755 --- a/gitlab/gitlab-to-mail/mailtogitlab.py +++ b/gitlab/gitlab-to-mail/mailtogitlab.py @@ -53,6 +53,7 @@ def find_mr(mail): def get_email_body(mail): + charset = mail.get_content_charset(failobj='UTF-8') if mail.is_multipart(): result = "" for part in mail.walk(): @@ -60,14 +61,14 @@ def get_email_body(mail): payload = part.get_payload(decode=True) # Skip things that look like a mailman tail if not re.search(r"^--[ ]*[\r\n]*.*mailing list[ \r\n]*.*[\r\n]^https", payload.decode(), re.MULTILINE): - result += payload.decode() + result += payload.decode(encoding=charset) return result else: if mail.get_content_type() != "text/plain": return "" payload = mail.get_payload(decode=True) - return payload.decode() + return payload.decode(encoding=charset) def escape_body(body): return body.replace("```", '\`\`\`')

1 0

Alexandre Julliard : Wine release 7.10
by Alexandre Julliard 03 Jun '22

03 Jun '22

Module: website Branch: master Commit: 2f4f22e89eb598546ddac714799ff23f48817c88 URL: https://source.winehq.org/git/website.git/?a=commit;h=2f4f22e89eb598546ddac… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Fri Jun 3 22:53:30 2022 +0200 Wine release 7.10 Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- news/en/2022060301.xml | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/news/en/2022060301.xml b/news/en/2022060301.xml new file mode 100644 index 00000000..e722ca94 --- /dev/null +++ b/news/en/2022060301.xml @@ -0,0 +1,17 @@ +<news> +<date>June 3, 2022</date> +<title>Wine 7.10 Released</title> +<body> + The Wine development release 7.10 is now available. + <a href="{$root}/announce/7.10">What's new</a> in this release: +<ul> + <li>macOS driver converted to PE.</li> + <li>Mono engine updated to version 7.3.0.</li> + <li>Windows-compatible Unicode collation.</li> + <li>Wow64 support in SECUR32.</li> + <li>Various bug fixes.</li> +</ul> + +The source is <a href="//dl.winehq.org/wine/source/7.x/wine-7.10.tar.xz">available now</a>. +Binary packages are in the process of being built, and will appear soon at their respective <a href="{$root}/download">download locations</a>. +</body></news>

1 0