July 2022 - Wine-commits - list.winehq.org

Julian Klemann : http.sys: Do not add URLs with query parameters to queue.
by Alexandre Julliard 08 Jul '22

08 Jul '22

Module: wine Branch: master Commit: 8e307b2ecd10da6c3c0a917f091eeb8cc8b374db URL: https://source.winehq.org/git/wine.git/?a=commit;h=8e307b2ecd10da6c3c0a917f… Author: Julian Klemann <jklemann(a)codeweavers.com> Date: Thu Jul 7 16:25:28 2022 -0500 http.sys: Do not add URLs with query parameters to queue. --- dlls/http.sys/http.c | 2 ++ dlls/httpapi/tests/httpapi.c | 4 ++++ 2 files changed, 6 insertions(+) diff --git a/dlls/http.sys/http.c b/dlls/http.sys/http.c index 4d2e10c90d9..e16805ccbdb 100644 --- a/dlls/http.sys/http.c +++ b/dlls/http.sys/http.c @@ -729,6 +729,8 @@ static NTSTATUS http_add_url(struct request_queue *queue, IRP *irp) return STATUS_INVALID_PARAMETER; if (!(addr.sin_port = htons(strtol(strchr(params->url + 7, ':') + 1, &endptr, 10))) || *endptr != '/') return STATUS_INVALID_PARAMETER; + if (strchr(params->url, '?')) + return STATUS_INVALID_PARAMETER; if (!(url = malloc(strlen(params->url)+1))) return STATUS_NO_MEMORY; diff --git a/dlls/httpapi/tests/httpapi.c b/dlls/httpapi/tests/httpapi.c index f52c584b93b..1d00aa22c50 100644 --- a/dlls/httpapi/tests/httpapi.c +++ b/dlls/httpapi/tests/httpapi.c @@ -1210,6 +1210,10 @@ static void test_v1_relative_urls(void) ret = HttpAddUrl(queue2, url2, NULL); ok(ret == ERROR_ALREADY_EXISTS, "Got error %u.\n", ret); + swprintf(url2, ARRAY_SIZE(url2), L"http://localhost:%u/barfoo?a=b", port); + ret = HttpAddUrl(queue2, url2, NULL); + ok(ret == ERROR_INVALID_PARAMETER, "Got error %u.\n", ret); + ret = CloseHandle(queue); ok(ret, "Failed to close queue handle, error %lu.\n", GetLastError()); ret = CloseHandle(queue2);

1 0

Francois Gouget : testbot/web: Clearly identify unused variables in the reset password page.
by Alexandre Julliard 08 Jul '22

08 Jul '22

Module: tools Branch: master Commit: 88bb46d5991d2c12925d08a861271da2cd41f96d URL: https://source.winehq.org/git/tools.git/?a=commit;h=88bb46d5991d2c12925d08a… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Fri Jul 8 15:34:44 2022 +0200 testbot/web: Clearly identify unused variables in the reset password page. This also avoids shadowing the $User variable. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- testbot/web/ResetPassword.pl | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/testbot/web/ResetPassword.pl b/testbot/web/ResetPassword.pl index 65dcdd53..b6c0ae9c 100644 --- a/testbot/web/ResetPassword.pl +++ b/testbot/web/ResetPassword.pl @@ -118,8 +118,8 @@ sub OnChangePassword($) return !1; } - ($ErrMessage, my $User) = $Users->Authenticate($self->GetParam("Name"), - $self->GetParam("Password1")); + ($ErrMessage, my $_User) = $Users->Authenticate($self->GetParam("Name"), + $self->GetParam("Password1")); if (defined $ErrMessage) { $self->AddError($ErrMessage, "Name"); @@ -127,8 +127,7 @@ sub OnChangePassword($) } my $Sessions = CreateSessions(); - ($ErrMessage, my $Session) = $Sessions->NewSession($User, - defined($self->GetParam("AutoLogin"))); + ($ErrMessage, my $_Session) = $Sessions->NewSession($User, defined $self->GetParam("AutoLogin")); if ($ErrMessage) { $self->AddError($ErrMessage, "Name");

1 0

Francois Gouget : testbot/web: Add links to the first and last new untracked failures.
by Alexandre Julliard 08 Jul '22

08 Jul '22

Module: tools Branch: master Commit: 8f9b52478dc31b7883447a83e7ca9862439bd4cf URL: https://source.winehq.org/git/tools.git/?a=commit;h=8f9b52478dc31b7883447a8… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Fri Jul 8 15:34:42 2022 +0200 testbot/web: Add links to the first and last new untracked failures. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- testbot/web/JobDetails.pl | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/testbot/web/JobDetails.pl b/testbot/web/JobDetails.pl index 3fbdb427..321d025e 100644 --- a/testbot/web/JobDetails.pl +++ b/testbot/web/JobDetails.pl @@ -437,8 +437,13 @@ sub GenerateFullLog($$$$$) } } } - $LogBugs{-1} ||= [$LineNo, ""]; - $LogBugs{9999999} = [$LineNo, ""]; + $LogBugs{-2} ||= [$LineNo, "First failure"]; + if ($ErrCategory{$LineNo} eq "fullnew" and !$ErrFailures{$LineNo}) + { + $LogBugs{-1} ||= [$LineNo, "First untracked new failure"]; + $LogBugs{10000000} = [$LineNo, "Last untracked new failure"]; + } + $LogBugs{10000001} = [$LineNo, "Last failure"]; } } if (%LogBugs) @@ -447,7 +452,11 @@ sub GenerateFullLog($$$$$) foreach my $Label (sort { $a <=> $b } keys %LogBugs) { my ($LineNo, $Title) = @{$LogBugs{$Label}}; - $Label = $Label < 0 ? "First" : $Label == 9999999 ? "Last" : $Label; + $Label = $Label == -2 ? "First" : + $Label == -1 ? "new" : + $Label == 10000000 ? "new" : + $Label == 10000001 ? "Last" : + $Label; $Title = " title='". $self->escapeHTML($Title) ."'" if ($Title); print " <a href='#k${LogId}L$LineNo'$Title>$Label</a>" }

1 0

Alexandre Julliard : Use Gitlab for git URLs.
by Alexandre Julliard 08 Jul '22

08 Jul '22

Module: website Branch: master Commit: ebb1a0246f8098bc88f80e9ccf9609b005daf944 URL: https://source.winehq.org/git/website.git/?a=commit;h=ebb1a0246f8098bc88f80… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Fri Jul 8 14:15:55 2022 +0200 Use Gitlab for git URLs. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- include/plugins/announce.php | 4 ++-- include/winehq.conf.sample | 4 ++-- templates/de/home.template | 4 ++-- templates/en/home.template | 4 ++-- templates/es/home.template | 4 ++-- templates/fr/home.template | 4 ++-- templates/ko/home.template | 4 ++-- templates/nl/home.template | 4 ++-- templates/pl/home.template | 4 ++-- templates/pt/home.template | 4 ++-- templates/tr/home.template | 4 ++-- templates/uk/home.template | 4 ++-- templates/zh-cn/home.template | 4 ++-- 13 files changed, 26 insertions(+), 26 deletions(-) Diff: https://source.winehq.org/git/website.git/?a=commitdiff;h=ebb1a0246f8098bc8…

1 0

Alexandre Julliard : Use Gitlab for commit URLs.
by Alexandre Julliard 08 Jul '22

08 Jul '22

Module: bugzilla Branch: master Commit: ea4302dd1afc72b1edb0039222c4bb7c2b7af7e9 URL: https://source.winehq.org/git/bugzilla.git/?a=commit;h=ea4302dd1afc72b1edb0… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Fri Jul 8 12:14:26 2022 +0200 Use Gitlab for commit URLs. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- template/en/default/bug/edit.html.tmpl | 4 ++-- template/en/default/list/table.html.tmpl | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/template/en/default/bug/edit.html.tmpl b/template/en/default/bug/edit.html.tmpl index 5685dc3..7cf3932 100644 --- a/template/en/default/bug/edit.html.tmpl +++ b/template/en/default/bug/edit.html.tmpl @@ -904,12 +904,12 @@ <tr> [% IF field.name == 'cf_regression_sha1sum' && bug.${field.name} %] [% PROCESS bug/field.html.tmpl value = bug.${field.name} - desc_url = "//source.winehq.org/git/wine.git/commit/${bug.cf_regression_sha1sum}" + desc_url = "https://gitlab.winehq.org/wine/wine/-/commit/${bug.cf_regression_sha1sum}" editable = bug.check_can_change_field(field.name, 0, 1) value_span = 2 %] [% ELSIF field.name == 'cf_fixedby_sha1sum' && bug.${field.name} %] [% PROCESS bug/field.html.tmpl value = bug.${field.name} - desc_url = "//source.winehq.org/git/wine.git/commit/${bug.cf_fixedby_sha1sum}" + desc_url = "https://gitlab.winehq.org/wine/wine/-/commit/${bug.cf_fixedby_sha1sum}" editable = bug.check_can_change_field(field.name, 0, 1) value_span = 2 %] [% ELSIF field.name == 'cf_staged_patchset' && bug.${field.name} && is_safe_url("${bug.cf_staged_patchset}") %] diff --git a/template/en/default/list/table.html.tmpl b/template/en/default/list/table.html.tmpl index 21f7713..a68b14c 100644 --- a/template/en/default/list/table.html.tmpl +++ b/template/en/default/list/table.html.tmpl @@ -199,10 +199,10 @@ [%- bug.$column.truncate(abbrev.$column.maxlength, abbrev.$column.ellipsis) FILTER html -%] </a> [% ELSIF column == 'cf_regression_sha1sum' && bug.cf_regression_sha1sum %] - <a href="//source.winehq.org/git/wine.git/commit/[% bug.cf_regression_sha1sum FILTER html %]"> + <a href="https://gitlab.winehq.org/wine/wine/-/commit/[% bug.cf_regression_sha1sum FILTER html %]"> [% bug.cf_regression_sha1sum.truncate(16) FILTER html %]</a> [% ELSIF column == 'cf_fixedby_sha1sum' && bug.cf_fixedby_sha1sum %] - <a href="//source.winehq.org/git/wine.git/commit/[% bug.cf_fixedby_sha1sum FILTER html %]"> + <a href="https://gitlab.winehq.org/wine/wine/-/commit/[% bug.cf_fixedby_sha1sum FILTER html %]"> [% bug.cf_fixedby_sha1sum.truncate(16) FILTER html %]</a> [% ELSE %] [%- display_value(column, bug.$column).truncate(abbrev.$column.maxlength, abbrev.$column.ellipsis) FILTER html -%]

1 0

Akihiro Sagawa : mciqtz32: Fix thread handle leak if a second play.
by Alexandre Julliard 07 Jul '22

07 Jul '22

Module: wine Branch: master Commit: de0794a1ddbfaa5bab9728e5d8f956541079c341 URL: https://source.winehq.org/git/wine.git/?a=commit;h=de0794a1ddbfaa5bab9728e5… Author: Akihiro Sagawa <sagawa.aki(a)gmail.com> Date: Tue Jul 5 21:02:49 2022 +0900 mciqtz32: Fix thread handle leak if a second play. Signed-off-by: Akihiro Sagawa <sagawa.aki(a)gmail.com> --- dlls/mciqtz32/mciqtz.c | 11 +++++++---- dlls/winmm/tests/mci.c | 13 +++++++++++++ 2 files changed, 20 insertions(+), 4 deletions(-) diff --git a/dlls/mciqtz32/mciqtz.c b/dlls/mciqtz32/mciqtz.c index a7ec0b78f33..5bde3f5dd14 100644 --- a/dlls/mciqtz32/mciqtz.c +++ b/dlls/mciqtz32/mciqtz.c @@ -449,10 +449,13 @@ static DWORD MCIQTZ_mciPlay(UINT wDevID, DWORD dwFlags, LPMCI_PLAY_PARMS lpParms IVideoWindow_put_Visible(wma->vidwin, OATRUE); - wma->thread = CreateThread(NULL, 0, MCIQTZ_notifyThread, wma, 0, NULL); - if (!wma->thread) { - TRACE("Can't create thread\n"); - return MCIERR_INTERNAL; + if (!wma->thread) + { + wma->thread = CreateThread(NULL, 0, MCIQTZ_notifyThread, wma, 0, NULL); + if (!wma->thread) { + TRACE("Can't create thread\n"); + return MCIERR_INTERNAL; + } } return 0; } diff --git a/dlls/winmm/tests/mci.c b/dlls/winmm/tests/mci.c index cfad9a77da8..2e31cf51708 100644 --- a/dlls/winmm/tests/mci.c +++ b/dlls/winmm/tests/mci.c @@ -1336,6 +1336,19 @@ static void test_playWaveTypeMpegvideo(void) err = mciSendStringA("close mysound", NULL, 0, NULL); ok(!err,"mci close returned %s\n", dbg_mcierr(err)); + + /* test a second play */ + err = mciSendStringA("open tempfile.wav type MPEGVideo alias mysound", NULL, 0, NULL); + ok(err==ok_saved,"mci open tempfile.wav type MPEGVideo returned %s\n", dbg_mcierr(err)); + + err = mciSendStringA("play mysound", NULL, 0, NULL); + ok(!err,"mci play retuend %s\n", dbg_mcierr(err)); + + err = mciSendStringA("play mysound", NULL, 0, NULL); + ok(!err,"mci play retuend %s\n", dbg_mcierr(err)); + + err = mciSendStringA("close mysound", NULL, 0, NULL); + ok(!err,"mci close returned %s\n", dbg_mcierr(err)); } static void test_asyncWaveTypeMpegvideo(HWND hwnd)

1 0

Hugh McMaster : regedit: Replace heap_x*() functions with malloc(), realloc() and free().
by Alexandre Julliard 07 Jul '22

07 Jul '22

Module: wine Branch: master Commit: a6063f836737fd1bb3719a607885b6a0533c7f63 URL: https://source.winehq.org/git/wine.git/?a=commit;h=a6063f836737fd1bb3719a60… Author: Hugh McMaster <hugh.mcmaster(a)outlook.com> Date: Thu Jul 7 21:55:37 2022 +1000 regedit: Replace heap_x*() functions with malloc(), realloc() and free(). Signed-off-by: Hugh McMaster <hugh.mcmaster(a)outlook.com> --- programs/regedit/childwnd.c | 29 +++++----- programs/regedit/edit.c | 36 ++++++------- programs/regedit/framewnd.c | 46 ++++++++-------- programs/regedit/hexedit.c | 25 +++++---- programs/regedit/listview.c | 30 +++++------ programs/regedit/main.c | 1 - programs/regedit/main.h | 3 +- programs/regedit/regedit.c | 14 ++--- programs/regedit/regproc.c | 128 +++++++++++++++++--------------------------- programs/regedit/treeview.c | 54 +++++++++---------- 10 files changed, 163 insertions(+), 203 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=a6063f836737fd1bb371…

1 0

Stefan Rentsch : wbemprox: Provide more accurate system information.
by Alexandre Julliard 07 Jul '22

07 Jul '22

Module: wine Branch: master Commit: fefe108e2043d8a9d993b4e2cb129c851ca5e795 URL: https://source.winehq.org/git/wine.git/?a=commit;h=fefe108e2043d8a9d993b4e2… Author: Stefan Rentsch <et14rest(a)gmail.com> Date: Tue Jul 5 14:28:30 2022 +0200 wbemprox: Provide more accurate system information. This re-uses existing functions from Win32_ComputerSystemProduct to provide more accurate values, which are helpful to system overview applications. > wmic.exe computersystem GET Manufacturer --- dlls/wbemprox/builtin.c | 67 +++++++++++++++++++++++++++---------------------- 1 file changed, 37 insertions(+), 30 deletions(-) diff --git a/dlls/wbemprox/builtin.c b/dlls/wbemprox/builtin.c index 4ac52918f6f..820fb61930f 100644 --- a/dlls/wbemprox/builtin.c +++ b/dlls/wbemprox/builtin.c @@ -1625,20 +1625,52 @@ static WCHAR *get_username(void) return ret; } +static WCHAR *get_compsysproduct_string( BYTE id, const char *buf, UINT len ) +{ + const struct smbios_header *hdr; + const struct smbios_system *system; + UINT offset; + + if (!(hdr = find_smbios_entry( SMBIOS_TYPE_SYSTEM, buf, len ))) return NULL; + + system = (const struct smbios_system *)hdr; + offset = (const char *)system - buf + system->hdr.length; + return get_smbios_string( id, buf, offset, len ); +} + +static WCHAR *get_compsysproduct_name( const char *buf, UINT len ) +{ + WCHAR *ret = get_compsysproduct_string( 2, buf, len ); + if (!ret) return wcsdup( L"Wine" ); + return ret; +} + +static WCHAR *get_compsysproduct_vendor( const char *buf, UINT len ) +{ + WCHAR *ret = get_compsysproduct_string( 1, buf, len ); + if (!ret) return wcsdup( L"The Wine Project" ); + return ret; +} + static enum fill_status fill_compsys( struct table *table, const struct expr *cond ) { struct record_computersystem *rec; enum fill_status status = FILL_STATUS_UNFILTERED; - UINT row = 0; + UINT row = 0, len; + char *buf; if (!resize_table( table, 1, sizeof(*rec) )) return FILL_STATUS_FAILED; + len = GetSystemFirmwareTable( RSMB, 0, NULL, 0 ); + if (!(buf = malloc( len ))) return FILL_STATUS_FAILED; + GetSystemFirmwareTable( RSMB, 0, buf, len ); + rec = (struct record_computersystem *)table->data; rec->description = L"AT/AT COMPATIBLE"; rec->domain = L"WORKGROUP"; rec->domainrole = 0; /* standalone workstation */ - rec->manufacturer = L"The Wine Project"; - rec->model = L"Wine"; + rec->manufacturer = get_compsysproduct_vendor( buf, len ); + rec->model = get_compsysproduct_name( buf, len ); rec->name = get_computername(); rec->num_logical_processors = get_logical_processor_count( NULL, &rec->num_processors ); rec->systemtype = get_systemtype(); @@ -1647,24 +1679,13 @@ static enum fill_status fill_compsys( struct table *table, const struct expr *co if (!match_row( table, row, cond, &status )) free_row_values( table, row ); else row++; + free( buf ); + TRACE("created %u rows\n", row); table->num_rows = row; return status; } -static WCHAR *get_compsysproduct_string( BYTE id, const char *buf, UINT len ) -{ - const struct smbios_header *hdr; - const struct smbios_system *system; - UINT offset; - - if (!(hdr = find_smbios_entry( SMBIOS_TYPE_SYSTEM, buf, len ))) return NULL; - - system = (const struct smbios_system *)hdr; - offset = (const char *)system - buf + system->hdr.length; - return get_smbios_string( id, buf, offset, len ); -} - static WCHAR *get_compsysproduct_identifyingnumber( const char *buf, UINT len ) { WCHAR *ret = get_compsysproduct_string( 4, buf, len ); @@ -1672,13 +1693,6 @@ static WCHAR *get_compsysproduct_identifyingnumber( const char *buf, UINT len ) return ret; } -static WCHAR *get_compsysproduct_name( const char *buf, UINT len ) -{ - WCHAR *ret = get_compsysproduct_string( 2, buf, len ); - if (!ret) return wcsdup( L"Wine" ); - return ret; -} - static WCHAR *get_compsysproduct_uuid( const char *buf, UINT len ) { static const BYTE none[] = {0xff,0xff,0xff,0xff,0xff,0xff,0xff,0xff,0xff,0xff,0xff,0xff,0xff,0xff,0xff,0xff}; @@ -1700,13 +1714,6 @@ done: return ret; } -static WCHAR *get_compsysproduct_vendor( const char *buf, UINT len ) -{ - WCHAR *ret = get_compsysproduct_string( 1, buf, len ); - if (!ret) return wcsdup( L"The Wine Project" ); - return ret; -} - static WCHAR *get_compsysproduct_version( const char *buf, UINT len ) { WCHAR *ret = get_compsysproduct_string( 3, buf, len );

1 0

Alexandre Julliard : server: Use standard named object functions for registry keys.
by Alexandre Julliard 07 Jul '22

07 Jul '22

Module: wine Branch: master Commit: 569c27945e9479e9b27a5ffaa9b0587e6f1f2ac7 URL: https://source.winehq.org/git/wine.git/?a=commit;h=569c27945e9479e9b27a5ffa… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Thu Jul 7 12:32:22 2022 +0200 server: Use standard named object functions for registry keys. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/ntdll/tests/om.c | 4 - dlls/ntdll/tests/reg.c | 32 +--- server/registry.c | 487 +++++++++++++++---------------------------------- 3 files changed, 152 insertions(+), 371 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=569c27945e9479e9b27a…

1 0

Roman Pišl : wpcap: Implement pcap_dispatch.
by Alexandre Julliard 07 Jul '22

07 Jul '22

Module: wine Branch: master Commit: 556077e674ce4a44bf1ae2ea2e4dd5b2501ce175 URL: https://source.winehq.org/git/wine.git/?a=commit;h=556077e674ce4a44bf1ae2ea… Author: Roman Pišl <rpisl(a)seznam.cz> Date: Tue Jul 5 12:11:03 2022 +0200 wpcap: Implement pcap_dispatch. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53104 Signed-off-by: Roman Pišl <rpisl(a)seznam.cz> Signed-off-by: André Zwing <nerv(a)dawncrow.de> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/wpcap/wpcap.c | 41 ++++++++++++++++++++++++++++++++--------- 1 file changed, 32 insertions(+), 9 deletions(-) diff --git a/dlls/wpcap/wpcap.c b/dlls/wpcap/wpcap.c index a295819f7fe..df35954bfa7 100644 --- a/dlls/wpcap/wpcap.c +++ b/dlls/wpcap/wpcap.c @@ -99,15 +99,6 @@ const char * CDECL pcap_datalink_val_to_name( int link ) return ret; } -int CDECL pcap_dispatch( struct pcap *pcap, int count, - void (CALLBACK *callback)(unsigned char *, const struct pcap_pkthdr_win32 *, const unsigned char *), - unsigned char *user ) -{ - /* FIXME: reimplement on top of pcap_next_ex */ - FIXME( "%p, %d, %p, %p: not implemented\n", pcap, count, callback, user ); - return -1; -} - void CDECL pcap_dump( unsigned char *user, const struct pcap_pkthdr_win32 *hdr, const unsigned char *packet ) { struct dump_params params = { user, hdr, packet }; @@ -543,6 +534,38 @@ const unsigned char * CDECL pcap_next( struct pcap *pcap, struct pcap_pkthdr_win return data; } +int CDECL pcap_dispatch( struct pcap *pcap, int count, + void (CALLBACK *callback)(unsigned char *, const struct pcap_pkthdr_win32 *, const unsigned char *), + unsigned char *user ) +{ + int processed = 0; + TRACE( "%p, %d, %p, %p\n", pcap, count, callback, user ); + + while (processed < count) + { + struct pcap_pkthdr_win32 *hdr = NULL; + const unsigned char *data = NULL; + + int ret = pcap_next_ex( pcap, &hdr, &data ); + + if (ret == 1) + processed++; + else if (ret == 0) + break; + else if (ret == -2) + { + if (processed == 0) return -2; + break; + } + else + return ret; + + callback( user, hdr, data ); + } + + return processed; +} + static char *strdupWA( const WCHAR *src ) { char *dst;

1 0