February 2023 - Wine-commits

Zebediah Figura : wined3d: Destroy objects belonging to wined3d_device_gl.completed_fence_id.
by Alexandre Julliard 14 Feb '23

14 Feb '23

Module: wine Branch: master Commit: 97b836a938928ce714fd7cf430a97d5fbefd7df0 URL: https://gitlab.winehq.org/wine/wine/-/commit/97b836a938928ce714fd7cf430a97d… Author: Zebediah Figura <zfigura(a)codeweavers.com> Date: Thu Feb 2 16:59:14 2023 -0600 wined3d: Destroy objects belonging to wined3d_device_gl.completed_fence_id. Not just those belonging to earlier completed fences. completed_fence_id names the most recent fence to be completed. In essence, this fixes an off-by-one error. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53217 --- dlls/wined3d/context_gl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/wined3d/context_gl.c b/dlls/wined3d/context_gl.c index 0217e12d903..5574997bf05 100644 --- a/dlls/wined3d/context_gl.c +++ b/dlls/wined3d/context_gl.c @@ -2726,7 +2726,7 @@ static void wined3d_context_gl_destroy_allocator_block(struct wined3d_context_gl struct wined3d_device_gl *device_gl = wined3d_device_gl(context_gl->c.device); struct wined3d_retired_block_gl *r; - if (device_gl->completed_fence_id > fence_id) + if (device_gl->completed_fence_id >= fence_id) { wined3d_device_gl_free_memory(device_gl, block); TRACE("Freed block %p.\n", block);

1 0

Paul Gofman : imm32: Disable cross thread access for ImmSetCompositionString().
by Alexandre Julliard 14 Feb '23

14 Feb '23

Module: wine Branch: master Commit: 9bcc90fb4bc81da21fc70e27e538c4349c7da388 URL: https://gitlab.winehq.org/wine/wine/-/commit/9bcc90fb4bc81da21fc70e27e538c4… Author: Paul Gofman <pgofman(a)codeweavers.com> Date: Fri Feb 3 20:15:48 2023 -0600 imm32: Disable cross thread access for ImmSetCompositionString(). --- dlls/imm32/imm.c | 6 ++++++ dlls/imm32/tests/imm32.c | 8 ++++++++ 2 files changed, 14 insertions(+) diff --git a/dlls/imm32/imm.c b/dlls/imm32/imm.c index fa2e0705db1..17061ae0034 100644 --- a/dlls/imm32/imm.c +++ b/dlls/imm32/imm.c @@ -2377,6 +2377,9 @@ BOOL WINAPI ImmSetCompositionStringA( if (!data) return FALSE; + if (IMM_IsCrossThreadAccess(NULL, hIMC)) + return FALSE; + if (!(dwIndex == SCS_SETSTR || dwIndex == SCS_CHANGEATTR || dwIndex == SCS_CHANGECLAUSE || @@ -2432,6 +2435,9 @@ BOOL WINAPI ImmSetCompositionStringW( if (!data) return FALSE; + if (IMM_IsCrossThreadAccess(NULL, hIMC)) + return FALSE; + if (!(dwIndex == SCS_SETSTR || dwIndex == SCS_CHANGEATTR || dwIndex == SCS_CHANGECLAUSE || diff --git a/dlls/imm32/tests/imm32.c b/dlls/imm32/tests/imm32.c index 75b5cde6c7b..496dc284fbc 100644 --- a/dlls/imm32/tests/imm32.c +++ b/dlls/imm32/tests/imm32.c @@ -984,6 +984,14 @@ static void test_ImmThreads(void) rc = ImmSetCompositionFontA(threadinfo.u_himc, &lf); ok(rc == 0, "ImmSetCompositionFont should fail\n"); + /* CompositionString */ + rc = ImmSetCompositionStringA(himc, SCS_SETSTR, "a", 2, NULL, 0); + ok(rc, "failed.\n"); + rc = ImmSetCompositionStringA(otherHimc, SCS_SETSTR, "a", 2, NULL, 0); + ok(!rc, "should fail.\n"); + rc = ImmSetCompositionStringA(threadinfo.u_himc, SCS_SETSTR, "a", 2, NULL, 0); + ok(!rc, "should fail.\n"); + /* CompositionWindow */ rc = ImmSetCompositionWindow(himc, &cf); ok(rc != 0, "ImmSetCompositionWindow failed\n");

1 0

Jinoh Kang : ntdll/tests: Update test_RtlUniform to match Windows Vista or later.
by Alexandre Julliard 14 Feb '23

14 Feb '23

Module: wine Branch: master Commit: b4ca6643b7163b500940b30ddd4aaa6033b983b6 URL: https://gitlab.winehq.org/wine/wine/-/commit/b4ca6643b7163b500940b30ddd4aaa… Author: Jinoh Kang <jinoh.kang.kr(a)gmail.com> Date: Sun Sep 11 02:59:00 2022 +0900 ntdll/tests: Update test_RtlUniform to match Windows Vista or later. Today, test_RtlUniform() skips almost all of its tests on Windows Vista or later. The skipped tests only succeed in Windows XP, and fail on Windows Vista or later. This is because RtlUniform()'s behavior has changed, presumably due to a bug fix shipped in Windows Vista. It appears that RtlUniform, a linear congruential generator, could overflow before computing the modulo in WindoWs XP. This is no longer the case in Windows Vista or later. Meanwhile, we no longer support Windows XP behavior and thus do not test for it regularly; therefore, the tests are obsolete as of 2023. Remove obsolete tests that no longer work with any of the Windows versions actively tested by WineHQ (as of 2023), and replace them with updated tests that works in the Windows versions from Vista up to 10. --- dlls/ntdll/tests/rtl.c | 330 ++++++++++++------------------------------------- 1 file changed, 78 insertions(+), 252 deletions(-)

1 0

Jinoh Kang : ntdll: Fix integer overflow in RtlUniform.
by Alexandre Julliard 14 Feb '23

14 Feb '23

Module: wine Branch: master Commit: 5242546465d9e333c488a612361dafe8d53e40a3 URL: https://gitlab.winehq.org/wine/wine/-/commit/5242546465d9e333c488a612361daf… Author: Jinoh Kang <jinoh.kang.kr(a)gmail.com> Date: Sun Sep 11 03:04:16 2022 +0900 ntdll: Fix integer overflow in RtlUniform. The integer overflow bug in RtlUniform has been fixed since Windows Vista. Synchronize Wine's version accordingly. --- dlls/ntdll/rtl.c | 32 +++++--------------------------- dlls/ntdll/tests/rtl.c | 6 ------ 2 files changed, 5 insertions(+), 33 deletions(-) diff --git a/dlls/ntdll/rtl.c b/dlls/ntdll/rtl.c index 84488ea1d81..25927afce54 100644 --- a/dlls/ntdll/rtl.c +++ b/dlls/ntdll/rtl.c @@ -684,7 +684,7 @@ __ASM_FASTCALL_FUNC(RtlUshortByteSwap, 4, /************************************************************************* * RtlUniform [NTDLL.@] * - * Generates an uniform random number + * Generates a uniform random number * * PARAMS * seed [O] The seed of the Random function @@ -693,12 +693,7 @@ __ASM_FASTCALL_FUNC(RtlUshortByteSwap, 4, * It returns a random number uniformly distributed over [0..MAXLONG-1]. * * NOTES - * Generates an uniform random number using D.H. Lehmer's 1948 algorithm. - * In our case the algorithm is: - * - *| result = (*seed * 0x7fffffed + 0x7fffffc3) % MAXLONG; - *| - *| *seed = result; + * Generates a uniform random number using a linear congruential generator. * * DIFFERENCES * The native documentation states that the random number is @@ -706,27 +701,10 @@ __ASM_FASTCALL_FUNC(RtlUshortByteSwap, 4, * function and our function return a random number uniformly * distributed over [0..MAXLONG-1]. */ -ULONG WINAPI RtlUniform (PULONG seed) +ULONG WINAPI RtlUniform( ULONG *seed ) { - ULONG result; - - /* - * Instead of the algorithm stated above, we use the algorithm - * below, which is totally equivalent (see the tests), but does - * not use a division and therefore is faster. - */ - result = *seed * 0xffffffed + 0x7fffffc3; - if (result == 0xffffffff || result == 0x7ffffffe) { - result = (result + 2) & MAXLONG; - } else if (result == 0x7fffffff) { - result = 0; - } else if ((result & 0x80000000) == 0) { - result = result + (~result & 1); - } else { - result = (result + (result & 1)) & MAXLONG; - } /* if */ - *seed = result; - return result; + /* See the tests for details. */ + return (*seed = ((ULONGLONG)*seed * 0x7fffffed + 0x7fffffc3) % 0x7fffffff); } diff --git a/dlls/ntdll/tests/rtl.c b/dlls/ntdll/tests/rtl.c index 3a308b38499..493cdc92cac 100644 --- a/dlls/ntdll/tests/rtl.c +++ b/dlls/ntdll/tests/rtl.c @@ -425,7 +425,6 @@ static void test_RtlUniform(void) expected = 0x7fffffb1; result = RtlUniform(&seed); - todo_wine ok(result == expected, "RtlUniform(&seed (seed == 0x80000000)) returns %lx, expected %lx\n", result, expected); @@ -438,7 +437,6 @@ static void test_RtlUniform(void) seed = 0x7fffffff; expected = 0x7fffffc3; result = RtlUniform(&seed); - todo_wine ok(result == expected, "RtlUniform(&seed (seed == 0x7fffffff)) returns %lx, expected %lx\n", result, expected); @@ -468,11 +466,9 @@ static void test_RtlUniform(void) seed = num; expected = ((ULONGLONG)seed * 0x7fffffed + 0x7fffffc3) % 0x7fffffff; result = RtlUniform(&seed); - todo_wine_if(num >= 2) ok(result == expected, "test: RtlUniform(&seed (seed == %lx)) returns %lx, expected %lx\n", num, result, expected); - todo_wine_if(num >= 2) ok(seed == expected, "test: RtlUniform(&seed (seed == %lx)) sets seed to %lx, expected %lx\n", num, result, expected); @@ -485,11 +481,9 @@ static void test_RtlUniform(void) expected = ((ULONGLONG)seed * 0x7fffffed + 0x7fffffc3) % 0x7fffffff; seed_bak = seed; result = RtlUniform(&seed); - todo_wine_if(seed_bak >= 2) ok(result == expected, "test: %ld RtlUniform(&seed (seed == %lx)) returns %lx, expected %lx\n", num, seed_bak, result, expected); - todo_wine_if(seed_bak >= 2) ok(seed == expected, "test: %ld RtlUniform(&seed (seed == %lx)) sets seed to %lx, expected %lx\n", num, seed_bak, result, expected);

1 0

Rémi Bernon : dinput: Use a WH_CBT hook instead of WH_CALLWNDPROC.
by Alexandre Julliard 14 Feb '23

14 Feb '23

Module: wine Branch: master Commit: b3aea08c319f4b52afba141d10a0dfac92880c15 URL: https://gitlab.winehq.org/wine/wine/-/commit/b3aea08c319f4b52afba141d10a0df… Author: Rémi Bernon <rbernon(a)codeweavers.com> Date: Mon Feb 13 23:43:09 2023 +0100 dinput: Use a WH_CBT hook instead of WH_CALLWNDPROC. WH_CALLWNDPROC hooks are called on every message, but we only need it for the activation messages. WH_CBT hooks are called for a few events only, which is much lighter, as we need to use a global hook to track windows which belong to any other thread. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54431 --- dlls/dinput/dinput_main.c | 21 ++++++++++++--------- 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/dlls/dinput/dinput_main.c b/dlls/dinput/dinput_main.c index 0bff483f100..9af8e064dc4 100644 --- a/dlls/dinput/dinput_main.c +++ b/dlls/dinput/dinput_main.c @@ -52,6 +52,7 @@ WINE_DEFAULT_DEBUG_CHANNEL(dinput); #define INPUT_THREAD_NOTIFY (WM_USER + 0x10) #define NOTIFY_THREAD_STOP 0 #define NOTIFY_REFRESH_DEVICES 1 +#define NOTIFY_FOREGROUND_LOST 2 struct input_thread_state { @@ -211,15 +212,14 @@ static void dinput_unacquire_devices(void) LeaveCriticalSection( &dinput_hook_crit ); } -static LRESULT CALLBACK callwndproc_proc( int code, WPARAM wparam, LPARAM lparam ) +static LRESULT CALLBACK cbt_hook_proc( int code, WPARAM wparam, LPARAM lparam ) { - CWPSTRUCT *msg = (CWPSTRUCT *)lparam; - - if (code != HC_ACTION || (msg->message != WM_KILLFOCUS && - msg->message != WM_ACTIVATEAPP && msg->message != WM_ACTIVATE)) - return CallNextHookEx( 0, code, wparam, lparam ); - - if (msg->hwnd != GetForegroundWindow()) dinput_unacquire_window_devices( msg->hwnd ); + if (code == HCBT_ACTIVATE && di_em_win) + { + CBTACTIVATESTRUCT *data = (CBTACTIVATESTRUCT *)lparam; + SendMessageW( di_em_win, INPUT_THREAD_NOTIFY, NOTIFY_FOREGROUND_LOST, + (LPARAM)data->hWndActive ); + } return CallNextHookEx( 0, code, wparam, lparam ); } @@ -265,7 +265,7 @@ static void input_thread_update_device_list( struct input_thread_state *state ) LeaveCriticalSection( &dinput_hook_crit ); if (foreground_count && !state->callwndproc_hook) - state->callwndproc_hook = SetWindowsHookExW( WH_CALLWNDPROC, callwndproc_proc, DINPUT_instance, GetCurrentThreadId() ); + state->callwndproc_hook = SetWindowsHookExW( WH_CBT, cbt_hook_proc, DINPUT_instance, 0 ); else if (!foreground_count && state->callwndproc_hook) { UnhookWindowsHookEx( state->callwndproc_hook ); @@ -341,6 +341,9 @@ static LRESULT WINAPI di_em_win_wndproc(HWND hwnd, UINT msg, WPARAM wparam, LPAR while (state->devices_count--) dinput_device_internal_release( state->devices[state->devices_count] ); input_thread_update_device_list( state ); break; + case NOTIFY_FOREGROUND_LOST: + dinput_unacquire_window_devices( (HWND)lparam ); + break; } return 0;

1 0

Zebediah Figura : ddraw/tests: Remove unnecessary skips and conditionals from test_pixel_format().
by Alexandre Julliard 14 Feb '23

14 Feb '23

Module: wine Branch: master Commit: 02b482f47b84c46e8f1427a4480b12acc03ba18c URL: https://gitlab.winehq.org/wine/wine/-/commit/02b482f47b84c46e8f1427a4480b12… Author: Zebediah Figura <zfigura(a)codeweavers.com> Date: Fri Jan 20 17:37:21 2023 -0600 ddraw/tests: Remove unnecessary skips and conditionals from test_pixel_format(). We do not expect normal CreateWindow() and GetDC() calls to ever fail. --- dlls/ddraw/tests/ddraw1.c | 108 ++++++++++++++++------------------------------ dlls/ddraw/tests/ddraw2.c | 108 ++++++++++++++++------------------------------ dlls/ddraw/tests/ddraw4.c | 108 ++++++++++++++++------------------------------ dlls/ddraw/tests/ddraw7.c | 108 ++++++++++++++++------------------------------ 4 files changed, 152 insertions(+), 280 deletions(-)

1 0

Zebediah Figura : d3d9/tests: Test that presenting does not set the pixel format on a window without one.
by Alexandre Julliard 14 Feb '23

14 Feb '23

Module: wine Branch: master Commit: 5535d834ee8f9378abde40f29436a924fde5a596 URL: https://gitlab.winehq.org/wine/wine/-/commit/5535d834ee8f9378abde40f29436a9… Author: Zebediah Figura <zfigura(a)codeweavers.com> Date: Fri Jan 20 17:56:32 2023 -0600 d3d9/tests: Test that presenting does not set the pixel format on a window without one. --- dlls/d3d9/tests/device.c | 72 ++++++++++++++++++++++++++++++++++++++++++------ 1 file changed, 64 insertions(+), 8 deletions(-) diff --git a/dlls/d3d9/tests/device.c b/dlls/d3d9/tests/device.c index 0a95e819018..0e361b3ac23 100644 --- a/dlls/d3d9/tests/device.c +++ b/dlls/d3d9/tests/device.c @@ -11050,10 +11050,12 @@ static void test_pixel_format(void) PIXELFORMATDESCRIPTOR pfd; IDirect3D9 *d3d9 = NULL; IDirect3DDevice9 *device = NULL; - HWND hwnd, hwnd2; - HDC hdc, hdc2; + HWND hwnd, hwnd2, hwnd3; + HDC hdc, hdc2, hdc3; + ULONG refcount; HMODULE gl; HRESULT hr; + BOOL ret; static const float point[] = {0.0f, 0.0f, 0.0f}; @@ -11152,14 +11154,68 @@ static void test_pixel_format(void) test_format = GetPixelFormat(hdc2); ok(test_format == format, "second window has pixel format %d, expected %d\n", test_format, format); -cleanup: - if (device) + refcount = IDirect3DDevice9_Release(device); + ok(!refcount, "Device has %lu references left.\n", refcount); + IDirect3D9_Release(d3d9); + + test_format = GetPixelFormat(hdc); + ok(test_format == format, "window has pixel format %d, expected %d\n", test_format, format); + + test_format = GetPixelFormat(hdc2); + ok(test_format == format, "second window has pixel format %d, expected %d\n", test_format, format); + + /* Test that creating a device doesn't set a pixel format on a window which + * never had one. */ + + hwnd3 = create_window(); + hdc3 = GetDC(hwnd3); + + test_format = GetPixelFormat(hdc3); + ok(!test_format, "Expected no format, got %d.\n", test_format); + + d3d9 = Direct3DCreate9(D3D_SDK_VERSION); + ok(!!d3d9, "Failed to create a D3D object.\n"); + if (!(device = create_device(d3d9, hwnd3, NULL))) { - ULONG refcount = IDirect3DDevice9_Release(device); - ok(!refcount, "Device has %lu references left.\n", refcount); + skip("Failed to create device\n"); + goto cleanup; } - if (d3d9) - IDirect3D9_Release(d3d9); + + hr = IDirect3DDevice9_SetFVF(device, D3DFVF_XYZ); + ok(hr == S_OK, "Got hr %#lx.\n", hr); + hr = IDirect3DDevice9_BeginScene(device); + ok(hr == S_OK, "Got hr %#lx.\n", hr); + hr = IDirect3DDevice9_DrawPrimitiveUP(device, D3DPT_POINTLIST, 1, point, 3 * sizeof(float)); + ok(hr == S_OK, "Got hr %#lx.\n", hr); + hr = IDirect3DDevice9_EndScene(device); + ok(hr == S_OK, "Got hr %#lx.\n", hr); + + test_format = GetPixelFormat(hdc3); + todo_wine ok(!test_format, "Expected no format, got %d.\n", test_format); + + hr = IDirect3DDevice9_Present(device, NULL, NULL, NULL, NULL); + ok(hr == S_OK, "Got hr %#lx.\n", hr); + + test_format = GetPixelFormat(hdc3); + todo_wine ok(!test_format, "Expected no format, got %d.\n", test_format); + + refcount = IDirect3DDevice9_Release(device); + ok(!refcount, "Device has %lu references left.\n", refcount); + IDirect3D9_Release(d3d9); + + test_format = GetPixelFormat(hdc3); + todo_wine ok(!test_format, "Expected no format, got %d.\n", test_format); + + ret = SetPixelFormat(hdc3, format, &pfd); + ok(ret, "Failed to set pixel format %d.\n", format); + + test_format = GetPixelFormat(hdc3); + ok(test_format == format, "Expected pixel format %d, got %d.\n", format, test_format); + + ReleaseDC(hwnd3, hdc3); + DestroyWindow(hwnd3); + +cleanup: FreeLibrary(gl); ReleaseDC(hwnd2, hdc2); ReleaseDC(hwnd, hdc);

1 0

Zebediah Figura : d3d8/tests: Test that presenting does not set the pixel format on a window without one.
by Alexandre Julliard 14 Feb '23

14 Feb '23

Module: wine Branch: master Commit: 5287d375a6f6be9f8ae1172f6ae058529c766d35 URL: https://gitlab.winehq.org/wine/wine/-/commit/5287d375a6f6be9f8ae1172f6ae058… Author: Zebediah Figura <zfigura(a)codeweavers.com> Date: Fri Jan 20 17:56:46 2023 -0600 d3d8/tests: Test that presenting does not set the pixel format on a window without one. --- dlls/d3d8/tests/device.c | 72 ++++++++++++++++++++++++++++++++++++++++++------ 1 file changed, 64 insertions(+), 8 deletions(-) diff --git a/dlls/d3d8/tests/device.c b/dlls/d3d8/tests/device.c index 59532d0a208..c8f52484054 100644 --- a/dlls/d3d8/tests/device.c +++ b/dlls/d3d8/tests/device.c @@ -7775,10 +7775,12 @@ static void test_pixel_format(void) PIXELFORMATDESCRIPTOR pfd; IDirect3D8 *d3d8 = NULL; IDirect3DDevice8 *device = NULL; - HWND hwnd, hwnd2; - HDC hdc, hdc2; + HWND hwnd, hwnd2, hwnd3; + HDC hdc, hdc2, hdc3; + ULONG refcount; HMODULE gl; HRESULT hr; + BOOL ret; static const float point[] = {0.0f, 0.0f, 0.0f}; @@ -7877,14 +7879,68 @@ static void test_pixel_format(void) test_format = GetPixelFormat(hdc2); ok(test_format == format, "second window has pixel format %d, expected %d\n", test_format, format); -cleanup: - if (device) + refcount = IDirect3DDevice8_Release(device); + ok(!refcount, "Device has %lu references left.\n", refcount); + IDirect3D8_Release(d3d8); + + test_format = GetPixelFormat(hdc); + ok(test_format == format, "window has pixel format %d, expected %d\n", test_format, format); + + test_format = GetPixelFormat(hdc2); + ok(test_format == format, "second window has pixel format %d, expected %d\n", test_format, format); + + /* Test that creating a device doesn't set a pixel format on a window which + * never had one. */ + + hwnd3 = create_window(); + hdc3 = GetDC(hwnd3); + + test_format = GetPixelFormat(hdc3); + ok(!test_format, "Expected no format, got %d.\n", test_format); + + d3d8 = Direct3DCreate8(D3D_SDK_VERSION); + ok(!!d3d8, "Failed to create a D3D object.\n"); + if (!(device = create_device(d3d8, hwnd3, NULL))) { - UINT refcount = IDirect3DDevice8_Release(device); - ok(!refcount, "Device has %u references left.\n", refcount); + skip("Failed to create device\n"); + goto cleanup; } - if (d3d8) - IDirect3D8_Release(d3d8); + + hr = IDirect3DDevice8_SetVertexShader(device, D3DFVF_XYZ); + ok(hr == S_OK, "Got hr %#lx.\n", hr); + hr = IDirect3DDevice8_BeginScene(device); + ok(hr == S_OK, "Got hr %#lx.\n", hr); + hr = IDirect3DDevice8_DrawPrimitiveUP(device, D3DPT_POINTLIST, 1, point, 3 * sizeof(float)); + ok(hr == S_OK, "Got hr %#lx.\n", hr); + hr = IDirect3DDevice8_EndScene(device); + ok(hr == S_OK, "Got hr %#lx.\n", hr); + + test_format = GetPixelFormat(hdc3); + todo_wine ok(!test_format, "Expected no format, got %d.\n", test_format); + + hr = IDirect3DDevice8_Present(device, NULL, NULL, NULL, NULL); + ok(hr == S_OK, "Got hr %#lx.\n", hr); + + test_format = GetPixelFormat(hdc3); + todo_wine ok(!test_format, "Expected no format, got %d.\n", test_format); + + refcount = IDirect3DDevice8_Release(device); + ok(!refcount, "Device has %lu references left.\n", refcount); + IDirect3D8_Release(d3d8); + + test_format = GetPixelFormat(hdc3); + todo_wine ok(!test_format, "Expected no format, got %d.\n", test_format); + + ret = SetPixelFormat(hdc3, format, &pfd); + ok(ret, "Failed to set pixel format %d.\n", format); + + test_format = GetPixelFormat(hdc3); + ok(test_format == format, "Expected pixel format %d, got %d.\n", format, test_format); + + ReleaseDC(hwnd3, hdc3); + DestroyWindow(hwnd3); + +cleanup: FreeLibrary(gl); ReleaseDC(hwnd2, hdc2); ReleaseDC(hwnd, hdc);

1 0

Zebediah Figura : ddraw/tests: Test that presenting does not set the pixel format on a window without one.
by Alexandre Julliard 14 Feb '23

14 Feb '23

Module: wine Branch: master Commit: 89e68fa9c9b0d0952f6b618dff78f57f94d4257d URL: https://gitlab.winehq.org/wine/wine/-/commit/89e68fa9c9b0d0952f6b618dff78f5… Author: Zebediah Figura <zfigura(a)codeweavers.com> Date: Fri Jan 20 17:56:56 2023 -0600 ddraw/tests: Test that presenting does not set the pixel format on a window without one. --- dlls/ddraw/tests/ddraw1.c | 65 +++++++++++++++++++++++++++++++++++++++++++++-- dlls/ddraw/tests/ddraw2.c | 65 +++++++++++++++++++++++++++++++++++++++++++++-- dlls/ddraw/tests/ddraw4.c | 65 +++++++++++++++++++++++++++++++++++++++++++++-- dlls/ddraw/tests/ddraw7.c | 65 +++++++++++++++++++++++++++++++++++++++++++++-- 4 files changed, 252 insertions(+), 8 deletions(-)

1 0

Zebediah Figura : user32: Pass BSMINFO in BroadcastSystemMessageExA().
by Alexandre Julliard 14 Feb '23

14 Feb '23

Module: wine Branch: master Commit: 0ac2166cecf8066b63c1e4e0c920a4ea119a3c13 URL: https://gitlab.winehq.org/wine/wine/-/commit/0ac2166cecf8066b63c1e4e0c920a4… Author: Zebediah Figura <zfigura(a)codeweavers.com> Date: Sun Feb 5 21:44:26 2023 -0600 user32: Pass BSMINFO in BroadcastSystemMessageExA(). --- dlls/user32/message.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/user32/message.c b/dlls/user32/message.c index 9ad4abd21b5..33e81c76e4b 100644 --- a/dlls/user32/message.c +++ b/dlls/user32/message.c @@ -1192,7 +1192,7 @@ LONG WINAPI BroadcastSystemMessageW( DWORD flags, LPDWORD recipients, UINT msg, LONG WINAPI BroadcastSystemMessageExA( DWORD flags, LPDWORD recipients, UINT msg, WPARAM wp, LPARAM lp, PBSMINFO pinfo ) { map_wparam_AtoW( msg, &wp, WMCHAR_MAP_NOMAPPING ); - return BroadcastSystemMessageExW( flags, recipients, msg, wp, lp, NULL ); + return BroadcastSystemMessageExW( flags, recipients, msg, wp, lp, pinfo ); }

1 0