February 2023 - Wine-commits

Rémi Bernon : comctl32: Always use unicode messages for subclass procedures.
by Alexandre Julliard 01 Feb '23

01 Feb '23

Module: wine Branch: master Commit: 8387d2fefff6886235a0ba46042e96ff2c6e89cc URL: https://gitlab.winehq.org/wine/wine/-/commit/8387d2fefff6886235a0ba46042e96… Author: Rémi Bernon <rbernon(a)codeweavers.com> Date: Tue Jan 10 17:39:17 2023 +0100 comctl32: Always use unicode messages for subclass procedures. Final Fantasy XIV Online depends on this for its text input. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=43073 --- dlls/comctl32/commctrl.c | 13 +++---------- dlls/comctl32/tests/subclass.c | 15 +++++++-------- 2 files changed, 10 insertions(+), 18 deletions(-) diff --git a/dlls/comctl32/commctrl.c b/dlls/comctl32/commctrl.c index 37cb66b9bbb..eae64022d65 100644 --- a/dlls/comctl32/commctrl.c +++ b/dlls/comctl32/commctrl.c @@ -1104,12 +1104,8 @@ BOOL WINAPI SetWindowSubclass (HWND hWnd, SUBCLASSPROC pfnSubclass, /* set window procedure to our own and save the current one */ stack->is_unicode = IsWindowUnicode (hWnd); - if (stack->is_unicode) - stack->origproc = (WNDPROC)SetWindowLongPtrW (hWnd, GWLP_WNDPROC, - (DWORD_PTR)COMCTL32_SubclassProc); - else - stack->origproc = (WNDPROC)SetWindowLongPtrA (hWnd, GWLP_WNDPROC, - (DWORD_PTR)COMCTL32_SubclassProc); + stack->origproc = (WNDPROC)SetWindowLongPtrW (hWnd, GWLP_WNDPROC, + (DWORD_PTR)COMCTL32_SubclassProc); } else { /* Check to see if we have called this function with the same uIDSubClass @@ -1332,10 +1328,7 @@ LRESULT WINAPI DefSubclassProc (HWND hWnd, UINT uMsg, WPARAM wParam, LPARAM lPar /* If we are at the end of stack then we have to call the original * window procedure */ if (!stack->stackpos) { - if (stack->is_unicode) - ret = CallWindowProcW (stack->origproc, hWnd, uMsg, wParam, lParam); - else - ret = CallWindowProcA (stack->origproc, hWnd, uMsg, wParam, lParam); + ret = CallWindowProcW (stack->origproc, hWnd, uMsg, wParam, lParam); } else { const SUBCLASSPROCS *proc = stack->stackpos; stack->stackpos = stack->stackpos->next; diff --git a/dlls/comctl32/tests/subclass.c b/dlls/comctl32/tests/subclass.c index 684593e6ed7..3c07a9d221c 100644 --- a/dlls/comctl32/tests/subclass.c +++ b/dlls/comctl32/tests/subclass.c @@ -202,7 +202,7 @@ static LRESULT WINAPI wnd_proc_1(HWND hwnd, UINT message, WPARAM wParam, LPARAM DWORD flags = GetWindowLongA(hwnd, GWLP_USERDATA); struct message msg; - todo_wine_if(flags & EXPECT_UNICODE) check_unicode(hwnd, flags); + check_unicode(hwnd, flags); if(message == WM_USER) { msg.wParam = wParam; @@ -234,7 +234,7 @@ static LRESULT WINAPI wnd_proc_sub(HWND hwnd, UINT message, WPARAM wParam, LPARA DWORD flags = GetWindowLongA(hwnd, GWLP_USERDATA); struct message msg; - todo_wine_if(flags & EXPECT_UNICODE) check_unicode(hwnd, flags); + check_unicode(hwnd, flags); if(message == WM_USER) { msg.wParam = wParam; @@ -245,22 +245,21 @@ static LRESULT WINAPI wnd_proc_sub(HWND hwnd, UINT message, WPARAM wParam, LPARA if(dwRefData & DELETE_SELF) { pRemoveWindowSubclass(hwnd, wnd_proc_sub, uldSubclass); pRemoveWindowSubclass(hwnd, wnd_proc_sub, uldSubclass); - todo_wine_if(flags & EXPECT_UNICODE) check_unicode(hwnd, flags); + check_unicode(hwnd, flags); } if(dwRefData & DELETE_PREV) { pRemoveWindowSubclass(hwnd, wnd_proc_sub, uldSubclass-1); - todo_wine_if(flags & EXPECT_UNICODE) check_unicode(hwnd, flags); + check_unicode(hwnd, flags); } if(dwRefData & SEND_NEST) { SendMessageA(hwnd, WM_USER, wParam+1, 0); - todo_wine_if(flags & EXPECT_UNICODE) check_unicode(hwnd, flags); + check_unicode(hwnd, flags); } } } if (message == WM_CHAR) { - todo_wine ok(wParam == 0x30c2, "got wParam %#Ix\n", wParam); } return pDefSubclassProc(hwnd, message, wParam, lParam); @@ -277,7 +276,7 @@ static void test_subclass(void) ret = pSetWindowSubclass(hwnd, wnd_proc_sub, 2, 0); ok(ret == TRUE, "Expected TRUE\n"); - todo_wine check_unicode(hwnd, EXPECT_UNICODE); + check_unicode(hwnd, EXPECT_UNICODE); SetWindowLongA(hwnd, GWLP_USERDATA, EXPECT_UNICODE); SendMessageA(hwnd, WM_USER, 1, 0); @@ -287,7 +286,7 @@ static void test_subclass(void) ret = pSetWindowSubclass(hwnd, wnd_proc_sub, 2, DELETE_SELF); ok(ret == TRUE, "Expected TRUE\n"); - todo_wine check_unicode(hwnd, EXPECT_UNICODE); + check_unicode(hwnd, EXPECT_UNICODE); SendMessageA(hwnd, WM_USER, 1, 1); ok_sequence(Sub_DeletedTest, "Deleted");

1 0

Rémi Bernon : comctl32: Skip restoring window proc if it has been modified.
by Alexandre Julliard 01 Feb '23

01 Feb '23

Module: wine Branch: master Commit: 078c6e5ab2acd70b448838189c81c7ff484a4ee9 URL: https://gitlab.winehq.org/wine/wine/-/commit/078c6e5ab2acd70b448838189c81c7… Author: Rémi Bernon <rbernon(a)codeweavers.com> Date: Thu Jan 26 15:40:43 2023 +0100 comctl32: Skip restoring window proc if it has been modified. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=43073 --- dlls/comctl32/commctrl.c | 4 +++- dlls/comctl32/tests/subclass.c | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/dlls/comctl32/commctrl.c b/dlls/comctl32/commctrl.c index eae64022d65..4c5900bc37f 100644 --- a/dlls/comctl32/commctrl.c +++ b/dlls/comctl32/commctrl.c @@ -1243,7 +1243,9 @@ BOOL WINAPI RemoveWindowSubclass(HWND hWnd, SUBCLASSPROC pfnSubclass, UINT_PTR u if (!stack->SubclassProcs && !stack->running) { TRACE("Last Subclass removed, cleaning up\n"); /* clean up our heap and reset the original window procedure */ - if (stack->is_unicode) + if ((WNDPROC)GetWindowLongPtrW (hWnd, GWLP_WNDPROC) != COMCTL32_SubclassProc) + WARN("Window procedure has been modified, skipping restore\n"); + else if (stack->is_unicode) SetWindowLongPtrW (hWnd, GWLP_WNDPROC, (DWORD_PTR)stack->origproc); else SetWindowLongPtrA (hWnd, GWLP_WNDPROC, (DWORD_PTR)stack->origproc); diff --git a/dlls/comctl32/tests/subclass.c b/dlls/comctl32/tests/subclass.c index 3c07a9d221c..bc3fc6f1d91 100644 --- a/dlls/comctl32/tests/subclass.c +++ b/dlls/comctl32/tests/subclass.c @@ -192,7 +192,7 @@ static void check_unicode_(int line, HWND hwnd, DWORD flags) else if (flags & EXPECT_WNDPROC_1) ok_(__FILE__, line)(proc == wnd_proc_1, "got proc %p\n", proc); else if (flags & EXPECT_WNDPROC_3) - todo_wine_if(proc == wnd_proc_1) ok_(__FILE__, line)(proc == wnd_proc_3, "got proc %p\n", proc); + ok_(__FILE__, line)(proc == wnd_proc_3, "got proc %p\n", proc); else ok_(__FILE__, line)(!IS_WNDPROC_HANDLE(proc), "got proc %p\n", proc); }

1 0

Alex Henrie : urlmon: Use the _recalloc function instead of reimplementing it.
by Alexandre Julliard 01 Feb '23

01 Feb '23

Module: wine Branch: master Commit: 42c15f1cdbaef89befe0fd0d7fc1944c6750db40 URL: https://gitlab.winehq.org/wine/wine/-/commit/42c15f1cdbaef89befe0fd0d7fc194… Author: Alex Henrie <alexhenrie24(a)gmail.com> Date: Wed Feb 1 00:32:15 2023 -0700 urlmon: Use the _recalloc function instead of reimplementing it. --- dlls/urlmon/sec_mgr.c | 19 +++++-------------- 1 file changed, 5 insertions(+), 14 deletions(-) diff --git a/dlls/urlmon/sec_mgr.c b/dlls/urlmon/sec_mgr.c index 78e4c96fd60..82266066e0f 100644 --- a/dlls/urlmon/sec_mgr.c +++ b/dlls/urlmon/sec_mgr.c @@ -1548,6 +1548,7 @@ static HRESULT WINAPI ZoneMgrImpl_CreateZoneEnumerator(IInternetZoneManagerEx2* ZoneMgrImpl* This = impl_from_IInternetZoneManagerEx2(iface); LPDWORD * new_maps; LPDWORD data; + DWORD new_map_count; DWORD i; TRACE("(%p)->(%p, %p, 0x%08lx)\n", This, pdwEnum, pdwCount, dwFlags); @@ -1569,25 +1570,15 @@ static HRESULT WINAPI ZoneMgrImpl_CreateZoneEnumerator(IInternetZoneManagerEx2* } } - if (This->zonemaps) { - /* try to double the nr. of pointers in the array */ - new_maps = realloc(This->zonemaps, This->zonemap_count * 2 * sizeof(DWORD*)); - if (new_maps) { - memset(new_maps + This->zonemap_count, 0, This->zonemap_count * sizeof(DWORD*)); - This->zonemap_count *= 2; - } - } - else - { - This->zonemap_count = 2; - new_maps = calloc(This->zonemap_count, sizeof(DWORD*)); - } - + /* try to double the number of pointers in the array */ + new_map_count = This->zonemaps ? This->zonemap_count * 2 : 2; + new_maps = _recalloc(This->zonemaps, new_map_count, sizeof(DWORD*)); if (!new_maps) { free(data); return E_FAIL; } This->zonemaps = new_maps; + This->zonemap_count = new_map_count; This->zonemaps[i] = data; *pdwEnum = i; *pdwCount = data[0];

1 0

Gabriel Ivăncescu : include/mshtml: Add the other IHTMLEventObj* interfaces.
by Alexandre Julliard 01 Feb '23

01 Feb '23

Module: wine Branch: master Commit: 3eaf3774ad966c10655929033a264595e26971bd URL: https://gitlab.winehq.org/wine/wine/-/commit/3eaf3774ad966c10655929033a2645… Author: Gabriel Ivăncescu <gabrielopcode(a)gmail.com> Date: Wed Feb 1 19:26:27 2023 +0200 include/mshtml: Add the other IHTMLEventObj* interfaces. Signed-off-by: Gabriel Ivăncescu <gabrielopcode(a)gmail.com> --- include/mshtmdid.h | 11 ++ include/mshtml.idl | 357 +++++++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 368 insertions(+)

1 0

Gabriel Ivăncescu : mshtml: Use Scrollbar_Auto as default for vertical scrollbars.
by Alexandre Julliard 01 Feb '23

01 Feb '23

Module: wine Branch: master Commit: 9beef3fc5a5109482155d42d7727069857ec4145 URL: https://gitlab.winehq.org/wine/wine/-/commit/9beef3fc5a5109482155d42d772706… Author: Gabriel Ivăncescu <gabrielopcode(a)gmail.com> Date: Wed Feb 1 19:26:27 2023 +0200 mshtml: Use Scrollbar_Auto as default for vertical scrollbars. While Internet Explorer 6 used to default to "always", this hasn't been the case for a long while now. Signed-off-by: Gabriel Ivăncescu <gabrielopcode(a)gmail.com> --- dlls/mshtml/nsembed.c | 2 +- dlls/mshtml/oleobj.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/mshtml/nsembed.c b/dlls/mshtml/nsembed.c index b7518f55ef9..b6d7b53f815 100644 --- a/dlls/mshtml/nsembed.c +++ b/dlls/mshtml/nsembed.c @@ -2268,7 +2268,7 @@ static HRESULT init_browser(GeckoBrowser *browser) nsres = nsIWebBrowser_QueryInterface(browser->webbrowser, &IID_nsIScrollable, (void**)&scrollable); if(NS_SUCCEEDED(nsres)) { nsres = nsIScrollable_SetDefaultScrollbarPreferences(scrollable, - ScrollOrientation_Y, Scrollbar_Always); + ScrollOrientation_Y, Scrollbar_Auto); if(NS_FAILED(nsres)) ERR("Could not set default Y scrollbar prefs: %08lx\n", nsres); diff --git a/dlls/mshtml/oleobj.c b/dlls/mshtml/oleobj.c index d1853435606..c01c18b5fa8 100644 --- a/dlls/mshtml/oleobj.c +++ b/dlls/mshtml/oleobj.c @@ -363,7 +363,7 @@ static void update_hostinfo(HTMLDocumentObj *This, DOCHOSTUIINFO *hostinfo) nsres = nsIWebBrowser_QueryInterface(This->nscontainer->webbrowser, &IID_nsIScrollable, (void**)&scrollable); if(NS_SUCCEEDED(nsres)) { nsres = nsIScrollable_SetDefaultScrollbarPreferences(scrollable, ScrollOrientation_Y, - (hostinfo->dwFlags & DOCHOSTUIFLAG_SCROLL_NO) ? Scrollbar_Never : Scrollbar_Always); + (hostinfo->dwFlags & DOCHOSTUIFLAG_SCROLL_NO) ? Scrollbar_Never : Scrollbar_Auto); if(NS_FAILED(nsres)) ERR("Could not set default Y scrollbar prefs: %08lx\n", nsres);

1 0

Gabriel Ivăncescu : jscript: Pass the correct ServiceProvider when invoking external prop.
by Alexandre Julliard 01 Feb '23

01 Feb '23

Module: wine Branch: master Commit: c2b5538711580032b730934f13bb5c6ea8c7d4b9 URL: https://gitlab.winehq.org/wine/wine/-/commit/c2b5538711580032b730934f13bb5c… Author: Gabriel Ivăncescu <gabrielopcode(a)gmail.com> Date: Wed Feb 1 19:26:27 2023 +0200 jscript: Pass the correct ServiceProvider when invoking external prop. Signed-off-by: Gabriel Ivăncescu <gabrielopcode(a)gmail.com> --- dlls/jscript/dispex.c | 33 +++++------ dlls/jscript/jscript.h | 8 ++- dlls/jscript/tests/run.c | 143 +++++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 167 insertions(+), 17 deletions(-)

1 0

Gabriel Ivăncescu : mshtml: Return undefined from window.XMLHttpRequest for uninitialized documents.
by Alexandre Julliard 01 Feb '23

01 Feb '23

Module: wine Branch: master Commit: fa63e870c56dbbcb9da991c949fd6a918ea76d16 URL: https://gitlab.winehq.org/wine/wine/-/commit/fa63e870c56dbbcb9da991c949fd6a… Author: Gabriel Ivăncescu <gabrielopcode(a)gmail.com> Date: Wed Feb 1 19:26:27 2023 +0200 mshtml: Return undefined from window.XMLHttpRequest for uninitialized documents. Signed-off-by: Gabriel Ivăncescu <gabrielopcode(a)gmail.com> --- dlls/mshtml/htmlwindow.c | 5 ++ dlls/mshtml/tests/dom.c | 114 ++++++++++++++++++++++++++++++++++++- dlls/mshtml/tests/events.c | 139 +++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 257 insertions(+), 1 deletion(-)

1 0

Gabriel Ivăncescu : mshtml: Traverse and unlink builtin func disps.
by Alexandre Julliard 01 Feb '23

01 Feb '23

Module: wine Branch: master Commit: f43f96762ec71015b4eccfa4f430135e8701a305 URL: https://gitlab.winehq.org/wine/wine/-/commit/f43f96762ec71015b4eccfa4f43013… Author: Gabriel Ivăncescu <gabrielopcode(a)gmail.com> Date: Wed Feb 1 19:26:27 2023 +0200 mshtml: Traverse and unlink builtin func disps. Signed-off-by: Gabriel Ivăncescu <gabrielopcode(a)gmail.com> --- dlls/mshtml/dispex.c | 27 ++++++++++++++++++++++++++- 1 file changed, 26 insertions(+), 1 deletion(-) diff --git a/dlls/mshtml/dispex.c b/dlls/mshtml/dispex.c index 1d00012572b..5b72f712b92 100644 --- a/dlls/mshtml/dispex.c +++ b/dlls/mshtml/dispex.c @@ -2003,7 +2003,17 @@ void dispex_traverse(DispatchEx *This, nsCycleCollectionTraversalCallback *cb) note_cc_edge((nsISupports*)V_DISPATCH(&prop->var), "dispex_data", cb); } - /* FIXME: Traverse func_disps */ + if(This->dynamic_data->func_disps) { + func_obj_entry_t *iter = This->dynamic_data->func_disps, *end = iter + This->info->func_disp_cnt; + + for(iter = This->dynamic_data->func_disps; iter < end; iter++) { + if(!iter->func_obj) + continue; + note_cc_edge((nsISupports*)&iter->func_obj->dispex.IDispatchEx_iface, "func_obj", cb); + if(V_VT(&iter->val) == VT_DISPATCH) + note_cc_edge((nsISupports*)V_DISPATCH(&iter->val), "func_val", cb); + } + } } void dispex_unlink(DispatchEx *This) @@ -2021,6 +2031,21 @@ void dispex_unlink(DispatchEx *This) VariantClear(&prop->var); } } + + if(This->dynamic_data->func_disps) { + func_obj_entry_t *iter = This->dynamic_data->func_disps, *end = iter + This->info->func_disp_cnt; + + for(iter = This->dynamic_data->func_disps; iter < end; iter++) { + if(!iter->func_obj) + continue; + iter->func_obj->obj = NULL; + IDispatchEx_Release(&iter->func_obj->dispex.IDispatchEx_iface); + VariantClear(&iter->val); + } + + free(This->dynamic_data->func_disps); + This->dynamic_data->func_disps = NULL; + } } const void *dispex_get_vtbl(DispatchEx *dispex)

1 0

Gabriel Ivăncescu : mshtml: Simplify dynamic props unlinking.
by Alexandre Julliard 01 Feb '23

01 Feb '23

Module: wine Branch: master Commit: e495c256bbe6f9119c74796cdd95ba8b1d0e05a8 URL: https://gitlab.winehq.org/wine/wine/-/commit/e495c256bbe6f9119c74796cdd95ba… Author: Gabriel Ivăncescu <gabrielopcode(a)gmail.com> Date: Wed Feb 1 19:26:27 2023 +0200 mshtml: Simplify dynamic props unlinking. Signed-off-by: Gabriel Ivăncescu <gabrielopcode(a)gmail.com> --- dlls/mshtml/dispex.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/dlls/mshtml/dispex.c b/dlls/mshtml/dispex.c index 5b72f712b92..2f9453918c1 100644 --- a/dlls/mshtml/dispex.c +++ b/dlls/mshtml/dispex.c @@ -2024,12 +2024,7 @@ void dispex_unlink(DispatchEx *This) return; for(prop = This->dynamic_data->props; prop < This->dynamic_data->props + This->dynamic_data->prop_cnt; prop++) { - if(V_VT(&prop->var) == VT_DISPATCH) { - V_VT(&prop->var) = VT_EMPTY; - IDispatch_Release(V_DISPATCH(&prop->var)); - }else { - VariantClear(&prop->var); - } + VariantClear(&prop->var); } if(This->dynamic_data->func_disps) {

1 0

Gabriel Ivăncescu : mshtml: Tie window.location to the outer window.
by Alexandre Julliard 01 Feb '23

01 Feb '23

Module: wine Branch: master Commit: 7b084e9f23ae7cfd170fe8ce64e88f3d9af1efc4 URL: https://gitlab.winehq.org/wine/wine/-/commit/7b084e9f23ae7cfd170fe8ce64e88f… Author: Gabriel Ivăncescu <gabrielopcode(a)gmail.com> Date: Wed Feb 1 19:26:28 2023 +0200 mshtml: Tie window.location to the outer window. Even in IE9+ modes, it's still a non-JS object. Signed-off-by: Gabriel Ivăncescu <gabrielopcode(a)gmail.com> --- dlls/mshtml/dispex.c | 1 + dlls/mshtml/htmllocation.c | 31 ++++++++++++++----------------- dlls/mshtml/htmlwindow.c | 19 +++++++++++-------- dlls/mshtml/mshtml_private.h | 7 +++---- dlls/mshtml/tests/dom.c | 17 ++++++++++++++++- dlls/mshtml/tests/events.c | 39 ++++++++++++++++++++++++++++++++++++++- 6 files changed, 83 insertions(+), 31 deletions(-)

1 0