March 2023 - Wine-commits - list.winehq.org

Paul Gofman : taskkill: Support terminating child processes.
by Alexandre Julliard 29 Mar '23

29 Mar '23

1 0

Sven Baars : kernelbase: Remove special Wow64 handling for HKEY_CLASSES_ROOT.
by Alexandre Julliard 29 Mar '23

29 Mar '23

Module: wine Branch: master Commit: 24208208e32e5b73e96d5d6c8ba817c75900d9e9 URL: https://gitlab.winehq.org/wine/wine/-/commit/24208208e32e5b73e96d5d6c8ba817… Author: Sven Baars <sbaars(a)codeweavers.com> Date: Fri Sep 23 16:09:13 2022 +0200 kernelbase: Remove special Wow64 handling for HKEY_CLASSES_ROOT. The server always returns the same key now. --- dlls/kernelbase/registry.c | 59 +++++++++++++++++++++------------------------- 1 file changed, 27 insertions(+), 32 deletions(-)

1 0

Michael Stefaniuc : msdasql: Remove redundant NULL check before heap_free().
by Alexandre Julliard 29 Mar '23

29 Mar '23

Module: wine Branch: master Commit: b7fd8972db36325f00905c05245f57f0c6727ed4 URL: https://gitlab.winehq.org/wine/wine/-/commit/b7fd8972db36325f00905c05245f57… Author: Michael Stefaniuc <mstefani(a)winehq.org> Date: Tue Mar 28 19:28:05 2023 +0200 msdasql: Remove redundant NULL check before heap_free(). --- dlls/msdasql/session.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/dlls/msdasql/session.c b/dlls/msdasql/session.c index 588be365b72..3e6e5f2a0b3 100644 --- a/dlls/msdasql/session.c +++ b/dlls/msdasql/session.c @@ -693,8 +693,7 @@ static ULONG WINAPI command_Release(ICommandText *iface) if (!refs) { TRACE( "destroying %p\n", command ); - if (command->properties) - heap_free(command->properties); + heap_free(command->properties); if (command->session) IUnknown_Release(command->session);

1 0

Michael Stefaniuc : windows.media.speech: Remove redundant NULL check before free().
by Alexandre Julliard 29 Mar '23

29 Mar '23

Module: wine Branch: master Commit: 1210b98cd3d8c173d41393c5f46c3f822404065f URL: https://gitlab.winehq.org/wine/wine/-/commit/1210b98cd3d8c173d41393c5f46c3f… Author: Michael Stefaniuc <mstefani(a)winehq.org> Date: Tue Mar 28 19:28:28 2023 +0200 windows.media.speech: Remove redundant NULL check before free(). --- dlls/windows.media.speech/listconstraint.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/windows.media.speech/listconstraint.c b/dlls/windows.media.speech/listconstraint.c index ef0dff0e4d5..555f3b214e1 100644 --- a/dlls/windows.media.speech/listconstraint.c +++ b/dlls/windows.media.speech/listconstraint.c @@ -372,7 +372,7 @@ static HRESULT WINAPI constraint_factory_CreateWithTag( ISpeechRecognitionListCo error: if (impl->commands) IVector_HSTRING_Release(impl->commands); - if (impl) free(impl); + free(impl); return hr; }

1 0

Vijay Kiran Kamuju : msvcr100: Add _UnrealizedChore::_CheckTaskCollection stub.
by Alexandre Julliard 28 Mar '23

28 Mar '23

Module: wine Branch: master Commit: 8426109a439c35334f72fbf12aa15948366b2fb4 URL: https://gitlab.winehq.org/wine/wine/-/commit/8426109a439c35334f72fbf12aa159… Author: Vijay Kiran Kamuju <infyquest(a)gmail.com> Date: Fri Mar 17 13:19:19 2023 +0000 msvcr100: Add _UnrealizedChore::_CheckTaskCollection stub. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53794 --- dlls/concrt140/concrt140.spec | 6 +++--- dlls/msvcr100/msvcr100.spec | 4 ++-- dlls/msvcr110/msvcr110.spec | 6 +++--- dlls/msvcr120/msvcr120.spec | 6 +++--- dlls/msvcr120_app/msvcr120_app.spec | 6 +++--- dlls/msvcrt/concurrency.c | 8 ++++++++ 6 files changed, 22 insertions(+), 14 deletions(-) diff --git a/dlls/concrt140/concrt140.spec b/dlls/concrt140/concrt140.spec index 8ddf2255f31..f2b2789a5e2 100644 --- a/dlls/concrt140/concrt140.spec +++ b/dlls/concrt140/concrt140.spec @@ -440,9 +440,9 @@ @ stub -arch=arm ?_Cancel(a)_TaskCollection@details(a)Concurrency@@QAAXXZ @ stub -arch=i386 ?_Cancel(a)_TaskCollection@details(a)Concurrency@@QAEXXZ @ stub -arch=win64 ?_Cancel(a)_TaskCollection@details(a)Concurrency@@QEAAXXZ -@ stub -arch=arm ?_CheckTaskCollection(a)_UnrealizedChore@details(a)Concurrency@@IAAXXZ -@ stub -arch=i386 ?_CheckTaskCollection(a)_UnrealizedChore@details(a)Concurrency@@IAEXXZ -@ stub -arch=win64 ?_CheckTaskCollection(a)_UnrealizedChore@details(a)Concurrency@@IEAAXXZ +@ cdecl -arch=arm ?_CheckTaskCollection(a)_UnrealizedChore@details(a)Concurrency@@IAAXXZ(ptr) _UnrealizedChore__CheckTaskCollection +@ thiscall -arch=i386 ?_CheckTaskCollection(a)_UnrealizedChore@details(a)Concurrency@@IAEXXZ(ptr) _UnrealizedChore__CheckTaskCollection +@ cdecl -arch=win64 ?_CheckTaskCollection(a)_UnrealizedChore@details(a)Concurrency@@IEAAXXZ(ptr) _UnrealizedChore__CheckTaskCollection @ stub -arch=arm ?_CleanupToken(a)_StructuredTaskCollection@details(a)Concurrency@@AAAXXZ @ stub -arch=i386 ?_CleanupToken(a)_StructuredTaskCollection@details(a)Concurrency@@AAEXXZ @ stub -arch=win64 ?_CleanupToken(a)_StructuredTaskCollection@details(a)Concurrency@@AEAAXXZ diff --git a/dlls/msvcr100/msvcr100.spec b/dlls/msvcr100/msvcr100.spec index e2107055c24..3e2839b3908 100644 --- a/dlls/msvcr100/msvcr100.spec +++ b/dlls/msvcr100/msvcr100.spec @@ -313,8 +313,8 @@ @ cdecl -arch=win64 ?_Cancel(a)_StructuredTaskCollection@details(a)Concurrency@@QEAAXXZ(ptr) _StructuredTaskCollection__Cancel @ stub -arch=win32 ?_Cancel(a)_TaskCollection@details(a)Concurrency@@QAEXXZ @ stub -arch=win64 ?_Cancel(a)_TaskCollection@details(a)Concurrency@@QEAAXXZ -@ stub -arch=win32 ?_CheckTaskCollection(a)_UnrealizedChore@details(a)Concurrency@@IAEXXZ -@ stub -arch=win64 ?_CheckTaskCollection(a)_UnrealizedChore@details(a)Concurrency@@IEAAXXZ +@ thiscall -arch=win32 ?_CheckTaskCollection(a)_UnrealizedChore@details(a)Concurrency@@IAEXXZ(ptr) _UnrealizedChore__CheckTaskCollection +@ cdecl -arch=win64 ?_CheckTaskCollection(a)_UnrealizedChore@details(a)Concurrency@@IEAAXXZ(ptr) _UnrealizedChore__CheckTaskCollection @ stub -arch=win32 ?_ConcRT_Assert(a)details@Concurrency@@YAXPBD0H(a)Z @ stub -arch=win64 ?_ConcRT_Assert(a)details@Concurrency@@YAXPEBD0H(a)Z @ stub -arch=win32 ?_ConcRT_CoreAssert(a)details@Concurrency@@YAXPBD0H(a)Z diff --git a/dlls/msvcr110/msvcr110.spec b/dlls/msvcr110/msvcr110.spec index 4fc5a069fbb..c23293ea658 100644 --- a/dlls/msvcr110/msvcr110.spec +++ b/dlls/msvcr110/msvcr110.spec @@ -493,9 +493,9 @@ @ stub -arch=arm ?_Cancel(a)_TaskCollection@details(a)Concurrency@@QAAXXZ @ stub -arch=i386 ?_Cancel(a)_TaskCollection@details(a)Concurrency@@QAEXXZ @ stub -arch=win64 ?_Cancel(a)_TaskCollection@details(a)Concurrency@@QEAAXXZ -@ stub -arch=arm ?_CheckTaskCollection(a)_UnrealizedChore@details(a)Concurrency@@IAAXXZ -@ stub -arch=i386 ?_CheckTaskCollection(a)_UnrealizedChore@details(a)Concurrency@@IAEXXZ -@ stub -arch=win64 ?_CheckTaskCollection(a)_UnrealizedChore@details(a)Concurrency@@IEAAXXZ +@ cdecl -arch=arm ?_CheckTaskCollection(a)_UnrealizedChore@details(a)Concurrency@@IAAXXZ(ptr) _UnrealizedChore__CheckTaskCollection +@ thiscall -arch=i386 ?_CheckTaskCollection(a)_UnrealizedChore@details(a)Concurrency@@IAEXXZ(ptr) _UnrealizedChore__CheckTaskCollection +@ cdecl -arch=win64 ?_CheckTaskCollection(a)_UnrealizedChore@details(a)Concurrency@@IEAAXXZ(ptr) _UnrealizedChore__CheckTaskCollection @ stub -arch=arm ?_CleanupToken(a)_StructuredTaskCollection@details(a)Concurrency@@AAAXXZ @ stub -arch=i386 ?_CleanupToken(a)_StructuredTaskCollection@details(a)Concurrency@@AAEXXZ @ stub -arch=win64 ?_CleanupToken(a)_StructuredTaskCollection@details(a)Concurrency@@AEAAXXZ diff --git a/dlls/msvcr120/msvcr120.spec b/dlls/msvcr120/msvcr120.spec index 7b379830d4b..6eac1937227 100644 --- a/dlls/msvcr120/msvcr120.spec +++ b/dlls/msvcr120/msvcr120.spec @@ -490,9 +490,9 @@ @ stub -arch=arm ?_Cancel(a)_TaskCollection@details(a)Concurrency@@QAAXXZ @ stub -arch=i386 ?_Cancel(a)_TaskCollection@details(a)Concurrency@@QAEXXZ @ stub -arch=win64 ?_Cancel(a)_TaskCollection@details(a)Concurrency@@QEAAXXZ -@ stub -arch=arm ?_CheckTaskCollection(a)_UnrealizedChore@details(a)Concurrency@@IAAXXZ -@ stub -arch=i386 ?_CheckTaskCollection(a)_UnrealizedChore@details(a)Concurrency@@IAEXXZ -@ stub -arch=win64 ?_CheckTaskCollection(a)_UnrealizedChore@details(a)Concurrency@@IEAAXXZ +@ cdecl -arch=arm ?_CheckTaskCollection(a)_UnrealizedChore@details(a)Concurrency@@IAAXXZ(ptr) _UnrealizedChore__CheckTaskCollection +@ thiscall -arch=i386 ?_CheckTaskCollection(a)_UnrealizedChore@details(a)Concurrency@@IAEXXZ(ptr) _UnrealizedChore__CheckTaskCollection +@ cdecl -arch=win64 ?_CheckTaskCollection(a)_UnrealizedChore@details(a)Concurrency@@IEAAXXZ(ptr) _UnrealizedChore__CheckTaskCollection @ stub -arch=arm ?_CleanupToken(a)_StructuredTaskCollection@details(a)Concurrency@@AAAXXZ @ stub -arch=i386 ?_CleanupToken(a)_StructuredTaskCollection@details(a)Concurrency@@AAEXXZ @ stub -arch=win64 ?_CleanupToken(a)_StructuredTaskCollection@details(a)Concurrency@@AEAAXXZ diff --git a/dlls/msvcr120_app/msvcr120_app.spec b/dlls/msvcr120_app/msvcr120_app.spec index 37282fc54f8..aad6ece8acc 100644 --- a/dlls/msvcr120_app/msvcr120_app.spec +++ b/dlls/msvcr120_app/msvcr120_app.spec @@ -487,9 +487,9 @@ @ stub -arch=arm ?_Cancel(a)_TaskCollection@details(a)Concurrency@@QAAXXZ @ stub -arch=i386 ?_Cancel(a)_TaskCollection@details(a)Concurrency@@QAEXXZ @ stub -arch=win64 ?_Cancel(a)_TaskCollection@details(a)Concurrency@@QEAAXXZ -@ stub -arch=arm ?_CheckTaskCollection(a)_UnrealizedChore@details(a)Concurrency@@IAAXXZ -@ stub -arch=i386 ?_CheckTaskCollection(a)_UnrealizedChore@details(a)Concurrency@@IAEXXZ -@ stub -arch=win64 ?_CheckTaskCollection(a)_UnrealizedChore@details(a)Concurrency@@IEAAXXZ +@ cdecl -arch=arm ?_CheckTaskCollection(a)_UnrealizedChore@details(a)Concurrency@@IAAXXZ(ptr) msvcr120.?_CheckTaskCollection(a)_UnrealizedChore@details(a)Concurrency@@IAAXXZ +@ thiscall -arch=i386 ?_CheckTaskCollection(a)_UnrealizedChore@details(a)Concurrency@@IAEXXZ(ptr) msvcr120.?_CheckTaskCollection(a)_UnrealizedChore@details(a)Concurrency@@IAEXXZ +@ cdecl -arch=win64 ?_CheckTaskCollection(a)_UnrealizedChore@details(a)Concurrency@@IEAAXXZ(ptr) msvcr120.?_CheckTaskCollection(a)_UnrealizedChore@details(a)Concurrency@@IEAAXXZ @ stub -arch=arm ?_CleanupToken(a)_StructuredTaskCollection@details(a)Concurrency@@AAAXXZ @ stub -arch=i386 ?_CleanupToken(a)_StructuredTaskCollection@details(a)Concurrency@@AAEXXZ @ stub -arch=win64 ?_CleanupToken(a)_StructuredTaskCollection@details(a)Concurrency@@AEAAXXZ diff --git a/dlls/msvcrt/concurrency.c b/dlls/msvcrt/concurrency.c index fe156938e3a..01ba54308f0 100644 --- a/dlls/msvcrt/concurrency.c +++ b/dlls/msvcrt/concurrency.c @@ -2224,6 +2224,14 @@ bool __thiscall _StructuredTaskCollection__IsCanceling( return FALSE; } +/* ?_CheckTaskCollection(a)_UnrealizedChore@details(a)Concurrency@@IAEXXZ */ +/* ?_CheckTaskCollection(a)_UnrealizedChore@details(a)Concurrency@@IEAAXXZ */ +DEFINE_THISCALL_WRAPPER(_UnrealizedChore__CheckTaskCollection, 4) +void __thiscall _UnrealizedChore__CheckTaskCollection(_UnrealizedChore *this) +{ + FIXME("() stub\n"); +} + /* ??0critical_section(a)Concurrency@@QAE(a)XZ */ /* ??0critical_section(a)Concurrency@@QEAA(a)XZ */ DEFINE_THISCALL_WRAPPER(critical_section_ctor, 4)

1 0

Piotr Caban : wineps: Support arc direction in PSDRV_DrawArc.
by Alexandre Julliard 28 Mar '23

28 Mar '23

Module: wine Branch: master Commit: dbf901a4da32b5f6ff613c4d2e09b057fcf67010 URL: https://gitlab.winehq.org/wine/wine/-/commit/dbf901a4da32b5f6ff613c4d2e09b0… Author: Piotr Caban <piotr(a)codeweavers.com> Date: Tue Mar 28 11:50:39 2023 +0200 wineps: Support arc direction in PSDRV_DrawArc. --- dlls/wineps.drv/graphics.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/dlls/wineps.drv/graphics.c b/dlls/wineps.drv/graphics.c index 3ea663ccb2d..94ae51d5764 100644 --- a/dlls/wineps.drv/graphics.c +++ b/dlls/wineps.drv/graphics.c @@ -226,7 +226,10 @@ static BOOL PSDRV_DrawArc( PHYSDEV dev, INT left, INT top, else PSDRV_WriteNewPath( dev ); - PSDRV_WriteArc(dev, x, y, w, h, start_angle, end_angle); + if(GetArcDirection(dev->hdc) == AD_COUNTERCLOCKWISE) + PSDRV_WriteArc(dev, x, y, w, h, start_angle, end_angle); + else + PSDRV_WriteArc(dev, x, y, w, h, end_angle, start_angle); if(lines == 1 || lines == 2) { /* chord or pie */ PSDRV_WriteClosePath(dev); PSDRV_Brush(dev,0);

1 0

Piotr Caban : wineps: Handle EMR_ANGLEARC record in spool files.
by Alexandre Julliard 28 Mar '23

28 Mar '23

Module: wine Branch: master Commit: f4d6b054efd5617b52598bcc527b244468ba4693 URL: https://gitlab.winehq.org/wine/wine/-/commit/f4d6b054efd5617b52598bcc527b24… Author: Piotr Caban <piotr(a)codeweavers.com> Date: Tue Mar 28 11:53:12 2023 +0200 wineps: Handle EMR_ANGLEARC record in spool files. --- dlls/wineps.drv/printproc.c | 32 ++++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+) diff --git a/dlls/wineps.drv/printproc.c b/dlls/wineps.drv/printproc.c index 71db4488b41..97af61664ac 100644 --- a/dlls/wineps.drv/printproc.c +++ b/dlls/wineps.drv/printproc.c @@ -18,6 +18,7 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA */ +#include <math.h> #include <stdlib.h> #include <windows.h> @@ -131,6 +132,11 @@ static struct pp_data* get_handle_data(HANDLE pp) return ret; } +static inline INT GDI_ROUND(double val) +{ + return (int)floor(val + 0.5); +} + static int WINAPI hmf_proc(HDC hdc, HANDLETABLE *htable, const ENHMETARECORD *rec, int n, LPARAM arg) { @@ -242,6 +248,32 @@ static int WINAPI hmf_proc(HDC hdc, HANDLETABLE *htable, return 1; } } + case EMR_ANGLEARC: + { + const EMRANGLEARC *p = (const EMRANGLEARC *)rec; + int arc_dir = SetArcDirection(data->pdev->dev.hdc, + p->eSweepAngle >= 0 ? AD_COUNTERCLOCKWISE : AD_CLOCKWISE); + EMRARCTO arcto; + int ret; + + arcto.emr.iType = EMR_ARCTO; + arcto.rclBox.left = p->ptlCenter.x - p->nRadius; + arcto.rclBox.top = p->ptlCenter.y - p->nRadius; + arcto.rclBox.right = p->ptlCenter.x + p->nRadius; + arcto.rclBox.bottom = p->ptlCenter.y + p->nRadius; + arcto.ptlStart.x = GDI_ROUND(p->ptlCenter.x + + cos(p->eStartAngle * M_PI / 180) * p->nRadius); + arcto.ptlStart.y = GDI_ROUND(p->ptlCenter.y - + sin(p->eStartAngle * M_PI / 180) * p->nRadius); + arcto.ptlEnd.x = GDI_ROUND(p->ptlCenter.x + + cos((p->eStartAngle + p->eSweepAngle) * M_PI / 180) * p->nRadius); + arcto.ptlEnd.y = GDI_ROUND(p->ptlCenter.y - + sin((p->eStartAngle + p->eSweepAngle) * M_PI / 180) * p->nRadius); + + ret = hmf_proc(hdc, htable, (ENHMETARECORD *)&arcto, n, arg); + SetArcDirection(data->pdev->dev.hdc, arc_dir); + return ret; + } case EMR_ELLIPSE: { const EMRELLIPSE *p = (const EMRELLIPSE *)rec;

1 0

Piotr Caban : wineps: Handle EMR_PAINTRGN record in spool files.
by Alexandre Julliard 28 Mar '23

28 Mar '23

Module: wine Branch: master Commit: 9e09705d494188a644f075e82532537a8654ce88 URL: https://gitlab.winehq.org/wine/wine/-/commit/9e09705d494188a644f075e8253253… Author: Piotr Caban <piotr(a)codeweavers.com> Date: Tue Mar 28 11:54:20 2023 +0200 wineps: Handle EMR_PAINTRGN record in spool files. --- dlls/wineps.drv/printproc.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/dlls/wineps.drv/printproc.c b/dlls/wineps.drv/printproc.c index 97af61664ac..702e04b3f63 100644 --- a/dlls/wineps.drv/printproc.c +++ b/dlls/wineps.drv/printproc.c @@ -356,6 +356,16 @@ static int WINAPI hmf_proc(HDC hdc, HANDLETABLE *htable, } return ret; } + case EMR_PAINTRGN: + { + const EMRPAINTRGN *p = (const EMRPAINTRGN *)rec; + HRGN rgn = ExtCreateRegion(NULL, p->cbRgnData, (const RGNDATA *)p->RgnData); + int ret; + + ret = PSDRV_PaintRgn(&data->pdev->dev, rgn); + DeleteObject(rgn); + return ret; + } case EMR_POLYBEZIER16: { const EMRPOLYBEZIER16 *p = (const EMRPOLYBEZIER16 *)rec;

1 0

Piotr Caban : wineps: Handle EMR_SETWINDOWEXTEX record in spool files.
by Alexandre Julliard 28 Mar '23

28 Mar '23

Module: wine Branch: master Commit: f6aa74e3b7a77fda1149637524db836112c6f3fb URL: https://gitlab.winehq.org/wine/wine/-/commit/f6aa74e3b7a77fda1149637524db83… Author: Piotr Caban <piotr(a)codeweavers.com> Date: Tue Mar 28 11:55:42 2023 +0200 wineps: Handle EMR_SETWINDOWEXTEX record in spool files. --- dlls/wineps.drv/printproc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/dlls/wineps.drv/printproc.c b/dlls/wineps.drv/printproc.c index 702e04b3f63..03f46a98616 100644 --- a/dlls/wineps.drv/printproc.c +++ b/dlls/wineps.drv/printproc.c @@ -513,6 +513,7 @@ static int WINAPI hmf_proc(HDC hdc, HANDLETABLE *htable, return 1; } + case EMR_SETWINDOWEXTEX: case EMR_MOVETOEX: case EMR_SETWORLDTRANSFORM: case EMR_MODIFYWORLDTRANSFORM:

1 0

Piotr Caban : wineps: Handle EMR_SETWINDOWORGEX record in spool files.
by Alexandre Julliard 28 Mar '23

28 Mar '23

Module: wine Branch: master Commit: 706569086fb6d9b82f6900f31af1ed30559ea582 URL: https://gitlab.winehq.org/wine/wine/-/commit/706569086fb6d9b82f6900f31af1ed… Author: Piotr Caban <piotr(a)codeweavers.com> Date: Tue Mar 28 11:56:14 2023 +0200 wineps: Handle EMR_SETWINDOWORGEX record in spool files. --- dlls/wineps.drv/printproc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/dlls/wineps.drv/printproc.c b/dlls/wineps.drv/printproc.c index 03f46a98616..49d2a401e23 100644 --- a/dlls/wineps.drv/printproc.c +++ b/dlls/wineps.drv/printproc.c @@ -514,6 +514,7 @@ static int WINAPI hmf_proc(HDC hdc, HANDLETABLE *htable, } case EMR_SETWINDOWEXTEX: + case EMR_SETWINDOWORGEX: case EMR_MOVETOEX: case EMR_SETWORLDTRANSFORM: case EMR_MODIFYWORLDTRANSFORM:

1 0