March 2023 - Wine-commits - list.winehq.org

Rémi Bernon : widl: Improve accuracy of error messages location.
by Alexandre Julliard 23 Mar '23

23 Mar '23

Module: wine Branch: master Commit: 472b2ecad40edf668e7cbefed3a5cd7fafc22e86 URL: https://gitlab.winehq.org/wine/wine/-/commit/472b2ecad40edf668e7cbefed3a5cd… Author: Rémi Bernon <rbernon(a)codeweavers.com> Date: Thu Mar 23 09:38:23 2023 +0100 widl: Improve accuracy of error messages location. --- tools/widl/parser.h | 2 +- tools/widl/parser.l | 77 ++++++++++++++++++++++++++++++++++++++------------- tools/widl/parser.y | 14 ++++++---- tools/widl/typetree.c | 4 +-- 4 files changed, 70 insertions(+), 27 deletions(-) diff --git a/tools/widl/parser.h b/tools/widl/parser.h index 2d35a2dd279..8dfde433334 100644 --- a/tools/widl/parser.h +++ b/tools/widl/parser.h @@ -27,7 +27,7 @@ int parser_parse(void); extern void generic_msg( const struct location *where, const char *s, const char *t, va_list ap ); extern void parser_error( const struct location *where, const char *message ); -extern void init_location( struct location *where ); +extern void init_location( struct location *copy, const struct location *begin, const struct location *end ); extern FILE *parser_in; extern int parser_debug; diff --git a/tools/widl/parser.l b/tools/widl/parser.l index 5437e6c5c5b..c2008c6865c 100644 --- a/tools/widl/parser.l +++ b/tools/widl/parser.l @@ -60,6 +60,13 @@ uuid {hd}{8}-{hd}{4}-{hd}{4}-{hd}{4}-{hd}{12} #include "parser.tab.h" +static void reset_location( struct location *where, const char *input_name ); +static void update_location( struct location *where, const char *yytext ); +static void end_of_line( struct location *where ); + +#define YY_USER_INIT reset_location( yylloc, input_name ) +#define YY_USER_ACTION update_location( yylloc, yytext ); + static void switch_to_acf(void); static warning_list_t *disabled_warnings = NULL; @@ -68,7 +75,7 @@ struct import_state { YY_BUFFER_STATE buffer; char *input_name; - int line_number; + struct location where; struct list entry; }; static struct list import_stack = LIST_INIT( import_stack ); @@ -80,7 +87,7 @@ struct import struct list entry; }; static struct list imports = LIST_INIT( imports ); -static int line_number = 1; +static struct location previous_location; /* converts an integer in string form to an unsigned long and prints an error * on overflow */ @@ -183,25 +190,28 @@ static void winrt_enable( int ns_prefix ) <PP_PRAGMA>{ midl_echo/"(" { yy_pop_state(); + yylloc->first_line -= 1; return tCPPQUOTE; } winrt{ws}+ns_prefix[^\n]* { yy_pop_state(); + yylloc->first_line -= 1; winrt_enable( TRUE ); } winrt[^\n]* { yy_pop_state(); + yylloc->first_line -= 1; winrt_enable( FALSE ); } [^\n]* { yy_pop_state(); + yylloc->first_line -= 1; return token_str( aPRAGMA, yytext, yylval ); } } <PP_LINE>[0-9]+{ws}* { yylloc->first_line = strtoul( yytext, NULL, 10 ) - 1; yylloc->last_line = yylloc->first_line; - line_number = yylloc->first_line; yy_pop_state(); yy_push_state(PP_FILE); } @@ -424,7 +434,7 @@ SAFEARRAY{ws}*/\( return tSAFEARRAY; \"(\\.|[^"\\])*\" { return token_str( aSTRING, yytext, yylval ); } \'(\\.|[^'\\])*\' { return token_str( aSQSTRING, yytext, yylval ); } - \n { line_number++; } + \n { end_of_line( yylloc ); } {ws} {} \<\< { return SHL; } \>\> { return SHR; } @@ -451,7 +461,7 @@ SAFEARRAY{ws}*/\( return tSAFEARRAY; } %% -void pop_import(void) +void pop_import( struct location *where ) { struct list *entry = list_head( &import_stack ); struct import_state *state; @@ -466,11 +476,11 @@ void pop_import(void) yy_switch_to_buffer( state->buffer ); input_name = state->input_name; - line_number = state->line_number; + *where = state->where; free( state ); } -void push_import( char *import_name ) +void push_import( const char *import_name, struct location *where ) { struct import_state *state; struct import *import; @@ -482,7 +492,7 @@ void push_import( char *import_name ) state->buffer = YY_CURRENT_BUFFER; state->input_name = input_name; - state->line_number = line_number; + state->where = *where; input_name = NULL; /* reset buffer for <<EOF>>, in case import fails or already imported */ @@ -497,7 +507,7 @@ void push_import( char *import_name ) input_name = find_input_file( import_name, state->input_name ); file = open_input_file( input_name ); - line_number = 1; + reset_location( where, input_name ); yy_switch_to_buffer( yy_create_buffer( file, YY_BUF_SIZE ) ); } @@ -511,13 +521,35 @@ static void switch_to_acf(void) input_name = xstrdup( acf_name ); file = open_input_file( input_name ); - line_number = 1; acf_name = NULL; yy_switch_to_buffer( yy_create_buffer( file, YY_BUF_SIZE ) ); } -#define CURRENT_LOCATION { input_name ? input_name : "stdin", parser_text, line_number, 0, line_number, 0 } +static void reset_location( struct location *where, const char *input_name ) +{ + where->first_line = 1; + where->last_line = 1; + where->first_column = 1; + where->last_column = 1; + where->input_name = xstrdup( input_name ); +} + +static void update_location( struct location *where, const char *yytext ) +{ + int len = strlen( yytext ); + previous_location = *where; + where->first_column = where->last_column; + where->last_column += len; +} + +static void end_of_line( struct location *where ) +{ + where->first_line++; + where->last_line++; + where->first_column = 1; + where->last_column = 1; +} static const int want_near_indication = 0; @@ -531,19 +563,26 @@ static void make_print(char *str) } } -void init_location( struct location *where ) +void init_location( struct location *where, const struct location *begin, const struct location *end ) { - where->input_name = input_name ? input_name : "stdin"; - where->near_text = parser_text; - where->first_line = line_number; - where->last_line = line_number; + if (!begin) begin = &previous_location; + *where = *begin; + + if (end) + { + where->last_line = end->last_line; + where->last_column = end->last_column; + } + else + { + where->first_line = begin->last_line; + where->first_column = begin->last_column; + } } void generic_msg( const struct location *where, const char *s, const char *t, va_list ap ) { - struct location cur_loc = CURRENT_LOCATION; - - if (!where) where = &cur_loc; + if (!where) where = &previous_location; fprintf( stderr, "%s:%d: %s: ", where->input_name, where->first_line, t ); vfprintf( stderr, s, ap ); diff --git a/tools/widl/parser.y b/tools/widl/parser.y index 35a392601e4..e92bd277771 100644 --- a/tools/widl/parser.y +++ b/tools/widl/parser.y @@ -125,8 +125,12 @@ static typelib_t *current_typelib; { int parser_lex( PARSER_STYPE *yylval, PARSER_LTYPE *yylloc ); -void push_import( char *input_name ); -void pop_import(void); +void push_import( const char *fname, PARSER_LTYPE *yylloc ); +void pop_import( PARSER_LTYPE *yylloc ); + +# define YYLLOC_DEFAULT( cur, rhs, n ) \ + do { if (n) init_location( &(cur), &YYRHSLOC( rhs, 1 ), &YYRHSLOC( rhs, n ) ); \ + else init_location( &(cur), &YYRHSLOC( rhs, 0 ), NULL ); } while(0) } @@ -511,9 +515,9 @@ typedecl: cppquote: tCPPQUOTE '(' aSTRING ')' { $$ = $3; } ; -import_start: tIMPORT aSTRING ';' { $$ = $2; push_import($2); } +import_start: tIMPORT aSTRING ';' { $$ = $2; push_import( $2, &yylloc ); } ; -import: import_start imp_statements aEOF { pop_import(); } +import: import_start imp_statements aEOF { pop_import( &yylloc ); } ; importlib: tIMPORTLIB '(' aSTRING ')' @@ -1974,7 +1978,7 @@ var_t *make_var(char *name) init_declspec(&v->declspec, NULL); v->attrs = NULL; v->eval = NULL; - init_location( &v->where ); + init_location( &v->where, NULL, NULL ); v->declonly = FALSE; return v; } diff --git a/tools/widl/typetree.c b/tools/widl/typetree.c index 8d4837b7943..b9173a33019 100644 --- a/tools/widl/typetree.c +++ b/tools/widl/typetree.c @@ -65,7 +65,7 @@ type_t *make_type(enum type_type type) t->tfswrite = FALSE; t->checked = FALSE; t->typelib_idx = -1; - init_location( &t->where ); + init_location( &t->where, NULL, NULL ); return t; } @@ -478,7 +478,7 @@ type_t *type_new_alias(const decl_spec_t *t, const char *name) a->name = xstrdup(name); a->attrs = NULL; a->details.alias.aliasee = *t; - init_location( &a->where ); + init_location( &a->where, NULL, NULL ); return a; }

1 0

Rémi Bernon : widl: Print the import stack and context in messages.
by Alexandre Julliard 23 Mar '23

23 Mar '23

Module: wine Branch: master Commit: 3149d27220acaf276bfa651e040ff006edcd6944 URL: https://gitlab.winehq.org/wine/wine/-/commit/3149d27220acaf276bfa651e040ff0… Author: Rémi Bernon <rbernon(a)codeweavers.com> Date: Thu Mar 23 09:38:23 2023 +0100 widl: Print the import stack and context in messages. --- tools/widl/parser.h | 2 +- tools/widl/parser.l | 69 ++++++++++++++++++++++++++++++-------------------- tools/widl/utils.c | 12 +++++++-- tools/widl/widltypes.h | 1 - 4 files changed, 52 insertions(+), 32 deletions(-) diff --git a/tools/widl/parser.h b/tools/widl/parser.h index 8dfde433334..7fef1e755bd 100644 --- a/tools/widl/parser.h +++ b/tools/widl/parser.h @@ -25,7 +25,7 @@ int parser_parse(void); -extern void generic_msg( const struct location *where, const char *s, const char *t, va_list ap ); +extern void parser_warning( const struct location *where, const char *message ); extern void parser_error( const struct location *where, const char *message ); extern void init_location( struct location *copy, const struct location *begin, const struct location *end ); diff --git a/tools/widl/parser.l b/tools/widl/parser.l index c2008c6865c..1b16de63f0b 100644 --- a/tools/widl/parser.l +++ b/tools/widl/parser.l @@ -461,6 +461,22 @@ SAFEARRAY{ws}*/\( return tSAFEARRAY; } %% +static void print_imports(void) +{ + struct import_state *state, *next; + + if (list_empty( &import_stack )) return; + + fprintf( stderr, "In file included from " ); + LIST_FOR_EACH_ENTRY_SAFE_REV( state, next, &import_stack, struct import_state, entry ) + { + if (&next->entry == &import_stack) break; + fprintf( stderr, "%s:%d,\n", state->input_name, state->where.first_line ); + fprintf( stderr, " from "); + } + fprintf( stderr, "%s:%d:\n", state->input_name, state->where.first_line ); +} + void pop_import( struct location *where ) { struct list *entry = list_head( &import_stack ); @@ -551,18 +567,6 @@ static void end_of_line( struct location *where ) where->last_column = 1; } -static const int want_near_indication = 0; - -static void make_print(char *str) -{ - while(*str) - { - if(!isprint(*str)) - *str = ' '; - str++; - } -} - void init_location( struct location *where, const struct location *begin, const struct location *end ) { if (!begin) begin = &previous_location; @@ -580,30 +584,39 @@ void init_location( struct location *where, const struct location *begin, const } } -void generic_msg( const struct location *where, const char *s, const char *t, va_list ap ) +static void diagnostic( const struct location *where, const char *type, const char *message ) { + char buffer[1024], *line = NULL; + FILE *file; + int i; + if (!where) where = &previous_location; - fprintf( stderr, "%s:%d: %s: ", where->input_name, where->first_line, t ); - vfprintf( stderr, s, ap ); + print_imports(); - if (want_near_indication) - { - char *cpy; - if (where->near_text) - { - cpy = xstrdup( where->near_text ); - make_print( cpy ); - fprintf( stderr, " near '%s'", cpy ); - free( cpy ); - } - } + fprintf( stderr, "%s:%d:%d: %s: %s\n", where->input_name, where->first_line, where->first_column, type, message ); + + if (!where->input_name || !(file = fopen( where->input_name, "r" ))) return; + for (i = 0; i < where->first_line; i++) if (!(line = fgets( buffer, sizeof(buffer), file ))) break; + fclose( file ); + if (!line) return; + fprintf( stderr, "%s", line ); + + line = buffer; + for (i = 0; i < where->first_column - 1; i++) line += sprintf( line, " " ); + line += sprintf( line, "^" ); + for (i = where->first_column + 1; i < where->last_column; i++) line += sprintf( line, "~" ); + fprintf( stderr, "%s\n", buffer ); } -/* yyerror: yacc assumes this is not newline terminated. */ void parser_error( const struct location *where, const char *message ) { - error_at( where, "%s\n", message ); + diagnostic( where, "error", message ); +} + +void parser_warning( const struct location *where, const char *message ) +{ + diagnostic( where, "warning", message ); } static void warning_disable(int warning) diff --git a/tools/widl/utils.c b/tools/widl/utils.c index 987301d1585..4f2e9d3d602 100644 --- a/tools/widl/utils.c +++ b/tools/widl/utils.c @@ -34,10 +34,14 @@ void error_at( const struct location *where, const char *s, ... ) { + char buffer[1024]; + va_list ap; va_start( ap, s ); - generic_msg( where, s, "error", ap ); + vsnprintf( buffer, sizeof(buffer), s, ap ); va_end( ap ); + + parser_error( where, buffer ); exit( 1 ); } @@ -62,10 +66,14 @@ void warning(const char *s, ...) void warning_at( const struct location *where, const char *s, ... ) { + char buffer[1024]; + va_list ap; va_start( ap, s ); - generic_msg( where, s, "warning", ap ); + vsnprintf( buffer, sizeof(buffer), s, ap ); va_end( ap ); + + parser_warning( where, buffer ); } void chat(const char *s, ...) diff --git a/tools/widl/widltypes.h b/tools/widl/widltypes.h index c3371e66871..fd108ecc473 100644 --- a/tools/widl/widltypes.h +++ b/tools/widl/widltypes.h @@ -313,7 +313,6 @@ enum type_basic_type struct location { const char *input_name; - const char *near_text; int first_line; int last_line; int first_column;

1 0

Piotr Caban : wineps: Write document header and footer in PrintDocumentOnPrintProcessor.
by Alexandre Julliard 23 Mar '23

23 Mar '23

Module: wine Branch: master Commit: f925d3b03bf332aee42d7da8c5c840607b93dab1 URL: https://gitlab.winehq.org/wine/wine/-/commit/f925d3b03bf332aee42d7da8c5c840… Author: Piotr Caban <piotr(a)codeweavers.com> Date: Thu Mar 23 12:23:37 2023 +0100 wineps: Write document header and footer in PrintDocumentOnPrintProcessor. --- dlls/wineps.drv/printproc.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/dlls/wineps.drv/printproc.c b/dlls/wineps.drv/printproc.c index 4c0271d4bd1..8ea2aa09015 100644 --- a/dlls/wineps.drv/printproc.c +++ b/dlls/wineps.drv/printproc.c @@ -312,6 +312,11 @@ BOOL WINAPI PrintDocumentOnPrintProcessor(HANDLE pp, WCHAR *doc_name) goto cleanup; data->pdev->job.hprinter = data->hport; + if (!PSDRV_WriteHeader(&data->pdev->dev, data->doc_name)) + { + WARN("Failed to write header\n"); + goto cleanup; + } data->pdev->job.banding = FALSE; data->pdev->job.OutOfPage = TRUE; data->pdev->job.PageNo = 0; @@ -375,6 +380,9 @@ BOOL WINAPI PrintDocumentOnPrintProcessor(HANDLE pp, WCHAR *doc_name) } cleanup: + if (data->pdev->job.PageNo) + PSDRV_WriteFooter(&data->pdev->dev); + HeapFree(GetProcessHeap(), 0, data->pdev->job.doc_name); ClosePrinter(spool_data); return EndDocPrinter(data->hport) && ret;

1 0

Piotr Caban : wineps: Handle EMR_HEADER record in spool files.
by Alexandre Julliard 23 Mar '23

23 Mar '23

Module: wine Branch: master Commit: 8ce850593726f20a490930078ab1a51ff29a10cd URL: https://gitlab.winehq.org/wine/wine/-/commit/8ce850593726f20a490930078ab1a5… Author: Piotr Caban <piotr(a)codeweavers.com> Date: Thu Mar 23 12:28:32 2023 +0100 wineps: Handle EMR_HEADER record in spool files. --- dlls/wineps.drv/printproc.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/dlls/wineps.drv/printproc.c b/dlls/wineps.drv/printproc.c index 8ea2aa09015..62d0dc7c300 100644 --- a/dlls/wineps.drv/printproc.c +++ b/dlls/wineps.drv/printproc.c @@ -133,7 +133,16 @@ static struct pp_data* get_handle_data(HANDLE pp) static int WINAPI hmf_proc(HDC hdc, HANDLETABLE *htable, const ENHMETARECORD *rec, int n, LPARAM arg) { - FIXME("unsupported record: %ld\n", rec->iType); + struct pp_data *data = (struct pp_data *)arg; + + switch (rec->iType) + { + case EMR_HEADER: + return PSDRV_StartPage(&data->pdev->dev); + default: + FIXME("unsupported record: %ld\n", rec->iType); + } + return 1; } @@ -174,7 +183,7 @@ static BOOL print_metafile(struct pp_data *data, HANDLE hdata) if (!hmf) return FALSE; - ret = EnumEnhMetaFile(NULL, hmf, hmf_proc, NULL, NULL); + ret = EnumEnhMetaFile(NULL, hmf, hmf_proc, (void *)data, NULL); DeleteEnhMetaFile(hmf); return ret; }

1 0

Piotr Caban : wineps: Handle EMR_EOF record in spool files.
by Alexandre Julliard 23 Mar '23

23 Mar '23

Module: wine Branch: master Commit: 8d2f5f22c4cfaf35893716a35f9716a30b892416 URL: https://gitlab.winehq.org/wine/wine/-/commit/8d2f5f22c4cfaf35893716a35f9716… Author: Piotr Caban <piotr(a)codeweavers.com> Date: Thu Mar 23 12:30:13 2023 +0100 wineps: Handle EMR_EOF record in spool files. --- dlls/wineps.drv/printproc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/dlls/wineps.drv/printproc.c b/dlls/wineps.drv/printproc.c index 62d0dc7c300..722bfc39cc0 100644 --- a/dlls/wineps.drv/printproc.c +++ b/dlls/wineps.drv/printproc.c @@ -139,6 +139,8 @@ static int WINAPI hmf_proc(HDC hdc, HANDLETABLE *htable, { case EMR_HEADER: return PSDRV_StartPage(&data->pdev->dev); + case EMR_EOF: + return PSDRV_EndPage(&data->pdev->dev); default: FIXME("unsupported record: %ld\n", rec->iType); }

1 0

Piotr Caban : wineps: Handle brush selection in spool files.
by Alexandre Julliard 23 Mar '23

23 Mar '23

Module: wine Branch: master Commit: e0cdf885d10cccf557a5480a0b1ce4d6df3de14d URL: https://gitlab.winehq.org/wine/wine/-/commit/e0cdf885d10cccf557a5480a0b1ce4… Author: Piotr Caban <piotr(a)codeweavers.com> Date: Thu Mar 23 12:36:08 2023 +0100 wineps: Handle brush selection in spool files. --- dlls/wineps.drv/printproc.c | 36 +++++++++++++++++++++++++++++++++++- 1 file changed, 35 insertions(+), 1 deletion(-) diff --git a/dlls/wineps.drv/printproc.c b/dlls/wineps.drv/printproc.c index 722bfc39cc0..5a4504dbd4d 100644 --- a/dlls/wineps.drv/printproc.c +++ b/dlls/wineps.drv/printproc.c @@ -40,6 +40,7 @@ struct pp_data WCHAR *doc_name; WCHAR *out_file; PSDRV_PDEVICE *pdev; + struct brush_pattern *patterns; }; typedef enum @@ -138,9 +139,40 @@ static int WINAPI hmf_proc(HDC hdc, HANDLETABLE *htable, switch (rec->iType) { case EMR_HEADER: - return PSDRV_StartPage(&data->pdev->dev); + { + const ENHMETAHEADER *header = (const ENHMETAHEADER *)rec; + + data->patterns = calloc(sizeof(*data->patterns), header->nHandles); + return data->patterns && PSDRV_StartPage(&data->pdev->dev); + } case EMR_EOF: return PSDRV_EndPage(&data->pdev->dev); + case EMR_SELECTOBJECT: + { + const EMRSELECTOBJECT *so = (const EMRSELECTOBJECT *)rec; + struct brush_pattern *pattern; + HGDIOBJ obj; + + if (so->ihObject & 0x80000000) + { + obj = GetStockObject(so->ihObject & 0x7fffffff); + pattern = NULL; + } + else + { + obj = (htable->objectHandle)[so->ihObject]; + pattern = data->patterns + so->ihObject; + } + SelectObject(data->pdev->dev.hdc, obj); + + switch (GetObjectType(obj)) + { + case OBJ_BRUSH: return PSDRV_SelectBrush(&data->pdev->dev, obj, pattern) != NULL; + default: + FIXME("unhandled object type %ld\n", GetObjectType(obj)); + return 1; + } + } default: FIXME("unsupported record: %ld\n", rec->iType); } @@ -187,6 +219,8 @@ static BOOL print_metafile(struct pp_data *data, HANDLE hdata) ret = EnumEnhMetaFile(NULL, hmf, hmf_proc, (void *)data, NULL); DeleteEnhMetaFile(hmf); + free(data->patterns); + data->patterns = NULL; return ret; }

1 0

Piotr Caban : wineps: Handle pen selection in spool files.
by Alexandre Julliard 23 Mar '23

23 Mar '23

Module: wine Branch: master Commit: c680d8139b5b18d60d3b66bd944b153b7f416c47 URL: https://gitlab.winehq.org/wine/wine/-/commit/c680d8139b5b18d60d3b66bd944b15… Author: Piotr Caban <piotr(a)codeweavers.com> Date: Thu Mar 23 12:37:11 2023 +0100 wineps: Handle pen selection in spool files. --- dlls/wineps.drv/printproc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/dlls/wineps.drv/printproc.c b/dlls/wineps.drv/printproc.c index 5a4504dbd4d..22985e0827c 100644 --- a/dlls/wineps.drv/printproc.c +++ b/dlls/wineps.drv/printproc.c @@ -167,6 +167,7 @@ static int WINAPI hmf_proc(HDC hdc, HANDLETABLE *htable, switch (GetObjectType(obj)) { + case OBJ_PEN: return PSDRV_SelectPen(&data->pdev->dev, obj, NULL) != NULL; case OBJ_BRUSH: return PSDRV_SelectBrush(&data->pdev->dev, obj, pattern) != NULL; default: FIXME("unhandled object type %ld\n", GetObjectType(obj));

1 0

Piotr Caban : wineps: Handle EMR_RECTANGLE record in spool files.
by Alexandre Julliard 23 Mar '23

23 Mar '23

Module: wine Branch: master Commit: 713d5d9644f5b68ae49ab934baae479d4c2b6b25 URL: https://gitlab.winehq.org/wine/wine/-/commit/713d5d9644f5b68ae49ab934baae47… Author: Piotr Caban <piotr(a)codeweavers.com> Date: Thu Mar 23 12:39:08 2023 +0100 wineps: Handle EMR_RECTANGLE record in spool files. --- dlls/wineps.drv/printproc.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/dlls/wineps.drv/printproc.c b/dlls/wineps.drv/printproc.c index 22985e0827c..f0acc6dd5f1 100644 --- a/dlls/wineps.drv/printproc.c +++ b/dlls/wineps.drv/printproc.c @@ -174,6 +174,13 @@ static int WINAPI hmf_proc(HDC hdc, HANDLETABLE *htable, return 1; } } + case EMR_RECTANGLE: + { + const EMRRECTANGLE *rect = (const EMRRECTANGLE *)rec; + + return PSDRV_Rectangle(&data->pdev->dev, rect->rclBox.left, + rect->rclBox.top, rect->rclBox.right, rect->rclBox.bottom); + } default: FIXME("unsupported record: %ld\n", rec->iType); }

1 0

Piotr Caban : wineps: Handle EMR_MOVETOEX record in spool files.
by Alexandre Julliard 23 Mar '23

23 Mar '23

Module: wine Branch: master Commit: 16489549f055b33764e591593407fa7d7cb47777 URL: https://gitlab.winehq.org/wine/wine/-/commit/16489549f055b33764e591593407fa… Author: Piotr Caban <piotr(a)codeweavers.com> Date: Thu Mar 23 12:40:26 2023 +0100 wineps: Handle EMR_MOVETOEX record in spool files. --- dlls/wineps.drv/printproc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/dlls/wineps.drv/printproc.c b/dlls/wineps.drv/printproc.c index f0acc6dd5f1..c7c7d61437d 100644 --- a/dlls/wineps.drv/printproc.c +++ b/dlls/wineps.drv/printproc.c @@ -181,6 +181,9 @@ static int WINAPI hmf_proc(HDC hdc, HANDLETABLE *htable, return PSDRV_Rectangle(&data->pdev->dev, rect->rclBox.left, rect->rclBox.top, rect->rclBox.right, rect->rclBox.bottom); } + + case EMR_MOVETOEX: + return PlayEnhMetaFileRecord(data->pdev->dev.hdc, htable, rec, n); default: FIXME("unsupported record: %ld\n", rec->iType); }

1 0

Piotr Caban : wineps: Handle EMR_LINETO record in spool files.
by Alexandre Julliard 23 Mar '23

23 Mar '23

Module: wine Branch: master Commit: c1dd7d6f52a7e8fb7eb36df992b12497e9bcb6f4 URL: https://gitlab.winehq.org/wine/wine/-/commit/c1dd7d6f52a7e8fb7eb36df992b124… Author: Piotr Caban <piotr(a)codeweavers.com> Date: Thu Mar 23 12:41:38 2023 +0100 wineps: Handle EMR_LINETO record in spool files. --- dlls/wineps.drv/printproc.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/dlls/wineps.drv/printproc.c b/dlls/wineps.drv/printproc.c index c7c7d61437d..30ca6ef0ce9 100644 --- a/dlls/wineps.drv/printproc.c +++ b/dlls/wineps.drv/printproc.c @@ -181,6 +181,13 @@ static int WINAPI hmf_proc(HDC hdc, HANDLETABLE *htable, return PSDRV_Rectangle(&data->pdev->dev, rect->rclBox.left, rect->rclBox.top, rect->rclBox.right, rect->rclBox.bottom); } + case EMR_LINETO: + { + const EMRLINETO *line = (const EMRLINETO *)rec; + + return PSDRV_LineTo(&data->pdev->dev, line->ptl.x, line->ptl.y) && + MoveToEx(data->pdev->dev.hdc, line->ptl.x, line->ptl.y, NULL); + } case EMR_MOVETOEX: return PlayEnhMetaFileRecord(data->pdev->dev.hdc, htable, rec, n);

1 0