May 2023 - Wine-commits - list.winehq.org

Piotr Caban : wineps: Mark default DEVMODE const.
by Alexandre Julliard 19 May '23

19 May '23

Module: wine Branch: master Commit: 1cccaa1e8a95420b300433eccc530b73ed66c644 URL: https://gitlab.winehq.org/wine/wine/-/commit/1cccaa1e8a95420b300433eccc530b… Author: Piotr Caban <piotr(a)codeweavers.com> Date: Wed May 17 18:02:17 2023 +0200 wineps: Mark default DEVMODE const. --- dlls/wineps.drv/unixlib.c | 8 ++++---- dlls/wineps.drv/unixlib.h | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/dlls/wineps.drv/unixlib.c b/dlls/wineps.drv/unixlib.c index d3d3d2ee68f..26b1232f63e 100644 --- a/dlls/wineps.drv/unixlib.c +++ b/dlls/wineps.drv/unixlib.c @@ -75,7 +75,7 @@ struct printer_info { struct list entry; const WCHAR *name; - PSDRV_DEVMODE *devmode; + const PSDRV_DEVMODE *devmode; }; static struct list printer_info_list = LIST_INIT(printer_info_list); @@ -91,7 +91,7 @@ typedef struct { struct gdi_physdev dev; PSDRV_DEVMODE *devmode; - struct printer_info *pi; + const struct printer_info *pi; /* builtin font info */ BOOL builtin; @@ -339,7 +339,7 @@ static const struct page_size *find_pagesize(const struct printer_info *pi, } static void merge_devmodes(PSDRV_DEVMODE *dm1, const DEVMODEW *dm2, - struct printer_info *pi) + const struct printer_info *pi) { /* some sanity checks here on dm2 */ @@ -1008,7 +1008,7 @@ static struct font_data *find_font_data(const char *name) return NULL; } -static struct font_data *find_builtin_font(PSDRV_DEVMODE *devmode, +static struct font_data *find_builtin_font(const PSDRV_DEVMODE *devmode, const WCHAR *facename, BOOL it, BOOL bd) { struct installed_font *installed_font; diff --git a/dlls/wineps.drv/unixlib.h b/dlls/wineps.drv/unixlib.h index 235f48b5832..1d908af78b4 100644 --- a/dlls/wineps.drv/unixlib.h +++ b/dlls/wineps.drv/unixlib.h @@ -107,7 +107,7 @@ struct open_dc_params const WCHAR *device; const DEVMODEW *devmode; const WCHAR *output; - PSDRV_DEVMODE *def_devmode; + const PSDRV_DEVMODE *def_devmode; HDC hdc; };

1 0

Piotr Caban : wineps: Simplify PSDRV_UVMetrics implementation.
by Alexandre Julliard 19 May '23

19 May '23

Module: wine Branch: master Commit: e70aa825cf557c425e646e22b81e6057618d7835 URL: https://gitlab.winehq.org/wine/wine/-/commit/e70aa825cf557c425e646e22b81e60… Author: Piotr Caban <piotr(a)codeweavers.com> Date: Wed May 17 18:16:58 2023 +0200 wineps: Simplify PSDRV_UVMetrics implementation. --- dlls/wineps.drv/afm.c | 36 ++++++++++++++++++++++++++++++++---- dlls/wineps.drv/builtin.c | 39 --------------------------------------- dlls/wineps.drv/psdrv.h | 1 - 3 files changed, 32 insertions(+), 44 deletions(-) diff --git a/dlls/wineps.drv/afm.c b/dlls/wineps.drv/afm.c index cd08cee55f8..ef4f4485b22 100644 --- a/dlls/wineps.drv/afm.c +++ b/dlls/wineps.drv/afm.c @@ -22,6 +22,7 @@ */ #include <string.h> +#include <stdlib.h> #include "psdrv.h" #include "wine/debug.h" @@ -185,6 +186,33 @@ static void PSDRV_DumpFontList(void) return; } +/****************************************************************************** + * PSDRV_UVMetrics + * + * Find the AFMMETRICS for a given UV. Returns NULL if the font does not + * have a glyph for the given UV. + */ +static int __cdecl MetricsByUV(const void *a, const void *b) +{ + return (int)(((const AFMMETRICS *)a)->UV - ((const AFMMETRICS *)b)->UV); +} + +static const AFMMETRICS *PSDRV_UVMetrics(LONG UV, const AFM *afm) +{ + AFMMETRICS key; + + /* + * Ugly work-around for symbol fonts. Wine is sending characters which + * belong in the Unicode private use range (U+F020 - U+F0FF) as ASCII + * characters (U+0020 - U+00FF). + */ + + if ((afm->Metrics->UV & 0xff00) == 0xf000 && UV < 0x100) + UV |= 0xf000; + + key.UV = UV; + return bsearch(&key, afm->Metrics, afm->NumofMetrics, sizeof(AFMMETRICS), MetricsByUV); +} /******************************************************************************* * PSDRV_CalcAvgCharWidth @@ -208,7 +236,7 @@ static inline SHORT MeanCharWidth(const AFM *afm) return (SHORT)(w + 0.5); } -static const struct { LONG UV; int weight; } UVweight[27] = +static const struct { LONG UV; int weight; } UVweight[] = { { 0x0061, 64 }, { 0x0062, 14 }, { 0x0063, 27 }, { 0x0064, 35 }, { 0x0065, 100 }, { 0x0066, 20 }, { 0x0067, 14 }, { 0x0068, 42 }, @@ -224,13 +252,13 @@ SHORT PSDRV_CalcAvgCharWidth(const AFM *afm) float w = 0.0; int i; - for (i = 0; i < 27; ++i) + for (i = 0; i < ARRAY_SIZE(UVweight); ++i) { const AFMMETRICS *afmm; afmm = PSDRV_UVMetrics(UVweight[i].UV, afm); - if (afmm->UV != UVweight[i].UV) /* UVMetrics returns first glyph */ - return MeanCharWidth(afm); /* in font if UV is missing */ + if (!afmm) + return MeanCharWidth(afm); w += afmm->WX * (float)(UVweight[i].weight); } diff --git a/dlls/wineps.drv/builtin.c b/dlls/wineps.drv/builtin.c index 02b452b0a8b..028c185d59c 100644 --- a/dlls/wineps.drv/builtin.c +++ b/dlls/wineps.drv/builtin.c @@ -84,42 +84,3 @@ BOOL PSDRV_WriteBuiltinGlyphShow(print_ctx *ctx, LPCWSTR str, INT count) return TRUE; } - -/****************************************************************************** - * PSDRV_UVMetrics - * - * Find the AFMMETRICS for a given UV. Returns first glyph in the font - * (space?) if the font does not have a glyph for the given UV. - */ -static int __cdecl MetricsByUV(const void *a, const void *b) -{ - return (int)(((const AFMMETRICS *)a)->UV - ((const AFMMETRICS *)b)->UV); -} - -const AFMMETRICS *PSDRV_UVMetrics(LONG UV, const AFM *afm) -{ - AFMMETRICS key; - const AFMMETRICS *needle; - - /* - * Ugly work-around for symbol fonts. Wine is sending characters which - * belong in the Unicode private use range (U+F020 - U+F0FF) as ASCII - * characters (U+0020 - U+00FF). - */ - - if ((afm->Metrics->UV & 0xff00) == 0xf000 && UV < 0x100) - UV |= 0xf000; - - key.UV = UV; - - needle = bsearch(&key, afm->Metrics, afm->NumofMetrics, sizeof(AFMMETRICS), - MetricsByUV); - - if (needle == NULL) - { - WARN("No glyph for U+%.4lX in %s\n", UV, afm->FontName); - needle = afm->Metrics; - } - - return needle; -} diff --git a/dlls/wineps.drv/psdrv.h b/dlls/wineps.drv/psdrv.h index 981ef6868dd..afeaa5fec0c 100644 --- a/dlls/wineps.drv/psdrv.h +++ b/dlls/wineps.drv/psdrv.h @@ -501,7 +501,6 @@ INT PSDRV_GlyphListInit(void) DECLSPEC_HIDDEN; const GLYPHNAME *PSDRV_GlyphName(LPCSTR szName) DECLSPEC_HIDDEN; VOID PSDRV_IndexGlyphList(void) DECLSPEC_HIDDEN; BOOL PSDRV_GetType1Metrics(void) DECLSPEC_HIDDEN; -const AFMMETRICS *PSDRV_UVMetrics(LONG UV, const AFM *afm) DECLSPEC_HIDDEN; SHORT PSDRV_CalcAvgCharWidth(const AFM *afm) DECLSPEC_HIDDEN; extern BOOL PSDRV_WriteSetBuiltinFont(print_ctx *ctx) DECLSPEC_HIDDEN;

1 0

Piotr Caban : wineps: Remove unused fields from print_ctx.
by Alexandre Julliard 19 May '23

19 May '23

Module: wine Branch: master Commit: 3fca78fbe42907e74fa3397246904863e759ffda URL: https://gitlab.winehq.org/wine/wine/-/commit/3fca78fbe42907e74fa33972469048… Author: Piotr Caban <piotr(a)codeweavers.com> Date: Wed May 17 18:20:52 2023 +0200 wineps: Remove unused fields from print_ctx. --- dlls/wineps.drv/color.c | 28 ---------------------------- dlls/wineps.drv/init.c | 42 ++++++------------------------------------ dlls/wineps.drv/ps.c | 1 - dlls/wineps.drv/psdrv.h | 7 ------- 4 files changed, 6 insertions(+), 72 deletions(-) diff --git a/dlls/wineps.drv/color.c b/dlls/wineps.drv/color.c index 26c235a8c6c..db14319cbd6 100644 --- a/dlls/wineps.drv/color.c +++ b/dlls/wineps.drv/color.c @@ -24,34 +24,6 @@ WINE_DEFAULT_DEBUG_CHANNEL(psdrv); -/********************************************************************** - * PSDRV_CopyColor - * - * Copies col2 into col1. Return FALSE on error. - */ -BOOL PSDRV_CopyColor(PSCOLOR *col1, PSCOLOR *col2) -{ - - switch(col2->type) { - case PSCOLOR_GRAY: - col1->value.gray.i = col2->value.gray.i; - break; - - case PSCOLOR_RGB: - col1->value.rgb.r = col2->value.rgb.r; - col1->value.rgb.g = col2->value.rgb.g; - col1->value.rgb.b = col2->value.rgb.b; - break; - - default: - ERR("Unknown colour type %d\n", col1->type); - return FALSE; - } - - col1->type = col2->type; - return TRUE; -} - PSRGB rgb_to_grayscale_scale( void ) { static const PSRGB scale = {0.3, 0.59, 0.11}; diff --git a/dlls/wineps.drv/init.c b/dlls/wineps.drv/init.c index 9cbea031d48..9d59830c60d 100644 --- a/dlls/wineps.drv/init.c +++ b/dlls/wineps.drv/init.c @@ -412,7 +412,7 @@ static void PSDRV_UpdateDevCaps( print_ctx *ctx ) { PAGESIZE *page; RESOLUTION *res; - INT width = 0, height = 0, resx = 0, resy = 0; + INT resx = 0, resy = 0; dump_devmode(&ctx->Devmode->dmPublic); @@ -460,63 +460,33 @@ static void PSDRV_UpdateDevCaps( print_ctx *ctx ) if(&page->entry == &ctx->pi->ppd->PageSizes) { FIXME("Can't find page\n"); SetRectEmpty(&ctx->ImageableArea); - ctx->PageSize.cx = 0; - ctx->PageSize.cy = 0; } else if(page->ImageableArea) { /* ctx sizes in device units; ppd sizes in 1/72" */ SetRect(&ctx->ImageableArea, page->ImageableArea->llx * ctx->logPixelsX / 72, page->ImageableArea->ury * ctx->logPixelsY / 72, page->ImageableArea->urx * ctx->logPixelsX / 72, page->ImageableArea->lly * ctx->logPixelsY / 72); - ctx->PageSize.cx = page->PaperDimension->x * - ctx->logPixelsX / 72; - ctx->PageSize.cy = page->PaperDimension->y * - ctx->logPixelsY / 72; } else { ctx->ImageableArea.left = ctx->ImageableArea.bottom = 0; - ctx->ImageableArea.right = ctx->PageSize.cx = + ctx->ImageableArea.right = page->PaperDimension->x * ctx->logPixelsX / 72; - ctx->ImageableArea.top = ctx->PageSize.cy = + ctx->ImageableArea.top = page->PaperDimension->y * ctx->logPixelsY / 72; } } else if((ctx->Devmode->dmPublic.dmFields & DM_PAPERLENGTH) && (ctx->Devmode->dmPublic.dmFields & DM_PAPERWIDTH)) { /* ctx sizes in device units; Devmode sizes in 1/10 mm */ ctx->ImageableArea.left = ctx->ImageableArea.bottom = 0; - ctx->ImageableArea.right = ctx->PageSize.cx = + ctx->ImageableArea.right = ctx->Devmode->dmPublic.dmPaperWidth * ctx->logPixelsX / 254; - ctx->ImageableArea.top = ctx->PageSize.cy = + ctx->ImageableArea.top = ctx->Devmode->dmPublic.dmPaperLength * ctx->logPixelsY / 254; } else { FIXME("Odd dmFields %lx\n", ctx->Devmode->dmPublic.dmFields); SetRectEmpty(&ctx->ImageableArea); - ctx->PageSize.cx = 0; - ctx->PageSize.cy = 0; } - TRACE("ImageableArea = %s: PageSize = %ldx%ld\n", wine_dbgstr_rect(&ctx->ImageableArea), - ctx->PageSize.cx, ctx->PageSize.cy); - - /* these are in device units */ - width = ctx->ImageableArea.right - ctx->ImageableArea.left; - height = ctx->ImageableArea.top - ctx->ImageableArea.bottom; - - if(ctx->Devmode->dmPublic.dmOrientation == DMORIENT_PORTRAIT) { - ctx->horzRes = width; - ctx->vertRes = height; - } else { - ctx->horzRes = height; - ctx->vertRes = width; - } - - /* these are in mm */ - ctx->horzSize = (ctx->horzRes * 25.4) / ctx->logPixelsX; - ctx->vertSize = (ctx->vertRes * 25.4) / ctx->logPixelsY; - - TRACE("devcaps: horzSize = %dmm, vertSize = %dmm, " - "horzRes = %d, vertRes = %d\n", - ctx->horzSize, ctx->vertSize, - ctx->horzRes, ctx->vertRes); + TRACE("ImageableArea = %s\n", wine_dbgstr_rect(&ctx->ImageableArea)); } print_ctx *create_print_ctx( HDC hdc, const WCHAR *device, diff --git a/dlls/wineps.drv/ps.c b/dlls/wineps.drv/ps.c index 007250e55db..421f01302bf 100644 --- a/dlls/wineps.drv/ps.c +++ b/dlls/wineps.drv/ps.c @@ -635,7 +635,6 @@ BOOL PSDRV_WriteSetColor(print_ctx *ctx, PSCOLOR *color) { char buf[256]; - PSDRV_CopyColor(&ctx->inkColor, color); switch(color->type) { case PSCOLOR_RGB: push_lc_numeric("C"); diff --git a/dlls/wineps.drv/psdrv.h b/dlls/wineps.drv/psdrv.h index afeaa5fec0c..dd63c0000cf 100644 --- a/dlls/wineps.drv/psdrv.h +++ b/dlls/wineps.drv/psdrv.h @@ -338,20 +338,14 @@ typedef struct PSPEN pen; PSBRUSH brush; PSCOLOR bkColor; - PSCOLOR inkColor; /* Last colour set */ JOB job; PSDRV_DEVMODE *Devmode; PRINTERINFO *pi; - SIZE PageSize; /* Physical page size in device units */ RECT ImageableArea; /* Imageable area in device units */ /* NB both PageSize and ImageableArea are not rotated in landscape mode, so PageSize.cx is generally < PageSize.cy */ - int horzRes; /* device caps */ - int vertRes; - int horzSize; - int vertSize; int logPixelsX; int logPixelsY; @@ -446,7 +440,6 @@ extern void PSDRV_AddClip( print_ctx *ctx, HRGN hrgn ) DECLSPEC_HIDDEN; extern void PSDRV_SetClip( print_ctx *ctx ) DECLSPEC_HIDDEN; extern void PSDRV_ResetClip( print_ctx *ctx ) DECLSPEC_HIDDEN; -extern BOOL PSDRV_CopyColor(PSCOLOR *col1, PSCOLOR *col2) DECLSPEC_HIDDEN; extern void PSDRV_CreateColor( print_ctx *ctx, PSCOLOR *pscolor, COLORREF wincolor ) DECLSPEC_HIDDEN; extern PSRGB rgb_to_grayscale_scale( void ) DECLSPEC_HIDDEN;

1 0

Piotr Caban : wineps: Don't store logPixels in print_ctx.
by Alexandre Julliard 19 May '23

19 May '23

Module: wine Branch: master Commit: cdb57c524c6d6f55e022bd976c43aa9912e5f455 URL: https://gitlab.winehq.org/wine/wine/-/commit/cdb57c524c6d6f55e022bd976c43aa… Author: Piotr Caban <piotr(a)codeweavers.com> Date: Wed May 17 18:47:57 2023 +0200 wineps: Don't store logPixels in print_ctx. --- dlls/wineps.drv/init.c | 61 +++++++++---------------------------------------- dlls/wineps.drv/ps.c | 18 ++++++++------- dlls/wineps.drv/psdrv.h | 3 --- 3 files changed, 21 insertions(+), 61 deletions(-) diff --git a/dlls/wineps.drv/init.c b/dlls/wineps.drv/init.c index 9d59830c60d..649b6ecb41b 100644 --- a/dlls/wineps.drv/init.c +++ b/dlls/wineps.drv/init.c @@ -410,47 +410,12 @@ static void dump_devmode(const DEVMODEW *dm) static void PSDRV_UpdateDevCaps( print_ctx *ctx ) { + int log_pixels_x = GetDeviceCaps(ctx->hdc, ASPECTX); + int log_pixels_y = GetDeviceCaps(ctx->hdc, ASPECTY); PAGESIZE *page; - RESOLUTION *res; - INT resx = 0, resy = 0; dump_devmode(&ctx->Devmode->dmPublic); - if (ctx->Devmode->dmPublic.dmFields & (DM_PRINTQUALITY | DM_YRESOLUTION | DM_LOGPIXELS)) - { - if (ctx->Devmode->dmPublic.dmFields & DM_PRINTQUALITY) - resx = resy = ctx->Devmode->dmPublic.dmPrintQuality; - - if (ctx->Devmode->dmPublic.dmFields & DM_YRESOLUTION) - resy = ctx->Devmode->dmPublic.dmYResolution; - - if (ctx->Devmode->dmPublic.dmFields & DM_LOGPIXELS) - resx = resy = ctx->Devmode->dmPublic.dmLogPixels; - - LIST_FOR_EACH_ENTRY(res, &ctx->pi->ppd->Resolutions, RESOLUTION, entry) - { - if (res->resx == resx && res->resy == resy) - { - ctx->logPixelsX = resx; - ctx->logPixelsY = resy; - break; - } - } - - if (&res->entry == &ctx->pi->ppd->Resolutions) - { - WARN("Requested resolution %dx%d is not supported by device\n", resx, resy); - ctx->logPixelsX = ctx->pi->ppd->DefaultResolution; - ctx->logPixelsY = ctx->logPixelsX; - } - } - else - { - WARN("Using default device resolution %d\n", ctx->pi->ppd->DefaultResolution); - ctx->logPixelsX = ctx->pi->ppd->DefaultResolution; - ctx->logPixelsY = ctx->logPixelsX; - } - if(ctx->Devmode->dmPublic.dmFields & DM_PAPERSIZE) { LIST_FOR_EACH_ENTRY(page, &ctx->pi->ppd->PageSizes, PAGESIZE, entry) { if(page->WinPage == ctx->Devmode->dmPublic.dmPaperSize) @@ -462,25 +427,23 @@ static void PSDRV_UpdateDevCaps( print_ctx *ctx ) SetRectEmpty(&ctx->ImageableArea); } else if(page->ImageableArea) { /* ctx sizes in device units; ppd sizes in 1/72" */ - SetRect(&ctx->ImageableArea, page->ImageableArea->llx * ctx->logPixelsX / 72, - page->ImageableArea->ury * ctx->logPixelsY / 72, - page->ImageableArea->urx * ctx->logPixelsX / 72, - page->ImageableArea->lly * ctx->logPixelsY / 72); + SetRect(&ctx->ImageableArea, page->ImageableArea->llx * log_pixels_x / 72, + page->ImageableArea->ury * log_pixels_y / 72, + page->ImageableArea->urx * log_pixels_x / 72, + page->ImageableArea->lly * log_pixels_y / 72); } else { ctx->ImageableArea.left = ctx->ImageableArea.bottom = 0; - ctx->ImageableArea.right = - page->PaperDimension->x * ctx->logPixelsX / 72; - ctx->ImageableArea.top = - page->PaperDimension->y * ctx->logPixelsY / 72; + ctx->ImageableArea.right = page->PaperDimension->x * log_pixels_x / 72; + ctx->ImageableArea.top = page->PaperDimension->y * log_pixels_y / 72; } } else if((ctx->Devmode->dmPublic.dmFields & DM_PAPERLENGTH) && (ctx->Devmode->dmPublic.dmFields & DM_PAPERWIDTH)) { /* ctx sizes in device units; Devmode sizes in 1/10 mm */ ctx->ImageableArea.left = ctx->ImageableArea.bottom = 0; ctx->ImageableArea.right = - ctx->Devmode->dmPublic.dmPaperWidth * ctx->logPixelsX / 254; + ctx->Devmode->dmPublic.dmPaperWidth * log_pixels_x / 254; ctx->ImageableArea.top = - ctx->Devmode->dmPublic.dmPaperLength * ctx->logPixelsY / 254; + ctx->Devmode->dmPublic.dmPaperLength * log_pixels_y / 254; } else { FIXME("Odd dmFields %lx\n", ctx->Devmode->dmPublic.dmFields); SetRectEmpty(&ctx->ImageableArea); @@ -523,8 +486,7 @@ print_ctx *create_print_ctx( HDC hdc, const WCHAR *device, memcpy( ctx->Devmode, pi->Devmode, pi->Devmode->dmPublic.dmSize + pi->Devmode->dmPublic.dmDriverExtra ); ctx->pi = pi; - ctx->logPixelsX = pi->ppd->DefaultResolution; - ctx->logPixelsY = pi->ppd->DefaultResolution; + ctx->hdc = hdc; if (devmode) { @@ -533,7 +495,6 @@ print_ctx *create_print_ctx( HDC hdc, const WCHAR *device, } PSDRV_UpdateDevCaps( ctx ); - ctx->hdc = hdc; SelectObject( hdc, GetStockObject( DEVICE_DEFAULT_FONT )); return ctx; } diff --git a/dlls/wineps.drv/ps.c b/dlls/wineps.drv/ps.c index 421f01302bf..751a5097034 100644 --- a/dlls/wineps.drv/ps.c +++ b/dlls/wineps.drv/ps.c @@ -400,7 +400,7 @@ INT PSDRV_WriteHeader( print_ctx *ctx, LPCWSTR title ) INPUTSLOT *slot = find_slot( ctx->pi->ppd, &ctx->Devmode->dmPublic ); PAGESIZE *page = find_pagesize( ctx->pi->ppd, &ctx->Devmode->dmPublic ); DUPLEX *duplex = find_duplex( ctx->pi->ppd, &ctx->Devmode->dmPublic ); - int llx, lly, urx, ury; + int llx, lly, urx, ury, log_pixels_x, log_pixels_y; int ret, len; const char * dmOrientation; @@ -429,10 +429,12 @@ INT PSDRV_WriteHeader( print_ctx *ctx, LPCWSTR title ) /* BBox co-ords are in default user co-ord system so urx < ury even in landscape mode */ - llx = ctx->ImageableArea.left * 72.0 / ctx->logPixelsX; - lly = ctx->ImageableArea.bottom * 72.0 / ctx->logPixelsY; - urx = ctx->ImageableArea.right * 72.0 / ctx->logPixelsX; - ury = ctx->ImageableArea.top * 72.0 / ctx->logPixelsY; + log_pixels_x = GetDeviceCaps(ctx->hdc, ASPECTX); + log_pixels_y = GetDeviceCaps(ctx->hdc, ASPECTY); + llx = ctx->ImageableArea.left * 72.0 / log_pixels_x; + lly = ctx->ImageableArea.bottom * 72.0 / log_pixels_y; + urx = ctx->ImageableArea.right * 72.0 / log_pixels_x; + ury = ctx->ImageableArea.top * 72.0 / log_pixels_y; /* FIXME should do something better with BBox */ dmOrientation = (ctx->Devmode->dmPublic.dmOrientation == DMORIENT_LANDSCAPE ? "Landscape" : "Portrait"); @@ -532,7 +534,7 @@ INT PSDRV_WriteNewPage( print_ctx *ctx ) } sprintf(buf, psnewpage, name, ctx->job.PageNo, - ctx->logPixelsX, ctx->logPixelsY, + GetDeviceCaps(ctx->hdc, ASPECTX), GetDeviceCaps(ctx->hdc, ASPECTY), xtrans, ytrans, rotation); if( write_spool( ctx, buf, strlen(buf) ) != strlen(buf) ) { @@ -981,8 +983,8 @@ BOOL PSDRV_WriteDIBPatternDict(print_ctx *ctx, const BITMAPINFO *bmi, BYTE *bits PSDRV_WriteIndexColorSpaceEnd(ctx); /* Windows seems to scale patterns so that a one pixel corresponds to 1/300" */ - w_mult = (ctx->logPixelsX + 150) / 300; - h_mult = (ctx->logPixelsY + 150) / 300; + w_mult = (GetDeviceCaps(ctx->hdc, ASPECTX) + 150) / 300; + h_mult = (GetDeviceCaps(ctx->hdc, ASPECTY) + 150) / 300; sprintf(buf, do_pattern, w * w_mult, h * h_mult, w * w_mult, h * h_mult, w * w_mult, h * h_mult); PSDRV_WriteSpool(ctx, buf, strlen(buf)); HeapFree( GetProcessHeap(), 0, buf ); diff --git a/dlls/wineps.drv/psdrv.h b/dlls/wineps.drv/psdrv.h index dd63c0000cf..20e80e9f1aa 100644 --- a/dlls/wineps.drv/psdrv.h +++ b/dlls/wineps.drv/psdrv.h @@ -346,9 +346,6 @@ typedef struct are not rotated in landscape mode, so PageSize.cx is generally < PageSize.cy */ - int logPixelsX; - int logPixelsY; - int pathdepth; } print_ctx;

1 0

Piotr Caban : wineps: Don't store ImageableArea in print_ctx.
by Alexandre Julliard 19 May '23

19 May '23

Module: wine Branch: master Commit: 410b0f4d51babc8aed1d0f2427df3ce340a473fc URL: https://gitlab.winehq.org/wine/wine/-/commit/410b0f4d51babc8aed1d0f2427df3c… Author: Piotr Caban <piotr(a)codeweavers.com> Date: Wed May 17 19:19:13 2023 +0200 wineps: Don't store ImageableArea in print_ctx. --- dlls/wineps.drv/init.c | 53 ++++-------------------------------------- dlls/wineps.drv/ps.c | 61 ++++++++++++++++++++++++++++++++++--------------- dlls/wineps.drv/psdrv.h | 5 ---- 3 files changed, 47 insertions(+), 72 deletions(-) diff --git a/dlls/wineps.drv/init.c b/dlls/wineps.drv/init.c index 649b6ecb41b..b38c1e1ac43 100644 --- a/dlls/wineps.drv/init.c +++ b/dlls/wineps.drv/init.c @@ -408,50 +408,6 @@ static void dump_devmode(const DEVMODEW *dm) TRACE("dmPelsHeight %lu\n", dm->dmPelsHeight); } -static void PSDRV_UpdateDevCaps( print_ctx *ctx ) -{ - int log_pixels_x = GetDeviceCaps(ctx->hdc, ASPECTX); - int log_pixels_y = GetDeviceCaps(ctx->hdc, ASPECTY); - PAGESIZE *page; - - dump_devmode(&ctx->Devmode->dmPublic); - - if(ctx->Devmode->dmPublic.dmFields & DM_PAPERSIZE) { - LIST_FOR_EACH_ENTRY(page, &ctx->pi->ppd->PageSizes, PAGESIZE, entry) { - if(page->WinPage == ctx->Devmode->dmPublic.dmPaperSize) - break; - } - - if(&page->entry == &ctx->pi->ppd->PageSizes) { - FIXME("Can't find page\n"); - SetRectEmpty(&ctx->ImageableArea); - } else if(page->ImageableArea) { - /* ctx sizes in device units; ppd sizes in 1/72" */ - SetRect(&ctx->ImageableArea, page->ImageableArea->llx * log_pixels_x / 72, - page->ImageableArea->ury * log_pixels_y / 72, - page->ImageableArea->urx * log_pixels_x / 72, - page->ImageableArea->lly * log_pixels_y / 72); - } else { - ctx->ImageableArea.left = ctx->ImageableArea.bottom = 0; - ctx->ImageableArea.right = page->PaperDimension->x * log_pixels_x / 72; - ctx->ImageableArea.top = page->PaperDimension->y * log_pixels_y / 72; - } - } else if((ctx->Devmode->dmPublic.dmFields & DM_PAPERLENGTH) && - (ctx->Devmode->dmPublic.dmFields & DM_PAPERWIDTH)) { - /* ctx sizes in device units; Devmode sizes in 1/10 mm */ - ctx->ImageableArea.left = ctx->ImageableArea.bottom = 0; - ctx->ImageableArea.right = - ctx->Devmode->dmPublic.dmPaperWidth * log_pixels_x / 254; - ctx->ImageableArea.top = - ctx->Devmode->dmPublic.dmPaperLength * log_pixels_y / 254; - } else { - FIXME("Odd dmFields %lx\n", ctx->Devmode->dmPublic.dmFields); - SetRectEmpty(&ctx->ImageableArea); - } - - TRACE("ImageableArea = %s\n", wine_dbgstr_rect(&ctx->ImageableArea)); -} - print_ctx *create_print_ctx( HDC hdc, const WCHAR *device, const DEVMODEW *devmode ) { @@ -494,7 +450,6 @@ print_ctx *create_print_ctx( HDC hdc, const WCHAR *device, PSDRV_MergeDevmodes( ctx->Devmode, devmode, pi ); } - PSDRV_UpdateDevCaps( ctx ); SelectObject( hdc, GetStockObject( DEVICE_DEFAULT_FONT )); return ctx; } @@ -502,12 +457,12 @@ print_ctx *create_print_ctx( HDC hdc, const WCHAR *device, /********************************************************************** * ResetDC (WINEPS.@) */ -BOOL CDECL PSDRV_ResetDC( print_ctx *ctx, const DEVMODEW *lpInitData ) +BOOL CDECL PSDRV_ResetDC( print_ctx *ctx, const DEVMODEW *devmode ) { - if (lpInitData) + if (devmode) { - PSDRV_MergeDevmodes(ctx->Devmode, lpInitData, ctx->pi); - PSDRV_UpdateDevCaps(ctx); + dump_devmode( devmode ); + PSDRV_MergeDevmodes( ctx->Devmode, devmode, ctx->pi ); } return TRUE; } diff --git a/dlls/wineps.drv/ps.c b/dlls/wineps.drv/ps.c index 751a5097034..a8050abe19b 100644 --- a/dlls/wineps.drv/ps.c +++ b/dlls/wineps.drv/ps.c @@ -400,7 +400,7 @@ INT PSDRV_WriteHeader( print_ctx *ctx, LPCWSTR title ) INPUTSLOT *slot = find_slot( ctx->pi->ppd, &ctx->Devmode->dmPublic ); PAGESIZE *page = find_pagesize( ctx->pi->ppd, &ctx->Devmode->dmPublic ); DUPLEX *duplex = find_duplex( ctx->pi->ppd, &ctx->Devmode->dmPublic ); - int llx, lly, urx, ury, log_pixels_x, log_pixels_y; + int llx, lly, urx, ury; int ret, len; const char * dmOrientation; @@ -429,12 +429,34 @@ INT PSDRV_WriteHeader( print_ctx *ctx, LPCWSTR title ) /* BBox co-ords are in default user co-ord system so urx < ury even in landscape mode */ - log_pixels_x = GetDeviceCaps(ctx->hdc, ASPECTX); - log_pixels_y = GetDeviceCaps(ctx->hdc, ASPECTY); - llx = ctx->ImageableArea.left * 72.0 / log_pixels_x; - lly = ctx->ImageableArea.bottom * 72.0 / log_pixels_y; - urx = ctx->ImageableArea.right * 72.0 / log_pixels_x; - ury = ctx->ImageableArea.top * 72.0 / log_pixels_y; + if ((ctx->Devmode->dmPublic.dmFields & DM_PAPERSIZE) && page) + { + if (page->ImageableArea) + { + llx = page->ImageableArea->llx; + lly = page->ImageableArea->lly; + urx = page->ImageableArea->urx; + ury = page->ImageableArea->ury; + } + else + { + llx = lly = 0; + urx = page->PaperDimension->x; + ury = page->PaperDimension->y; + } + } + else if ((ctx->Devmode->dmPublic.dmFields & DM_PAPERLENGTH) && + (ctx->Devmode->dmPublic.dmFields & DM_PAPERWIDTH)) + { + /* Devmode sizes in 1/10 mm */ + llx = lly = 0; + urx = ctx->Devmode->dmPublic.dmPaperWidth * 72.0 / 254.0; + ury = ctx->Devmode->dmPublic.dmPaperLength * 72.0 / 254.0; + } + else + { + llx = lly = urx = ury = 0; + } /* FIXME should do something better with BBox */ dmOrientation = (ctx->Devmode->dmPublic.dmOrientation == DMORIENT_LANDSCAPE ? "Landscape" : "Portrait"); @@ -519,18 +541,21 @@ INT PSDRV_WriteNewPage( print_ctx *ctx ) if(ctx->Devmode->dmPublic.dmOrientation == DMORIENT_LANDSCAPE) { if(ctx->pi->ppd->LandscapeOrientation == -90) { - xtrans = ctx->ImageableArea.right; - ytrans = ctx->ImageableArea.top; - rotation = 90; - } else { - xtrans = ctx->ImageableArea.left; - ytrans = ctx->ImageableArea.bottom; - rotation = -90; - } + xtrans = GetDeviceCaps(ctx->hdc, PHYSICALHEIGHT) - + GetDeviceCaps(ctx->hdc, PHYSICALOFFSETY); + ytrans = GetDeviceCaps(ctx->hdc, PHYSICALWIDTH) - + GetDeviceCaps(ctx->hdc, PHYSICALOFFSETX); + rotation = 90; + } else { + xtrans = GetDeviceCaps(ctx->hdc, PHYSICALOFFSETY); + ytrans = GetDeviceCaps(ctx->hdc, PHYSICALOFFSETX); + rotation = -90; + } } else { - xtrans = ctx->ImageableArea.left; - ytrans = ctx->ImageableArea.top; - rotation = 0; + xtrans = GetDeviceCaps(ctx->hdc, PHYSICALOFFSETX); + ytrans = GetDeviceCaps(ctx->hdc, PHYSICALHEIGHT) - + GetDeviceCaps(ctx->hdc, PHYSICALOFFSETY); + rotation = 0; } sprintf(buf, psnewpage, name, ctx->job.PageNo, diff --git a/dlls/wineps.drv/psdrv.h b/dlls/wineps.drv/psdrv.h index 20e80e9f1aa..389c6a5b562 100644 --- a/dlls/wineps.drv/psdrv.h +++ b/dlls/wineps.drv/psdrv.h @@ -341,11 +341,6 @@ typedef struct JOB job; PSDRV_DEVMODE *Devmode; PRINTERINFO *pi; - RECT ImageableArea; /* Imageable area in device units */ - /* NB both PageSize and ImageableArea - are not rotated in landscape mode, - so PageSize.cx is generally - < PageSize.cy */ int pathdepth; } print_ctx;

1 0

Brendan Shanks : winemac: Add missing event to dbgstr_event().
by Alexandre Julliard 18 May '23

18 May '23

Module: wine Branch: master Commit: a4f19d18793761dc1c90f34dc6544dfb6d8cfe01 URL: https://gitlab.winehq.org/wine/wine/-/commit/a4f19d18793761dc1c90f34dc6544d… Author: Brendan Shanks <bshanks(a)codeweavers.com> Date: Thu May 18 12:18:13 2023 -0700 winemac: Add missing event to dbgstr_event(). --- dlls/winemac.drv/event.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/dlls/winemac.drv/event.c b/dlls/winemac.drv/event.c index 11f5dd3314c..9241a7a3326 100644 --- a/dlls/winemac.drv/event.c +++ b/dlls/winemac.drv/event.c @@ -80,6 +80,7 @@ static const char *dbgstr_event(int type) "STATUS_ITEM_MOUSE_MOVE", "WINDOW_BROUGHT_FORWARD", "WINDOW_CLOSE_REQUESTED", + "WINDOW_DID_MINIMIZE", "WINDOW_DID_UNMINIMIZE", "WINDOW_DRAG_BEGIN", "WINDOW_DRAG_END", @@ -91,6 +92,7 @@ static const char *dbgstr_event(int type) "WINDOW_RESIZE_ENDED", "WINDOW_RESTORE_REQUESTED", }; + C_ASSERT(ARRAYSIZE(event_names) == NUM_EVENT_TYPES); if (0 <= type && type < NUM_EVENT_TYPES) return event_names[type]; return wine_dbg_sprintf("Unknown event %d", type);

1 0

Sebastian Mayr : d3d8/tests: Test IDirect3DDevice8::ValidateDevice() with various min, mag and mip filters.
by Alexandre Julliard 18 May '23

18 May '23

Module: wine Branch: master Commit: 38f3f839438ababa4ae413a9195edfe63b785a53 URL: https://gitlab.winehq.org/wine/wine/-/commit/38f3f839438ababa4ae413a9195edf… Author: Sebastian Mayr <me(a)sam.st> Date: Thu May 18 11:22:46 2023 +0200 d3d8/tests: Test IDirect3DDevice8::ValidateDevice() with various min, mag and mip filters. This test is an adaptation of the corresponding d3d9 test. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54898 --- dlls/d3d8/tests/device.c | 67 ++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 67 insertions(+) diff --git a/dlls/d3d8/tests/device.c b/dlls/d3d8/tests/device.c index 6a585458bae..ec6f2ce51b3 100644 --- a/dlls/d3d8/tests/device.c +++ b/dlls/d3d8/tests/device.c @@ -10910,6 +10910,72 @@ static void test_window_position(void) IDirect3D8_Release(d3d); } +static void test_filter(void) +{ + unsigned int mag, min, mip; + IDirect3DTexture8 *texture; + IDirect3DDevice8 *device; + BOOL has_texture; + IDirect3D8 *d3d; + ULONG refcount; + DWORD passes; + HWND window; + HRESULT hr; + + d3d = Direct3DCreate8(D3D_SDK_VERSION); + ok(!!d3d, "Failed to create a D3D object.\n"); + + window = create_window(); + if (!(device = create_device(d3d, window, NULL))) + { + skip("Failed to create a D3D device, skipping tests.\n"); + IDirect3D8_Release(d3d); + DestroyWindow(window); + return; + } + + hr = IDirect3DDevice8_CreateTexture(device, 128, 128, 0, 0, D3DFMT_X8R8G8B8, D3DPOOL_MANAGED, &texture); + ok(SUCCEEDED(hr), "Failed to create texture, hr %#lx.\n", hr); + + for (has_texture = FALSE; has_texture <= TRUE; ++has_texture) + for (mag = 0; mag <= D3DTEXF_GAUSSIANCUBIC + 1; ++mag) + for (min = 0; min <= D3DTEXF_GAUSSIANCUBIC + 1; ++min) + for (mip = 0; mip <= D3DTEXF_GAUSSIANCUBIC + 1; ++mip) + { + if (has_texture) + { + hr = IDirect3DDevice8_SetTexture(device, 0, (IDirect3DBaseTexture8 *)texture); + ok(SUCCEEDED(hr), "Failed to set texture, hr %#lx.\n", hr); + } + else + { + hr = IDirect3DDevice8_SetTexture(device, 0, NULL); + ok(SUCCEEDED(hr), "Failed to set texture, hr %#lx.\n", hr); + } + + hr = IDirect3DDevice8_SetTextureStageState(device, 0, D3DTSS_MAGFILTER, mag); + ok(SUCCEEDED(hr), "Failed to set sampler state, hr %#lx.\n", hr); + hr = IDirect3DDevice8_SetTextureStageState(device, 0, D3DTSS_MINFILTER, min); + ok(SUCCEEDED(hr), "Failed to set sampler state, hr %#lx.\n", hr); + hr = IDirect3DDevice8_SetTextureStageState(device, 0, D3DTSS_MIPFILTER, mip); + ok(SUCCEEDED(hr), "Failed to set sampler state, hr %#lx.\n", hr); + + passes = 0xdeadbeef; + hr = IDirect3DDevice8_ValidateDevice(device, &passes); + ok(SUCCEEDED(hr), "Failed to validate device, hr %#lx.\n", hr); + ok(passes && passes != 0xdeadbeef, "Got unexpected passes %#lx.\n", passes); + } + + hr = IDirect3DDevice8_SetTexture(device, 0, NULL); + ok(SUCCEEDED(hr), "Failed to set texture, hr %#lx.\n", hr); + IDirect3DTexture8_Release(texture); + + refcount = IDirect3DDevice8_Release(device); + ok(!refcount, "Device has %lu references left.\n", refcount); + IDirect3D8_Release(d3d); + DestroyWindow(window); +} + START_TEST(device) { HMODULE d3d8_handle = GetModuleHandleA("d3d8.dll"); @@ -11031,6 +11097,7 @@ START_TEST(device) test_creation_parameters(); test_cursor_clipping(); test_window_position(); + test_filter(); UnregisterClassA("d3d8_test_wc", GetModuleHandleA(NULL)); }

1 0

Sebastian Mayr : wined3d: Improve d3d8 compatibility of texture filters.
by Alexandre Julliard 18 May '23

18 May '23

Module: wine Branch: master Commit: 7a2b34c32492680d32d52a6dde64418f14aa51d0 URL: https://gitlab.winehq.org/wine/wine/-/commit/7a2b34c32492680d32d52a6dde6441… Author: Sebastian Mayr <me(a)sam.st> Date: Wed May 17 18:20:19 2023 +0200 wined3d: Improve d3d8 compatibility of texture filters. In d3d8, setting texture filters to invalid values does not yield an error when calling IDirect3DDevice8::ValidateDevice. Some applications, such as Worms Blast, rely on this behaviour. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54898 --- dlls/d3d8/device.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/dlls/d3d8/device.c b/dlls/d3d8/device.c index 3727ad3e4eb..5cf22b08f79 100644 --- a/dlls/d3d8/device.c +++ b/dlls/d3d8/device.c @@ -2409,6 +2409,15 @@ static HRESULT WINAPI d3d8_device_ValidateDevice(IDirect3DDevice8 *iface, DWORD hr = wined3d_device_validate_device(device->wined3d_device, pass_count); wined3d_mutex_unlock(); + /* In d3d8, texture filters are not validated, so errors concerning + * unsupported ones are ignored here. */ + if (hr == WINED3DERR_UNSUPPORTEDTEXTUREFILTER) + { + WARN("Ignoring invalid texture filter settings.\n"); + *pass_count = 1; + return D3D_OK; + } + return hr; }

1 0

Paul Gofman : ntdll: Handle context overlap in call_user_exception_dispatcher() on x64.
by Alexandre Julliard 18 May '23

18 May '23

Module: wine Branch: master Commit: 901c8b90a1d2e5e91cd33bed57316e43e607ccbf URL: https://gitlab.winehq.org/wine/wine/-/commit/901c8b90a1d2e5e91cd33bed57316e… Author: Paul Gofman <pgofman(a)codeweavers.com> Date: Tue May 16 17:43:57 2023 -0600 ntdll: Handle context overlap in call_user_exception_dispatcher() on x64. --- dlls/ntdll/unix/signal_x86_64.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/dlls/ntdll/unix/signal_x86_64.c b/dlls/ntdll/unix/signal_x86_64.c index 97d3a009c03..2875ead70d4 100644 --- a/dlls/ntdll/unix/signal_x86_64.c +++ b/dlls/ntdll/unix/signal_x86_64.c @@ -1554,15 +1554,15 @@ NTSTATUS call_user_exception_dispatcher( EXCEPTION_RECORD *rec, CONTEXT *context rsp = (rsp - sizeof(XSTATE)) & ~63; stack = (struct stack_layout *)rsp - 1; assert( !((ULONG_PTR)stack->xstate & 63) ); + memmove( &stack->context, context, sizeof(*context) ); context_init_xstate( &stack->context, stack->xstate ); memcpy( stack->xstate, &frame->xstate, sizeof(frame->xstate) ); } - - memmove( &stack->context, context, sizeof(*context) ); + else memmove( &stack->context, context, sizeof(*context) ); stack->rec = *rec; /* fix up instruction pointer in context for EXCEPTION_BREAKPOINT */ if (stack->rec.ExceptionCode == EXCEPTION_BREAKPOINT) stack->context.Rip--; - frame->rbp = context->Rbp; + frame->rbp = stack->context.Rbp; frame->rsp = (ULONG64)stack; frame->rip = (ULONG64)pKiUserExceptionDispatcher; frame->restore_flags |= CONTEXT_CONTROL;

1 0

Bartosz Kosiorek : gdiplus: Improve performance of gdip_transform_points.
by Alexandre Julliard 18 May '23

18 May '23

Module: wine Branch: master Commit: 9749caf78e4167b96f58755e28279a6cc033758b URL: https://gitlab.winehq.org/wine/wine/-/commit/9749caf78e4167b96f58755e28279a… Author: Bartosz Kosiorek <gang65(a)poczta.onet.pl> Date: Tue Dec 20 17:21:16 2022 +0100 gdiplus: Improve performance of gdip_transform_points. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53947 --- dlls/gdiplus/graphics.c | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/dlls/gdiplus/graphics.c b/dlls/gdiplus/graphics.c index fca66c8654b..6831cfcb247 100644 --- a/dlls/gdiplus/graphics.c +++ b/dlls/gdiplus/graphics.c @@ -6887,13 +6887,15 @@ GpStatus get_graphics_transform(GpGraphics *graphics, GpCoordinateSpace dst_spac if (dst_space != src_space) { - scale_x = units_to_pixels(1.0, graphics->unit, graphics->xres, graphics->printer_display); - scale_y = units_to_pixels(1.0, graphics->unit, graphics->yres, graphics->printer_display); - if(graphics->unit != UnitDisplay) { - scale_x *= graphics->scale; - scale_y *= graphics->scale; + scale_x = units_to_pixels(graphics->scale, graphics->unit, graphics->xres, graphics->printer_display); + scale_y = units_to_pixels(graphics->scale, graphics->unit, graphics->yres, graphics->printer_display); + } + else + { + scale_x = units_to_pixels(1.0, graphics->unit, graphics->xres, graphics->printer_display); + scale_y = units_to_pixels(1.0, graphics->unit, graphics->yres, graphics->printer_display); } if (dst_space < src_space) @@ -6903,12 +6905,11 @@ GpStatus get_graphics_transform(GpGraphics *graphics, GpCoordinateSpace dst_spac { case WineCoordinateSpaceGdiDevice: { - GpMatrix gdixform; - gdixform = graphics->gdi_transform; + GpMatrix gdixform = graphics->gdi_transform; stat = GdipInvertMatrix(&gdixform); if (stat != Ok) break; - GdipMultiplyMatrix(matrix, &gdixform, MatrixOrderAppend); + memcpy(matrix->matrix, gdixform.matrix, sizeof(matrix->matrix)); if (dst_space == CoordinateSpaceDevice) break; /* else fall-through */ @@ -6934,7 +6935,7 @@ GpStatus get_graphics_transform(GpGraphics *graphics, GpCoordinateSpace dst_spac switch ((int)src_space) { case CoordinateSpaceWorld: - GdipMultiplyMatrix(matrix, &graphics->worldtrans, MatrixOrderAppend); + memcpy(matrix->matrix, &graphics->worldtrans, sizeof(matrix->matrix)); if (dst_space == CoordinateSpacePage) break; /* else fall-through */

1 0