July 2023 - Wine-commits - list.winehq.org

Gabriel Ivăncescu : mshtml/tests: Fix element leak in test_elems.
by Alexandre Julliard 07 Jul '23

07 Jul '23

Module: wine Branch: master Commit: dcd364609b72860e86630bfe5ace5a0cc01c040c URL: https://gitlab.winehq.org/wine/wine/-/commit/dcd364609b72860e86630bfe5ace5a… Author: Gabriel Ivăncescu <gabrielopcode(a)gmail.com> Date: Fri Jul 7 17:25:04 2023 +0300 mshtml/tests: Fix element leak in test_elems. Signed-off-by: Gabriel Ivăncescu <gabrielopcode(a)gmail.com> --- dlls/mshtml/tests/dom.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/dlls/mshtml/tests/dom.c b/dlls/mshtml/tests/dom.c index 07c4fec9bd8..b593985e87f 100644 --- a/dlls/mshtml/tests/dom.c +++ b/dlls/mshtml/tests/dom.c @@ -9441,6 +9441,8 @@ static void test_elems(IHTMLDocument2 *doc) set_elem_language(elem, L"vbscript"); set_elem_language(elem, L"xxx"); + + IHTMLElement_Release(elem); } elem = get_elem_by_id(doc, L"in", TRUE);

1 0

Gabriel Ivăncescu : mshtml/tests: Fix form element leak in test_form_item.
by Alexandre Julliard 07 Jul '23

07 Jul '23

Module: wine Branch: master Commit: f4f879955748065867345863cd53f7dcbf4a62ae URL: https://gitlab.winehq.org/wine/wine/-/commit/f4f879955748065867345863cd53f7… Author: Gabriel Ivăncescu <gabrielopcode(a)gmail.com> Date: Fri Jul 7 17:25:04 2023 +0300 mshtml/tests: Fix form element leak in test_form_item. Signed-off-by: Gabriel Ivăncescu <gabrielopcode(a)gmail.com> --- dlls/mshtml/tests/dom.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/dlls/mshtml/tests/dom.c b/dlls/mshtml/tests/dom.c index b593985e87f..81b1f87c6c5 100644 --- a/dlls/mshtml/tests/dom.c +++ b/dlls/mshtml/tests/dom.c @@ -5782,6 +5782,8 @@ static void test_form_item(IHTMLElement *elem) ok(hres == S_FALSE, "Next failed: %08lx\n", hres); ok(fetched == 0, "fetched = %lu\n", fetched); IEnumVARIANT_Release(enum_var); + + IHTMLFormElement_Release(form); } static void test_create_option_elem(IHTMLDocument2 *doc)

1 0

Gabriel Ivăncescu : mshtml/tests: Fix attribute leak in test_attr.
by Alexandre Julliard 07 Jul '23

07 Jul '23

Module: wine Branch: master Commit: 5a1da7334a9c356a4eabe00df3d177e354288902 URL: https://gitlab.winehq.org/wine/wine/-/commit/5a1da7334a9c356a4eabe00df3d177… Author: Gabriel Ivăncescu <gabrielopcode(a)gmail.com> Date: Fri Jul 7 17:25:04 2023 +0300 mshtml/tests: Fix attribute leak in test_attr. Signed-off-by: Gabriel Ivăncescu <gabrielopcode(a)gmail.com> --- dlls/mshtml/tests/dom.c | 1 + 1 file changed, 1 insertion(+) diff --git a/dlls/mshtml/tests/dom.c b/dlls/mshtml/tests/dom.c index 81b1f87c6c5..fea718c6b6b 100644 --- a/dlls/mshtml/tests/dom.c +++ b/dlls/mshtml/tests/dom.c @@ -9944,6 +9944,7 @@ static void test_attr(IHTMLDocument2 *doc, IHTMLElement *elem) V_BSTR(&v) = SysAllocString(L"newvalue"); put_attr_node_value(attr, v); VariantClear(&v); + IHTMLDOMAttribute_Release(attr); attr = get_elem_attr_node((IUnknown*)elem, L"emptyattr", TRUE); get_attr_node_value(attr, &v, VT_BSTR);

1 0

Gabriel Ivăncescu : mshtml/tests: Fix node leak in test_create_elems.
by Alexandre Julliard 07 Jul '23

07 Jul '23

Module: wine Branch: master Commit: 129482f88626b120cb5a353605c0b2e68652995c URL: https://gitlab.winehq.org/wine/wine/-/commit/129482f88626b120cb5a353605c0b2… Author: Gabriel Ivăncescu <gabrielopcode(a)gmail.com> Date: Fri Jul 7 17:25:04 2023 +0300 mshtml/tests: Fix node leak in test_create_elems. Signed-off-by: Gabriel Ivăncescu <gabrielopcode(a)gmail.com> --- dlls/mshtml/tests/dom.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dlls/mshtml/tests/dom.c b/dlls/mshtml/tests/dom.c index fea718c6b6b..429edf37668 100644 --- a/dlls/mshtml/tests/dom.c +++ b/dlls/mshtml/tests/dom.c @@ -10454,8 +10454,9 @@ static void test_create_elems(IHTMLDocument2 *doc) node = test_create_text(doc, L" Test"); V_VT(&var) = VT_DISPATCH; V_DISPATCH(&var) = NULL; - test_node_insertbefore((IUnknown*)body, node, &var); + node2 = test_node_insertbefore((IUnknown*)body, node, &var); test_elem_innertext(body, L"insert test Test"); + IHTMLDOMNode_Release(node2); IHTMLDOMNode_Release(node); doc5 = get_htmldoc5_iface((IUnknown*)doc);

1 0

Gabriel Ivăncescu : mshtml/tests: Fix node leaks in test_docfrag.
by Alexandre Julliard 07 Jul '23

07 Jul '23

Module: wine Branch: master Commit: f17f7df5c76f85fc6bc2bd9758a31dd0ec5912bb URL: https://gitlab.winehq.org/wine/wine/-/commit/f17f7df5c76f85fc6bc2bd9758a31d… Author: Gabriel Ivăncescu <gabrielopcode(a)gmail.com> Date: Fri Jul 7 17:25:04 2023 +0300 mshtml/tests: Fix node leaks in test_docfrag. Signed-off-by: Gabriel Ivăncescu <gabrielopcode(a)gmail.com> --- dlls/mshtml/tests/dom.c | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/dlls/mshtml/tests/dom.c b/dlls/mshtml/tests/dom.c index 429edf37668..68dc38f2a03 100644 --- a/dlls/mshtml/tests/dom.c +++ b/dlls/mshtml/tests/dom.c @@ -5238,6 +5238,13 @@ static IHTMLDOMNode *_test_node_append_child(unsigned line, IUnknown *node_unk, return new_child; } +#define test_node_append_child_discard(n,c) _test_node_append_child_discard(__LINE__,n,c) +static void _test_node_append_child_discard(unsigned line, IUnknown *node_unk, IUnknown *child_unk) +{ + IHTMLDOMNode *node = _test_node_append_child(line, node_unk, child_unk); + IHTMLDOMNode_Release(node); +} + #define test_node_insertbefore(n,c,v) _test_node_insertbefore(__LINE__,n,c,v) static IHTMLDOMNode *_test_node_insertbefore(unsigned line, IUnknown *node_unk, IHTMLDOMNode *child, VARIANT *var) { @@ -11046,7 +11053,7 @@ static void test_docfrag(IHTMLDocument2 *doc) br = test_create_elem(doc, L"BR"); test_elem_source_index(br, -1); - test_node_append_child((IUnknown*)frag, (IUnknown*)br); + test_node_append_child_discard((IUnknown*)frag, (IUnknown*)br); test_elem_source_index(br, 0); IHTMLElement_Release(br); @@ -11054,7 +11061,7 @@ static void test_docfrag(IHTMLDocument2 *doc) test_doc_getelembytag(frag, "Br", ET_BR, 1); div = get_elem_by_id(doc, L"divid", TRUE); - test_node_append_child((IUnknown*)div, (IUnknown*)frag); + test_node_append_child_discard((IUnknown*)div, (IUnknown*)frag); IHTMLElement_Release(div); hres = IHTMLDocument2_get_all(doc, &col); @@ -11064,23 +11071,23 @@ static void test_docfrag(IHTMLDocument2 *doc) html = test_create_elem(doc, L"HTML"); test_elem_source_index(html, -1); - test_node_append_child((IUnknown*)frag, (IUnknown*)html); + test_node_append_child_discard((IUnknown*)frag, (IUnknown*)html); test_elem_source_index(html, 0); div = test_create_elem(doc, L"DIV"); test_elem_source_index(div, -1); - test_node_append_child((IUnknown*)html, (IUnknown*)div); + test_node_append_child_discard((IUnknown*)html, (IUnknown*)div); test_elem_source_index(div, 1); IHTMLElement_Release(div); div = test_create_elem(doc, L"DIV"); test_elem_source_index(div, -1); - test_node_append_child((IUnknown*)html, (IUnknown*)div); + test_node_append_child_discard((IUnknown*)html, (IUnknown*)div); test_elem_source_index(div, 2); frag_body = test_create_elem(doc, L"BODY"); test_elem_source_index(frag_body, -1); - test_node_append_child((IUnknown*)div, (IUnknown*)frag_body); + test_node_append_child_discard((IUnknown*)div, (IUnknown*)frag_body); test_elem_source_index(frag_body, 3); IHTMLElement_Release(frag_body); IHTMLElement_Release(div);

1 0

Gabriel Ivăncescu : mshtml/tests: Fix performance leaks in test_document_mode_lock.
by Alexandre Julliard 07 Jul '23

07 Jul '23

Module: wine Branch: master Commit: 2a9944c136aa6a783959d71fbcd943bd63cfac27 URL: https://gitlab.winehq.org/wine/wine/-/commit/2a9944c136aa6a783959d71fbcd943… Author: Gabriel Ivăncescu <gabrielopcode(a)gmail.com> Date: Fri Jul 7 17:25:04 2023 +0300 mshtml/tests: Fix performance leaks in test_document_mode_lock. Signed-off-by: Gabriel Ivăncescu <gabrielopcode(a)gmail.com> --- dlls/mshtml/tests/dom.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/dlls/mshtml/tests/dom.c b/dlls/mshtml/tests/dom.c index 68dc38f2a03..571643fb66b 100644 --- a/dlls/mshtml/tests/dom.c +++ b/dlls/mshtml/tests/dom.c @@ -11985,6 +11985,8 @@ static void test_document_mode_lock(void) hres = IDispatch_QueryInterface(V_DISPATCH(&var), &IID_IHTMLPerformance, (void**)&perf2); ok(hres == S_OK, "Could not get IHTMLPerformance: %08lx\n", hres); ok(perf != perf2, "perf == perf2\n"); + IHTMLPerformance_Release(perf2); + IHTMLPerformance_Release(perf); IHTMLWindow7_Release(window7); IHTMLWindow2_Release(window); VariantClear(&var);

1 0

Gabriel Ivăncescu : mshtml/tests: Fix element leak in test_frameset.
by Alexandre Julliard 07 Jul '23

07 Jul '23

Module: wine Branch: master Commit: 1915d6568b186a41eaa91fcdee405c74aa3986ff URL: https://gitlab.winehq.org/wine/wine/-/commit/1915d6568b186a41eaa91fcdee405c… Author: Gabriel Ivăncescu <gabrielopcode(a)gmail.com> Date: Fri Jul 7 17:25:04 2023 +0300 mshtml/tests: Fix element leak in test_frameset. Signed-off-by: Gabriel Ivăncescu <gabrielopcode(a)gmail.com> --- dlls/mshtml/tests/dom.c | 1 + 1 file changed, 1 insertion(+) diff --git a/dlls/mshtml/tests/dom.c b/dlls/mshtml/tests/dom.c index 571643fb66b..6cbd7084f59 100644 --- a/dlls/mshtml/tests/dom.c +++ b/dlls/mshtml/tests/dom.c @@ -10960,6 +10960,7 @@ static void test_frameset(IHTMLDocument2 *doc) ok(hres == S_OK, "getElementById failed: %08lx\n", hres); ok(elem2 != NULL, "elem2 is NULL\n"); test_elem_id((IUnknown*)elem2, L"fr1"); + IHTMLElement2_Release(elem2); SysFreeString(str); IHTMLDocument6_Release(doc6);

1 0

Gabriel Ivăncescu : mshtml/tests: Fix node leak in test_replacechild_elems.
by Alexandre Julliard 07 Jul '23

07 Jul '23

Module: wine Branch: master Commit: a8889b9d3068e8f38b7ff1487c6c054296142e1a URL: https://gitlab.winehq.org/wine/wine/-/commit/a8889b9d3068e8f38b7ff1487c6c05… Author: Gabriel Ivăncescu <gabrielopcode(a)gmail.com> Date: Fri Jul 7 17:25:05 2023 +0300 mshtml/tests: Fix node leak in test_replacechild_elems. Signed-off-by: Gabriel Ivăncescu <gabrielopcode(a)gmail.com> --- dlls/mshtml/tests/dom.c | 1 + 1 file changed, 1 insertion(+) diff --git a/dlls/mshtml/tests/dom.c b/dlls/mshtml/tests/dom.c index 6cbd7084f59..e5b4df7312c 100644 --- a/dlls/mshtml/tests/dom.c +++ b/dlls/mshtml/tests/dom.c @@ -10531,6 +10531,7 @@ static void test_replacechild_elems(IHTMLDocument2 *doc) IHTMLDOMNode_Release(node2); IHTMLDOMNode_Release(node3); IHTMLDOMNode_Release(nodeBody); + IHTMLDOMNode_Release(nodeNew); IHTMLElement_Release(body); }

1 0

Gabriel Ivăncescu : mshtml/tests: Fix performance leak in test_window.
by Alexandre Julliard 07 Jul '23

07 Jul '23

Module: wine Branch: master Commit: aeab112a979e48a295e613f2cc1c4791b14b8b24 URL: https://gitlab.winehq.org/wine/wine/-/commit/aeab112a979e48a295e613f2cc1c47… Author: Gabriel Ivăncescu <gabrielopcode(a)gmail.com> Date: Fri Jul 7 17:25:05 2023 +0300 mshtml/tests: Fix performance leak in test_window. Signed-off-by: Gabriel Ivăncescu <gabrielopcode(a)gmail.com> --- dlls/mshtml/tests/dom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/mshtml/tests/dom.c b/dlls/mshtml/tests/dom.c index e5b4df7312c..6f62effa1dd 100644 --- a/dlls/mshtml/tests/dom.c +++ b/dlls/mshtml/tests/dom.c @@ -7376,7 +7376,7 @@ static void test_window(IHTMLDocument2 *doc) hres = IDispatch_QueryInterface(V_DISPATCH(&v), &IID_IHTMLPerformance, (void**)&performance); ok(hres == S_OK, "Could not get IHTMLPerformance iface: %08lx\n", hres); - + IDispatch_Release(V_DISPATCH(&v)); IHTMLPerformance_Release(performance); V_VT(&v) = VT_I2;

1 0

Gabriel Ivăncescu : mshtml/tests: Fix element leak in get_elem_doc.
by Alexandre Julliard 07 Jul '23

07 Jul '23

Module: wine Branch: master Commit: 675e32c3fd49eb461e694d9eaccdf2f2b670b62f URL: https://gitlab.winehq.org/wine/wine/-/commit/675e32c3fd49eb461e694d9eaccdf2… Author: Gabriel Ivăncescu <gabrielopcode(a)gmail.com> Date: Fri Jul 7 17:25:05 2023 +0300 mshtml/tests: Fix element leak in get_elem_doc. Signed-off-by: Gabriel Ivăncescu <gabrielopcode(a)gmail.com> --- dlls/mshtml/tests/dom.c | 1 + 1 file changed, 1 insertion(+) diff --git a/dlls/mshtml/tests/dom.c b/dlls/mshtml/tests/dom.c index 6f62effa1dd..34172c9156e 100644 --- a/dlls/mshtml/tests/dom.c +++ b/dlls/mshtml/tests/dom.c @@ -5084,6 +5084,7 @@ static IHTMLDocument2 *_get_elem_doc(unsigned line, IUnknown *unk) hres = IHTMLElement_get_document(elem, &disp); ok(hres == S_OK, "get_document failed: %08lx\n", hres); ok(disp != NULL, "disp == NULL\n"); + IHTMLElement_Release(elem); hres = IDispatch_QueryInterface(disp, &IID_IHTMLDocument2, (void**)&doc); IDispatch_Release(disp);

1 0