August 2023 - Wine-commits - list.winehq.org

Sven Baars : wldap32: Fix a message leak in ldap_parse_resultW() (Valgrind).
by Alexandre Julliard 01 Aug '23

01 Aug '23

Module: wine Branch: master Commit: 2d17c0ff72cf7d250e85de48fe228f3b02828d19 URL: https://gitlab.winehq.org/wine/wine/-/commit/2d17c0ff72cf7d250e85de48fe228f… Author: Sven Baars <sbaars(a)codeweavers.com> Date: Sun Jul 30 16:16:39 2023 +0200 wldap32: Fix a message leak in ldap_parse_resultW() (Valgrind). --- dlls/wldap32/parse.c | 1 + 1 file changed, 1 insertion(+) diff --git a/dlls/wldap32/parse.c b/dlls/wldap32/parse.c index 26e8de14c85..9eff55e4f0e 100644 --- a/dlls/wldap32/parse.c +++ b/dlls/wldap32/parse.c @@ -188,6 +188,7 @@ ULONG CDECL ldap_parse_resultW( LDAP *ld, WLDAP32_LDAPMessage *result, ULONG *re if (referrals) *referrals = strarrayUtoW( referralsU ); if (serverctrls) *serverctrls = controlarrayUtoW( serverctrlsU ); + if (free) ldap_msgfree( result ); ldap_memfree( matchedU ); ldap_memfree( errorU ); ldap_memfree( referralsU );

1 0

Sven Baars : ldap: Free the output buffer after every InitializeSecurityContextA() call (Valgrind).
by Alexandre Julliard 01 Aug '23

01 Aug '23

Module: wine Branch: master Commit: 4fd56146a8e4d2387ff04cd15b96c542d06a10dc URL: https://gitlab.winehq.org/wine/wine/-/commit/4fd56146a8e4d2387ff04cd15b96c5… Author: Sven Baars <sbaars(a)codeweavers.com> Date: Sun Jul 30 20:34:49 2023 +0200 ldap: Free the output buffer after every InitializeSecurityContextA() call (Valgrind). --- libs/ldap/libldap/tls_w.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libs/ldap/libldap/tls_w.c b/libs/ldap/libldap/tls_w.c index c798d4249c0..39cb5436053 100644 --- a/libs/ldap/libldap/tls_w.c +++ b/libs/ldap/libldap/tls_w.c @@ -228,7 +228,9 @@ tlsw_session_connect( LDAP *ld, tls_session *session, const char *name_in ) expected -= size; } - out_bufs[0].cbBuffer = max_token; + FreeContextBuffer( out_bufs[0].pvBuffer ); + out_bufs[0].pvBuffer = NULL; + status = InitializeSecurityContextA( &s->cred_handle, &s->ctxt_handle, (SEC_CHAR *)name_in, flags, 0, 0, &in_buf_desc, 0, NULL, &out_buf_desc, &attrs, NULL ); if ( status == SEC_E_INCOMPLETE_MESSAGE ) {

1 0

Alistair Leslie-Hughes : windowscodecs: Remove DECLSPEC_HIDDEN usage.
by Alexandre Julliard 01 Aug '23

01 Aug '23

Module: wine Branch: master Commit: 0442d18363b0198b5a8109d354869d167761d201 URL: https://gitlab.winehq.org/wine/wine/-/commit/0442d18363b0198b5a8109d354869d… Author: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Date: Sat Jul 29 18:14:17 2023 +1000 windowscodecs: Remove DECLSPEC_HIDDEN usage. --- dlls/windowscodecs/clsfactory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/windowscodecs/clsfactory.c b/dlls/windowscodecs/clsfactory.c index 54cc154bb22..6832d984586 100644 --- a/dlls/windowscodecs/clsfactory.c +++ b/dlls/windowscodecs/clsfactory.c @@ -35,7 +35,7 @@ WINE_DEFAULT_DEBUG_CHANNEL(wincodecs); -extern HRESULT WINAPI WIC_DllGetClassObject(REFCLSID, REFIID, LPVOID *) DECLSPEC_HIDDEN; +extern HRESULT WINAPI WIC_DllGetClassObject(REFCLSID, REFIID, LPVOID *); typedef struct { REFCLSID classid;

1 0

Piotr Caban : wineps.drv: Flush spool data even if there are no pages to print.
by Alexandre Julliard 01 Aug '23

01 Aug '23

Module: wine Branch: master Commit: 3345404cbe5f5945e0fbc4d495db40365a9eda58 URL: https://gitlab.winehq.org/wine/wine/-/commit/3345404cbe5f5945e0fbc4d495db40… Author: Piotr Caban <piotr(a)codeweavers.com> Date: Mon Jul 31 15:31:40 2023 +0200 wineps.drv: Flush spool data even if there are no pages to print. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55291 --- dlls/wineps.drv/printproc.c | 1 + dlls/wineps.drv/ps.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/dlls/wineps.drv/printproc.c b/dlls/wineps.drv/printproc.c index 72e5540b5be..b899814f8c1 100644 --- a/dlls/wineps.drv/printproc.c +++ b/dlls/wineps.drv/printproc.c @@ -3140,6 +3140,7 @@ BOOL WINAPI PrintDocumentOnPrintProcessor(HANDLE pp, WCHAR *doc_name) cleanup: if (data->ctx->job.PageNo) PSDRV_WriteFooter(data->ctx); + flush_spool(data->ctx); HeapFree(GetProcessHeap(), 0, data->ctx->job.doc_name); ClosePrinter(spool_data); diff --git a/dlls/wineps.drv/ps.c b/dlls/wineps.drv/ps.c index f9f54fa9bc6..a8050abe19b 100644 --- a/dlls/wineps.drv/ps.c +++ b/dlls/wineps.drv/ps.c @@ -502,7 +502,7 @@ INT PSDRV_WriteFooter( print_ctx *ctx ) sprintf(buf, psfooter, ctx->job.PageNo); - if( write_spool( ctx, buf, strlen(buf) ) != strlen(buf) || !flush_spool(ctx) ) { + if( write_spool( ctx, buf, strlen(buf) ) != strlen(buf) ) { WARN("WriteSpool error\n"); ret = 0; }

1 0

Sven Baars : wldap32: Fix a mod_type leak (Valgrind).
by Alexandre Julliard 01 Aug '23

01 Aug '23

Module: wine Branch: master Commit: ca692fb39c7d8c1e0a579f50d84a60833d72066e URL: https://gitlab.winehq.org/wine/wine/-/commit/ca692fb39c7d8c1e0a579f50d84a60… Author: Sven Baars <sbaars(a)codeweavers.com> Date: Sun Jul 30 15:58:01 2023 +0200 wldap32: Fix a mod_type leak (Valgrind). --- dlls/wldap32/winldap_private.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/dlls/wldap32/winldap_private.h b/dlls/wldap32/winldap_private.h index e834f9d4e6f..ce9a7cc3fa8 100644 --- a/dlls/wldap32/winldap_private.h +++ b/dlls/wldap32/winldap_private.h @@ -868,6 +868,7 @@ static inline void modfreeU( LDAPMod *mod ) bvarrayfreeU( mod->mod_vals.modv_bvals ); else strarrayfreeU( mod->mod_vals.modv_strvals ); + free( mod->mod_type ); free( mod ); } @@ -1010,6 +1011,7 @@ static inline void modfreeW( LDAPModW *mod ) bvarrayfreeW( mod->mod_vals.modv_bvals ); else strarrayfreeW( mod->mod_vals.modv_strvals ); + free( mod->mod_type ); free( mod ); }

1 0

Alistair Leslie-Hughes : dinput: Remove DECLSPEC_HIDDEN usage.
by Alexandre Julliard 01 Aug '23

01 Aug '23

Module: wine Branch: master Commit: 1b99f38bf3748f49600eceb4bb7b337dfc4af0e6 URL: https://gitlab.winehq.org/wine/wine/-/commit/1b99f38bf3748f49600eceb4bb7b33… Author: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Date: Sat Jul 29 18:16:28 2023 +1000 dinput: Remove DECLSPEC_HIDDEN usage. --- dlls/dinput/dinput_private.h | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/dlls/dinput/dinput_private.h b/dlls/dinput/dinput_private.h index 944d12b860f..0609b816b3b 100644 --- a/dlls/dinput/dinput_private.h +++ b/dlls/dinput/dinput_private.h @@ -44,8 +44,8 @@ struct dinput struct list device_players; /* device instance guid to player name */ }; -extern const IDirectInput7AVtbl dinput7_a_vtbl DECLSPEC_HIDDEN; -extern const IDirectInput8AVtbl dinput8_a_vtbl DECLSPEC_HIDDEN; +extern const IDirectInput7AVtbl dinput7_a_vtbl; +extern const IDirectInput8AVtbl dinput8_a_vtbl; extern void dinput_internal_addref( struct dinput *dinput ); extern void dinput_internal_release( struct dinput *dinput ); @@ -75,12 +75,12 @@ extern void dinput_mouse_rawinput_hook( IDirectInputDevice8W *iface, WPARAM wpar extern void dinput_keyboard_rawinput_hook( IDirectInputDevice8W *iface, WPARAM wparam, LPARAM lparam, RAWINPUT *raw ); -extern void check_dinput_events(void) DECLSPEC_HIDDEN; +extern void check_dinput_events(void); -extern HRESULT _configure_devices(IDirectInput8W *iface, LPDICONFIGUREDEVICESCALLBACK lpdiCallback, LPDICONFIGUREDEVICESPARAMSW lpdiCDParams, DWORD dwFlags, LPVOID pvRefData) DECLSPEC_HIDDEN; +extern HRESULT _configure_devices(IDirectInput8W *iface, LPDICONFIGUREDEVICESCALLBACK lpdiCallback, LPDICONFIGUREDEVICESPARAMSW lpdiCDParams, DWORD dwFlags, LPVOID pvRefData); -extern WCHAR* get_mapping_path(const WCHAR *device, const WCHAR *username) DECLSPEC_HIDDEN; -extern DWORD get_device_type(DWORD version, BOOL is_joystick) DECLSPEC_HIDDEN; +extern WCHAR* get_mapping_path(const WCHAR *device, const WCHAR *username); +extern DWORD get_device_type(DWORD version, BOOL is_joystick); #define IS_DIPROP(x) (((ULONG_PTR)(x) >> 16) == 0)

1 0

Alistair Leslie-Hughes : hidclass.sys: Remove DECLSPEC_HIDDEN usage.
by Alexandre Julliard 01 Aug '23

01 Aug '23

Module: wine Branch: master Commit: 88cc46593432fc6cc7568181a3c56c9221b4f9f5 URL: https://gitlab.winehq.org/wine/wine/-/commit/88cc46593432fc6cc7568181a3c56c… Author: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Date: Sat Jul 29 18:16:28 2023 +1000 hidclass.sys: Remove DECLSPEC_HIDDEN usage. --- dlls/hidclass.sys/hid.h | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/dlls/hidclass.sys/hid.h b/dlls/hidclass.sys/hid.h index b8cec55fb7c..3eefbf87f63 100644 --- a/dlls/hidclass.sys/hid.h +++ b/dlls/hidclass.sys/hid.h @@ -118,15 +118,15 @@ typedef struct _minidriver } minidriver; void call_minidriver( ULONG code, DEVICE_OBJECT *device, void *in_buff, ULONG in_size, - void *out_buff, ULONG out_size, IO_STATUS_BLOCK *io ) DECLSPEC_HIDDEN; + void *out_buff, ULONG out_size, IO_STATUS_BLOCK *io ); /* Internal device functions */ -void HID_StartDeviceThread(DEVICE_OBJECT *device) DECLSPEC_HIDDEN; +void HID_StartDeviceThread( DEVICE_OBJECT *device ); void hid_queue_remove_pending_irps( struct hid_queue *queue ); void hid_queue_destroy( struct hid_queue *queue ); -NTSTATUS WINAPI pdo_ioctl(DEVICE_OBJECT *device, IRP *irp) DECLSPEC_HIDDEN; -NTSTATUS WINAPI pdo_read(DEVICE_OBJECT *device, IRP *irp) DECLSPEC_HIDDEN; -NTSTATUS WINAPI pdo_write(DEVICE_OBJECT *device, IRP *irp) DECLSPEC_HIDDEN; -NTSTATUS WINAPI pdo_create(DEVICE_OBJECT *device, IRP *irp) DECLSPEC_HIDDEN; -NTSTATUS WINAPI pdo_close(DEVICE_OBJECT *device, IRP *irp) DECLSPEC_HIDDEN; +NTSTATUS WINAPI pdo_ioctl( DEVICE_OBJECT *device, IRP *irp ); +NTSTATUS WINAPI pdo_read( DEVICE_OBJECT *device, IRP *irp ); +NTSTATUS WINAPI pdo_write( DEVICE_OBJECT *device, IRP *irp ); +NTSTATUS WINAPI pdo_create( DEVICE_OBJECT *device, IRP *irp ); +NTSTATUS WINAPI pdo_close( DEVICE_OBJECT *device, IRP *irp );

1 0