January 2024 - Wine-commits

Hans Leidekker : wldap32/tests: Skip tests when the server can't be reached.
by Alexandre Julliard 10 Jan '24

10 Jan '24

Module: wine Branch: master Commit: 928d73d4ef94555cd977e420b5e9fea611e3b1c0 URL: https://gitlab.winehq.org/wine/wine/-/commit/928d73d4ef94555cd977e420b5e9fe… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Wed Jan 10 11:28:29 2024 +0100 wldap32/tests: Skip tests when the server can't be reached. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55784 --- dlls/wldap32/tests/parse.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/dlls/wldap32/tests/parse.c b/dlls/wldap32/tests/parse.c index 726b814081b..faf49622586 100644 --- a/dlls/wldap32/tests/parse.c +++ b/dlls/wldap32/tests/parse.c @@ -169,6 +169,12 @@ static void test_ldap_bind_sA( void ) } ret = ldap_connect( ld, NULL ); + if (ret == LDAP_SERVER_DOWN) + { + skip( "test server can't be reached\n" ); + ldap_unbind( ld ); + return; + } ok( !ret, "ldap_connect failed %#lx\n", ret ); ret = ldap_bind_sA( ld, (char *)"uid=winetest,ou=users,dc=debian,dc=org", (char *)"winetest", @@ -511,6 +517,12 @@ static void test_opt_ssl(void) ret = ldap_set_optionA( ld, LDAP_OPT_SSL, LDAP_OPT_ON ); ok( !ret, "ldap_set_optionA should succeed, got %#lx\n", ret ); ret = ldap_simple_bind_sA( ld, NULL, NULL ); + if (ret == LDAP_SERVER_DOWN) + { + skip( "test server can't be reached\n" ); + ldap_unbind( ld ); + return; + } todo_wine ok( ret == LDAP_PROTOCOL_ERROR, "ldap_simple_bind_sA should fail, got %#lx\n", ret ); ldap_unbind( ld );

1 0

Rémi Bernon : ntoskrnl.exe/tests: Use SUOI_FORCEDELETE when uninstalling the driver.
by Alexandre Julliard 10 Jan '24

10 Jan '24

Module: wine Branch: master Commit: 866f17c147e4d76b6dd14ad98030918c341cde38 URL: https://gitlab.winehq.org/wine/wine/-/commit/866f17c147e4d76b6dd14ad9803091… Author: Rémi Bernon <rbernon(a)codeweavers.com> Date: Wed Jan 10 11:23:30 2024 +0100 ntoskrnl.exe/tests: Use SUOI_FORCEDELETE when uninstalling the driver. Avoids conflicts with the dinput tests somehow. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52962 --- dlls/ntoskrnl.exe/tests/ntoskrnl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/ntoskrnl.exe/tests/ntoskrnl.c b/dlls/ntoskrnl.exe/tests/ntoskrnl.c index 5a47523cf71..36983e2c8b8 100644 --- a/dlls/ntoskrnl.exe/tests/ntoskrnl.c +++ b/dlls/ntoskrnl.exe/tests/ntoskrnl.c @@ -1874,7 +1874,7 @@ static void test_pnp_driver(struct testsign_context *ctx) GetFullPathNameA("winetest.inf", sizeof(path), path, NULL); ret = SetupCopyOEMInfA(path, NULL, 0, 0, dest, sizeof(dest), NULL, &filepart); ok(ret, "Failed to copy INF, error %#lx\n", GetLastError()); - ret = SetupUninstallOEMInfA(filepart, 0, NULL); + ret = SetupUninstallOEMInfA(filepart, SUOI_FORCEDELETE, NULL); ok(ret, "Failed to uninstall INF, error %lu\n", GetLastError()); ret = DeleteFileA("winetest.cat");

1 0

Enol Puente : po: Update Asturian translation.
by Alexandre Julliard 10 Jan '24

10 Jan '24

Module: wine Branch: master Commit: 7a9fba29d6354b824253f0419f260113d9f88b76 URL: https://gitlab.winehq.org/wine/wine/-/commit/7a9fba29d6354b824253f0419f2601… Author: Enol Puente <enolp(a)softastur.org> Date: Sun Jan 7 22:56:58 2024 +0000 po: Update Asturian translation. --- po/ast.po | 6081 +++++++++++++++++++++++++++++++------------------------------ 1 file changed, 3108 insertions(+), 2973 deletions(-)

1 0

Rémi Bernon : dmusic: Clone streams instead of allocating wave data.
by Alexandre Julliard 09 Jan '24

09 Jan '24

Module: wine Branch: master Commit: 1b753413467b75b0a638ad635127ca5a5e426e7c URL: https://gitlab.winehq.org/wine/wine/-/commit/1b753413467b75b0a638ad635127ca… Author: Rémi Bernon <rbernon(a)codeweavers.com> Date: Mon Jan 8 10:26:15 2024 +0100 dmusic: Clone streams instead of allocating wave data. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56117 --- dlls/dmusic/wave.c | 50 +++++++++++++++++++++++++++++++++----------------- 1 file changed, 33 insertions(+), 17 deletions(-) diff --git a/dlls/dmusic/wave.c b/dlls/dmusic/wave.c index 27f7224af49..f741cff1418 100644 --- a/dlls/dmusic/wave.c +++ b/dlls/dmusic/wave.c @@ -38,7 +38,7 @@ struct wave struct sample *sample; WAVEFORMATEX *format; UINT data_size; - void *data; + IStream *data; }; static inline struct wave *impl_from_IUnknown(IUnknown *iface) @@ -96,7 +96,7 @@ static ULONG WINAPI wave_Release(IUnknown *iface) if (!ref) { free(This->format); - free(This->data); + if (This->data) IStream_Release(This->data); free(This->sample); free(This); } @@ -150,8 +150,8 @@ static HRESULT parse_wave_chunk(struct wave *This, IStream *stream, struct chunk break; case mmioFOURCC('d','a','t','a'): - if (!(This->data = malloc(chunk.size))) return E_OUTOFMEMORY; - hr = stream_chunk_get_data(stream, &chunk, This->data, chunk.size); + if (This->data) IStream_Release(This->data); + hr = IStream_Clone(stream, &This->data); if (SUCCEEDED(hr)) This->data_size = chunk.size; break; @@ -341,9 +341,9 @@ HRESULT wave_create_from_soundfont(struct soundfont *soundfont, UINT index, IDir struct sample *sample = NULL; WAVEFORMATEX *format = NULL; HRESULT hr = E_OUTOFMEMORY; - UINT data_size, offset; + DWORD data_size, offset; struct wave *This; - void *data = NULL; + IStream *stream = NULL; IDirectMusicObject *iface; TRACE("(%p, %u, %p)\n", soundfont, index, ret_iface); @@ -365,9 +365,9 @@ HRESULT wave_create_from_soundfont(struct soundfont *soundfont, UINT index, IDir sample->loops[0].ulLength = sf_sample->end_loop - sf_sample->start_loop; data_size = sf_sample->end - sf_sample->start; - if (!(data = malloc(data_size * format->nBlockAlign))) goto failed; + if (FAILED(hr = CreateStreamOnHGlobal(NULL, TRUE, &stream))) goto failed; offset = sf_sample->start * format->nBlockAlign / format->nChannels; - memcpy(data, soundfont->sdta + offset, data_size); + if (FAILED(hr = IStream_Write(stream, soundfont->sdta + offset, data_size, &data_size))) goto failed; if (FAILED(hr = wave_create(&iface))) goto failed; @@ -375,7 +375,7 @@ HRESULT wave_create_from_soundfont(struct soundfont *soundfont, UINT index, IDir This->format = format; This->sample = sample; This->data_size = data_size; - This->data = data; + This->data = stream; if (TRACE_ON(dmusic)) { @@ -408,12 +408,26 @@ HRESULT wave_create_from_soundfont(struct soundfont *soundfont, UINT index, IDir return S_OK; failed: - free(data); + if (stream) IStream_Release(stream); free(sample); free(format); return hr; } +static HRESULT wave_read_data(struct wave *This, void *data, DWORD *data_size) +{ + IStream *stream; + HRESULT hr; + + if (SUCCEEDED(hr = IStream_Clone(This->data, &stream))) + { + hr = IStream_Read(stream, data, This->data_size, data_size); + IStream_Release(stream); + } + + return hr; +} + HRESULT wave_download_to_port(IDirectMusicObject *iface, IDirectMusicPortDownload *port, DWORD *id) { struct download_buffer @@ -446,11 +460,12 @@ HRESULT wave_download_to_port(IDirectMusicObject *iface, IDirectMusicPortDownloa buffer->wave.ulCopyrightIdx = 0; buffer->wave.ulFirstExtCkIdx = 0; - buffer->data.cbSize = This->data_size; - memcpy(buffer->data.byData, This->data, This->data_size); - - if (SUCCEEDED(hr = IDirectMusicPortDownload_Download(port, download))) *id = buffer->info.dwDLId; - else WARN("Failed to download wave to port, hr %#lx\n", hr); + if (FAILED(hr = wave_read_data(This, buffer->data.byData, &buffer->data.cbSize))) + WARN("Failed to read wave data from stream, hr %#lx\n", hr); + else if (FAILED(hr = IDirectMusicPortDownload_Download(port, download))) + WARN("Failed to download wave to port, hr %#lx\n", hr); + else + *id = buffer->info.dwDLId; } IDirectMusicDownload_Release(download); @@ -481,8 +496,9 @@ HRESULT wave_download_to_dsound(IDirectMusicObject *iface, IDirectSound *dsound, if (SUCCEEDED(hr = IDirectSoundBuffer_Lock(buffer, 0, This->data_size, &data, &size, NULL, 0, 0))) { - memcpy(data, This->data, This->data_size); - hr = IDirectSoundBuffer_Unlock(buffer, data, This->data_size, NULL, 0); + if (FAILED(hr = wave_read_data(This, data, &size))) + WARN("Failed to read wave data from stream, hr %#lx\n", hr); + hr = IDirectSoundBuffer_Unlock(buffer, data, size, NULL, 0); } if (FAILED(hr))

1 0

Gabriel Ivăncescu : Revert "winex11: Use the correct root window for virtual desktops.".
by Alexandre Julliard 09 Jan '24

09 Jan '24

Module: wine Branch: master Commit: d9b5bf9a719b1145f514230f170ccc6b969a6679 URL: https://gitlab.winehq.org/wine/wine/-/commit/d9b5bf9a719b1145f514230f170ccc… Author: Gabriel Ivăncescu <gabrielopcode(a)gmail.com> Date: Tue Jan 9 19:44:06 2024 +0200 Revert "winex11: Use the correct root window for virtual desktops.". This reverts commit 790133e95036597092443b30c0fe0aa6a40a9167. It was incorrect, sorry about that. The issue was weirder in a different place (MWM_FUNC_RESIZE not set before setting fullscreen). Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56149 --- dlls/winex11.drv/desktop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/winex11.drv/desktop.c b/dlls/winex11.drv/desktop.c index fcb6ba2faf5..687c0cf5a4c 100644 --- a/dlls/winex11.drv/desktop.c +++ b/dlls/winex11.drv/desktop.c @@ -107,7 +107,7 @@ static void update_desktop_fullscreen( unsigned int width, unsigned int height) if (!display || !is_virtual_desktop()) return; xev.xclient.type = ClientMessage; - xev.xclient.window = DefaultRootWindow(display); + xev.xclient.window = root_window; xev.xclient.message_type = x11drv_atom(_NET_WM_STATE); xev.xclient.serial = 0; xev.xclient.display = display;

1 0

Gabriel Ivăncescu : winex11: Set MWM_FUNC_RESIZE for fullscreen desktop windows.
by Alexandre Julliard 09 Jan '24

09 Jan '24

Module: wine Branch: master Commit: 75a774f90a86d1e39b2ea4fd5716ec74ac5aae64 URL: https://gitlab.winehq.org/wine/wine/-/commit/75a774f90a86d1e39b2ea4fd5716ec… Author: Gabriel Ivăncescu <gabrielopcode(a)gmail.com> Date: Tue Jan 9 19:45:26 2024 +0200 winex11: Set MWM_FUNC_RESIZE for fullscreen desktop windows. Same workaround as used in is_window_resizable, except it's on a different code path. This also affects other WMs (e.g. Kwin, compiz). Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56149 Signed-off-by: Gabriel Ivăncescu <gabrielopcode(a)gmail.com> --- dlls/winex11.drv/window.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/dlls/winex11.drv/window.c b/dlls/winex11.drv/window.c index 51125065958..f5f2dd03662 100644 --- a/dlls/winex11.drv/window.c +++ b/dlls/winex11.drv/window.c @@ -747,9 +747,13 @@ static void set_mwm_hints( struct x11drv_win_data *data, UINT style, UINT ex_sty if (data->hwnd == NtUserGetDesktopWindow()) { - if (is_desktop_fullscreen()) mwm_hints.decorations = 0; - else mwm_hints.decorations = MWM_DECOR_TITLE | MWM_DECOR_BORDER | MWM_DECOR_MENU | MWM_DECOR_MINIMIZE; mwm_hints.functions = MWM_FUNC_MOVE | MWM_FUNC_MINIMIZE | MWM_FUNC_CLOSE; + if (is_desktop_fullscreen()) + { + mwm_hints.decorations = 0; + mwm_hints.functions |= MWM_FUNC_RESIZE; /* some WMs need this to make it fullscreen */ + } + else mwm_hints.decorations = MWM_DECOR_TITLE | MWM_DECOR_BORDER | MWM_DECOR_MENU | MWM_DECOR_MINIMIZE; } else {

1 0

Gabriel Ivăncescu : winex11: Update Virtual Desktop fullscreen WM state after setting window pos.
by Alexandre Julliard 09 Jan '24

09 Jan '24

Module: wine Branch: master Commit: 4054795ff199c3f65612f351a88daf17f56a6db9 URL: https://gitlab.winehq.org/wine/wine/-/commit/4054795ff199c3f65612f351a88daf… Author: Gabriel Ivăncescu <gabrielopcode(a)gmail.com> Date: Tue Jan 9 19:45:26 2024 +0200 winex11: Update Virtual Desktop fullscreen WM state after setting window pos. To make sure the hints are set up properly first. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56149 Signed-off-by: Gabriel Ivăncescu <gabrielopcode(a)gmail.com> --- dlls/winex11.drv/desktop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/winex11.drv/desktop.c b/dlls/winex11.drv/desktop.c index 687c0cf5a4c..5867f9d16a4 100644 --- a/dlls/winex11.drv/desktop.c +++ b/dlls/winex11.drv/desktop.c @@ -149,10 +149,10 @@ void X11DRV_resize_desktop(void) height = primary_rect.bottom; TRACE( "desktop %p change to (%dx%d)\n", hwnd, width, height ); - update_desktop_fullscreen( width, height ); NtUserSetWindowPos( hwnd, 0, virtual_rect.left, virtual_rect.top, virtual_rect.right - virtual_rect.left, virtual_rect.bottom - virtual_rect.top, SWP_NOZORDER | SWP_NOACTIVATE | SWP_DEFERERASE ); + update_desktop_fullscreen( width, height ); if (old_virtual_rect.left != virtual_rect.left || old_virtual_rect.top != virtual_rect.top) send_message_timeout( HWND_BROADCAST, WM_X11DRV_DESKTOP_RESIZED, old_virtual_rect.left,

1 0

Jacek Caban : gitlab: Cache config.cache in Clang builds.
by Alexandre Julliard 09 Jan '24

09 Jan '24

Module: wine Branch: master Commit: 67f2da2a8d1f219f528bf820b3d6002c5f34d5e4 URL: https://gitlab.winehq.org/wine/wine/-/commit/67f2da2a8d1f219f528bf820b3d600… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Tue Jan 9 15:16:06 2024 +0100 gitlab: Cache config.cache in Clang builds. --- tools/gitlab/build-clang | 4 +++- tools/gitlab/build.yml | 29 +++++++++++++++++++++++------ 2 files changed, 26 insertions(+), 7 deletions(-) diff --git a/tools/gitlab/build-clang b/tools/gitlab/build-clang index e335faf049c..b93bdf146f3 100755 --- a/tools/gitlab/build-clang +++ b/tools/gitlab/build-clang @@ -9,5 +9,7 @@ set -Eeuxo pipefail ./tools/make_makefiles autoreconf -f -./configure -q --enable-archs=i386,x86_64,aarch64 --with-mingw=clang +cd build +../configure -q -C --enable-archs=i386,x86_64,aarch64 --with-mingw=clang make -s -j$(nproc) +cd .. diff --git a/tools/gitlab/build.yml b/tools/gitlab/build.yml index 75cb4b26945..9337d6c3b43 100644 --- a/tools/gitlab/build.yml +++ b/tools/gitlab/build.yml @@ -9,12 +9,6 @@ cache: - paths: - ccache/ - - key: - files: - - configure.ac - paths: - - build32/config.cache - - build64/config.cache before_script: - export BASEDIR="$PWD" - export CCACHE_BASEDIR="$BASEDIR" @@ -34,7 +28,15 @@ build-linux: expire_in: 1 day paths: - usr/local/ + cache: + - key: + files: + - configure.ac + paths: + - build32/config.cache + - build64/config.cache script: + - mkdir -p build32 build64 - git rebase $CI_MERGE_REQUEST_DIFF_BASE_SHA --exec ./tools/gitlab/build-linux - git diff --name-only $CI_MERGE_REQUEST_DIFF_BASE_SHA | sed -re '/\/tests\//!d; s@/tests/.*@/tests/Makefile.in@' | (xargs -r ls 2>/dev/null || true) | xargs -r sed '/TESTDLL/!d; s(a).dll@@; s(a).*= *@@' >usr/local/share/wine/winetest.args @@ -43,7 +45,14 @@ build-clang: extends: .wine-build rules: - if: $CI_PIPELINE_SOURCE == 'merge_request_event' + cache: + - key: + files: + - configure.ac + paths: + - build/config.cache script: + - mkdir -p build - ./tools/gitlab/build-clang build-mac: @@ -52,12 +61,20 @@ build-mac: - if: $CI_PIPELINE_SOURCE == 'merge_request_event' tags: - mac + cache: + - key: + files: + - configure.ac + paths: + - build32/config.cache + - build64/config.cache artifacts: when: on_failure paths: - build64/config.log - build32/config.log script: + - mkdir -p build32 build64 - export PATH="/usr/local/opt/ccache/libexec:$PATH" - git rebase $CI_MERGE_REQUEST_DIFF_BASE_SHA --exec ./tools/gitlab/build-mac

1 0

Giovanni Mascellani : configure: Detect pthread support using -pthread instead of -lpthread.
by Alexandre Julliard 09 Jan '24

09 Jan '24

Module: vkd3d Branch: master Commit: 0752e545e46bd2d05301ff23405770823f9bade4 URL: https://gitlab.winehq.org/wine/vkd3d/-/commit/0752e545e46bd2d05301ff2340577… Author: Giovanni Mascellani <gmascellani(a)codeweavers.com> Date: Tue Jan 9 10:31:37 2024 +0100 configure: Detect pthread support using -pthread instead of -lpthread. The latter links the pthread library, but doesn't set the preprocessor state that some toolchains require. The former is the supported way to use pthread. This allows vkd3d to be compiled with the Android NDK. --- m4/check-pthread.m4 | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/m4/check-pthread.m4 b/m4/check-pthread.m4 index 5fa82ecb..706829d9 100644 --- a/m4/check-pthread.m4 +++ b/m4/check-pthread.m4 @@ -15,7 +15,15 @@ AS_IF([test "x$vkd3d_pthread_found" = "xno"], [PTHREAD_LIBS=""]) LIBS="$vkd3d_libs_saved"]) AS_IF([test "x$vkd3d_pthread_found" != "xyes"], -AC_CHECK_LIB([pthread], [pthread_create], - [PTHREAD_LIBS="-lpthread"], - [AC_MSG_ERROR([libpthread not found.])])) +[vkd3d_libs_saved="$LIBS" +PTHREAD_LIBS="-pthread" +LIBS="$LIBS $PTHREAD_LIBS" + +AC_MSG_CHECKING([checking for pthread_create in $PTHREAD_LIBS]) +AC_TRY_LINK_FUNC([pthread_create], [vkd3d_pthread_found=yes]) +AC_MSG_RESULT([$vkd3d_pthread_found]) + +AS_IF([test "x$vkd3d_pthread_found" = "xno"], [PTHREAD_LIBS=""]) + +LIBS="$vkd3d_libs_saved"]) ])

1 0

Giovanni Mascellani : vkd3d-utils: Support many different surface types when creating a device.
by Alexandre Julliard 09 Jan '24

09 Jan '24

Module: vkd3d Branch: master Commit: e3fb4e7eace34001bd5d81457050f14dd2b9345c URL: https://gitlab.winehq.org/wine/vkd3d/-/commit/e3fb4e7eace34001bd5d81457050f… Author: Giovanni Mascellani <gmascellani(a)codeweavers.com> Date: Tue Jan 9 10:44:37 2024 +0100 vkd3d-utils: Support many different surface types when creating a device. This is nice for the application, which can use our implementation of D3D12CreateDevice() in more environments, and basically free for us, because surface creation is still the application's business. --- libs/vkd3d-utils/vkd3d_utils_main.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/libs/vkd3d-utils/vkd3d_utils_main.c b/libs/vkd3d-utils/vkd3d_utils_main.c index a2edf403..96676660 100644 --- a/libs/vkd3d-utils/vkd3d_utils_main.c +++ b/libs/vkd3d-utils/vkd3d_utils_main.c @@ -70,8 +70,14 @@ HRESULT WINAPI D3D12CreateDeviceVKD3D(IUnknown *adapter, D3D_FEATURE_LEVEL minim }; static const char * const optional_instance_extensions[] = { + "VK_KHR_android_surface", + "VK_KHR_wayland_surface", + "VK_KHR_win32_surface", "VK_KHR_xcb_surface", + "VK_KHR_xlib_surface", + "VK_EXT_metal_surface", "VK_MVK_macos_surface", + "VK_MVK_ios_surface", }; static const char * const device_extensions[] = {

1 0