May 2024 - Wine-commits - list.winehq.org

Rémi Bernon : win32u: Fix list corruption in vulkan_detach_surfaces.
by Alexandre Julliard 02 May '24

02 May '24

Module: wine Branch: master Commit: ad4f9d73fdfb89b8424b6727554f99a043b18263 URL: https://gitlab.winehq.org/wine/wine/-/commit/ad4f9d73fdfb89b8424b6727554f99… Author: Rémi Bernon <rbernon(a)codeweavers.com> Date: Thu May 2 11:36:04 2024 +0200 win32u: Fix list corruption in vulkan_detach_surfaces. --- dlls/win32u/vulkan.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/win32u/vulkan.c b/dlls/win32u/vulkan.c index 4fae491b1db..59b9364065e 100644 --- a/dlls/win32u/vulkan.c +++ b/dlls/win32u/vulkan.c @@ -258,9 +258,9 @@ static void vulkan_init(void) void vulkan_detach_surfaces( struct list *surfaces ) { - struct surface *surface; + struct surface *surface, *next; - LIST_FOR_EACH_ENTRY( surface, surfaces, struct surface, entry ) + LIST_FOR_EACH_ENTRY_SAFE( surface, next, surfaces, struct surface, entry ) { driver_funcs->p_vulkan_surface_detach( surface->hwnd, surface->driver_private ); list_remove( &surface->entry );

1 0

Rémi Bernon : win32u: Remove now unnecessary rawinput_device_get_usages.
by Alexandre Julliard 02 May '24

02 May '24

Module: wine Branch: master Commit: f0e02e4f981552a595a5aace326241142bc88eec URL: https://gitlab.winehq.org/wine/wine/-/commit/f0e02e4f981552a595a5aace326241… Author: Rémi Bernon <rbernon(a)codeweavers.com> Date: Mon Apr 29 18:28:40 2024 +0200 win32u: Remove now unnecessary rawinput_device_get_usages. --- dlls/win32u/rawinput.c | 19 ------------------- dlls/win32u/win32u_private.h | 1 - 2 files changed, 20 deletions(-) diff --git a/dlls/win32u/rawinput.c b/dlls/win32u/rawinput.c index 1120ce053aa..c86e28dea8d 100644 --- a/dlls/win32u/rawinput.c +++ b/dlls/win32u/rawinput.c @@ -316,25 +316,6 @@ static struct device *find_device_from_handle( HANDLE handle ) return NULL; } -BOOL rawinput_device_get_usages( HANDLE handle, USAGE *usage_page, USAGE *usage ) -{ - struct device *device; - - pthread_mutex_lock( &rawinput_mutex ); - - if (!(device = find_device_from_handle( handle )) || device->info.dwType != RIM_TYPEHID) - *usage_page = *usage = 0; - else - { - *usage_page = device->info.hid.usUsagePage; - *usage = device->info.hid.usUsage; - } - - pthread_mutex_unlock( &rawinput_mutex ); - - return *usage_page || *usage; -} - /********************************************************************** * NtUserGetRawInputDeviceList (win32u.@) */ diff --git a/dlls/win32u/win32u_private.h b/dlls/win32u/win32u_private.h index ff861db4dd9..24e8b1b498d 100644 --- a/dlls/win32u/win32u_private.h +++ b/dlls/win32u/win32u_private.h @@ -146,7 +146,6 @@ extern void pack_user_message( void *buffer, size_t size, UINT message, /* rawinput.c */ extern BOOL process_rawinput_message( MSG *msg, UINT hw_id, const struct hardware_msg_data *msg_data ); -extern BOOL rawinput_device_get_usages( HANDLE handle, USHORT *usage_page, USHORT *usage ); /* scroll.c */ extern void draw_nc_scrollbar( HWND hwnd, HDC hdc, BOOL draw_horizontal, BOOL draw_vertical );

1 0

Rémi Bernon : win32u: Use find_device_from_handle in process_rawinput_message.
by Alexandre Julliard 02 May '24

02 May '24

Module: wine Branch: master Commit: f333f4cdbe993a3ca6847402fdaf0be3c7cab22a URL: https://gitlab.winehq.org/wine/wine/-/commit/f333f4cdbe993a3ca6847402fdaf0b… Author: Rémi Bernon <rbernon(a)codeweavers.com> Date: Wed Jan 5 16:14:02 2022 +0100 win32u: Use find_device_from_handle in process_rawinput_message. And only refresh the list if the device handle isn't known. --- dlls/win32u/rawinput.c | 19 ++++++++++++++++--- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/dlls/win32u/rawinput.c b/dlls/win32u/rawinput.c index c86e28dea8d..c004f296038 100644 --- a/dlls/win32u/rawinput.c +++ b/dlls/win32u/rawinput.c @@ -301,12 +301,13 @@ static void rawinput_update_device_list(void) enumerate_devices( RIM_TYPEHID, guid_devinterface_hidW ); } -static struct device *find_device_from_handle( HANDLE handle ) +static struct device *find_device_from_handle( HANDLE handle, BOOL refresh ) { struct device *device; LIST_FOR_EACH_ENTRY( device, &devices, struct device, entry ) if (device->handle == handle) return device; + if (!refresh) return NULL; rawinput_update_device_list(); @@ -399,7 +400,7 @@ UINT WINAPI NtUserGetRawInputDeviceInfo( HANDLE handle, UINT command, void *data pthread_mutex_lock( &rawinput_mutex ); - if (!(device = find_device_from_handle( handle ))) + if (!(device = find_device_from_handle( handle, TRUE ))) { pthread_mutex_unlock( &rawinput_mutex ); RtlSetLastWin32Error( ERROR_INVALID_HANDLE ); @@ -568,8 +569,20 @@ BOOL process_rawinput_message( MSG *msg, UINT hw_id, const struct hardware_msg_d if (msg->message == WM_INPUT_DEVICE_CHANGE) { + BOOL refresh = msg->wParam == GIDC_ARRIVAL; + struct device *device; + pthread_mutex_lock( &rawinput_mutex ); - rawinput_update_device_list(); + if ((device = find_device_from_handle( UlongToHandle( msg_data->rawinput.device ), refresh ))) + { + if (msg->wParam == GIDC_REMOVAL) + { + list_remove( &device->entry ); + NtClose( device->file ); + free( device->data ); + free( device ); + } + } pthread_mutex_unlock( &rawinput_mutex ); } else

1 0

Rémi Bernon : win32u: Move rawinput device cache ticks check to rawinput_update_device_list.
by Alexandre Julliard 02 May '24

02 May '24

Module: wine Branch: master Commit: 464ce9a0858c4c2b1a2d5a5234a63413ce92bd1b URL: https://gitlab.winehq.org/wine/wine/-/commit/464ce9a0858c4c2b1a2d5a5234a634… Author: Rémi Bernon <rbernon(a)codeweavers.com> Date: Thu May 2 17:54:32 2024 +0200 win32u: Move rawinput device cache ticks check to rawinput_update_device_list. --- dlls/win32u/rawinput.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/dlls/win32u/rawinput.c b/dlls/win32u/rawinput.c index c004f296038..5b1d9d211df 100644 --- a/dlls/win32u/rawinput.c +++ b/dlls/win32u/rawinput.c @@ -282,12 +282,17 @@ static void enumerate_devices( DWORD type, const WCHAR *class ) NtClose( class_key ); } -static void rawinput_update_device_list(void) +static void rawinput_update_device_list( BOOL force ) { + unsigned int ticks = NtGetTickCount(); + static unsigned int last_check; struct device *device, *next; TRACE( "\n" ); + if (ticks - last_check <= 2000 && !force) return; + last_check = ticks; + LIST_FOR_EACH_ENTRY_SAFE( device, next, &devices, struct device, entry ) { list_remove( &device->entry ); @@ -309,7 +314,7 @@ static struct device *find_device_from_handle( HANDLE handle, BOOL refresh ) if (device->handle == handle) return device; if (!refresh) return NULL; - rawinput_update_device_list(); + rawinput_update_device_list( TRUE ); LIST_FOR_EACH_ENTRY( device, &devices, struct device, entry ) if (device->handle == handle) return device; @@ -322,8 +327,7 @@ static struct device *find_device_from_handle( HANDLE handle, BOOL refresh ) */ UINT WINAPI NtUserGetRawInputDeviceList( RAWINPUTDEVICELIST *device_list, UINT *device_count, UINT size ) { - unsigned int count = 0, ticks = NtGetTickCount(); - static unsigned int last_check; + unsigned int count = 0; struct device *device; TRACE( "device_list %p, device_count %p, size %u.\n", device_list, device_count, size ); @@ -342,11 +346,7 @@ UINT WINAPI NtUserGetRawInputDeviceList( RAWINPUTDEVICELIST *device_list, UINT * pthread_mutex_lock( &rawinput_mutex ); - if (ticks - last_check > 2000) - { - last_check = ticks; - rawinput_update_device_list(); - } + rawinput_update_device_list( FALSE ); LIST_FOR_EACH_ENTRY( device, &devices, struct device, entry ) {

1 0

Evan Tang : user32/tests: Check RegisterRawInputDevices RIDDEV_DEVNOTIFY posted messages.
by Alexandre Julliard 02 May '24

02 May '24

Module: wine Branch: master Commit: a3134963e01ec9f17ec2d594e0ae90fffb2bcb29 URL: https://gitlab.winehq.org/wine/wine/-/commit/a3134963e01ec9f17ec2d594e0ae90… Author: Evan Tang <etang(a)codeweavers.com> Date: Thu May 2 17:39:21 2024 +0200 user32/tests: Check RegisterRawInputDevices RIDDEV_DEVNOTIFY posted messages. --- dlls/user32/tests/input.c | 43 +++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 43 insertions(+) diff --git a/dlls/user32/tests/input.c b/dlls/user32/tests/input.c index b92e59396ac..8b374fae8a3 100644 --- a/dlls/user32/tests/input.c +++ b/dlls/user32/tests/input.c @@ -1778,6 +1778,7 @@ static void test_RegisterRawInputDevices(void) HWND hwnd; RAWINPUTDEVICE raw_devices[2] = {0}; UINT count, raw_devices_count; + MSG msg; raw_devices[0].usUsagePage = HID_USAGE_PAGE_GENERIC; raw_devices[0].usUsage = HID_USAGE_GENERIC_GAMEPAD; @@ -1849,6 +1850,48 @@ static void test_RegisterRawInputDevices(void) raw_devices[1].hwndTarget = hwnd; ok_ret( 1, RegisterRawInputDevices( raw_devices, ARRAY_SIZE( raw_devices ), sizeof(RAWINPUTDEVICE) ) ); + /* RIDEV_DEVNOTIFY send messages for any pre-existing device */ + raw_devices[0].dwFlags = RIDEV_DEVNOTIFY; + raw_devices[0].hwndTarget = 0; + raw_devices[0].usUsagePage = HID_USAGE_PAGE_GENERIC; + raw_devices[0].usUsage = HID_USAGE_GENERIC_MOUSE; + raw_devices[1].dwFlags = RIDEV_DEVNOTIFY; + raw_devices[1].hwndTarget = 0; + raw_devices[1].usUsagePage = HID_USAGE_PAGE_GENERIC; + raw_devices[1].usUsage = HID_USAGE_GENERIC_KEYBOARD; + + ok_ret( 1, RegisterRawInputDevices( raw_devices, ARRAY_SIZE( raw_devices ), sizeof(RAWINPUTDEVICE) ) ); + while (PeekMessageW( &msg, 0, 0, 0, PM_REMOVE )) + { + ok_ne( WM_INPUT_DEVICE_CHANGE, msg.message, UINT, "%#x" ); + TranslateMessage( &msg ); + DispatchMessageW( &msg ); + } + + /* RIDEV_DEVNOTIFY send messages only to hwndTarget */ + raw_devices[0].hwndTarget = hwnd; + raw_devices[1].hwndTarget = hwnd; + + count = 0; + ok_ret( 1, RegisterRawInputDevices( raw_devices, ARRAY_SIZE( raw_devices ), sizeof(RAWINPUTDEVICE) ) ); + while (PeekMessageW( &msg, 0, 0, 0, PM_REMOVE )) + { + if (msg.message == WM_INPUT_DEVICE_CHANGE) count++; + TranslateMessage( &msg ); + DispatchMessageW( &msg ); + } + todo_wine ok( count >= 2, "got %u messages\n", count ); + + count = 0; + ok_ret( 1, RegisterRawInputDevices( raw_devices, ARRAY_SIZE( raw_devices ), sizeof(RAWINPUTDEVICE) ) ); + while (PeekMessageW( &msg, 0, 0, 0, PM_REMOVE )) + { + if (msg.message == WM_INPUT_DEVICE_CHANGE) count++; + TranslateMessage( &msg ); + DispatchMessageW( &msg ); + } + todo_wine ok( count >= 2, "got %u messages\n", count ); + /* RIDEV_REMOVE requires hwndTarget == NULL */ raw_devices[0].dwFlags = RIDEV_REMOVE; raw_devices[0].hwndTarget = hwnd;

1 0

Evan Tang : win32u: Post device arrival messages in NtUserRegisterRawInputDevices.
by Alexandre Julliard 02 May '24

02 May '24

Module: wine Branch: master Commit: 4ae893e2f005e0915be480075feaecc0ccec8d8f URL: https://gitlab.winehq.org/wine/wine/-/commit/4ae893e2f005e0915be480075feaec… Author: Evan Tang <etang(a)codeweavers.com> Date: Thu May 2 17:44:18 2024 +0200 win32u: Post device arrival messages in NtUserRegisterRawInputDevices. --- dlls/user32/tests/input.c | 4 ++-- dlls/win32u/rawinput.c | 27 +++++++++++++++++++++++++++ 2 files changed, 29 insertions(+), 2 deletions(-) diff --git a/dlls/user32/tests/input.c b/dlls/user32/tests/input.c index 8b374fae8a3..fcaa4229b02 100644 --- a/dlls/user32/tests/input.c +++ b/dlls/user32/tests/input.c @@ -1880,7 +1880,7 @@ static void test_RegisterRawInputDevices(void) TranslateMessage( &msg ); DispatchMessageW( &msg ); } - todo_wine ok( count >= 2, "got %u messages\n", count ); + ok( count >= 2, "got %u messages\n", count ); count = 0; ok_ret( 1, RegisterRawInputDevices( raw_devices, ARRAY_SIZE( raw_devices ), sizeof(RAWINPUTDEVICE) ) ); @@ -1890,7 +1890,7 @@ static void test_RegisterRawInputDevices(void) TranslateMessage( &msg ); DispatchMessageW( &msg ); } - todo_wine ok( count >= 2, "got %u messages\n", count ); + ok( count >= 2, "got %u messages\n", count ); /* RIDEV_REMOVE requires hwndTarget == NULL */ raw_devices[0].dwFlags = RIDEV_REMOVE; diff --git a/dlls/win32u/rawinput.c b/dlls/win32u/rawinput.c index 5b1d9d211df..1083571802d 100644 --- a/dlls/win32u/rawinput.c +++ b/dlls/win32u/rawinput.c @@ -598,6 +598,30 @@ BOOL process_rawinput_message( MSG *msg, UINT hw_id, const struct hardware_msg_d return TRUE; } +static void post_device_notifications( const RAWINPUTDEVICE *filter ) +{ + ULONG usages = MAKELONG( filter->usUsagePage, filter->usUsage ); + struct device *device; + + LIST_FOR_EACH_ENTRY( device, &devices, struct device, entry ) + { + switch (device->info.dwType) + { + case RIM_TYPEMOUSE: + if (usages != MAKELONG( HID_USAGE_PAGE_GENERIC, HID_USAGE_GENERIC_MOUSE )) continue; + break; + case RIM_TYPEKEYBOARD: + if (usages != MAKELONG( HID_USAGE_PAGE_GENERIC, HID_USAGE_GENERIC_KEYBOARD )) continue; + break; + case RIM_TYPEHID: + if (usages != MAKELONG( device->info.hid.usUsagePage, device->info.hid.usUsage )) continue; + break; + } + + NtUserPostMessage( filter->hwndTarget, WM_INPUT_DEVICE_CHANGE, GIDC_ARRIVAL, (LPARAM)device->handle ); + } +} + static void register_rawinput_device( const RAWINPUTDEVICE *device ) { RAWINPUTDEVICE *pos, *end; @@ -619,6 +643,7 @@ static void register_rawinput_device( const RAWINPUTDEVICE *device ) } else { + if ((device->dwFlags & RIDEV_DEVNOTIFY) && device->hwndTarget) post_device_notifications( device ); if (pos == end || pos->usUsagePage != device->usUsagePage || pos->usUsage != device->usUsage) { memmove( pos + 1, pos, (char *)end - (char *)pos ); @@ -684,6 +709,8 @@ BOOL WINAPI NtUserRegisterRawInputDevices( const RAWINPUTDEVICE *devices, UINT d return FALSE; } + rawinput_update_device_list( TRUE ); + registered_devices = new_registered_devices; for (i = 0; i < device_count; ++i) register_rawinput_device( devices + i );

1 0

Alistair Leslie-Hughes : windowscodecs: Avoid implicit cast changing value.
by Alexandre Julliard 02 May '24

02 May '24

Module: wine Branch: master Commit: 013f54af1f721dce651c85f87a5339ba3cb9d4a1 URL: https://gitlab.winehq.org/wine/wine/-/commit/013f54af1f721dce651c85f87a5339… Author: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Date: Thu May 2 09:55:01 2024 +1000 windowscodecs: Avoid implicit cast changing value. This appear to be introduced with commit 12f73ed9d851. When This->stride is negative (bottom up image) it converts the multiplication to an UINT. Thus causing the pointer to be incorrect when y > 0. --- dlls/windowscodecs/bmpdecode.c | 2 +- dlls/windowscodecs/wincodecs_common.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/windowscodecs/bmpdecode.c b/dlls/windowscodecs/bmpdecode.c index 9d4867447f0..ae6feda5b50 100644 --- a/dlls/windowscodecs/bmpdecode.c +++ b/dlls/windowscodecs/bmpdecode.c @@ -432,7 +432,7 @@ static HRESULT BmpFrameDecode_ReadABGRasBGR(BmpDecoder* This) { for (y = 0; y < height; y++) { - pixel = This->imagedatastart + This->stride * y; + pixel = This->imagedatastart + This->stride * (INT)y; for (x = 0; x < width; x++) { diff --git a/dlls/windowscodecs/wincodecs_common.h b/dlls/windowscodecs/wincodecs_common.h index f56e91e1f54..dcccdc2e5f1 100644 --- a/dlls/windowscodecs/wincodecs_common.h +++ b/dlls/windowscodecs/wincodecs_common.h @@ -201,7 +201,7 @@ void reverse_bgr8(UINT bytesperpixel, LPBYTE bits, UINT width, UINT height, INT for (y=0; y<height; y++) { - pixel = bits + stride * y; + pixel = bits + stride * (INT)y; for (x=0; x<width; x++) {

1 0

Alex Henrie : shell32: Add SHAssocEnumHandlersForProtocolByApplication stub.
by Alexandre Julliard 02 May '24

02 May '24

Module: wine Branch: master Commit: 0af35ccd06c30cd09d378599efe33a2bb7238b4f URL: https://gitlab.winehq.org/wine/wine/-/commit/0af35ccd06c30cd09d378599efe33a… Author: Alex Henrie <alexhenrie24(a)gmail.com> Date: Wed May 1 22:15:25 2024 -0600 shell32: Add SHAssocEnumHandlersForProtocolByApplication stub. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56581 --- dlls/shell32/assoc.c | 9 +++++++++ dlls/shell32/shell32.spec | 1 + 2 files changed, 10 insertions(+) diff --git a/dlls/shell32/assoc.c b/dlls/shell32/assoc.c index 37cdc01101a..45e9781d078 100644 --- a/dlls/shell32/assoc.c +++ b/dlls/shell32/assoc.c @@ -1132,3 +1132,12 @@ HRESULT WINAPI SHAssocEnumHandlers(const WCHAR *extra, ASSOC_FILTER filter, IEnu *enumhandlers = &enumassoc->IEnumAssocHandlers_iface; return S_OK; } + +/************************************************************************** + * SHAssocEnumHandlersForProtocolByApplication [SHELL32.@] + */ +HRESULT WINAPI SHAssocEnumHandlersForProtocolByApplication(const WCHAR *protocol, REFIID riid, void **handlers) +{ + FIXME("(%s %s %p): stub\n", debugstr_w(protocol), debugstr_guid(riid), handlers); + return E_NOTIMPL; +} diff --git a/dlls/shell32/shell32.spec b/dlls/shell32/shell32.spec index 8155365318d..bdf3378a235 100644 --- a/dlls/shell32/shell32.spec +++ b/dlls/shell32/shell32.spec @@ -332,6 +332,7 @@ @ stdcall SHAddToRecentDocs (long ptr) @ stdcall SHAppBarMessage(long ptr) @ stdcall SHAssocEnumHandlers(wstr long ptr) +@ stdcall SHAssocEnumHandlersForProtocolByApplication(wstr ptr ptr) @ stdcall SHBindToFolderIDListParent(ptr ptr ptr ptr ptr) @ stdcall SHBindToObject(ptr ptr ptr ptr ptr) @ stdcall SHBindToParent(ptr ptr ptr ptr)

1 0

Alex Henrie : pdh: Add PdhConnectMachineA stub.
by Alexandre Julliard 02 May '24

02 May '24

Module: wine Branch: master Commit: 30019a5b8759c2d56ac82fe7454bda09cca77b63 URL: https://gitlab.winehq.org/wine/wine/-/commit/30019a5b8759c2d56ac82fe7454bda… Author: Alex Henrie <alexhenrie24(a)gmail.com> Date: Wed May 1 21:40:18 2024 -0600 pdh: Add PdhConnectMachineA stub. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56599 --- dlls/pdh/pdh.spec | 2 +- dlls/pdh/pdh_main.c | 9 +++++++++ 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/dlls/pdh/pdh.spec b/dlls/pdh/pdh.spec index 711c970029b..3d51f6257ef 100644 --- a/dlls/pdh/pdh.spec +++ b/dlls/pdh/pdh.spec @@ -18,7 +18,7 @@ @ stdcall PdhCollectQueryDataWithTime(ptr ptr) @ stdcall PdhCollectQueryDataEx(ptr long ptr) @ stub PdhComputeCounterStatistics -@ stub PdhConnectMachineA +@ stdcall PdhConnectMachineA(str) @ stub PdhConnectMachineW @ stub PdhCreateSQLTablesA @ stub PdhCreateSQLTablesW diff --git a/dlls/pdh/pdh_main.c b/dlls/pdh/pdh_main.c index 12bda6bedc0..dec86a9962b 100644 --- a/dlls/pdh/pdh_main.c +++ b/dlls/pdh/pdh_main.c @@ -1280,3 +1280,12 @@ PDH_STATUS WINAPI PdhBindInputDataSourceW(PDH_HLOG *source, const WCHAR *filenam FIXME("%p %s: stub\n", source, debugstr_w(filenamelist)); return PDH_NOT_IMPLEMENTED; } + +/*********************************************************************** + * PdhConnectMachineA (PDH.@) + */ +PDH_STATUS WINAPI PdhConnectMachineA(const char *name) +{ + FIXME("%s: stub\n", debugstr_a(name)); + return PDH_NOT_IMPLEMENTED; +}

1 0

Anton Baskanov : user32/tests: Test that display settings are restored on process exit.
by Alexandre Julliard 02 May '24

02 May '24

Module: wine Branch: master Commit: 30c3d0a3373db51f978b846fe90551ee2fe2b9d6 URL: https://gitlab.winehq.org/wine/wine/-/commit/30c3d0a3373db51f978b846fe90551… Author: Anton Baskanov <baskanov(a)gmail.com> Date: Tue Feb 6 16:52:24 2024 +0700 user32/tests: Test that display settings are restored on process exit. --- dlls/user32/tests/monitor.c | 308 +++++++++++++++++++++++++++++++++++++++++--- 1 file changed, 290 insertions(+), 18 deletions(-)

1 0