Module: tools Branch: master Commit: 34b71eecf88d54d4cf86d56dc6c53a780b259a15 URL: https://gitlab.winehq.org/winehq/tools/-/commit/34b71eecf88d54d4cf86d56dc6c5... Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Tue Oct 25 15:04:24 2022 +0200 testbot/LogUtils: Remove the unused $LogInfo->{Failures} field. It was essentially redundant with the ErrCount field anyway, except that the latter includes the flaky failures. Also this field name could cause confusion with the per-MsgGroup Failures field used to track known failures. --- testbot/lib/WineTestBot/LogUtils.pm | 8 -------- 1 file changed, 8 deletions(-) diff --git a/testbot/lib/WineTestBot/LogUtils.pm b/testbot/lib/WineTestBot/LogUtils.pm index a9c893a3..05af274c 100644 --- a/testbot/lib/WineTestBot/LogUtils.pm +++ b/testbot/lib/WineTestBot/LogUtils.pm @@ -382,7 +382,6 @@ sub _AddExtra($$;$) $Error = "$Cur->{Dll}:$Cur->{Unit} $Error" if (defined $Cur); push @{$LogInfo->{Extra}}, $Error; - $LogInfo->{Failures}++; } sub _CheckUnit($$$$) @@ -472,8 +471,6 @@ sub _CloseTestUnit($$$) } } } - - $LogInfo->{Failures} += $Cur->{LineFailures}; } sub _AddReportError($$$$) @@ -516,9 +513,6 @@ The number of test units. =item TimeoutCount The number of test units that timed out. -=item Failures -The number of failed tests. - =item ErrCount, ErrGroupNames, ErrGroups, BadLog See ParseTaskLog() for details. @@ -539,7 +533,6 @@ sub ParseWineTestReport($$$) TestUnitCount => 0, TimeoutCount => 0, - Failures => undef, ErrGroupNames => [], ErrGroups => {}, @@ -750,7 +743,6 @@ sub ParseWineTestReport($$$) { # The done line will already be shown as a timeout (see JobDetails) # so record the failure but don't add an error message. - $LogInfo->{Failures}++; $Cur->{IsBroken} = 1; $LogInfo->{TimeoutCount}++; _AddReportError($LogInfo, $Cur, $LineNo, $&);