Module: wine Branch: master Commit: 496380709dfdeccd2ff12358e5bdb5b7b8338ac2 URL: https://source.winehq.org/git/wine.git/?a=commit;h=496380709dfdeccd2ff12358e... Author: Piotr Caban <piotr(a)codeweavers.com> Date: Mon May 27 17:36:17 2019 +0200 services: Don't double release process in service_start. Fixes a crash while running ntoskrnl tests. Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- programs/services/services.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/programs/services/services.c b/programs/services/services.c index 0634c83..7ca249c 100644 --- a/programs/services/services.c +++ b/programs/services/services.c @@ -1069,10 +1069,13 @@ DWORD service_start(struct service_entry *service, DWORD service_argc, LPCWSTR * if (err != ERROR_SUCCESS) { service_lock(service); - service->status.dwCurrentState = SERVICE_STOPPED; - service->process = NULL; - if (!--process->use_count) process_terminate(process); - release_process(process); + if (service->process) + { + service->status.dwCurrentState = SERVICE_STOPPED; + service->process = NULL; + if (!--process->use_count) process_terminate(process); + release_process(process); + } service_unlock(service); }