Module: wine Branch: master Commit: e5e301b7a55cfbf9fff5890889159ffe77efffd6 URL: http://source.winehq.org/git/wine.git/?a=commit;h=e5e301b7a55cfbf9fff5890889... Author: Ricardo Filipe <ricardo_barbano(a)hotmail.com> Date: Thu Nov 13 13:33:27 2008 +0000 msxml3: Check some dead store results (llvm/clang). --- dlls/msxml3/saxreader.c | 19 ++++++++++++++++--- 1 files changed, 16 insertions(+), 3 deletions(-) diff --git a/dlls/msxml3/saxreader.c b/dlls/msxml3/saxreader.c index 5b16663..9fc226a 100644 --- a/dlls/msxml3/saxreader.c +++ b/dlls/msxml3/saxreader.c @@ -1168,6 +1168,13 @@ static void libxmlEndElementNS( Prefix, SysStringLen(Prefix)); SysFreeString(Prefix); + + if(hr != S_OK) + { + format_error_message_from_id(This, hr); + return; + } + } } @@ -1218,6 +1225,12 @@ static void libxmlCharacters( Chars, SysStringLen(Chars)); SysFreeString(Chars); + if(hr != S_OK) + { + format_error_message_from_id(This, hr); + return; + } + This->column += end-cur+1; if(lastEvent) @@ -1772,7 +1785,7 @@ static HRESULT internal_parseBuffer(saxreader *This, const char *buffer, int siz hr = SAXLocator_create(This, &locator, vbInterface); if(FAILED(hr)) - return E_FAIL; + return hr; locator->pParserCtxt = xmlCreateMemoryParserCtxt(buffer, size); if(!locator->pParserCtxt) @@ -1797,7 +1810,7 @@ static HRESULT internal_parseBuffer(saxreader *This, const char *buffer, int siz } ISAXLocator_Release((ISAXLocator*)&locator->lpSAXLocatorVtbl); - return S_OK; + return hr; } static HRESULT internal_parseStream(saxreader *This, IStream *stream, BOOL vbInterface) @@ -1813,7 +1826,7 @@ static HRESULT internal_parseStream(saxreader *This, IStream *stream, BOOL vbInt hr = SAXLocator_create(This, &locator, vbInterface); if(FAILED(hr)) - return E_FAIL; + return hr; locator->pParserCtxt = xmlCreatePushParserCtxt( &locator->saxreader->sax, locator,