Module: wine Branch: master Commit: edd9066d5b676104c036cb621574f36ea055951b URL: http://source.winehq.org/git/wine.git/?a=commit;h=edd9066d5b676104c036cb6215... Author: Frédéric Delanoy <frederic.delanoy(a)gmail.com> Date: Thu Jan 19 17:14:21 2012 +0100 setupapi: Correctly handle errors in fake_dlls_callback (Coverity). --- dlls/setupapi/install.c | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/dlls/setupapi/install.c b/dlls/setupapi/install.c index 947a512..96eb914 100644 --- a/dlls/setupapi/install.c +++ b/dlls/setupapi/install.c @@ -701,7 +701,6 @@ static BOOL register_dlls_callback( HINF hinf, PCWSTR field, void *arg ) static BOOL fake_dlls_callback( HINF hinf, PCWSTR field, void *arg ) { INFCONTEXT context; - BOOL ret = TRUE; BOOL ok = SetupFindFirstLineW( hinf, field, NULL, &context ); for (; ok; ok = SetupFindNextLine( &context, &context )) @@ -730,9 +729,8 @@ static BOOL fake_dlls_callback( HINF hinf, PCWSTR field, void *arg ) done: HeapFree( GetProcessHeap(), 0, path ); - if (!ret) break; } - return ret; + return TRUE; } /***********************************************************************