Marcus Meissner : hidclass.sys: Add missing case/missing HeapFree ( Coverity).
Module: wine Branch: master Commit: bb590b3f9f68917855fe822c31ef50d40af7d4f9 URL: http://source.winehq.org/git/wine.git/?a=commit;h=bb590b3f9f68917855fe822c31... Author: Marcus Meissner <marcus(a)jet.franken.de> Date: Sat Apr 23 20:03:10 2016 +0200 hidclass.sys: Add missing case/missing HeapFree (Coverity). Signed-off-by: Marcus Meissner <marcus(a)jet.franken.de> Signed-off-by: Aric Stewart <aric(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/hidclass.sys/pnp.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/dlls/hidclass.sys/pnp.c b/dlls/hidclass.sys/pnp.c index d97184f..5a6a0a7 100644 --- a/dlls/hidclass.sys/pnp.c +++ b/dlls/hidclass.sys/pnp.c @@ -292,10 +292,9 @@ NTSTATUS WINAPI HID_PNP_Dispatch(DEVICE_OBJECT *device, IRP *irp) case IRP_MN_QUERY_ID: { BASE_DEVICE_EXTENSION *ext = device->DeviceExtension; - ULONG type = irpsp->Parameters.QueryId.IdType; WCHAR *id = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(WCHAR)*REGSTR_VAL_MAX_HCID_LEN); - TRACE("IRP_MN_QUERY_ID[%i]\n", type); - switch (type) + TRACE("IRP_MN_QUERY_ID[%i]\n", irpsp->Parameters.QueryId.IdType); + switch (irpsp->Parameters.QueryId.IdType) { case BusQueryHardwareIDs: case BusQueryCompatibleIDs: @@ -326,6 +325,10 @@ NTSTATUS WINAPI HID_PNP_Dispatch(DEVICE_OBJECT *device, IRP *irp) irp->IoStatus.Information = (ULONG_PTR)id; rc = STATUS_SUCCESS; break; + case BusQueryDeviceSerialNumber: + FIXME("BusQueryDeviceSerialNumber not implemented\n"); + HeapFree(GetProcessHeap(), 0, id); + break; } break; }
participants (1)
-
Alexandre Julliard