Francois Gouget : testbot: Fix the Job and Step status update.

[Alexandre Julliard]

Module: tools
Branch: master
Commit: 4c266ab9e904222186b0fae0c28b190b80d22ce1
URL:    http://source.winehq.org/git/tools.git/?a=commit;h=4c266ab9e904222186b0fae0c...

Author: Francois Gouget <fgouget(a)codeweavers.com>
Date:   Fri Nov  2 00:11:00 2012 +0100

testbot: Fix the Job and Step status update.

A job that has a non-build step fail should still be marked as
failed. That's because when there are test failures the TestFailures
field gets set to a non-zero value but the task's Status is still set
to completed. So a failed Step really reflects a bot error.  Also
simplify the code and avoid duplicating the UpdateStatus() logic in
the Check() method.

---

 testbot/lib/WineTestBot/Jobs.pm  |  253 +++++++-------------------------------
 testbot/lib/WineTestBot/Steps.pm |   36 ++++++
 testbot/lib/WineTestBot/Tasks.pm |   43 +++++++
 3 files changed, 125 insertions(+), 207 deletions(-)

Diff:   http://source.winehq.org/git/tools.git/?a=commitdiff;h=4c266ab9e904222186b0f...