Bruno Jesus : iphlpapi: Fix a one counter for two loops error (PVS-Studio) .
Module: wine Branch: master Commit: 794d52273efccf5ef6e5ed56783b3f4c7130cc4d URL: http://source.winehq.org/git/wine.git/?a=commit;h=794d52273efccf5ef6e5ed5678... Author: Bruno Jesus <00cpxxx(a)gmail.com> Date: Fri Oct 24 01:47:02 2014 -0200 iphlpapi: Fix a one counter for two loops error (PVS-Studio). --- dlls/iphlpapi/iphlpapi_main.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/dlls/iphlpapi/iphlpapi_main.c b/dlls/iphlpapi/iphlpapi_main.c index 88db25a..4d18711 100644 --- a/dlls/iphlpapi/iphlpapi_main.c +++ b/dlls/iphlpapi/iphlpapi_main.c @@ -983,6 +983,7 @@ static ULONG adapterAddressesFromIndex(ULONG family, ULONG flags, IF_INDEX index struct WS_sockaddr_in6 *sa; const IN6_ADDR *addr, *mask; BOOL done = FALSE; + ULONG k; prefix->u.s.Length = sizeof(*prefix); prefix->u.s.Flags = 0; @@ -1000,11 +1001,11 @@ static ULONG adapterAddressesFromIndex(ULONG family, ULONG flags, IF_INDEX index sa->sin6_scope_id = 0; prefix->PrefixLength = 0; - for (i = 0; i < 8 && !done; i++) + for (k = 0; k < 8 && !done; k++) { for (j = 0; j < sizeof(WORD) * 8 && !done; j++) { - if (mask->u.Word[i] & 1 << j) prefix->PrefixLength++; + if (mask->u.Word[k] & 1 << j) prefix->PrefixLength++; else done = TRUE; } }
participants (1)
-
Alexandre Julliard