Henri Verbeet : d3d8: Don' t return a pointer to the implementation in IDirect3DDevice8Impl_QueryInterface ().

[Alexandre Julliard]

Module: wine
Branch: master
Commit: 925a791dff8aadcee354839e96891d284904ffb3
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=925a791dff8aadcee354839e96...

Author: Henri Verbeet <hverbeet(a)codeweavers.com>
Date:   Sun Mar 25 20:56:29 2012 +0200

d3d8: Don't return a pointer to the implementation in IDirect3DDevice8Impl_QueryInterface().

---

 dlls/d3d8/device.c |   12 ++++++------
 1 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/dlls/d3d8/device.c b/dlls/d3d8/device.c
index b528e2c..c6ce5b5 100644
--- a/dlls/d3d8/device.c
+++ b/dlls/d3d8/device.c
@@ -262,19 +262,19 @@ static inline IDirect3DDevice8Impl *impl_from_IDirect3DDevice8(IDirect3DDevice8
 static HRESULT WINAPI IDirect3DDevice8Impl_QueryInterface(IDirect3DDevice8 *iface, REFIID riid,
         void **ppobj)
 {
-    IDirect3DDevice8Impl *This = impl_from_IDirect3DDevice8(iface);
-
     TRACE("iface %p, riid %s, object %p.\n",
             iface, debugstr_guid(riid), ppobj);
 
-    if (IsEqualGUID(riid, &IID_IUnknown)
-        || IsEqualGUID(riid, &IID_IDirect3DDevice8)) {
+    if (IsEqualGUID(riid, &IID_IDirect3DDevice8)
+            || IsEqualGUID(riid, &IID_IUnknown))
+    {
         IUnknown_AddRef(iface);
-        *ppobj = This;
+        *ppobj = iface;
         return S_OK;
     }
 
-    WARN("(%p)->(%s,%p),not found\n", This, debugstr_guid(riid), ppobj);
+    WARN("%s not implemented, returning E_NOINTERFACE.\n", debugstr_guid(riid));
+
     *ppobj = NULL;
     return E_NOINTERFACE;
 }