Gabriel Ivăncescu : mshtml: Explicitly hold ref to the plugin host in NPP_New.
Module: wine Branch: master Commit: 08dc691dfb410de7115db3f9c34b225327e21f67 URL: https://gitlab.winehq.org/wine/wine/-/commit/08dc691dfb410de7115db3f9c34b225... Author: Gabriel Ivăncescu <gabrielopcode(a)gmail.com> Date: Mon May 22 19:03:22 2023 +0300 mshtml: Explicitly hold ref to the plugin host in NPP_New. Currently this worked by luck because it is leaking; the element holding it never releases it. Signed-off-by: Gabriel Ivăncescu <gabrielopcode(a)gmail.com> --- dlls/mshtml/npplugin.c | 1 + 1 file changed, 1 insertion(+) diff --git a/dlls/mshtml/npplugin.c b/dlls/mshtml/npplugin.c index a1c38e5ed1a..6dfb65c0a6e 100644 --- a/dlls/mshtml/npplugin.c +++ b/dlls/mshtml/npplugin.c @@ -301,6 +301,7 @@ static NPError CDECL NPP_New(NPMIMEType pluginType, NPP instance, UINT16 mode, I } instance->pdata = container->plugin_host; + IOleClientSite_AddRef(&container->plugin_host->IOleClientSite_iface); node_release(&container->element.node); return err;
participants (1)
-
Alexandre Julliard