Matteo Bruni : d3dx9: Avoid double free on effect initialization failure.

[Alexandre Julliard]

Module: wine
Branch: master
Commit: cffe35488dc16414c6938e0f1a0169fb59730c97
URL:    https://source.winehq.org/git/wine.git/?a=commit;h=cffe35488dc16414c6938e0f1...

Author: Matteo Bruni <mbruni(a)codeweavers.com>
Date:   Mon Mar 18 19:58:39 2019 +0100

d3dx9: Avoid double free on effect initialization failure.

Signed-off-by: Matteo Bruni <mbruni(a)codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard(a)winehq.org>

---

 dlls/d3dx9_36/effect.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/dlls/d3dx9_36/effect.c b/dlls/d3dx9_36/effect.c
index 51c7a37..3a8e152 100644
--- a/dlls/d3dx9_36/effect.c
+++ b/dlls/d3dx9_36/effect.c
@@ -6303,7 +6303,6 @@ static HRESULT d3dx9_base_effect_init(struct d3dx9_base_effect *base,
                             debugstr_a(skip_constants[i]), j);
                     HeapFree(GetProcessHeap(), 0, skip_constants_buffer);
                     HeapFree(GetProcessHeap(), 0, skip_constants);
-                    d3dx9_base_effect_cleanup(effect);
                     return D3DERR_INVALIDCALL;
                 }
             }