Francois Gouget : testbot/web: Remove OnPrev() and OnNext() from Submit.

[Alexandre Julliard]

Module: tools
Branch: master
Commit: 40e17bc1a26ff86948793a0c9bafffd139b382f7
URL:    https://source.winehq.org/git/tools.git/?a=commit;h=40e17bc1a26ff86948793a0c...

Author: Francois Gouget <fgouget(a)codeweavers.com>
Date:   Tue Nov 27 04:04:32 2018 +0100

testbot/web: Remove OnPrev() and OnNext() from Submit.

These one-liners add an unnecessary layer of indirection.

Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard(a)winehq.org>

---

 testbot/web/Submit.pl | 17 ++---------------
 1 file changed, 2 insertions(+), 15 deletions(-)

diff --git a/testbot/web/Submit.pl b/testbot/web/Submit.pl
index 85a12a0..67c1f9b 100644
--- a/testbot/web/Submit.pl
+++ b/testbot/web/Submit.pl
@@ -709,13 +709,6 @@ sub OnPage2Next($)
   return 1;
 }
 
-sub OnNext($)
-{
-  my ($self) = @_;
-
-  return $self->{Page} == 2 ? $self->OnPage2Next() : $self->OnPage1Next();
-}
-
 sub OnPage2Prev($)
 {
   my ($self) = @_;
@@ -741,12 +734,6 @@ sub OnPage3Prev($)
   return 1;
 }
 
-sub OnPrev($)
-{
-  my ($self) = @_;
-
-  return $self->{Page} == 3 ? $self->OnPage3Prev() : $self->OnPage2Prev();
-}
 
 sub SubmitJob($$$)
 {
@@ -1018,11 +1005,11 @@ sub OnAction($$)
 
   if ($Action eq "Next >")
   {
-    return $self->OnNext();
+    return $self->{Page} == 2 ? $self->OnPage2Next() : $self->OnPage1Next();
   }
   elsif ($Action eq "< Prev")
   {
-    return $self->OnPrev();
+    return $self->{Page} == 3 ? $self->OnPage3Prev() : $self->OnPage2Prev();
   }
   elsif ($Action eq "Submit")
   {