Alex Henrie : nsiproxy: Fix use after free in icmp_send_echo (scan-build).

[Alexandre Julliard]

Module: wine
Branch: master
Commit: 06923f61e25bf5fb1037303e94014e515f3fc4cf
URL:    https://source.winehq.org/git/wine.git/?a=commit;h=06923f61e25bf5fb1037303e9...

Author: Alex Henrie <alexhenrie24(a)gmail.com>
Date:   Mon Dec 20 22:01:21 2021 -0700

nsiproxy: Fix use after free in icmp_send_echo (scan-build).

Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com>
Signed-off-by: Huw Davies <huw(a)codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard(a)winehq.org>

---

 dlls/nsiproxy.sys/icmp_echo.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/nsiproxy.sys/icmp_echo.c b/dlls/nsiproxy.sys/icmp_echo.c
index cfebb287547..f36ff156bef 100644
--- a/dlls/nsiproxy.sys/icmp_echo.c
+++ b/dlls/nsiproxy.sys/icmp_echo.c
@@ -656,8 +656,8 @@ NTSTATUS icmp_send_echo( void *args )
     if (ret < 0)
     {
         TRACE( "sendto() rets %d errno %d\n", ret, errno );
-        icmp_data_free( data );
         params->reply_len = data->ops->set_reply_ip_status( errno_to_ip_status( errno ), params->bits, params->reply );
+        icmp_data_free( data );
         return STATUS_SUCCESS;
     }