Alex Henrie : mshtml: Fix use after free in use_gecko_script (Coverity).
Module: wine Branch: master Commit: 4ef2557d87e363a1ed38083f9b1ed413bff76d26 URL: https://source.winehq.org/git/wine.git/?a=commit;h=4ef2557d87e363a1ed38083f9... Author: Alex Henrie <alexhenrie24(a)gmail.com> Date: Wed Dec 29 22:56:38 2021 -0700 mshtml: Fix use after free in use_gecko_script (Coverity). Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com> Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/mshtml/script.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dlls/mshtml/script.c b/dlls/mshtml/script.c index 28e07a50c8e..2a0d86c9f76 100644 --- a/dlls/mshtml/script.c +++ b/dlls/mshtml/script.c @@ -1716,12 +1716,13 @@ static BOOL use_gecko_script(IUri *uri) return FALSE; hres = IInternetSecurityManager_MapUrlToZone(get_security_manager(), display_uri, &zone, 0); - SysFreeString(display_uri); if(FAILED(hres)) { WARN("Could not map %s to zone: %08x\n", debugstr_w(display_uri), hres); + SysFreeString(display_uri); return TRUE; } + SysFreeString(display_uri); TRACE("zone %d\n", zone); return zone == URLZONE_UNTRUSTED; }
participants (1)
-
Alexandre Julliard