Rob Shearman : msi: Free version after using lpVer in msi_get_disk_file_version as lpVer points inside of version .

[Alexandre Julliard]

Module: wine
Branch: master
Commit: 023383afd3fa7f9f0a963a21425bc4563e4bed74
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=023383afd3fa7f9f0a963a2142...

Author: Rob Shearman <rob(a)codeweavers.com>
Date:   Tue Jun 26 22:23:30 2007 +0100

msi: Free version after using lpVer in msi_get_disk_file_version as lpVer points inside of version.

---

 dlls/msi/action.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/dlls/msi/action.c b/dlls/msi/action.c
index 1525602..a6677bd 100644
--- a/dlls/msi/action.c
+++ b/dlls/msi/action.c
@@ -1987,7 +1987,6 @@ static LPWSTR msi_get_disk_file_version( LPCWSTR filename )
         msi_free( version );
         return NULL;
     }
-    msi_free( version );
 
     sprintfW( filever, name_fmt,
         HIWORD(lpVer->dwFileVersionMS),
@@ -1995,6 +1994,8 @@ static LPWSTR msi_get_disk_file_version( LPCWSTR filename )
         HIWORD(lpVer->dwFileVersionLS),
         LOWORD(lpVer->dwFileVersionLS));
 
+    msi_free( version );
+
     return strdupW( filever );
 }