Conor McCarthy : dbghelp: Return NULL instead of IMAGE_NO_MAP when PE file mapping fails.
Module: wine Branch: master Commit: 9d3687ad324f866c835c4b73922f859a30e47aee URL: https://source.winehq.org/git/wine.git/?a=commit;h=9d3687ad324f866c835c4b739... Author: Conor McCarthy <cmccarthy(a)codeweavers.com> Date: Tue Jul 16 13:41:08 2019 +1000 dbghelp: Return NULL instead of IMAGE_NO_MAP when PE file mapping fails. A NULL test is always applied to the return value from pe_map_full(), but IMAGE_NO_MAP is not NULL, it is ((void*)-1). Signed-off-by: Conor McCarthy <cmccarthy(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/dbghelp/pe_module.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/dbghelp/pe_module.c b/dlls/dbghelp/pe_module.c index 58530e7..4b7c7ba 100644 --- a/dlls/dbghelp/pe_module.c +++ b/dlls/dbghelp/pe_module.c @@ -53,7 +53,7 @@ static void* pe_map_full(struct image_file_map* fmap, IMAGE_NT_HEADERS** nth) fmap->u.pe.full_count++; return fmap->u.pe.full_map; } - return IMAGE_NO_MAP; + return NULL; } static void pe_unmap_full(struct image_file_map* fmap)
participants (1)
-
Alexandre Julliard