Alex Henrie : ole32: Fix memory leak on error path in CompositeMonikerImpl_CommonPrefixWith (Coverity).
Module: wine Branch: master Commit: e6869fe920025c184ecf497573c61f13d7c1c6e8 URL: https://gitlab.winehq.org/wine/wine/-/commit/e6869fe920025c184ecf497573c61f1... Author: Alex Henrie <alexhenrie24(a)gmail.com> Date: Tue Nov 15 20:35:09 2022 -0700 ole32: Fix memory leak on error path in CompositeMonikerImpl_CommonPrefixWith (Coverity). --- dlls/ole32/compositemoniker.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/dlls/ole32/compositemoniker.c b/dlls/ole32/compositemoniker.c index 40f77459ef8..26c950a072e 100644 --- a/dlls/ole32/compositemoniker.c +++ b/dlls/ole32/compositemoniker.c @@ -751,7 +751,11 @@ static HRESULT WINAPI CompositeMonikerImpl_CommonPrefixWith(IMoniker *iface, IMo heap_free(components); heap_free(other_components); - if (!prefix_len) return MK_E_NOPREFIX; + if (!prefix_len) + { + heap_free(prefix_components); + return MK_E_NOPREFIX; + } last = prefix_components[0]; for (i = 1; i < prefix_len; ++i)
participants (1)
-
Alexandre Julliard