David Kahurani : xmllite/reader: Avoid memory leak on error path.
Module: wine Branch: master Commit: 630c38b261960a814bdbdfdc8ab9c52bb4ef0179 URL: https://source.winehq.org/git/wine.git/?a=commit;h=630c38b261960a814bdbdfdc8... Author: David Kahurani <k.kahurani(a)gmail.com> Date: Mon Jun 20 12:01:19 2022 +0300 xmllite/reader: Avoid memory leak on error path. attr->value should not be freed as it was not allocated attr->localname should instead having just being previously allocated and not freed anywhere else Signed-off-by: David Kahurani <k.kahurani(a)gmail.com> --- dlls/xmllite/reader.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/xmllite/reader.c b/dlls/xmllite/reader.c index 4045b4dfcca..d99f121e0cb 100644 --- a/dlls/xmllite/reader.c +++ b/dlls/xmllite/reader.c @@ -424,7 +424,7 @@ static HRESULT reader_add_attr(xmlreader *reader, strval *prefix, strval *localn { hr = reader_strvaldup(reader, value, &attr->value); if (hr != S_OK) - reader_free_strvalued(reader, &attr->value); + reader_free_strvalued(reader, &attr->localname); } if (hr != S_OK) {
participants (1)
-
Alexandre Julliard