[Git][wine/wine][master] winebus: Do not touch autocenter on device init and device reset.

[Alexandre Julliard (＠julliard)]

Alexandre Julliard pushed to branch master at wine / wine


Commits:
b0db6d50 by Tomasz Pakuła at 2025-08-06T22:01:04+09:00
winebus: Do not touch autocenter on device init and device reset.

FFB Autocenter introduced in https://gitlab.winehq.org/wine/wine/-/merge_requests/4911
had one major misunderstanding.

The USB PID standard doesn't actually define any explicit way to
autocenter a device. One could of course use the spring effect with a
deadzone of 0 and dead band of 0. This is what I'm actually working on
for the Linux PID driver (spring + friction/damper).

Some devices implement autocenter in firmware when they receive the
DC Disable Actuators command. Very few, if not just one, implement this
weird autocenter effect on slot 1. This is, from what I can gather, only
implemented on the MS SideWinder joystick(s) and the Windows' USB PID
driver is created around these devices.

Windows PID driver is a bit out of spec, is quite permissive when it
comes to fields missing in the descriptor (basically, only effect types
and their effect type blocks are optional). Another thing it does is
handling of this out-of-spec autocentering for their joysticks.
Funnliy enough, the creator of the Linux PID driver based the initial
code on testing with MS Sidewinder so it's autocentering is supported.

This is where the autocentering mentioned in the MR comes from. It's not
the directinput api that does it but the Windows PID driver. As such,
autocentering on reset should be left to the drivers, not handeled by
Wine.

SDL lacks full reset support and Linux is even more barebones, whre it's
not even possible to query the device state, effects etc (something I'm
working on slowly). As such, when games send out RESET to prepare the
device, the device starts autocentering for no good reason and the
effect is not removed once other effect are uploaded and played which
would be the case for MS sidewinder.

tl;dr
Set autocentering to 0 instead of max value when DISFFC_RESET is
reveived to remove the unwanted autocenter behavior.

Signed-off-by: Tomasz Pakuła <tomasz.pakula.oficjalny(a)gmail.com>

- - - - -


2 changed files:

- dlls/winebus.sys/bus_sdl.c
- dlls/winebus.sys/bus_udev.c


View it on GitLab: https://gitlab.winehq.org/wine/wine/-/commit/b0db6d50530023a19846f08f1c62f14...

-- 
View it on GitLab: https://gitlab.winehq.org/wine/wine/-/commit/b0db6d50530023a19846f08f1c62f14...
You're receiving this email because of your account on gitlab.winehq.org.