Nikolay Sivov : user32/combo: Remove unnecessary argument from button painting helper.

[Alexandre Julliard]

Module: wine
Branch: master
Commit: 76ef090f3de3bcf7fa49b7469181d7f94dd2a2d9
URL:    https://source.winehq.org/git/wine.git/?a=commit;h=76ef090f3de3bcf7fa49b7469...

Author: Nikolay Sivov <nsivov(a)codeweavers.com>
Date:   Wed Nov 27 11:31:02 2019 +0300

user32/combo: Remove unnecessary argument from button painting helper.

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard(a)winehq.org>

---

 dlls/user32/combo.c | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/dlls/user32/combo.c b/dlls/user32/combo.c
index 40ff0ef521..52d2f7190d 100644
--- a/dlls/user32/combo.c
+++ b/dlls/user32/combo.c
@@ -574,10 +574,13 @@ static LRESULT COMBO_Create( HWND hwnd, LPHEADCOMBO lphc, HWND hwndParent, LONG
  *
  * Paint combo button (normal, pressed, and disabled states).
  */
-static void CBPaintButton( LPHEADCOMBO lphc, HDC hdc, RECT rectButton)
+static void CBPaintButton(HEADCOMBO *lphc, HDC hdc)
 {
     UINT buttonState = DFCS_SCROLLCOMBOBOX;
 
+    if (IsRectEmpty(&lphc->buttonRect))
+        return;
+
     if( lphc->wState & CBF_NOREDRAW )
       return;
 
@@ -588,7 +591,7 @@ static void CBPaintButton( LPHEADCOMBO lphc, HDC hdc, RECT rectButton)
     if (CB_DISABLED(lphc))
 	buttonState |= DFCS_INACTIVE;
 
-    DrawFrameControl(hdc, &rectButton, DFC_SCROLL, buttonState);
+    DrawFrameControl(hdc, &lphc->buttonRect, DFC_SCROLL, buttonState);
 }
 
 /***********************************************************************
@@ -816,11 +819,7 @@ static LRESULT COMBO_Paint(LPHEADCOMBO lphc, HDC hParamDC)
        * In non 3.1 look, there is a sunken border on the combobox
        */
       CBPaintBorder(lphc->self, lphc, hDC);
-
-      if( !IsRectEmpty(&lphc->buttonRect) )
-      {
-	CBPaintButton(lphc, hDC, lphc->buttonRect);
-      }
+      CBPaintButton(lphc, hDC);
 
       /* paint the edit control padding area */
       if (CB_GETTYPE(lphc) != CBS_DROPDOWNLIST)