Stefan Dösinger : d3d8/tests: Ignore random testbot failures in test_cursor.

[Alexandre Julliard]

Module: wine
Branch: master
Commit: 83285d54bd50ae0d02f2ac3f39510a49afcb8438
URL:    https://source.winehq.org/git/wine.git/?a=commit;h=83285d54bd50ae0d02f2ac3f3...

Author: Stefan Dösinger <stefan(a)codeweavers.com>
Date:   Sat Jan 29 15:00:26 2022 +0300

d3d8/tests: Ignore random testbot failures in test_cursor.

Signed-off-by: Stefan Dösinger <stefan(a)codeweavers.com>
Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard(a)winehq.org>

---

 dlls/d3d8/tests/device.c | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/dlls/d3d8/tests/device.c b/dlls/d3d8/tests/device.c
index 68b7fd00e70..cb1e83b64b3 100644
--- a/dlls/d3d8/tests/device.c
+++ b/dlls/d3d8/tests/device.c
@@ -1074,11 +1074,19 @@ static void test_cursor(void)
 
     IDirect3DSurface8_Release(cursor);
 
+    /* On the testbot the cursor handle does not behave as expected in rare situations,
+     * leading to random test failures. Either the cursor handle changes before we expect
+     * it to, or it doesn't change afterwards (or already changed before we read the
+     * initial handle?). I was not able to reproduce this on my own machines. Moving the
+     * mouse outside the window results in similar behavior. However, I tested various
+     * obvious failure causes: Was the mouse moved? Was the window hidden or moved? Is
+     * the window in the background? Neither of those applies. Making the window topmost
+     * or using a fullscreen device doesn't improve the test's reliability either. */
     memset(&info, 0, sizeof(info));
     info.cbSize = sizeof(info);
     ok(GetCursorInfo(&info), "GetCursorInfo failed\n");
     ok(info.flags & (CURSOR_SHOWING|CURSOR_SUPPRESSED), "The gdi cursor is hidden (%08x)\n", info.flags);
-    ok(info.hCursor == cur, "The cursor handle is %p\n", info.hCursor); /* unchanged */
+    ok(info.hCursor == cur || broken(1), "The cursor handle is %p\n", info.hCursor); /* unchanged */
 
     /* Still hidden */
     ret = IDirect3DDevice8_ShowCursor(device, TRUE);
@@ -1092,7 +1100,7 @@ static void test_cursor(void)
     info.cbSize = sizeof(info);
     ok(GetCursorInfo(&info), "GetCursorInfo failed\n");
     ok(info.flags & (CURSOR_SHOWING|CURSOR_SUPPRESSED), "The gdi cursor is hidden (%08x)\n", info.flags);
-    ok(info.hCursor != cur, "The cursor handle is %p\n", info.hCursor);
+    ok(info.hCursor != cur || broken(1), "The cursor handle is %p\n", info.hCursor);
 
     /* Cursor dimensions must all be powers of two */
     for (test_idx = 0; test_idx < ARRAY_SIZE(cursor_sizes); ++test_idx)