Francois Gouget : testbot/cgi: Use AddError() instead of direct field access in ItemPage.

[Alexandre Julliard]

Module: tools
Branch: master
Commit: e6e241c32d7c7fd1aefde50aca5cbca45f2aad21
URL:    https://source.winehq.org/git/tools.git/?a=commit;h=e6e241c32d7c7fd1aefde50a...

Author: Francois Gouget <fgouget(a)codeweavers.com>
Date:   Wed Jul  6 16:06:08 2022 +0200

testbot/cgi: Use AddError() instead of direct field access in ItemPage.

Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard(a)winehq.org>

---

 testbot/lib/ObjectModel/CGI/ItemPage.pm | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/testbot/lib/ObjectModel/CGI/ItemPage.pm b/testbot/lib/ObjectModel/CGI/ItemPage.pm
index cd40ba2e..3ec201d9 100644
--- a/testbot/lib/ObjectModel/CGI/ItemPage.pm
+++ b/testbot/lib/ObjectModel/CGI/ItemPage.pm
@@ -176,8 +176,13 @@ sub Save($)
 
   return !1 if (!$self->SUPER::Save());
 
-  (my $_ErrKey, $self->{ErrField}, $self->{ErrMessage}) = $self->{Collection}->Save();
-  return !defined $self->{ErrMessage};
+  my ($_ErrKey, $ErrProperty, $ErrMessage) = $self->{Collection}->Save();
+  if (defined $ErrMessage)
+  {
+    $self->AddError($ErrMessage, $ErrProperty);
+    return undef;
+  }
+  return 1;
 }
 
 1;