Rémi Bernon : xinput: Fix rumble amount value rounding.
Module: wine Branch: master Commit: d636cc18ba53ed7ca798c919dd56b0d5dabee9fa URL: https://source.winehq.org/git/wine.git/?a=commit;h=d636cc18ba53ed7ca798c919d... Author: Rémi Bernon <rbernon(a)codeweavers.com> Date: Tue May 28 16:41:20 2019 +0200 xinput: Fix rumble amount value rounding. XINPUT_VIBRATION structure documentation says that wLeftMotorSpeed and wRightMotorSpeed can range from 0 to 65535. The values were incorrectly divided by 255 in HID_set_state, which made the value range overflow one byte. Signed-off-by: Rémi Bernon <rbernon(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/xinput1_3/hid.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/xinput1_3/hid.c b/dlls/xinput1_3/hid.c index 34e4e51..dc5601c 100644 --- a/dlls/xinput1_3/hid.c +++ b/dlls/xinput1_3/hid.c @@ -469,8 +469,8 @@ DWORD HID_set_state(xinput_controller* device, XINPUT_VIBRATION* state) report.report = 0; report.pad1[0] = 0x8; report.pad1[1] = 0x0; - report.left = (BYTE)(state->wLeftMotorSpeed / 255); - report.right = (BYTE)(state->wRightMotorSpeed / 255); + report.left = (BYTE)(state->wLeftMotorSpeed / 256); + report.right = (BYTE)(state->wRightMotorSpeed / 256); memset(&report.pad2, 0, sizeof(report.pad2)); EnterCriticalSection(&private->crit);
participants (1)
-
Alexandre Julliard