Michael Stefaniuc : dmsynth: Lock/unlock the module only on creation/ desctruction.

[Alexandre Julliard]

Module: wine
Branch: master
Commit: 8ba03f8a986b439d3b5b46ce58be1333222c8155
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=8ba03f8a986b439d3b5b46ce58...

Author: Michael Stefaniuc <mstefani(a)redhat.de>
Date:   Tue Jul 19 09:53:07 2016 +0200

dmsynth: Lock/unlock the module only on creation/desctruction.

Signed-off-by: Michael Stefaniuc <mstefani(a)redhat.de>
Signed-off-by: Alexandre Julliard <julliard(a)winehq.org>

---

 dlls/dmsynth/synth.c     | 7 +++----
 dlls/dmsynth/synthsink.c | 5 +----
 2 files changed, 4 insertions(+), 8 deletions(-)

diff --git a/dlls/dmsynth/synth.c b/dlls/dmsynth/synth.c
index fceeebd..88ba53e 100644
--- a/dlls/dmsynth/synth.c
+++ b/dlls/dmsynth/synth.c
@@ -72,8 +72,6 @@ static ULONG WINAPI IDirectMusicSynth8Impl_AddRef(LPDIRECTMUSICSYNTH8 iface)
 
     TRACE("(%p)->(): new ref = %u\n", This, ref);
 
-    DMSYNTH_LockModule();
-
     return ref;
 }
 
@@ -88,10 +86,9 @@ static ULONG WINAPI IDirectMusicSynth8Impl_Release(LPDIRECTMUSICSYNTH8 iface)
         if (This->pLatencyClock)
             IReferenceClock_Release(This->pLatencyClock);
         HeapFree(GetProcessHeap(), 0, This);
+        DMSYNTH_UnlockModule();
     }
 
-    DMSYNTH_UnlockModule();
-
     return ref;
 }
 
@@ -605,7 +602,9 @@ HRESULT WINAPI DMUSIC_CreateDirectMusicSynthImpl(REFIID riid, void **ppobj)
     obj->pCaps.dwEffectFlags = DMUS_EFFECT_REVERB;
     strcpyW(obj->pCaps.wszDescription, descrW);
 
+    DMSYNTH_LockModule();
     hr = IDirectMusicSynth8_QueryInterface(&obj->IDirectMusicSynth8_iface, riid, ppobj);
     IDirectMusicSynth8_Release(&obj->IDirectMusicSynth8_iface);
+
     return hr;
 }
diff --git a/dlls/dmsynth/synthsink.c b/dlls/dmsynth/synthsink.c
index 4720e59..7d148b0 100644
--- a/dlls/dmsynth/synthsink.c
+++ b/dlls/dmsynth/synthsink.c
@@ -67,8 +67,6 @@ static ULONG WINAPI IDirectMusicSynthSinkImpl_AddRef(LPDIRECTMUSICSYNTHSINK ifac
 
     TRACE("(%p)->(): new ref = %u\n", This, ref);
 
-    DMSYNTH_LockModule();
-
     return ref;
 }
 
@@ -83,10 +81,9 @@ static ULONG WINAPI IDirectMusicSynthSinkImpl_Release(LPDIRECTMUSICSYNTHSINK ifa
         if (This->latency_clock)
             IReferenceClock_Release(This->latency_clock);
         HeapFree(GetProcessHeap(), 0, This);
+        DMSYNTH_UnlockModule();
     }
 
-    DMSYNTH_UnlockModule();
-
     return ref;
 }