[Git][wine/vkd3d][master] 3 commits: tests: Mark a number of test failures as buggy on macOS before Sequoia.
Henri Verbeet pushed to branch master at wine / vkd3d Commits: aab8ba02 by Giovanni Mascellani at 2025-04-03T20:26:26+02:00 tests: Mark a number of test failures as buggy on macOS before Sequoia. It's hard to pinpoint exactly what's going wrong with these tests. They seem to be related to atomics and GPU timestamps, both categories that are known to have problems on MoltenVK in a way or another; those failures clearly depend on a few factors like the MoltenVK version, the macOS version and whether we're in a virtual machine or not, but the exact dependency on those factors is hard to describe (for example, in general the paravirtualized device offered inside virtual machines has a lot more problems than real devices, but I've seen tests, fixed all other conditions, working on the paravirtualized device and not on the real device). The only thing all tests in this batch have in common is that I've never seen them fail on a Sequoia system, thus I've settled for using just that as the bug_if() condition. Ultimately, wasting a lot of time to get to the bottom of each single test failure is pointless, and being able to mark the CI job as not allowed to fail gives better regression protection than investigating each of those. Also, I routinely run the tests on a Sequoia system, so if these tests get broken this is going to be noticed anyway. - - - - - 653e4f47 by Giovanni Mascellani at 2025-04-03T20:28:27+02:00 ci: Disable testing with DXC on macOS. With this we can finally disallow failure for the macOS CI script, which is more valuable than checking DXC. Eventually DXC tests will have to be fixed, though. - - - - - 7b4a29da by Giovanni Mascellani at 2025-04-03T20:28:31+02:00 tests: Mark a todo as resolved on MoltenVK 1.2.12. Technically it is not, the Vulkan commands we're generating are still not correct. But let's get rid of the failure message. - - - - - 4 changed files: - gitlab/build.yml - tests/d3d12.c - tests/d3d12_crosstest.h - tests/vulkan_utils.h View it on GitLab: https://gitlab.winehq.org/wine/vkd3d/-/compare/254008198896248286846b64ad061... -- View it on GitLab: https://gitlab.winehq.org/wine/vkd3d/-/compare/254008198896248286846b64ad061... You're receiving this email because of your account on gitlab.winehq.org.
participants (1)
-
Henri Verbeet (＠hverbeet)