Erich Hoover : hhctrl.ocx: Fix removing a window from the help list when window creation fails.

[Alexandre Julliard]

Module: wine
Branch: master
Commit: aedcc11e4fe0954323d5257e14981e9729738f22
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=aedcc11e4fe0954323d5257e14...

Author: Erich Hoover <ehoover(a)mines.edu>
Date:   Wed Oct  3 09:18:52 2012 -0600

hhctrl.ocx: Fix removing a window from the help list when window creation fails.

---

 dlls/hhctrl.ocx/help.c |    6 +-----
 1 files changed, 1 insertions(+), 5 deletions(-)

diff --git a/dlls/hhctrl.ocx/help.c b/dlls/hhctrl.ocx/help.c
index c884dc0..833b681 100644
--- a/dlls/hhctrl.ocx/help.c
+++ b/dlls/hhctrl.ocx/help.c
@@ -1825,13 +1825,12 @@ void ReleaseHelpViewer(HHInfo *info)
 
 HHInfo *CreateHelpViewer(HHInfo *info, LPCWSTR filename, HWND caller)
 {
-    BOOL add_to_window_list = FALSE;
     int i;
 
     if(!info)
     {
         info = heap_alloc_zero(sizeof(HHInfo));
-        add_to_window_list = TRUE;
+        list_add_tail(&window_list, &info->entry);
     }
 
     /* Set the invalid tab ID (-1) as the default value for all
@@ -1859,9 +1858,6 @@ HHInfo *CreateHelpViewer(HHInfo *info, LPCWSTR filename, HWND caller)
         return NULL;
     }
 
-    if(add_to_window_list)
-        list_add_tail(&window_list, &info->entry);
-
     return info;
 }