Nikolay Sivov : comctl32/listview: Initialize subitem text buffer before drawing each subitem.
Module: wine Branch: stable Commit: 081192240fd078e6cf2113b9b3f9624fd79142f4 URL: https://gitlab.winehq.org/wine/wine/-/commit/081192240fd078e6cf2113b9b3f9624... Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Wed Feb 23 13:48:23 2022 +0300 comctl32/listview: Initialize subitem text buffer before drawing each subitem. Notification handler for LVN_GETDISPINFO is not guaranteed to touch text buffer. When it doesn't, it can lead to already queried text to be reused for subitems. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52583 Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> (cherry picked from commit 4f1853c57633629ad81a233ab75a85b6f41399ad) Signed-off-by: Michael Stefaniuc <mstefani(a)winehq.org> --- dlls/comctl32/listview.c | 1 + 1 file changed, 1 insertion(+) diff --git a/dlls/comctl32/listview.c b/dlls/comctl32/listview.c index 9e35f7879b7..1b39cf3d41a 100644 --- a/dlls/comctl32/listview.c +++ b/dlls/comctl32/listview.c @@ -4795,6 +4795,7 @@ static BOOL LISTVIEW_DrawItem(LISTVIEW_INFO *infoPtr, HDC hdc, INT nItem, ITERAT lvItem.lParam = 0; lvItem.cchTextMax = DISP_TEXT_SIZE; lvItem.pszText = szDispText; + szDispText[0] = 0; if (!LISTVIEW_GetItemW(infoPtr, &lvItem)) return FALSE; if (infoPtr->dwLvExStyle & LVS_EX_FULLROWSELECT) lvItem.state = LISTVIEW_GetItemState(infoPtr, nItem, LVIS_SELECTED);
participants (1)
-
Alexandre Julliard