Marcus Meissner : msi: Fix potential uninitialized use of substg.
Module: wine Branch: master Commit: 628b8e7630dbca0eca3ef24d3a733aaf025cd639 URL: http://source.winehq.org/git/wine.git/?a=commit;h=628b8e7630dbca0eca3ef24d3a... Author: Marcus Meissner <meissner(a)suse.de> Date: Sun Sep 28 22:27:29 2008 +0200 msi: Fix potential uninitialized use of substg. --- dlls/msi/storages.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/msi/storages.c b/dlls/msi/storages.c index 7b20dd9..4fb3ba0 100644 --- a/dlls/msi/storages.c +++ b/dlls/msi/storages.c @@ -184,7 +184,7 @@ done: static UINT STORAGES_set_row(struct tagMSIVIEW *view, UINT row, MSIRECORD *rec, UINT mask) { MSISTORAGESVIEW *sv = (MSISTORAGESVIEW *)view; - IStorage *stg, *substg; + IStorage *stg, *substg = NULL; IStream *stm; LPWSTR name = NULL; HRESULT hr; @@ -236,7 +236,7 @@ static UINT STORAGES_set_row(struct tagMSIVIEW *view, UINT row, MSIRECORD *rec, done: msi_free(name); - IStorage_Release(substg); + if (substg) IStorage_Release(substg); IStorage_Release(stg); IStream_Release(stm);
participants (1)
-
Alexandre Julliard